tb_redirects 0.9.0 → 1.0.beta1

data/spec/dummy/db/schema.rb

@@ -11,87 +11,85 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20160212211331) do
-
-  create_table "spud_permissions", force: :cascade do |t|
-    t.string   "name",       limit: 255, null: false
-    t.string   "tag",        limit: 255, null: false
-    t.datetime "created_at"
-    t.datetime "updated_at"
+ActiveRecord::Schema.define(version: 20_160_212_211_331) do
+  create_table 'spud_permissions', force: :cascade do |t|
+    t.string   'name',       limit: 255, null: false
+    t.string   'tag',        limit: 255, null: false
+    t.datetime 'created_at'
+    t.datetime 'updated_at'
   end
 
-  add_index "spud_permissions", ["tag"], name: "index_spud_permissions_on_tag", unique: true, length: {"tag"=>191}, using: :btree
+  add_index 'spud_permissions', ['tag'], name: 'index_spud_permissions_on_tag', unique: true, length: { 'tag' => 191 }, using: :btree
 
-  create_table "spud_role_permissions", force: :cascade do |t|
-    t.integer  "spud_role_id",        limit: 4,   null: false
-    t.string   "spud_permission_tag", limit: 255, null: false
-    t.datetime "created_at"
-    t.datetime "updated_at"
+  create_table 'spud_role_permissions', force: :cascade do |t|
+    t.integer  'spud_role_id',        limit: 4,   null: false
+    t.string   'spud_permission_tag', limit: 255, null: false
+    t.datetime 'created_at'
+    t.datetime 'updated_at'
   end
 
-  add_index "spud_role_permissions", ["spud_permission_tag"], name: "index_spud_role_permissions_on_spud_permission_tag", length: {"spud_permission_tag"=>191}, using: :btree
-  add_index "spud_role_permissions", ["spud_role_id"], name: "index_spud_role_permissions_on_spud_role_id", using: :btree
+  add_index 'spud_role_permissions', ['spud_permission_tag'], name: 'index_spud_role_permissions_on_spud_permission_tag', length: { 'spud_permission_tag' => 191 }, using: :btree
+  add_index 'spud_role_permissions', ['spud_role_id'], name: 'index_spud_role_permissions_on_spud_role_id', using: :btree
 
-  create_table "spud_roles", force: :cascade do |t|
-    t.string   "name",       limit: 255
-    t.datetime "created_at"
-    t.datetime "updated_at"
+  create_table 'spud_roles', force: :cascade do |t|
+    t.string   'name',       limit: 255
+    t.datetime 'created_at'
+    t.datetime 'updated_at'
   end
 
-  create_table "spud_user_settings", force: :cascade do |t|
-    t.integer  "spud_user_id", limit: 4
-    t.string   "key",          limit: 255
-    t.string   "value",        limit: 255
-    t.datetime "created_at"
-    t.datetime "updated_at"
+  create_table 'spud_user_settings', force: :cascade do |t|
+    t.integer  'spud_user_id', limit: 4
+    t.string   'key',          limit: 255
+    t.string   'value',        limit: 255
+    t.datetime 'created_at'
+    t.datetime 'updated_at'
   end
 
-  create_table "spud_users", force: :cascade do |t|
-    t.string   "first_name",               limit: 255
-    t.string   "last_name",                limit: 255
-    t.boolean  "super_admin"
-    t.string   "login",                    limit: 255,                 null: false
-    t.string   "email",                    limit: 255,                 null: false
-    t.string   "crypted_password",         limit: 255,                 null: false
-    t.string   "password_salt",            limit: 255,                 null: false
-    t.string   "persistence_token",        limit: 255,                 null: false
-    t.string   "single_access_token",      limit: 255,                 null: false
-    t.string   "perishable_token",         limit: 255,                 null: false
-    t.integer  "login_count",              limit: 4,   default: 0,     null: false
-    t.integer  "failed_login_count",       limit: 4,   default: 0,     null: false
-    t.datetime "last_request_at"
-    t.datetime "current_login_at"
-    t.datetime "last_login_at"
-    t.string   "current_login_ip",         limit: 255
-    t.string   "last_login_ip",            limit: 255
-    t.datetime "created_at"
-    t.datetime "updated_at"
-    t.string   "time_zone",                limit: 255
-    t.integer  "spud_role_id",             limit: 4
-    t.boolean  "requires_password_change",             default: false
+  create_table 'spud_users', force: :cascade do |t|
+    t.string   'first_name',               limit: 255
+    t.string   'last_name',                limit: 255
+    t.boolean  'super_admin'
+    t.string   'login',                    limit: 255,                 null: false
+    t.string   'email',                    limit: 255,                 null: false
+    t.string   'crypted_password',         limit: 255,                 null: false
+    t.string   'password_salt',            limit: 255,                 null: false
+    t.string   'persistence_token',        limit: 255,                 null: false
+    t.string   'single_access_token',      limit: 255,                 null: false
+    t.string   'perishable_token',         limit: 255,                 null: false
+    t.integer  'login_count',              limit: 4,   default: 0,     null: false
+    t.integer  'failed_login_count',       limit: 4,   default: 0,     null: false
+    t.datetime 'last_request_at'
+    t.datetime 'current_login_at'
+    t.datetime 'last_login_at'
+    t.string   'current_login_ip',         limit: 255
+    t.string   'last_login_ip',            limit: 255
+    t.datetime 'created_at'
+    t.datetime 'updated_at'
+    t.string   'time_zone',                limit: 255
+    t.integer  'spud_role_id',             limit: 4
+    t.boolean  'requires_password_change', default: false
   end
 
-  add_index "spud_users", ["email"], name: "index_spud_users_on_email", length: {"email"=>191}, using: :btree
-  add_index "spud_users", ["login"], name: "index_spud_users_on_login", length: {"login"=>191}, using: :btree
-  add_index "spud_users", ["spud_role_id"], name: "index_spud_users_on_spud_role_id", using: :btree
+  add_index 'spud_users', ['email'], name: 'index_spud_users_on_email', length: { 'email' => 191 }, using: :btree
+  add_index 'spud_users', ['login'], name: 'index_spud_users_on_login', length: { 'login' => 191 }, using: :btree
+  add_index 'spud_users', ['spud_role_id'], name: 'index_spud_users_on_spud_role_id', using: :btree
 
-  create_table "tb_redirects", force: :cascade do |t|
-    t.string   "owner_type",  limit: 255
-    t.integer  "owner_id",    limit: 4
-    t.string   "source",      limit: 255, null: false
-    t.string   "destination", limit: 255, null: false
-    t.string   "created_by",  limit: 255
-    t.datetime "created_at",              null: false
-    t.datetime "updated_at",              null: false
+  create_table 'tb_redirects', force: :cascade do |t|
+    t.string   'owner_type',  limit: 255
+    t.integer  'owner_id',    limit: 4
+    t.string   'source',      limit: 255, null: false
+    t.string   'destination', limit: 255, null: false
+    t.string   'created_by',  limit: 255
+    t.datetime 'created_at',              null: false
+    t.datetime 'updated_at',              null: false
   end
 
-  add_index "tb_redirects", ["owner_type", "owner_id"], name: "index_tb_redirects_on_owner_type_and_owner_id", length: {"owner_type"=>191, "owner_id"=>nil}, using: :btree
-  add_index "tb_redirects", ["source"], name: "index_tb_redirects_on_source", unique: true, length: {"source"=>191}, using: :btree
+  add_index 'tb_redirects', ['owner_type', 'owner_id'], name: 'index_tb_redirects_on_owner_type_and_owner_id', length: { 'owner_type' => 191, 'owner_id' => nil }, using: :btree
+  add_index 'tb_redirects', ['source'], name: 'index_tb_redirects_on_source', unique: true, length: { 'source' => 191 }, using: :btree
 
-  create_table "widgets", force: :cascade do |t|
-    t.string   "name",       limit: 255
-    t.datetime "created_at",             null: false
-    t.datetime "updated_at",             null: false
+  create_table 'widgets', force: :cascade do |t|
+    t.string   'name', limit: 255
+    t.datetime 'created_at',             null: false
+    t.datetime 'updated_at',             null: false
   end
-
 end

data/spec/factories/tb_redirects.rb

@@ -2,8 +2,8 @@ FactoryGirl.define do
   factory :tb_redirect do
     owner_type nil
     owner_id nil
-    sequence(:source){ |n| "/test-#{n}" }
-    sequence(:destination){ |n| "/redirected-#{n}" }
+    sequence(:source) { |n| "/test-#{n}" }
+    sequence(:destination) { |n| "/redirected-#{n}" }
     created_by 'user'
   end
 end

data/spec/helpers/admin/tb_redirects_helper_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 RSpec.describe Admin::TbRedirectsHelper, type: :helper do
-
   describe '#created_by_for_tb_redirect' do
     it 'should return an info label' do
       result = helper.created_by_for_tb_redirect('user')
@@ -12,5 +11,4 @@ RSpec.describe Admin::TbRedirectsHelper, type: :helper do
       expect(result).to include('label-default')
     end
   end
-
 end

data/spec/jobs/tb_redirects/detect_redirect_loop_job_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 RSpec.describe TbRedirects::DetectRedirectLoopJob, type: :job do
-
   before do
     TbRedirect.skip_callback(:save, :after, :schedule_loop_detection)
   end
@@ -12,58 +11,57 @@ RSpec.describe TbRedirects::DetectRedirectLoopJob, type: :job do
   describe '#perform' do
     it 'should destroy a redirect' do
       redirects = TbRedirect.create([
-        {:source => '/1', :destination => '/2', :created_by => 'user'},
-        {:source => '/2', :destination => '/3', :created_by => 'user'},
-        {:source => '/3', :destination => '/1', :created_by => 'user'}
-      ])
-      expect{
+                                      { source: '/1', destination: '/2', created_by: 'user' },
+                                      { source: '/2', destination: '/3', created_by: 'user' },
+                                      { source: '/3', destination: '/1', created_by: 'user' }
+                                    ])
+      expect do
         TbRedirects::DetectRedirectLoopJob.perform_now(redirects.first)
-      }.to change(TbRedirect, :count).by(-1)
+      end.to change(TbRedirect, :count).by(-1)
     end
-    
+
     it 'should not destroy anything' do
       redirects = TbRedirect.create([
-        {:source => '/1', :destination => '/2', :created_by => 'user'},
-        {:source => '/2', :destination => '/3', :created_by => 'user'},
-        {:source => '/3', :destination => '/4', :created_by => 'user'}
-      ])
-      expect{
+                                      { source: '/1', destination: '/2', created_by: 'user' },
+                                      { source: '/2', destination: '/3', created_by: 'user' },
+                                      { source: '/3', destination: '/4', created_by: 'user' }
+                                    ])
+      expect do
         TbRedirects::DetectRedirectLoopJob.perform_now(redirects.first)
-      }.to_not change(TbRedirect, :count)
+      end.to_not change(TbRedirect, :count)
     end
   end
 
   describe '#search_parent' do
     before(:each) do
       @redirects = TbRedirect.create([
-        {:source => '/1', :destination => '/2', :created_by => 'user'},
-        {:source => '/2', :destination => '/3', :created_by => 'user'},
-        {:source => '/3', :destination => '/1', :created_by => 'user'}
-      ])
+                                       { source: '/1', destination: '/2', created_by: 'user' },
+                                       { source: '/2', destination: '/3', created_by: 'user' },
+                                       { source: '/3', destination: '/1', created_by: 'user' }
+                                     ])
       @redirect = @redirects.first
     end
 
     it 'should destroy a redirect' do
       job = TbRedirects::DetectRedirectLoopJob.new(@redirect)
-      expect{
+      expect do
         job.send(:search_parent, @redirects.second, @redirect.destination)
-      }.to change(TbRedirect, :count).by(-1)
+      end.to change(TbRedirect, :count).by(-1)
     end
 
     it 'should continue searching' do
       job = TbRedirects::DetectRedirectLoopJob.new(@redirect)
-      expect{
-        job.send(:search_parent, @redirects.third, @redirect.destination)  
-      }.to change(job, :attempts).by(2)
+      expect do
+        job.send(:search_parent, @redirects.third, @redirect.destination)
+      end.to change(job, :attempts).by(2)
     end
 
     it 'should give up after MAX_ATTEMPTS' do
       job = TbRedirects::DetectRedirectLoopJob.new(@redirect)
-      job.instance_variable_set(:@attempts, TbRedirects::DetectRedirectLoopJob::MAX_ATTEMPTS+1)
-      expect{
+      job.instance_variable_set(:@attempts, TbRedirects::DetectRedirectLoopJob::MAX_ATTEMPTS + 1)
+      expect do
         job.send(:search_parent, @redirects.second, @redirect.destination)
-      }.to raise_error(TbRedirects::DetectRedirectLoopJob::AttemptsExceeded)
+      end.to raise_error(TbRedirects::DetectRedirectLoopJob::AttemptsExceeded)
     end
   end
-
 end

data/spec/models/tb_redirect_spec.rb

@@ -1,77 +1,74 @@
 require 'rails_helper'
 
 RSpec.describe TbRedirect, type: :model do
-
-  describe '.find_by_uri' do
+  describe '.find_with_uri' do
     before(:each) do
-      @sample_a = FactoryGirl.create(:tb_redirect, :source => '/test', :destination => '/redirected')
-      @sample_b = FactoryGirl.create(:tb_redirect, :source => 'http://test.com/blog', :destination => '/redirected')
-      @sample_c = FactoryGirl.create(:tb_redirect, :source => 'http://test.com/about', :destination => '/redirected')
+      @sample_a = FactoryGirl.create(:tb_redirect, source: '/test', destination: '/redirected')
+      @sample_b = FactoryGirl.create(:tb_redirect, source: 'http://test.com/blog', destination: '/redirected')
+      @sample_c = FactoryGirl.create(:tb_redirect, source: 'http://test.com/about', destination: '/redirected')
     end
 
     it 'should find a record where the path matches' do
-      result = TbRedirect.find_by_uri('http://google.com/test')
+      result = TbRedirect.find_with_uri('http://google.com/test')
       expect(result).to eq(@sample_a)
     end
 
     it 'should find a record where the full URI matches' do
-      result = TbRedirect.find_by_uri('http://test.com/blog')
+      result = TbRedirect.find_with_uri('http://test.com/blog')
       expect(result).to eq(@sample_b)
     end
 
     it 'should find no records' do
-      result = TbRedirect.find_by_uri('http://test.com/contact')
+      result = TbRedirect.find_with_uri('http://test.com/contact')
       expect(result).to eq(nil)
     end
 
     it 'should catch an invalid URI error' do
-      expect{
-        TbRedirect.find_by_uri('%!&*')
-      }.to_not raise_error
+      expect do
+        TbRedirect.find_with_uri('%!&*')
+      end.to_not raise_error
     end
-
   end
 
   describe '.create_smart' do
     it 'should create a new redirect' do
       redirect_1 = FactoryGirl.create(:tb_redirect)
-      expect{
-        redirect_2 = TbRedirect.create_smart(FactoryGirl.attributes_for(:tb_redirect, :source => '/new'))
-      }.to change(TbRedirect, :count).by(1)
+      expect do
+        redirect_2 = TbRedirect.create_smart(FactoryGirl.attributes_for(:tb_redirect, source: '/new'))
+      end.to change(TbRedirect, :count).by(1)
     end
 
     it 'should update an existing redirect' do
       redirect_1 = FactoryGirl.create(:tb_redirect)
-      expect{
-        redirect_2 = TbRedirect.create_smart(FactoryGirl.attributes_for(:tb_redirect, :source => redirect_1.source))
-      }.to_not change(TbRedirect, :count)
+      expect do
+        redirect_2 = TbRedirect.create_smart(FactoryGirl.attributes_for(:tb_redirect, source: redirect_1.source))
+      end.to_not change(TbRedirect, :count)
     end
   end
 
   describe '#source_not_equals_destination' do
     it 'should not allow the source and destination to be equal' do
-      redirect_1 = FactoryGirl.build(:tb_redirect, :source => 'a', :destination => 'a')
+      redirect_1 = FactoryGirl.build(:tb_redirect, source: 'a', destination: 'a')
       expect(redirect_1).to be_invalid
     end
   end
 
   describe '#destroy_opposite_redirect' do
     it 'should destroy the other redirect' do
-      redirect_1 = FactoryGirl.build(:tb_redirect, :source => 'a', :destination => 'b')
-      redirect_2 = FactoryGirl.build(:tb_redirect, :source => 'b', :destination => 'a')
-      expect{
+      redirect_1 = FactoryGirl.build(:tb_redirect, source: 'a', destination: 'b')
+      redirect_2 = FactoryGirl.build(:tb_redirect, source: 'b', destination: 'a')
+      expect do
         redirect_1.reload
-      }.to raise_error(ActiveRecord::RecordNotFound)
+      end.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
 
   describe '#schedule_loop_detection' do
     it 'should schedule a job' do
       parent = FactoryGirl.create(:tb_redirect)
-      expect{
-        FactoryGirl.create(:tb_redirect, :source => parent.destination)
-      }.to have_enqueued_job(TbRedirects::DetectRedirectLoopJob)
+      expect do
+        FactoryGirl.create(:tb_redirect, source: parent.destination)
+      end.to have_enqueued_job(TbRedirects::DetectRedirectLoopJob)
     end
   end
-
 end

data/spec/rails_helper.rb

@@ -3,13 +3,14 @@ SimpleCov.start 'rails'
 
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 ENV['RAILS_ENV'] ||= 'test'
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require File.expand_path('../dummy/config/environment.rb', __FILE__)
 
 # Prevent database truncation if the environment is production
-abort("The Rails environment is running in production mode!") if Rails.env.production?
+abort('The Rails environment is running in production mode!') if Rails.env.production?
 
 require 'spec_helper'
 require 'rspec/rails'
+require 'rails-controller-testing'
 require 'database_cleaner'
 require 'factory_girl_rails'
 require 'tb_core/test_helper'
@@ -36,6 +37,12 @@ require 'tb_core/test_helper'
 # ActiveRecord::Migration.maintain_test_schema!
 
 RSpec.configure do |config|
+  [:controller, :view, :request].each do |type|
+    config.include ::Rails::Controller::Testing::TestProcess, type: type
+    config.include ::Rails::Controller::Testing::TemplateAssertions, type: type
+    config.include ::Rails::Controller::Testing::Integration, type: type
+  end
+
   config.infer_base_class_for_anonymous_controllers = false
 
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
@@ -74,5 +81,4 @@ RSpec.configure do |config|
       example.run
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -40,53 +40,51 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Allows RSpec to persist some state between runs in order to support
-  # the `--only-failures` and `--next-failure` CLI options. We recommend
-  # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = "spec/examples.txt"
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
-  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
-  config.disable_monkey_patching!
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # These two settings work together to allow you to limit a spec run
+  #   # to individual examples or groups you care about by tagging them with
+  #   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  #   # get run.
+  #   config.filter_run :focus
+  #   config.run_all_when_everything_filtered = true
+  #
+  #   # Allows RSpec to persist some state between runs in order to support
+  #   # the `--only-failures` and `--next-failure` CLI options. We recommend
+  #   # you configure your source control system to ignore this file.
+  #   config.example_status_persistence_file_path = "spec/examples.txt"
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is
+  #   # recommended. For more details, see:
+  #   #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  #   config.disable_monkey_patching!
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = 'doc'
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
 end