taxjar-ruby 2.6.0 → 2.6.1

data/lib/taxjar/api/request.rb

@@ -28,7 +28,12 @@ module Taxjar
       def perform
         options_key = [:get, :delete].include?(@request_method) ? :params : :json
         response = build_http_client.request(request_method, uri.to_s, options_key => @options)
-        response_body = symbolize_keys!(response.parse)
+        response_body =
+          begin
+            symbolize_keys!(response.parse(:json))
+          rescue JSON::ParserError
+            nil
+          end
         fail_or_return_response_body(response.code, response_body)
       end
 
@@ -74,6 +79,7 @@ module Taxjar
         end
 
         def extract_error(code, body)
+          return Taxjar::Error.for_json_parse_error(code) if body.nil?
           klass = Taxjar::Error::ERRORS[code]
           if !klass.nil?
             klass.from_response(body)

data/lib/taxjar/error.rb

@@ -61,6 +61,10 @@ module Taxjar
         new(message, code)
       end
 
+      def for_json_parse_error(code)
+        ServerError.new("Couldn't parse response as JSON.", code)
+      end
+
     end
 
     def initialize(message = '', code = nil)

data/lib/taxjar/version.rb

@@ -10,7 +10,7 @@ module Taxjar
     end
 
     def patch
-      0
+      1
     end
 
     def pre

data/spec/taxjar/api/request_spec.rb

@@ -168,6 +168,17 @@ describe Taxjar::API::Request do
       end
     end
 
+    it 'handles unexpected Content-Type responses' do
+      stub_request(:get, "https://api.taxjar.com/api_path").
+        with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
+                          'Host'=>'api.taxjar.com',
+                          'User-Agent'=>"TaxjarRubyGem/#{Taxjar::Version.to_s}"}).
+        to_return(:status => 200, :body => 'Something unexpected',
+                  :headers => {content_type: 'text/html; charset=UTF-8'})
+
+      expect{subject.perform}.to raise_error(Taxjar::Error::ServerError)
+    end
+
     Taxjar::Error::ERRORS.each do |status, exception|
       context "when HTTP status is #{status}" do
         it "raises #{exception}" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taxjar-ruby
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 2.6.1
 platform: ruby
 authors:
 - TaxJar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-09 00:00:00.000000000 Z
+date: 2019-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable