taxjar-ruby 2.4.1 → 3.0.1

data/spec/taxjar/api/request_spec.rb

@@ -41,7 +41,7 @@ describe Taxjar::API::Request do
     it 'should return headers' do
       expect(subject).to respond_to(:headers)
       expect(subject.headers).to be_instance_of(Hash)
-      expect(subject.headers[:user_agent]).to match('TaxjarRubyGem')
+      expect(subject.headers[:user_agent]).to match(/^TaxJar\/Ruby \(.+\) taxjar-ruby\/\d+\.\d+\.\d+$/)
       expect(subject.headers[:authorization]).to eq('Bearer AK')
     end
 
@@ -52,7 +52,7 @@ describe Taxjar::API::Request do
       subject = Taxjar::API::Request.new(client, :get, '/api_path', 'object')
       expect(subject).to respond_to(:headers)
       expect(subject.headers).to be_instance_of(Hash)
-      expect(subject.headers[:user_agent]).to match('TaxjarRubyGem')
+      expect(subject.headers[:user_agent]).to match(/^TaxJar\/Ruby \(.+\) taxjar-ruby\/\d+\.\d+\.\d+$/)
       expect(subject.headers[:authorization]).to eq('Bearer AK')
       expect(subject.headers['X-TJ-Expected-Response']).to eq(422)
     end
@@ -119,12 +119,25 @@ describe Taxjar::API::Request do
       Taxjar::API::Request.new(client, :get, '/api_path', 'object')
     end
 
+    context 'with a proxy' do
+      let(:client){ Taxjar::Client.new(api_key: 'AK', http_proxy: ["127.0.0.1", 8080])}
+      it "runs through the proxy" do
+        stub_request(:get, "https://api.taxjar.com/api_path").
+          with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
+                            'Host'=>'api.taxjar.com'}).
+          to_return(:status => 200, :body => '{"object": {"id": "3"}}',
+                    :headers => {content_type: 'application/json; charset=UTF-8'})
+
+        expect(subject.perform).to eq({id: '3'})
+        expect(subject.send(:build_http_client).default_options.proxy).to eq({proxy_address: "127.0.0.1", proxy_port: 8080})
+      end
+    end
+
     context 'with get' do
       it 'should return a body if no errors' do
         stub_request(:get, "https://api.taxjar.com/api_path").
           with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
-                            'Host'=>'api.taxjar.com',
-                            'User-Agent'=>"TaxjarRubyGem/#{Taxjar::Version.to_s}"}).
+                            'Host'=>'api.taxjar.com'}).
           to_return(:status => 200, :body => '{"object": {"id": "3"}}',
                     :headers => {content_type: 'application/json; charset=UTF-8'})
 
@@ -144,8 +157,7 @@ describe Taxjar::API::Request do
                     with(:body => "{\"city\":\"New York\"}",
                          :headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
                                       'Content-Type'=>'application/json; charset=UTF-8',
-                                      'Host'=>'api.taxjar.com',
-                                      'User-Agent'=>"TaxjarRubyGem/#{Taxjar::Version.to_s}"}).
+                                      'Host'=>'api.taxjar.com'}).
           to_return(:status => 200, :body => '{"object": {"id": "3"}}',
                     :headers => {content_type: 'application/json; charset=UTF-8'})
 
@@ -153,13 +165,22 @@ describe Taxjar::API::Request do
       end
     end
 
+    it 'handles unexpected Content-Type responses' do
+      stub_request(:get, "https://api.taxjar.com/api_path").
+        with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
+                          'Host'=>'api.taxjar.com'}).
+        to_return(:status => 200, :body => 'Something unexpected',
+                  :headers => {content_type: 'text/html; charset=UTF-8'})
+
+      expect{subject.perform}.to raise_error(Taxjar::Error::ServerError)
+    end
+
     Taxjar::Error::ERRORS.each do |status, exception|
       context "when HTTP status is #{status}" do
         it "raises #{exception}" do
           stub_request(:get, "https://api.taxjar.com/api_path").
             with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
-                              'Host'=>'api.taxjar.com',
-                              'User-Agent'=>"TaxjarRubyGem/#{Taxjar::Version.to_s}"}).
+                              'Host'=>'api.taxjar.com'}).
             to_return(:status => status,
                       :body => '{"error": "Not Acceptable",
                                  "detail": "error explanation",
@@ -170,5 +191,41 @@ describe Taxjar::API::Request do
         end
       end
     end
+
+    context "when HTTP status is 502" do
+      it "raises Taxjar::Error" do
+        stub_request(:get, "https://api.taxjar.com/api_path").
+          with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
+                            'Host'=>'api.taxjar.com'}).
+          to_return(:status => 502,
+                    :body => '{}',
+                    :headers => {content_type: 'application/json; charset=UTF-8'})
+
+        expect{subject.perform}.to raise_error(
+          an_instance_of(Taxjar::Error).and having_attributes({
+            "message" => "Bad Gateway",
+            "code" => 502
+          })
+        )
+      end
+    end
+
+    context "when HTTP status is 5xx" do
+      it "raises Taxjar::Error" do
+        stub_request(:get, "https://api.taxjar.com/api_path").
+          with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
+                            'Host'=>'api.taxjar.com'}).
+          to_return(:status => 509,
+                    :body => '{}',
+                    :headers => {content_type: 'application/json; charset=UTF-8'})
+
+        expect{subject.perform}.to raise_error(
+          an_instance_of(Taxjar::Error).and having_attributes({
+            "message" => "Unknown Error",
+            "code" => 509
+          })
+        )
+      end
+    end
   end
 end

data/spec/taxjar/client_spec.rb

@@ -1,7 +1,7 @@
 require 'helper'
 
 describe Taxjar::Client do
-  describe '#api_key?' do 
+  describe '#api_key?' do
     it 'returns true if api_key is present' do
       client = Taxjar::Client.new(api_key: 'AK')
       expect(client.api_key?).to be true
@@ -25,14 +25,14 @@ describe Taxjar::Client do
       client.set_api_config('api_url', 'https://api.sandbox.taxjar.com')
       expect(client.api_url).to eq('https://api.sandbox.taxjar.com')
     end
-    
+
     it 'sets new custom headers' do
       client = Taxjar::Client.new(api_key: 'AK')
       client.set_api_config('headers', { 'X-TJ-Expected-Response' => 422 })
       expect(client.headers).to eq({ 'X-TJ-Expected-Response' => 422 })
     end
   end
-  
+
   describe "#get_api_config" do
     it 'gets a config value' do
       client = Taxjar::Client.new(api_key: 'AK')
@@ -44,7 +44,7 @@ describe Taxjar::Client do
   describe '#user_agent' do
     it 'returns string with version' do
       client = Taxjar::Client.new(api_key: 'AK')
-      expect(client.user_agent).to eq("TaxjarRubyGem/#{Taxjar::Version}")
+      expect(client.user_agent).to match(/^TaxJar\/Ruby \(.+\) taxjar-ruby\/\d+\.\d+\.\d+$/)
     end
   end
 end

data/taxjar-ruby.gemspec

@@ -18,13 +18,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = '>= 2.0'
+  spec.required_ruby_version = '>= 2.3'
 
   spec.add_dependency 'addressable', '~> 2.3'
-  spec.add_dependency 'http', '>= 1.0', '< 5.0'
+  spec.add_dependency 'http', '>= 4.3', '< 5.0'
   spec.add_dependency 'memoizable', '~> 0.4.0'
   spec.add_dependency 'model_attribute', '~> 3.2'
-  spec.add_development_dependency "bundler", "~> 1.7"
+  spec.add_development_dependency "bundler", ">= 1.7", "< 3.0"
   spec.add_development_dependency "rake", "~> 12.0"
 
   if spec.respond_to?(:metadata)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taxjar-ruby
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 3.0.1
 platform: ruby
 authors:
 - TaxJar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-04 00:00:00.000000000 Z
+date: 2021-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -30,7 +30,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '4.3'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
@@ -40,7 +40,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '4.3'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
@@ -76,16 +76,22 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -189,7 +195,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -197,7 +203,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper for Taxjar API