tax_generator 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c747d61bb720bf5072dc9e9ec0870d11974e31c3
-  data.tar.gz: 971979df05fb6b2d3632f24b93c62ed318745ad4
+  metadata.gz: ebca2ea57fc475ca090d59931aa1fb5e03ebe670
+  data.tar.gz: 842a48f3c52909c6f5efb9954626b9135a057d6b
 SHA512:
-  metadata.gz: d0463ac2a1ce210da8b8e5ae4ea3348695c3d50e3e4a2bd526c7a05d8abe161cbdb26e02cd9bdceea1e7eed70928d563b5558bfa26d886899ce97be379916dc8
-  data.tar.gz: 94489169e099c7bf427d3693571c31ee7e508f680f1a078e8ef73c903f7fba861e82feae9f9db37341199ac80de6e440c9cfb16d26b18e11b983c3cb5014f49f
+  metadata.gz: 43b6403e00263f0c203a4121d98fa394e727ece241d68af14dbdb4d2aab98a7d6b750489f5982606e34b58427a241b7b627b64579599ee503f1d42a10dcebbf3
+  data.tar.gz: f29351e59eee725744c37ce1ee1ea858343e0d520d702f24756c774f6eb68ef8cfd8939bbea946d10bbe4fadca444c799d5e6ced20999c15e00fe758bc161ada

data/README.md

@@ -3,6 +3,12 @@ tax_generator
 
 [![Gem Version](https://badge.fury.io/rb/tax_generator.svg)](http://badge.fury.io/rb/tax_generator) [![Gem Downloads](https://ruby-gem-downloads-badge.herokuapp.com/tax_generator?type=total)](https://github.com/bogdanRada/tax_generator) [![Analytics](https://ga-beacon.appspot.com/UA-72570203-1/bogdanRada/tax_generator)](https://github.com/bogdanRada/tax_generator)
 
+NEW Improvements in version 0.6.0
+---------------------------------
+
+-	a lot of refactoring and bug fixes
+-	removed Celluloid in favor of Concurrent-Ruby for better performance
+
 Description
 -----------
 
@@ -25,11 +31,12 @@ Requirements
 
 1.	[Ruby 1.9.x or Ruby 2.x.x](http://www.ruby-lang.org)
 2.	[ActiveSuport >= 4.2.0](https://rubygems.org/gems/activesupport)
-3.	[celluloid >= 0.16.0](https://github.com/celluloid/celluloid)
-4.	[celluloid-pmap >= 0.2.2](https://github.com/jwo/celluloid-pmap)
+3.	[concurrent-ruby >= 1.0](https://github.com/celluloid/celluloid)
+4.	[concurrent-ruby-edge >= 0.2](https://github.com/jwo/celluloid-pmap)
 5.	[nokogiri >= 1.6.7](https://github.com/sparklemotion/nokogiri)
 6.	[slop >= 4.2.1](https://github.com/leejarvis/slop)
 7.	[rubytree >= 0.9.6](https://github.com/evolve75/RubyTree)
+8.	[tilt >= 2.0](https://github.com/rtomayko/tilt)
 
 Compatibility
 -------------

data/Rakefile

@@ -23,5 +23,5 @@ task default: [:all]
 
 desc 'Test the plugin under all supported Rails versions.'
 task :all do |_t|
-    exec('bundle exec rubocop -a . && bundle exec inch --pedantic && bundle exec yard stats --list-undoc && bundle exec rake spec')
+    exec('bundle exec rake spec')
 end

data/lib/tax_generator/version.rb

@@ -17,7 +17,7 @@ module TaxGenerator
     # minor release version
     MINOR = 6
     # tiny release version
-    TINY = 0
+    TINY = 1
     # prelease version ( set this only if it is a prelease)
     PRE = nil
 

data/spec/lib/tax_generator/classes/file_creator_spec.rb

@@ -5,7 +5,7 @@ describe TaxGenerator::FileCreator do
   let(:output_folder) {"some_other_path" }
   let(:destinations_file_path) {  "some_path" }
   let(:destination_xml) { "some_xml" }
-  let(:subject) { TaxGenerator::FileCreator.new }
+
   let(:first_destination) { "some destination" }
 
   let(:fake_node) { mock }
@@ -16,6 +16,7 @@ describe TaxGenerator::FileCreator do
 
 
   let(:job) { { atlas_id: atlas_id_value, taxonomy: fake_node, destination: first_destination, output_folder: output_folder } }
+
   before(:each) do
     destination_xml.stubs(:at_xpath).returns(fake_node)
     destination_xml.stubs(:xpath).returns([fake_node])
@@ -27,12 +28,13 @@ describe TaxGenerator::FileCreator do
     fake_tilt.stubs(:render).returns(true)
     subject.stubs(:mark_job_completed).returns(true)
     default_processor.stubs(:all_workers_finished).returns(false)
+    default_processor.stubs(:register_worker_for_job).returns(true)
   end
+    let(:subject) {
+      default_processor.stubs(:register_worker_for_job).returns(true)
+      TaxGenerator::FileCreator.new(*[job, default_processor]) }
 
   context 'checks the job keys' do
-    before(:each) do
-      subject.work(job, default_processor)
-    end
 
     specify { expect(subject.job).to eq job.stringify_keys }
     specify { expect(subject.processor).to eq default_processor }
@@ -56,15 +58,9 @@ describe TaxGenerator::FileCreator do
 
   context "job related " do
 
-    before(:each) do
-
-      subject.work(job, default_processor)
-      default_processor.stubs(:register_worker_for_job).returns(true)
-    end
 
     it 'gets start work' do
       details = {details: fake_node, root: root}
-      Actor.stubs(:current).returns(subject)
       subject.stubs(:fetch_atlas_details).returns(details)
       fake_tilt.stubs(:render).with(subject,details).returns(true)
       subject.start_work

data/spec/lib/tax_generator/classes/processor_spec.rb

@@ -6,36 +6,10 @@ describe TaxGenerator::Processor do
   let(:workers) { TaxGenerator::FileCreator.new }
 
   before(:each) do
-    Celluloid::SupervisionGroup.stubs(:run!).returns(actor_pool)
-    actor_pool.stubs(:pool).returns(workers)
-    Actor.current.stubs(:link).returns(true)
-  end
-
-  context "intialize" do
-
-    it 'boots the celluloid' do
-      Celluloid.expects(:boot).returns(true)
-      TaxGenerator::Processor.new
-    end
-
-    it 'runs the supervision group' do
-      Celluloid::SupervisionGroup.expects(:run!).returns(actor_pool)
-      TaxGenerator::Processor.new
-    end
-
-    it 'creates the pool of workers' do
-      actor_pool.expects(:pool).with(TaxGenerator::FileCreator, as: :workers, size: 50).returns(workers)
-      TaxGenerator::Processor.new
-    end
-
-    it "links the actor to the current actor" do
-      Actor.current.stubs(:link).returns(true)
-      TaxGenerator::Processor.new
-    end
-
 
   end
 
+
   context "intialize" do
 
     specify { expect(subject.jobs).to eq({}) }

data/spec/spec_helper.rb

@@ -41,11 +41,3 @@ RSpec.configure do |config|
     end
   end
 end
-
-Celluloid.logger = nil
-
-at_exit do
-  Celluloid::Actor.all.each do |actor|
-    Celluloid::Actor.kill(actor)
-  end
-end

data/tax_generator.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'concurrent-ruby', '~> 1.0', '>= 1.0'
   s.add_runtime_dependency 'concurrent-ruby-edge', '~> 0.2' , '>= 0.2'
   s.add_runtime_dependency 'slop', '~> 4.2', '>= 4.2.1'
-  s.add_runtime_dependency 'activesupport', '~> 4.2', '>= 4.2.5'
+  s.add_runtime_dependency 'activesupport', '>= 4.1', '>= 4.1.0'
   s.add_runtime_dependency 'rubytree', '~> 0.9', '>= 0.9.6'
   s.add_runtime_dependency 'tilt', '~> 2.0', '>= 2.0.1'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tax_generator
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - bogdanRada
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-27 00:00:00.000000000 Z
+date: 2016-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -94,22 +94,22 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '4.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.5
+        version: 4.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '4.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.5
+        version: 4.1.0
 - !ruby/object:Gem::Dependency
   name: rubytree
   requirement: !ruby/object:Gem::Requirement