tax_cloud 0.2.2 → 0.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: dce34f03969027431c16d3504d5f02106ae8c086
+  data.tar.gz: c55d7e4fa58df6cc206994e42ad2f0bfff8ead2b
+SHA512:
+  metadata.gz: 4c0b46885a58ebf4ba0d807d32e7b342d57b5057824d024cc60ab699e32ec5ff9ea2f815ad466362d91e468f962c1bb9b198052052adfed99b74829d4308efc7
+  data.tar.gz: 4b909e99313bfcb962d44d124cdaf1b8d2d4c27d1d067549ad00f823d474fbd1c6fe0ffc5912f3fc38aeb7cd6da9677cf89637844c7870b9bdd709642bfb1521

data/.rubocop.yml

@@ -0,0 +1,29 @@
+AllCops:
+  Excludes:
+    - vendor/**
+    - bin/**
+
+LineLength:
+  Enabled: false
+
+MethodLength:
+  Enabled: false
+
+ClassLength:
+  Enabled: false
+
+Documentation:
+  # don't require classes to be documented
+  Enabled: false
+
+NumericLiterals:
+  # don't separate numeric literals with _
+  Enabled: false
+
+RaiseArgs:
+  # don't need to provide an exception class and message, SoapError takes care of that
+  Enabled: false
+
+Encoding:
+  # missing UTF-8 comment
+  Enabled: false

data/.travis.yml

@@ -1,9 +1,6 @@
 rvm:
-  - 1.8.7
-  - 1.9.2
   - 1.9.3
-  - ruby-head
-  - jruby
-  - rbx
-  - ree
-
+  - 2.0.0
+  - 2.1.0
+  - jruby-19mode
+  - rbx-2.1.1

data/CHANGELOG.rdoc

@@ -1,3 +1,9 @@
+=== 0.3.0 (1/9/2014)
+
+* #19: Support Savon 2 - @drewtempelmeyer.
+* Implemented Rubocop, Ruby style linter - @dblock.
+* Ruby 1.8.7 and 1.9.2 are no longer supported - @dblock.
+
 === 0.2.2 (4/29/2013)
 
 * Relaxed thirdparty gem dependency versions - @mperham.

data/Gemfile

@@ -1,4 +1,9 @@
 source "http://rubygems.org"
 
-# Specify your gem's dependencies in tax_cloud.gemspec
 gemspec
+
+platform :rbx do
+  gem 'rubysl', '~> 2.0'
+  gem 'racc'
+  gem 'iconv'
+end

data/README.rdoc

@@ -135,6 +135,6 @@ TaxCloud manages a list of states in which you can calculate sales tax. The defa
 
 === License
 
-Copyright Drew Tempelmeyer and contributors, 2011-2013.
+Copyright Drew Tempelmeyer and contributors, 2011-2014.
 
-This gem is licened under the MIT license.
+This gem is licensed under the MIT license.

data/Rakefile

@@ -29,4 +29,7 @@ load 'lib/tasks/tax_code_groups.rake'
 
 load 'vcr/tasks/vcr.rake'
 
-task :default => :test
+require 'rubocop/rake_task'
+Rubocop::RakeTask.new(:rubocop)
+
+task default: [:rubocop, :test]

data/lib/hash.rb

@@ -1,11 +1,9 @@
 class Hash #:nodoc: all
-
   # Downcase the keys. Use this because <tt>TaxCloud::Address.verify</tt> requires downcased keys
   def downcase_keys
-    inject({}) do |h, (k, v)|
+    reduce({}) do |h, (k, v)|
       h[k.downcase] = v
       h
     end
   end
-
-end
+end

data/lib/tax_cloud.rb

@@ -1,7 +1,6 @@
 require 'savon'
 require 'i18n'
 require 'hash'
-require 'savon_soap_xml'
 require 'active_support/core_ext'
 
 require 'tax_cloud/version'
@@ -20,12 +19,11 @@ require 'tax_cloud/tax_code_group_constants'
 require 'tax_cloud/configuration'
 require 'tax_cloud/client'
 
-I18n.load_path << File.join(File.dirname(__FILE__), "config", "locales", "en.yml")
+I18n.load_path << File.join(File.dirname(__FILE__), 'config', 'locales', 'en.yml')
 
 # TaxCloud is a web service to calculate and track sales tax for your ecommerce platform. Integration is easy to use.
 # For information on configuring and using the TaxCloud API, look at the <tt>README</tt> file.
 module TaxCloud
-
   # WSDL location for TaxCloud API.
   WSDL_URL = 'https://api.taxcloud.net/1.0/?wsdl'
 
@@ -33,13 +31,12 @@ module TaxCloud
   API_VERSION = '1.0'
 
   class << self
-
     # TaxCloud gem configuration.
     attr_accessor :configuration
 
     # Returns true if the gem has been configured.
     def configured?
-      !! self.configuration
+      !!configuration
     end
 
     # Configure the gem.
@@ -51,21 +48,20 @@ module TaxCloud
     # Reset the current configuration.
     def reset!
       self.configuration = nil
+      @client = nil
     end
 
     # The configured SOAP client to the TaxCloud service.
     def client
       check_configuration!
-      @@client ||= TaxCloud::Client.new
+      @client ||= TaxCloud::Client.new
     end
 
     private
 
-      def check_configuration!
-        raise TaxCloud::Errors::MissingConfig.new unless self.configuration
-        self.configuration.check!
-      end
-
+    def check_configuration!
+      fail TaxCloud::Errors::MissingConfig.new unless self.configuration
+      self.configuration.check!
+    end
   end
-
 end

data/lib/tax_cloud/address.rb

@@ -1,7 +1,6 @@
 module TaxCloud #:nodoc:
   # An <tt>Address</tt> defines an address in the United States.
   class Address < Record
-
     # First line of address.
     attr_accessor :address1
     # Second line of adress.
@@ -20,9 +19,9 @@ module TaxCloud #:nodoc:
     # Returns a verified TaxCloud::Address.
     def verify
       params = to_hash.downcase_keys
-      params = params.merge({
+      params = params.merge(
         'uspsUserID' => TaxCloud.configuration.usps_username
-      }) if TaxCloud.configuration.usps_username
+      ) if TaxCloud.configuration.usps_username
       response = TaxCloud.client.request(:verify_address, params)
       TaxCloud::Responses::VerifyAddress.parse(response)
     end
@@ -31,7 +30,7 @@ module TaxCloud #:nodoc:
     # Returns a 9-digit Zip Code, when available.
     def zip
       return nil unless zip5 && zip5.length > 0
-      [ zip5, zip4 ].select { |z| z && z.length > 0 }.join("-")
+      [zip5, zip4].select { |z| z && z.length > 0 }.join('-')
     end
 
     # Convert the object to a usable hash for SOAP requests
@@ -45,6 +44,5 @@ module TaxCloud #:nodoc:
         'Zip4' => zip4
       }
     end
-
   end
 end

data/lib/tax_cloud/cart_item.rb

@@ -1,7 +1,6 @@
 module TaxCloud #:nodoc:
   # A <tt>CartItem</tt> defines a single line item for the purchase. Used to calculate the tax amount.
   class CartItem < Record
-
     # The unique index number for the line item. Must be unique for the scope of the cart.
     attr_accessor :index
     # The stock keeping unit (SKU) number.
@@ -23,6 +22,5 @@ module TaxCloud #:nodoc:
         'Qty' => quantity
       }
     end
-
   end
 end

data/lib/tax_cloud/client.rb

@@ -1,24 +1,27 @@
 module TaxCloud #:nodoc:
-  # A <tt>Client</tt> communicates with the TaCloud service.
+  # A <tt>Client</tt> communicates with the TaxCloud service.
   class Client < Savon::Client
-
     # Create a new client.
     def initialize
-      super TaxCloud::WSDL_URL
+      super wsdl: TaxCloud::WSDL_URL
     end
 
-    # Make a safe SOAP call. 
+    # Make a safe SOAP call.
     # Will raise a TaxCloud::Errors::SoapError on error.
     #
     # === Parameters
     # [method] SOAP method.
     # [body] Body content.
-    def request(method, body = {})
+    def call(method, message = {})
       safe do
-        super method, :body => body.merge(auth_params)
+        super method, message: message.merge(auth_params)
       end
     end
 
+    def request(method, message = {})
+      call method, message
+    end
+
     # Ping the TaxCloud service.
     #
     # Returns "OK" or raises an error if the TaxCloud service is unreachable.
@@ -28,21 +31,19 @@ module TaxCloud #:nodoc:
 
     private
 
-      # Authorization hash to use with all SOAP requests
-      def auth_params
-        {
-          'apiLoginID' => TaxCloud.configuration.api_login_id,
-          'apiKey' => TaxCloud.configuration.api_key
-        }
-      end
-
-      def safe &block
-        begin
-          yield
-        rescue Savon::SOAP::Fault => e
-          raise TaxCloud::Errors::SoapError.new(e)
-        end
-      end
+    # Authorization hash to use with all SOAP requests
+    def auth_params
+      return {} unless TaxCloud.configuration
+      {
+        'apiLoginID' => TaxCloud.configuration.api_login_id,
+        'apiKey' => TaxCloud.configuration.api_key
+      }
+    end
 
+    def safe(&block)
+      yield
+    rescue Savon::SOAPFault => e
+      raise TaxCloud::Errors::SoapError.new(e)
+    end
   end
 end

data/lib/tax_cloud/configuration.rb

@@ -1,7 +1,6 @@
 module TaxCloud #:nodoc:
   # TaxCloud gem configuration.
   class Configuration
-
     # TaxCloud login ID.
     attr_accessor :api_login_id
     # TaxCloud API key.
@@ -13,8 +12,8 @@ module TaxCloud #:nodoc:
     #
     # Will raise a TaxCloud::Errors::MissingConfigOption if any of the API login ID or the API key are missing.
     def check!
-      raise TaxCloud::Errors::MissingConfigOption.new('api_login_id') unless self.api_login_id && self.api_login_id.strip.length > 0
-      raise TaxCloud::Errors::MissingConfigOption.new('api_key') unless self.api_key && self.api_key.strip.length > 0
+      fail TaxCloud::Errors::MissingConfigOption.new('api_login_id') unless api_login_id && api_login_id.strip.length > 0
+      fail TaxCloud::Errors::MissingConfigOption.new('api_key') unless api_key && api_key.strip.length > 0
     end
   end
 end

data/lib/tax_cloud/errors/api_error.rb

@@ -1,18 +1,18 @@
 # encoding: utf-8
 module TaxCloud #:nodoc:
   module Errors #:nodoc:
-    # This error is raised when the TaxCloud service 
+    # This error is raised when the TaxCloud service
     # returns an error from an API.
     class ApiError < TaxCloudError
       # === Parameters
       # [message] Error message.
       # [raw] Raw data from the SOAP response.
       def initialize(message, raw)
-        super(compose_message("api_error", {
-          :message => message,
-          :raw => raw
-        }))
+        super(compose_message('api_error',
+                              message: message,
+                              raw: raw
+        ))
       end
     end
   end
-end
+end

data/lib/tax_cloud/errors/missing_config_error.rb

@@ -6,8 +6,8 @@ module TaxCloud #:nodoc:
     class MissingConfig < TaxCloudError
       # Create a new error.
       def initialize
-        super(compose_message("missing_config"))
+        super(compose_message('missing_config'))
       end
     end
   end
-end
+end

data/lib/tax_cloud/errors/missing_config_option_error.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 module TaxCloud #:nodoc:
   module Errors #:nodoc:
-    # This error is raised when a configuration 
+    # This error is raised when a configuration
     # option is missing.
     class MissingConfigOption < TaxCloudError
       # === Parameters
@@ -9,11 +9,11 @@ module TaxCloud #:nodoc:
       def initialize(name)
         super(
           compose_message(
-            "missing_config_option",
-            { :name => name }
+            'missing_config_option',
+            name: name
           )
         )
-      end      
+      end
     end
   end
-end
+end

data/lib/tax_cloud/errors/soap_error.rb

@@ -3,7 +3,6 @@ module TaxCloud #:nodoc:
   module Errors #:nodoc:
     # This error is raised when a SOAP call fails.
     class SoapError < TaxCloudError
-
       # Original SOAP failt.
       attr_reader :fault
 
@@ -15,19 +14,18 @@ module TaxCloud #:nodoc:
         e.to_hash.tap do |fault|
           fault_code = fault[:fault][:faultcode]
           fault_string = parse_fault(fault[:fault][:faultstring])
-          super(compose_message("soap_error", {
-            :message => fault_string,
-            :code => fault_code
-          }))          
+          super(compose_message('soap_error',
+                                message: fault_string,
+                                code: fault_code
+          ))
         end
       end
 
       private
 
-        def parse_fault(fault_string)
-          fault_string.lines.first.strip
-        end
-
+      def parse_fault(fault_string)
+        fault_string.lines.first.strip
+      end
     end
   end
-end
+end

data/lib/tax_cloud/errors/tax_cloud_error.rb

@@ -1,14 +1,12 @@
 # encoding: utf-8
 module TaxCloud #:nodoc:
   module Errors #:nodoc:
-
     # Default parent TaxCloud error for all custom errors. This handles the base
     # key for the translations and provides the convenience method for
     # translating the messages.
     #
     # Generously borrowed from Mongoid[https://github.com/mongoid/mongoid/blob/master/lib/mongoid/errors/mongoid_error.rb].
     class TaxCloudError < StandardError
-
       # Problem occurred.
       attr_reader :problem
 
@@ -27,60 +25,59 @@ module TaxCloud #:nodoc:
         @summary = create_summary(key, attributes)
         @resolution = create_resolution(key, attributes)
 
-        "\nProblem:\n  #{@problem}"+
-        "\nSummary:\n  #{@summary}"+
+        "\nProblem:\n  #{@problem}" +
+        "\nSummary:\n  #{@summary}" +
         "\nResolution:\n  #{@resolution}"
       end
 
       private
 
-        BASE_KEY = "taxcloud.errors.messages" #:nodoc:
-
-        # Given the key of the specific error and the options hash, translate the
-        # message.
-        #
-        # === Parameters
-        # [key] The key of the error in the locales.
-        # [options] The objects to pass to create the message.
-        #
-        # Returns a localized error message string.
-        def translate(key, options)
-          ::I18n.translate("#{BASE_KEY}.#{key}", { :locale => :en }.merge(options)).strip
-        end
+      BASE_KEY = 'taxcloud.errors.messages' #:nodoc:
 
-        # Create the problem.
-        #
-        # === Parameters
-        # [key] The error key.
-        # [attributes] The attributes to interpolate.
-        #
-        # Returns the problem.
-        def create_problem(key, attributes)
-          translate("#{key}.message", attributes)
-        end
+      # Given the key of the specific error and the options hash, translate the
+      # message.
+      #
+      # === Parameters
+      # [key] The key of the error in the locales.
+      # [options] The objects to pass to create the message.
+      #
+      # Returns a localized error message string.
+      def translate(key, options)
+        ::I18n.translate("#{BASE_KEY}.#{key}", { locale: :en }.merge(options)).strip
+      end
 
-        # Create the summary.
-        #
-        # === Parameters
-        # [key] The error key.
-        # [attributes] The attributes to interpolate.
-        #
-        # Returns the summary.
-        def create_summary(key, attributes)
-          translate("#{key}.summary", attributes)
-        end
+      # Create the problem.
+      #
+      # === Parameters
+      # [key] The error key.
+      # [attributes] The attributes to interpolate.
+      #
+      # Returns the problem.
+      def create_problem(key, attributes)
+        translate("#{key}.message", attributes)
+      end
 
-        # Create the resolution.
-        #
-        # === Parameters
-        # [key] The error key.
-        # [attributes] The attributes to interpolate.
-        #
-        # Returns the resolution.
-        def create_resolution(key, attributes)
-          translate("#{key}.resolution", attributes)
-        end
+      # Create the summary.
+      #
+      # === Parameters
+      # [key] The error key.
+      # [attributes] The attributes to interpolate.
+      #
+      # Returns the summary.
+      def create_summary(key, attributes)
+        translate("#{key}.summary", attributes)
+      end
 
+      # Create the resolution.
+      #
+      # === Parameters
+      # [key] The error key.
+      # [attributes] The attributes to interpolate.
+      #
+      # Returns the resolution.
+      def create_resolution(key, attributes)
+        translate("#{key}.resolution", attributes)
+      end
     end
   end
-end
+end