tax_cloud 0.2.2 → 0.3.0

data/lib/tax_cloud/errors/unexpected_soap_response_error.rb

@@ -1,23 +1,20 @@
 # encoding: utf-8
 module TaxCloud #:nodoc:
   module Errors #:nodoc:
-
-    # This error is raised when TaxCloud returns an 
+    # This error is raised when TaxCloud returns an
     # unexpected SOAP response.
     class UnexpectedSoapResponse < TaxCloudError
-
       # === Parameters
       # [raw] Raw data from the SOAP response.
       # [key] Expected key in the SOAP response.
       # [chain] Complete SOAP response chain in which the key could not be found.
       def initialize(raw, key, chain)
-        super(compose_message("unexpected_soap_response", {
-          :key => key,
-          :raw => raw,
-          :chain => chain
-        }))
+        super(compose_message('unexpected_soap_response',
+                              key: key,
+                              raw: raw,
+                              chain: chain
+        ))
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/record.rb

@@ -7,7 +7,7 @@ module TaxCloud #:nodoc:
     # [attrs] Attributes defined for this record.
     def initialize(attrs = {})
       attrs.each do |sym, val|
-        self.send "#{sym}=", val
+        send "#{sym}=", val
       end
     end
   end

data/lib/tax_cloud/responses.rb

@@ -10,4 +10,4 @@ require 'tax_cloud/responses/captured'
 require 'tax_cloud/responses/returned'
 require 'tax_cloud/responses/tax_codes'
 require 'tax_cloud/responses/tax_code_groups'
-require 'tax_cloud/responses/tax_codes_by_group'
+require 'tax_cloud/responses/tax_codes_by_group'

data/lib/tax_cloud/responses/authorized.rb

@@ -7,4 +7,4 @@ module TaxCloud #:nodoc:
       response_key :authorized
     end
   end
-end
+end

data/lib/tax_cloud/responses/authorized_with_capture.rb

@@ -7,4 +7,4 @@ module TaxCloud #:nodoc:
       response_key :authorized_with_capture
     end
   end
-end
+end

data/lib/tax_cloud/responses/base.rb

@@ -1,10 +1,8 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # A base TaxCloud SOAP response.
     class Base
-
-      # Raw response.      
+      # Raw response.
       attr_accessor :raw
 
       # === Parameters
@@ -15,23 +13,22 @@ module TaxCloud #:nodoc:
       end
 
       class << self
-
         # === Parameters
         # [value] Location of the response type in the SOAP XML.
         def response_type(value)
-          self.set_dsl(:response_type, value)
+          set_dsl(:response_type, value)
         end
 
         # === Parameters
         # [value] Location of the error message in the SOAP XML.
         def error_message(value)
-          self.set_dsl(:error_message, value)
+          set_dsl(:error_message, value)
         end
 
         # === Parameters
         # [value] Location of the error number in the SOAP XML.
         def error_number(value)
-          self.set_dsl(:error_number, value)
+          set_dsl(:error_number, value)
         end
 
         # Parse a SOAP response.
@@ -39,7 +36,7 @@ module TaxCloud #:nodoc:
         # === Parameters
         # [savon_response] SOAP response.
         def parse(savon_response)
-          self.new(savon_response)
+          new(savon_response)
         end
       end
 
@@ -49,40 +46,39 @@ module TaxCloud #:nodoc:
       # [chain] XML path to match.
       def match(chain)
         current_value = raw
-        chain.split("/").each do |key|
+        chain.split('/').each do |key|
           current_value = current_value[key.to_sym]
           next if current_value
-          raise TaxCloud::Errors::UnexpectedSoapResponse.new(raw, key, chain)
+          fail TaxCloud::Errors::UnexpectedSoapResponse.new(raw, key, chain)
         end
         current_value
       end
 
       private
 
-        class_attribute :dsl
+      class_attribute :dsl
 
-        class << self
-          def set_dsl(key, value)
-            self.dsl ||= {}
-            self.dsl[key] = value
-            self.dsl
-          end
+      class << self
+        def set_dsl(key, value)
+          self.dsl ||= {}
+          self.dsl[key] = value
+          self.dsl
         end
+      end
 
-        def parse!
-          if self.dsl[:response_type]
-            case match(self.dsl[:response_type])
-            when "OK", "Informational" then
-              return true
-            end
-          elsif self.dsl[:error_number]
-            return true if match(self.dsl[:error_number]) == "0"
-          end
-          if self.dsl[:error_message]
-            raise TaxCloud::Errors::ApiError.new(match(self.dsl[:error_message]), raw)
+      def parse!
+        if self.dsl[:response_type]
+          case match(self.dsl[:response_type])
+          when 'OK', 'Informational' then
+            return true
           end
+        elsif self.dsl[:error_number]
+          return true if match(self.dsl[:error_number]) == '0'
         end
-
+        if self.dsl[:error_message]
+          fail TaxCloud::Errors::ApiError.new(match(self.dsl[:error_message]), raw)
+        end
+      end
     end
   end
-end
+end

data/lib/tax_cloud/responses/captured.rb

@@ -1,11 +1,10 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # Response to a TaxCloud Captured API call.
-    # 
+    #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=Captured.
     class Captured < Generic
       response_key :captured
     end
   end
-end
+end

data/lib/tax_cloud/responses/cart_item.rb

@@ -1,11 +1,9 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # A single item in the response to a TaxCloud Lookup API call.
-    # 
+    #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=Lookup.
     class CartItem
-
       # The index of the cart item.
       attr_accessor :cart_item_index
 
@@ -18,7 +16,6 @@ module TaxCloud #:nodoc:
         self.cart_item_index = savon_response[:cart_item_index].to_i
         self.tax_amount = savon_response[:tax_amount].to_f
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/responses/generic.rb

@@ -1,14 +1,11 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # A generic response to a TaxCloud API call.
     class Generic < Base
-
       # Response key.
       class_attribute :key
 
       class << self
-
         # Set the response key.
         # === Parameters
         # [key] Response key.
@@ -25,11 +22,10 @@ module TaxCloud #:nodoc:
         #
         # Usually returns "OK" or raises an error.
         def parse(savon_response)
-          response = self.new(savon_response)
+          response = new(savon_response)
           response.raw["#{key}_response".to_sym]["#{key}_result".to_sym][:response_type]
         end
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/responses/lookup.rb

@@ -1,41 +1,38 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # Response to a TaxCloud Lookup API call.
     #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=Lookup.
     class Lookup < Base
-
       # Cart ID.
       attr_accessor :cart_id
 
       # Cart items.
       attr_accessor :cart_items
 
-      response_type "lookup_response/lookup_result/response_type"
-      error_message "lookup_response/lookup_result/messages/response_message/message"
+      response_type 'lookup_response/lookup_result/response_type'
+      error_message 'lookup_response/lookup_result/messages/response_message/message'
 
       # === Parameters
       # [savon_response] SOAP response.
       def initialize(savon_response)
         super savon_response
-        self.cart_id = match("lookup_response/lookup_result/cart_id")
+        self.cart_id = match('lookup_response/lookup_result/cart_id')
         # there can be on response or an array of responses
-        cart_item_responses = match("lookup_response/lookup_result/cart_items_response/cart_item_response")
+        cart_item_responses = match('lookup_response/lookup_result/cart_items_response/cart_item_response')
         if cart_item_responses.is_a?(Array)
           self.cart_items = cart_item_responses.map do |cart_item_response|
             TaxCloud::Responses::CartItem.new(cart_item_response)
           end
         else
-          self.cart_items = [ TaxCloud::Responses::CartItem.new(cart_item_responses) ]
+          self.cart_items = [TaxCloud::Responses::CartItem.new(cart_item_responses)]
         end
       end
 
       # Total tax amount in this cart.
       def tax_amount
-        cart_items.inject(0) { |acc, item| acc + item.tax_amount }
+        cart_items.reduce(0) { |a, e| a + e.tax_amount }
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/responses/ping.rb

@@ -1,10 +1,10 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
     # Response to a TaxCloud Ping API call.
-    # 
+    #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=Ping.
     class Ping < Generic
       response_key :ping
     end
   end
-end
+end

data/lib/tax_cloud/responses/returned.rb

@@ -1,10 +1,10 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
     # Response to a TaxCloud Returned API call.
-    # 
+    #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=Returned.
     class Returned < Generic
       response_key :returned
     end
   end
-end
+end

data/lib/tax_cloud/responses/tax_code_groups.rb

@@ -1,33 +1,30 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # Response to a TaxCloud getTICGroups API call.
     #
     # https://api.taxcloud.net/1.0/TaxCloud.asmx?op=GetTICGroups
     class TaxCodeGroups < Base
-
-      response_type "get_tic_groups_response/get_tic_groups_result/response_type"
-      error_message "get_tic_groups_response/get_tic_groups_result/messages/response_message/message"
+      response_type 'get_tic_groups_response/get_tic_groups_result/response_type'
+      error_message 'get_tic_groups_response/get_tic_groups_result/messages/response_message/message'
 
       class << self
         # Parse a TaxCloud response.
         #
-        # === Parameters        
+        # === Parameters
         # [savon_response] SOAP response.
         #
         # Returns an array of Tax Code Groups.
         def parse(savon_response)
-          response = self.new(savon_response)
-          tax_code_groups = response.match("get_tic_groups_response/get_tic_groups_result/tic_groups/tic_group")
+          response = new(savon_response)
+          tax_code_groups = response.match('get_tic_groups_response/get_tic_groups_result/tic_groups/tic_group')
           tax_code_groups.map do |tax_code_group|
-            TaxCloud::TaxCodeGroup.new({ 
-              :group_id => tax_code_group[:group_id].to_i,
-              :description => tax_code_group[:description].strip
-            })
+            TaxCloud::TaxCodeGroup.new(
+              group_id: tax_code_group[:group_id].to_i,
+              description: tax_code_group[:description].strip
+            )
           end
         end
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/responses/tax_codes.rb

@@ -1,13 +1,11 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # Response to a TaxCloud getTICs API call.
     #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=GetTICs.
     class TaxCodes < Base
-
-      response_type "get_ti_cs_response/get_ti_cs_result/response_type"
-      error_message "get_ti_cs_response/get_ti_cs_result/messages/response_message/message"
+      response_type 'get_ti_cs_response/get_ti_cs_result/response_type'
+      error_message 'get_ti_cs_response/get_ti_cs_result/messages/response_message/message'
 
       class << self
         # Parse a TaxCloud response.
@@ -17,17 +15,16 @@ module TaxCloud #:nodoc:
         #
         # Returns an array of tax codes.
         def parse(savon_response)
-          response = self.new(savon_response)
-          tax_codes = response.match("get_ti_cs_response/get_ti_cs_result/ti_cs/tic")
+          response = new(savon_response)
+          tax_codes = response.match('get_ti_cs_response/get_ti_cs_result/ti_cs/tic')
           tax_codes.map do |tax_code|
-            TaxCloud::TaxCode.new({ 
-              :ticid => tax_code[:ticid].to_i,
-              :description => tax_code[:description].strip
-            })
+            TaxCloud::TaxCode.new(
+              ticid: tax_code[:ticid].to_i,
+              description: tax_code[:description].strip
+            )
           end
         end
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/responses/tax_codes_by_group.rb

@@ -1,33 +1,30 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # Response to a TaxCloud getTICsByGroup API call.
-    # 
+    #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=GetTICsByGroup.
     class TaxCodesByGroup < Base
-
-      response_type "get_ti_cs_by_group_response/get_ti_cs_by_group_result/response_type"
-      error_message "get_ti_cs_by_group_response/get_ti_cs_by_group_result/messages/response_message/message"
+      response_type 'get_ti_cs_by_group_response/get_ti_cs_by_group_result/response_type'
+      error_message 'get_ti_cs_by_group_response/get_ti_cs_by_group_result/messages/response_message/message'
 
       class << self
         # Parse a TaxCloud response.
         #
-        # === Parameters        
+        # === Parameters
         # [savon_response] SOAP response.
         #
         # Returns an array of tax codes.
         def parse(savon_response)
-          response = self.new(savon_response)
-          tax_codes = response.match("get_ti_cs_by_group_response/get_ti_cs_by_group_result/ti_cs/tic")
+          response = new(savon_response)
+          tax_codes = response.match('get_ti_cs_by_group_response/get_ti_cs_by_group_result/ti_cs/tic')
           tax_codes.map do |tax_code|
-            TaxCloud::TaxCode.new({ 
-              :ticid => tax_code[:ticid].to_i,
-              :description => tax_code[:description] 
-            })
+            TaxCloud::TaxCode.new(
+              ticid: tax_code[:ticid].to_i,
+              description: tax_code[:description]
+            )
           end
         end
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/responses/verify_address.rb

@@ -1,14 +1,12 @@
 module TaxCloud #:nodoc:
   module Responses #:nodoc:
-
     # Response to a TaxCloud VerifyAddress API call.
-    # 
+    #
     # See https://api.taxcloud.net/1.0/TaxCloud.asmx?op=VerifyAddress.
     class VerifyAddress < Base
+      error_number 'verify_address_response/verify_address_result/err_number'
+      error_message 'verify_address_response/verify_address_result/err_description'
 
-      error_number "verify_address_response/verify_address_result/err_number"
-      error_message "verify_address_response/verify_address_result/err_description"
-      
       class << self
         # Parse a TaxCloud response.
         #
@@ -17,13 +15,12 @@ module TaxCloud #:nodoc:
         #
         # Returns a verified TaxCloud::Address.
         def parse(savon_response)
-          response = self.new(savon_response)
-          result = response.match("verify_address_response/verify_address_result")
+          response = new(savon_response)
+          result = response.match('verify_address_response/verify_address_result')
           result.delete(:err_number)
           TaxCloud::Address.new result
         end
       end
-
     end
   end
-end
+end