tastytrade 0.2.0 → 0.3.1

data/spec/tastytrade/session_env_spec.rb

@@ -0,0 +1,169 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe Tastytrade::Session do
+  describe ".from_environment" do
+    around do |example|
+      # Save original environment
+      original_env = ENV.to_hash
+
+      # Clear relevant environment variables
+      %w[TASTYTRADE_USERNAME TT_USERNAME TASTYTRADE_PASSWORD TT_PASSWORD
+         TASTYTRADE_REMEMBER TT_REMEMBER TASTYTRADE_ENVIRONMENT TT_ENVIRONMENT].each do |key|
+        ENV.delete(key)
+      end
+
+      example.run
+
+      # Restore original environment
+      ENV.clear
+      ENV.update(original_env)
+    end
+
+    context "with TASTYTRADE_ prefixed variables" do
+      before do
+        ENV["TASTYTRADE_USERNAME"] = "test@example.com"
+        ENV["TASTYTRADE_PASSWORD"] = "test_password"
+      end
+
+      it "creates a session with username and password" do
+        session = described_class.from_environment
+        expect(session).not_to be_nil
+        expect(session.instance_variable_get(:@username)).to eq("test@example.com")
+        expect(session.instance_variable_get(:@password)).to eq("test_password")
+      end
+
+      it "defaults to production environment" do
+        session = described_class.from_environment
+        expect(session.is_test).to be false
+      end
+
+      it "defaults to remember_me false" do
+        session = described_class.from_environment
+        expect(session.instance_variable_get(:@remember_me)).to be false
+      end
+
+      context "with TASTYTRADE_REMEMBER set to true" do
+        before do
+          ENV["TASTYTRADE_REMEMBER"] = "true"
+        end
+
+        it "enables remember_me" do
+          session = described_class.from_environment
+          expect(session.instance_variable_get(:@remember_me)).to be true
+        end
+      end
+
+      context "with TASTYTRADE_REMEMBER set to TRUE" do
+        before do
+          ENV["TASTYTRADE_REMEMBER"] = "TRUE"
+        end
+
+        it "enables remember_me (case insensitive)" do
+          session = described_class.from_environment
+          expect(session.instance_variable_get(:@remember_me)).to be true
+        end
+      end
+
+      context "with TASTYTRADE_ENVIRONMENT set to sandbox" do
+        before do
+          ENV["TASTYTRADE_ENVIRONMENT"] = "sandbox"
+        end
+
+        it "sets is_test to true" do
+          session = described_class.from_environment
+          expect(session.is_test).to be true
+        end
+      end
+
+      context "with TASTYTRADE_ENVIRONMENT set to SANDBOX" do
+        before do
+          ENV["TASTYTRADE_ENVIRONMENT"] = "SANDBOX"
+        end
+
+        it "sets is_test to true (case insensitive)" do
+          session = described_class.from_environment
+          expect(session.is_test).to be true
+        end
+      end
+    end
+
+    context "with TT_ prefixed variables" do
+      before do
+        ENV["TT_USERNAME"] = "tt@example.com"
+        ENV["TT_PASSWORD"] = "tt_password"
+      end
+
+      it "creates a session with username and password" do
+        session = described_class.from_environment
+        expect(session).not_to be_nil
+        expect(session.instance_variable_get(:@username)).to eq("tt@example.com")
+        expect(session.instance_variable_get(:@password)).to eq("tt_password")
+      end
+
+      context "with TT_REMEMBER set" do
+        before do
+          ENV["TT_REMEMBER"] = "true"
+        end
+
+        it "enables remember_me" do
+          session = described_class.from_environment
+          expect(session.instance_variable_get(:@remember_me)).to be true
+        end
+      end
+
+      context "with TT_ENVIRONMENT set to sandbox" do
+        before do
+          ENV["TT_ENVIRONMENT"] = "sandbox"
+        end
+
+        it "sets is_test to true" do
+          session = described_class.from_environment
+          expect(session.is_test).to be true
+        end
+      end
+    end
+
+    context "with both TASTYTRADE_ and TT_ variables" do
+      before do
+        ENV["TASTYTRADE_USERNAME"] = "tastytrade@example.com"
+        ENV["TT_USERNAME"] = "tt@example.com"
+        ENV["TASTYTRADE_PASSWORD"] = "tastytrade_password"
+        ENV["TT_PASSWORD"] = "tt_password"
+      end
+
+      it "prefers TASTYTRADE_ prefixed variables" do
+        session = described_class.from_environment
+        expect(session.instance_variable_get(:@username)).to eq("tastytrade@example.com")
+        expect(session.instance_variable_get(:@password)).to eq("tastytrade_password")
+      end
+    end
+
+    context "with missing username" do
+      before do
+        ENV["TASTYTRADE_PASSWORD"] = "test_password"
+      end
+
+      it "returns nil" do
+        expect(described_class.from_environment).to be_nil
+      end
+    end
+
+    context "with missing password" do
+      before do
+        ENV["TASTYTRADE_USERNAME"] = "test@example.com"
+      end
+
+      it "returns nil" do
+        expect(described_class.from_environment).to be_nil
+      end
+    end
+
+    context "with no environment variables set" do
+      it "returns nil" do
+        expect(described_class.from_environment).to be_nil
+      end
+    end
+  end
+end

data/spec/tastytrade/session_manager_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 require "tastytrade/session_manager"
-require "tastytrade/keyring_store"
+require "tastytrade/file_store"
 require "tastytrade/cli_config"
 
 RSpec.describe Tastytrade::SessionManager do
@@ -16,7 +16,7 @@ RSpec.describe Tastytrade::SessionManager do
     allow(Tastytrade::CLIConfig).to receive(:new).and_return(config)
     allow(config).to receive(:set)
     allow(config).to receive(:delete)
-    allow(Tastytrade::KeyringStore).to receive(:available?).and_return(true)
+    allow(Tastytrade::FileStore).to receive(:available?).and_return(true)
   end
 
   describe "#initialize" do
@@ -34,16 +34,21 @@ RSpec.describe Tastytrade::SessionManager do
   describe "#save_session" do
     let(:session_token) { "session_token_123" }
     let(:remember_token) { "remember_token_456" }
+    let(:user) { instance_double(Tastytrade::Models::User,
+                                email: "test@example.com",
+                                username: "testuser",
+                                external_id: "test-external-id") }
 
     before do
       allow(session).to receive(:session_token).and_return(session_token)
       allow(session).to receive(:remember_token).and_return(remember_token)
       allow(session).to receive(:session_expiration).and_return(nil)
-      allow(Tastytrade::KeyringStore).to receive(:set).and_return(true)
+      allow(session).to receive(:user).and_return(user)
+      allow(Tastytrade::FileStore).to receive(:set).and_return(true)
     end
 
     it "saves session token" do
-      expect(Tastytrade::KeyringStore).to receive(:set)
+      expect(Tastytrade::FileStore).to receive(:set)
         .with("token_test@example.com_production", session_token)
 
       manager.save_session(session)
@@ -57,7 +62,7 @@ RSpec.describe Tastytrade::SessionManager do
       end
 
       it "saves session expiration" do
-        expect(Tastytrade::KeyringStore).to receive(:set)
+        expect(Tastytrade::FileStore).to receive(:set)
           .with("session_expiration_test@example.com_production", expiration_time.iso8601)
 
         manager.save_session(session)
@@ -74,18 +79,18 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "with remember option" do
       it "saves remember token and password" do
-        expect(Tastytrade::KeyringStore).to receive(:set)
+        expect(Tastytrade::FileStore).to receive(:set)
           .with("remember_test@example.com_production", remember_token)
-        expect(Tastytrade::KeyringStore).to receive(:set)
+        expect(Tastytrade::FileStore).to receive(:set)
           .with("password_test@example.com_production", "secret123")
 
         manager.save_session(session, password: "secret123", remember: true)
       end
 
       it "doesn't save password if keyring unavailable" do
-        allow(Tastytrade::KeyringStore).to receive(:available?).and_return(false)
+        allow(Tastytrade::FileStore).to receive(:available?).and_return(false)
 
-        expect(Tastytrade::KeyringStore).not_to receive(:set)
+        expect(Tastytrade::FileStore).not_to receive(:set)
           .with("password_test@example.com_production", anything)
 
         manager.save_session(session, password: "secret123", remember: true)
@@ -94,9 +99,9 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "without remember option" do
       it "doesn't save remember token or password" do
-        expect(Tastytrade::KeyringStore).not_to receive(:set)
+        expect(Tastytrade::FileStore).not_to receive(:set)
           .with("remember_test@example.com_production", anything)
-        expect(Tastytrade::KeyringStore).not_to receive(:set)
+        expect(Tastytrade::FileStore).not_to receive(:set)
           .with("password_test@example.com_production", anything)
 
         manager.save_session(session, password: "secret123", remember: false)
@@ -104,7 +109,7 @@ RSpec.describe Tastytrade::SessionManager do
     end
 
     it "handles errors gracefully" do
-      allow(Tastytrade::KeyringStore).to receive(:set).and_raise(StandardError, "Save error")
+      allow(Tastytrade::FileStore).to receive(:set).and_raise(StandardError, "Save error")
 
       expect { manager.save_session(session) }.to output(/Failed to save session/).to_stderr
       expect(manager.save_session(session)).to be false
@@ -114,11 +119,14 @@ RSpec.describe Tastytrade::SessionManager do
   describe "#load_session" do
     context "with saved token" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("token_test@example.com_production").and_return("saved_token")
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("remember_test@example.com_production").and_return("saved_remember")
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
+          .with("user_data_test@example.com_production")
+          .and_return('{"email":"test@example.com","username":"testuser","external_id":"test-external-id"}')
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("session_expiration_test@example.com_production").and_return(nil)
       end
 
@@ -128,6 +136,8 @@ RSpec.describe Tastytrade::SessionManager do
         expect(result).to eq({
                                session_token: "saved_token",
                                remember_token: "saved_remember",
+                               user_data: { "email" => "test@example.com", "username" => "testuser",
+                                            "external_id" => "test-external-id" },
                                session_expiration: nil,
                                username: username,
                                environment: environment
@@ -137,7 +147,7 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "without saved token" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("token_test@example.com_production").and_return(nil)
       end
 
@@ -157,9 +167,9 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "with saved remember token" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("password_test@example.com_production").and_return(nil)
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("remember_test@example.com_production").and_return("saved_remember")
       end
 
@@ -177,9 +187,9 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "with saved password" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("remember_test@example.com_production").and_return(nil)
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("password_test@example.com_production").and_return("saved_password")
       end
 
@@ -199,9 +209,9 @@ RSpec.describe Tastytrade::SessionManager do
       let(:environment) { "sandbox" }
 
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("password_test@example.com_sandbox").and_return("saved_password")
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("remember_test@example.com_sandbox").and_return(nil)
       end
 
@@ -216,7 +226,7 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "without saved credentials" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get).and_return(nil)
+        allow(Tastytrade::FileStore).to receive(:get).and_return(nil)
       end
 
       it "returns nil" do
@@ -225,9 +235,9 @@ RSpec.describe Tastytrade::SessionManager do
     end
 
     it "handles errors gracefully" do
-      allow(Tastytrade::KeyringStore).to receive(:get)
+      allow(Tastytrade::FileStore).to receive(:get)
         .with("password_test@example.com_production").and_return("password")
-      allow(Tastytrade::KeyringStore).to receive(:get)
+      allow(Tastytrade::FileStore).to receive(:get)
         .with("remember_test@example.com_production").and_return(nil)
       allow(new_session).to receive(:login).and_raise(StandardError, "Login error")
 
@@ -238,13 +248,13 @@ RSpec.describe Tastytrade::SessionManager do
 
   describe "#clear_session!" do
     it "deletes all stored credentials" do
-      expect(Tastytrade::KeyringStore).to receive(:delete)
+      expect(Tastytrade::FileStore).to receive(:delete)
         .with("token_test@example.com_production")
-      expect(Tastytrade::KeyringStore).to receive(:delete)
+      expect(Tastytrade::FileStore).to receive(:delete)
         .with("remember_test@example.com_production")
-      expect(Tastytrade::KeyringStore).to receive(:delete)
+      expect(Tastytrade::FileStore).to receive(:delete)
         .with("password_test@example.com_production")
-      expect(Tastytrade::KeyringStore).to receive(:delete)
+      expect(Tastytrade::FileStore).to receive(:delete)
         .with("session_expiration_test@example.com_production")
 
       manager.clear_session!
@@ -261,7 +271,7 @@ RSpec.describe Tastytrade::SessionManager do
   describe "#saved_credentials?" do
     context "with saved password" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("password_test@example.com_production").and_return("password")
       end
 
@@ -272,9 +282,9 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "with saved remember token" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("password_test@example.com_production").and_return(nil)
-        allow(Tastytrade::KeyringStore).to receive(:get)
+        allow(Tastytrade::FileStore).to receive(:get)
           .with("remember_test@example.com_production").and_return("token")
       end
 
@@ -285,7 +295,7 @@ RSpec.describe Tastytrade::SessionManager do
 
     context "without saved credentials" do
       before do
-        allow(Tastytrade::KeyringStore).to receive(:get).and_return(nil)
+        allow(Tastytrade::FileStore).to receive(:get).and_return(nil)
       end
 
       it "returns false" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tastytrade
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Ryan Hamamura
@@ -37,20 +37,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
-- !ruby/object:Gem::Dependency
-  name: keyring
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: pastel
   requirement: !ruby/object:Gem::Requirement
@@ -215,6 +201,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".claude/commands/plan.md"
 - ".claude/commands/release-pr.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/ISSUE_TEMPLATE/roadmap_task.md"
@@ -238,37 +225,66 @@ files:
 - exe/tastytrade
 - lib/tastytrade.rb
 - lib/tastytrade/cli.rb
+- lib/tastytrade/cli/history_formatter.rb
+- lib/tastytrade/cli/orders.rb
+- lib/tastytrade/cli/positions_formatter.rb
 - lib/tastytrade/cli_config.rb
 - lib/tastytrade/cli_helpers.rb
 - lib/tastytrade/client.rb
-- lib/tastytrade/keyring_store.rb
+- lib/tastytrade/file_store.rb
+- lib/tastytrade/instruments/equity.rb
 - lib/tastytrade/models.rb
 - lib/tastytrade/models/account.rb
 - lib/tastytrade/models/account_balance.rb
 - lib/tastytrade/models/base.rb
+- lib/tastytrade/models/buying_power_effect.rb
 - lib/tastytrade/models/current_position.rb
+- lib/tastytrade/models/live_order.rb
+- lib/tastytrade/models/order_response.rb
+- lib/tastytrade/models/order_status.rb
+- lib/tastytrade/models/trading_status.rb
+- lib/tastytrade/models/transaction.rb
 - lib/tastytrade/models/user.rb
+- lib/tastytrade/order.rb
+- lib/tastytrade/order_validator.rb
 - lib/tastytrade/session.rb
 - lib/tastytrade/session_manager.rb
 - lib/tastytrade/version.rb
 - sig/tastytrade.rbs
 - spec/exe/tastytrade_spec.rb
 - spec/spec_helper.rb
+- spec/tastytrade/cli/positions_spec.rb
 - spec/tastytrade/cli_accounts_spec.rb
 - spec/tastytrade/cli_auth_spec.rb
 - spec/tastytrade/cli_config_spec.rb
+- spec/tastytrade/cli_env_login_spec.rb
 - spec/tastytrade/cli_helpers_spec.rb
 - spec/tastytrade/cli_interactive_spec.rb
 - spec/tastytrade/cli_logout_spec.rb
+- spec/tastytrade/cli_orders_spec.rb
 - spec/tastytrade/cli_select_spec.rb
 - spec/tastytrade/cli_status_spec.rb
 - spec/tastytrade/client_spec.rb
-- spec/tastytrade/keyring_store_spec.rb
+- spec/tastytrade/file_store_spec.rb
 - spec/tastytrade/models/account_balance_spec.rb
+- spec/tastytrade/models/account_order_history_spec.rb
+- spec/tastytrade/models/account_order_management_spec.rb
+- spec/tastytrade/models/account_place_order_spec.rb
 - spec/tastytrade/models/account_spec.rb
 - spec/tastytrade/models/base_spec.rb
+- spec/tastytrade/models/buying_power_effect_spec.rb
 - spec/tastytrade/models/current_position_spec.rb
+- spec/tastytrade/models/live_order_json_spec.rb
+- spec/tastytrade/models/live_order_spec.rb
+- spec/tastytrade/models/order_response_spec.rb
+- spec/tastytrade/models/order_status_spec.rb
+- spec/tastytrade/models/trading_status_spec.rb
+- spec/tastytrade/models/transaction_spec.rb
 - spec/tastytrade/models/user_spec.rb
+- spec/tastytrade/order_edge_cases_spec.rb
+- spec/tastytrade/order_spec.rb
+- spec/tastytrade/order_validator_spec.rb
+- spec/tastytrade/session_env_spec.rb
 - spec/tastytrade/session_manager_spec.rb
 - spec/tastytrade/session_spec.rb
 - spec/tastytrade_spec.rb
@@ -297,7 +313,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.0
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Unofficial Ruby SDK for the Tastytrade API
 test_files: []

data/lib/tastytrade/keyring_store.rb

@@ -1,72 +0,0 @@
-# frozen_string_literal: true
-
-require "keyring"
-
-module Tastytrade
-  # Secure credential storage using system keyring
-  class KeyringStore
-    SERVICE_NAME = "tastytrade-ruby"
-
-    class << self
-      # Store a credential securely
-      #
-      # @param key [String] The credential key
-      # @param value [String] The credential value
-      # @return [Boolean] Success status
-      def set(key, value)
-        return false if key.nil? || value.nil?
-
-        backend.set_password(SERVICE_NAME, key.to_s, value.to_s)
-        true
-      rescue StandardError => e
-        warn "Failed to store credential: #{e.message}"
-        false
-      end
-
-      # Retrieve a credential
-      #
-      # @param key [String] The credential key
-      # @return [String, nil] The credential value or nil if not found
-      def get(key)
-        return nil if key.nil?
-
-        backend.get_password(SERVICE_NAME, key.to_s)
-      rescue StandardError => e
-        warn "Failed to retrieve credential: #{e.message}"
-        nil
-      end
-
-      # Delete a credential
-      #
-      # @param key [String] The credential key
-      # @return [Boolean] Success status
-      def delete(key)
-        return false if key.nil?
-
-        backend.delete_password(SERVICE_NAME, key.to_s)
-        true
-      rescue StandardError => e
-        warn "Failed to delete credential: #{e.message}"
-        false
-      end
-
-      # Check if keyring is available
-      #
-      # @return [Boolean] True if keyring backend is available
-      def available?
-        !backend.nil?
-      rescue StandardError
-        false
-      end
-
-      private
-
-      def backend
-        @backend ||= Keyring.new
-      rescue StandardError => e
-        warn "Keyring not available: #{e.message}"
-        nil
-      end
-    end
-  end
-end