taskrabbit 0.0.5 → 0.0.6

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## v0.0.6
+
+* Fix Task#create
+* Add Task#new_record?
+
 ## v0.0.5
 
 * add compatibility with ruby 1.9.3

data/README.md

@@ -90,6 +90,7 @@ tr.users.find(user_id).tasks
 ```ruby
 tr = Taskrabbit::Api.new(user_token)
 task = tr.tasks.create({:named_price => 32, :name => 'Ikea'})
+task.new_record? #=> false
 ```
 
 or 

data/lib/taskrabbit/client.rb

@@ -34,8 +34,7 @@ module Taskrabbit
       # check if an error has occured
       def check_response_errors(response)
         return unless net_http_response = response.response rescue nil
-        return unless [Net::HTTPClientError, Net::HTTPServerError].include?(net_http_response.class.superclass)
-
+        return if ([Net::HTTPClientError, Net::HTTPServerError] & [net_http_response.class, net_http_response.class.superclass]).empty?
         response_hash = response.to_hash
         error = response_hash.fetch('error') { "#{net_http_response.code} #{net_http_response.message}".strip }
 

data/lib/taskrabbit/task.rb

@@ -32,7 +32,9 @@ module Taskrabbit
       end
       
       def create(api, params)
-        api.request('post', "tasks", self, :task => params)
+        task = api.tasks.new(params)
+        task.save
+        task
       end
     end
     
@@ -48,6 +50,10 @@ module Taskrabbit
       end
     end
 
+    def new_record?
+      !id
+    end
+
     def delete!
       reload('delete', "tasks/#{id.to_s}")
     end

data/lib/taskrabbit/version.rb

@@ -1,3 +1,3 @@
 module Taskrabbit
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/support/cassettes/tasks/create/with_invalid_params.yml

@@ -0,0 +1,34 @@
+---
+- !ruby/struct:VCR::HTTPInteraction
+  request: !ruby/struct:VCR::Request
+    method: :post
+    uri: http://localhost:3000/api/v1/tasks?
+    body: 
+    headers:
+      x-client-application:
+      - euqmQpzV04GmN1dJTY639PdI7eiSjCjI3lKTkPWn
+      authorization:
+      - OAuth RhyRtRg1bRNyqmdozkY6JJJ3eGDpoRGTm9AXUudp
+  response: !ruby/struct:VCR::Response
+    status: !ruby/struct:VCR::ResponseStatus
+      code: 422
+      message: 
+    headers:
+      content-type:
+      - application/json; charset=utf-8
+      x-runtime:
+      - '11415'
+      content-length:
+      - '365'
+      set-cookie:
+      - current_geo=1053; path=/; expires=Tue, 02-Oct-2012 06:08:56 GMT
+      cache-control:
+      - no-cache
+      server:
+      - thin 1.4.1 codename Chromeo
+    body: ! '{"errors":{"messages":["Task title can''t be blank","Amount you are willing
+      to pay needs to be a whole dollar amount greater than zero"],"fields":[["name","can''t
+      be blank"],["named_price","needs to be a whole dollar amount greater than zero"]]},"error":"Task
+      title can''t be blank, \nAmount you are willing to pay needs to be a whole dollar
+      amount greater than zero"}'
+    http_version: '1.1'

data/spec/taskrabbit/task_spec.rb

@@ -78,6 +78,20 @@ describe Taskrabbit::Task do
       end
     end
     
+    describe "#new_record?" do
+      subject { Taskrabbit::Task.new }
+
+      it "returns true if the task has no id" do
+        subject.stub(:id => nil)
+        subject.should be_new_record
+      end
+
+      it "returns false if the task has an id" do
+        subject.stub(:id => 123)
+        subject.should_not be_new_record
+      end
+    end
+
     describe "#find" do
 
       it "should fetch tasks" do
@@ -203,10 +217,11 @@ describe Taskrabbit::Task do
           tr = Taskrabbit::Api.new(TR_USERS[:with_card][:secret])
           VCR.use_cassette('tasks/create/with_invalid_params', :record => :new_episodes) do
             tr_task = nil
-            expect { tr_task = tr.tasks.create(invalid_params) }.to
-            raise_error(Taskrabbit::Error, "Task title can't be blank,\n" +
-                                           "Amount you are willing to pay needs to be a whole dollar amount greater than zero")
-            tr_task.should be_nil
+            tr_task = tr.tasks.create(invalid_params)
+            tr_task.should be_instance_of(Taskrabbit::Task)
+            tr_task.errors.should == {"messages"=>["Task title can't be blank", "Amount you are willing to pay needs to be a whole dollar amount greater than zero"], 
+                                      "fields"=>[["name", "can't be blank"], ["named_price", "needs to be a whole dollar amount greater than zero"]]}
+            tr_task.error.should  == "Task title can't be blank, \nAmount you are willing to pay needs to be a whole dollar amount greater than zero"
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: taskrabbit
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-01 00:00:00.000000000 Z
+date: 2012-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: api_smith
@@ -119,6 +119,7 @@ files:
 - spec/support/cassettes/tasks/all.yml
 - spec/support/cassettes/tasks/create/default.yml
 - spec/support/cassettes/tasks/create/using_account.yml
+- spec/support/cassettes/tasks/create/with_invalid_params.yml
 - spec/support/cassettes/tasks/create/with_location.yml
 - spec/support/cassettes/tasks/create/without_credit_card.yml
 - spec/support/cassettes/tasks/create/without_user.yml
@@ -157,7 +158,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3232776619035883631
+      hash: 1376035083108164495
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -184,6 +185,7 @@ test_files:
 - spec/support/cassettes/tasks/all.yml
 - spec/support/cassettes/tasks/create/default.yml
 - spec/support/cassettes/tasks/create/using_account.yml
+- spec/support/cassettes/tasks/create/with_invalid_params.yml
 - spec/support/cassettes/tasks/create/with_location.yml
 - spec/support/cassettes/tasks/create/without_credit_card.yml
 - spec/support/cassettes/tasks/create/without_user.yml