taskjuggler 3.7.2 → 3.8.2

data/lib/taskjuggler/TjTime.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = TjTime.rb -- The TaskJuggler III Project Management Software
@@ -501,18 +502,25 @@ class TaskJuggler
         end
 
         @time = Time.utc(year, month, day, hour, minute, second)
-        sign = zone[0] == ?- ? 1 : -1
+        sign = zone[0] == ?- ? -1 : 1
         tzHour = zone[1..2].to_i
-        if tzHour < 0 || tzHour > 12
-          raise TjException.new, "Time zone adjustment hour out of range " +
-                                 "(0 - 12) but is #{tzHour}"
-        end
         tzMinute = zone[3..4].to_i
         if tzMinute < 0 || tzMinute > 59
           raise TjException.new, "Time zone adjustment minute out of range " +
                                  "(0 - 59) but is #{tzMinute}"
         end
-        @time += sign * (tzHour * 3600 + tzMinute * 60)
+
+        time_offset = sign * (tzHour * 3600 + tzMinute * 60)
+        # UTC-1200 is the most westerly time zone but UTC+1400 is the most
+        # easterly time zone (Republic of Kiribati).
+        if time_offset < -12 * 3600 || time_offset > 14 * 3600
+          raise TjException.new, "Time zone adjustment out of range " +
+                                 "(-1200 - +1400} but is #{zone})"
+        end
+
+        # The time offset must be substracted from the base time to convert it
+        # to UTC.
+        @time -= time_offset
       else
         @time = Time.mktime(year, month, day, hour, minute, second)
       end

data/lib/taskjuggler/TjpExample.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = TjpExample.rb -- The TaskJuggler III Project Management Software
@@ -58,7 +59,7 @@ class TaskJuggler
       tag = 'full text' unless tag
       return nil unless @snippets[tag]
 
-      s = ''
+      s = +''
       @snippets[tag].each { |l| s << l }
       s
     end

data/lib/taskjuggler/TjpSyntaxRules.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = TjpSyntaxRules.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/URLParameter.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = URLParameter.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/UTF8String.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = UTF8String.rb -- The TaskJuggler III Project Management Software
@@ -29,7 +30,7 @@ class String
     # the String. This implementation looks more awkward but is noticeably
     # faster than the often propagated regexp based implementations.
     def each_utf8_char
-      c = ''
+      c = +''
       length = 0
       each_byte do |b|
         c << b
@@ -38,7 +39,7 @@ class String
           if (length -= 1) == 0
             # end of unicode character reached
             yield c
-            c = ''
+            c = +''
           end
         elsif (b & 0xC0) == 0xC0
           # first unicode byte
@@ -50,7 +51,7 @@ class String
         else
           # ASCII character
           yield c
-          c = ''
+          c = +''
         end
       end
     end

data/lib/taskjuggler/UserManual.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = UserManual.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/VimSyntax.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = VimSyntax.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/WorkingHours.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = WorkingHours.rb -- The TaskJuggler III Project Management Software
@@ -177,7 +178,7 @@ class TaskJuggler
     # Returns the time interval settings for each day in a human readable form.
     def to_s
       dayNames = %w( Sun Mon Tue Wed Thu Fri Sat )
-      str = ''
+      str = +''
       7.times do |day|
         str += "#{dayNames[day]}: "
         if @days[day].empty?

data/lib/taskjuggler/XMLDocument.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = XMLDocument.rb -- The TaskJuggler III Project Management Software
@@ -42,7 +43,7 @@ class TaskJuggler
 
     # Produce the XMLDocument as String.
     def to_s
-      str = ''
+      str = +''
       @elements.each do |element|
         str << element.to_s(0)
       end

data/lib/taskjuggler/XMLElement.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = XMLElement.rb -- The TaskJuggler III Project Management Software
@@ -134,7 +135,7 @@ class TaskJuggler
 
     # Escape special characters in input String _str_.
     def escape(str, quotes = false)
-      out = ''
+      out = +''
       str.each_utf8_char do |c|
         case c
         when '&'
@@ -164,7 +165,7 @@ class TaskJuggler
     end
 
     def to_s(indent)
-      out = ''
+      out = +''
       @text.each_utf8_char do |c|
         case c
         when '<'
@@ -198,7 +199,7 @@ class TaskJuggler
   # This is a specialized XMLElement to represent a comment.
   class XMLComment < XMLElement
 
-    def initialize(text = '')
+    def initialize(text = +'')
       super(nil, {})
       @text = text
     end
@@ -224,14 +225,14 @@ class TaskJuggler
   # interpreted and must be valid XML in the content it is added.
   class XMLBlob < XMLElement
 
-    def initialize(blob = '')
+    def initialize(blob = +'')
       super(nil, {})
       raise ArgumentError, "blob may not be nil" if blob.nil?
       @blob = blob
     end
 
     def to_s(indent)
-      out = ''
+      out = +''
       @blob.each_utf8_char do |c|
         out += (c == "\n" ? "\n" + ' ' * indent : c)
       end

data/lib/taskjuggler/apps/Tj3.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3Client.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3Client.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3Daemon.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3Daemon.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3Man.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3Man.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3SsReceiver.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3SsReceiver.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3SsSender.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3SsSender.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3TsReceiver.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3TsReceiver.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3TsSender.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3TsSender.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3TsSummary.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3TsSummary.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/apps/Tj3WebD.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Tj3WebD.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/Daemon.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Daemon.rb -- The TaskJuggler III Project Management Software
@@ -68,7 +69,7 @@ class TaskJuggler
 
       # We no longer have a controlling terminal, so these are useless.
       $stdin.reopen('/dev/null')
-      $stdout.reopen('/dev/null', 'a')
+      $stdout.reopen(StringIO.new)
       $stderr.reopen($stdout)
 
       info('daemon_pid',

data/lib/taskjuggler/daemon/DaemonConnector.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = DaemonConnector.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/ProcessIntercom.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ProcessIntercom.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/ProjectBroker.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ProjectBroker.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/ProjectServer.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ProjectServer.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/ReportServer.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ReportServer.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/ReportServlet.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ReportServlet.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/WebServer.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = WebServer.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/daemon/WelcomePage.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = WelcomePage.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/deep_copy.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = deep_copy.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/AccountListRE.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = AccountListRE.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/CSVFile.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = CSVFile.rb -- The TaskJuggler III Project Management Software
@@ -68,7 +69,7 @@ class TaskJuggler
     def to_s
       raise "No seperator defined." if @separator.nil?
 
-      s = ''
+      s = +''
       @data.each do |line|
         first = true
         line.each do |field|
@@ -107,7 +108,7 @@ class TaskJuggler
           state = :startOfField
           redo
         when :startOfField
-          field = ''
+          field = +''
           quoted = false
           if c == @quote
             # We've found the start of a quoted field.

data/lib/taskjuggler/reports/ChartPlotter.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ChartPlotter.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/CollisionDetector.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = CollisionDetector.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/ColumnTable.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ColumnTable.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/ExportRE.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ExportRE.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttChart.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttChart.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttContainer.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttContainer.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttHeader.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttHeader.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttHeaderScaleItem.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttHeaderScaleItem.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttLine.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttLine.rb -- The TaskJuggler III Project Management Software
@@ -368,7 +369,7 @@ class TaskJuggler
         query.process
         title = query.to_s
       else
-        title = ''
+        title = +''
       end
       trigger['onclick'] = "TagToTip('ID#{trigger.object_id}', " +
                            "TITLE, '#{title.gsub(/'/, ''')}')"

data/lib/taskjuggler/reports/GanttLoadStack.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttLoadStack.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttMilestone.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttMilestone.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttRouter.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttRouter.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/GanttTaskBar.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = GanttTaskBar.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/HTMLGraphics.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = HTMLGraphics.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/ICalReport.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ICalReport.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/MspXmlRE.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = MspXmlRE.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/Navigator.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Navigator.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/NikuReport.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = NikuReport.rb -- The TaskJuggler III Project Management Software
@@ -128,7 +129,7 @@ class TaskJuggler
           next if projectTotal(projectId) <= 0.0
           value = sum(projectId, resourceId)
           valStr = numberFormat.format(value)
-          valStr = '' if valStr.to_f == 0.0
+          valStr = +'' if valStr.to_f == 0.0
           tr << htmlTabCell(valStr)
         end
 

data/lib/taskjuggler/reports/Report.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = Report.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/ReportBase.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ReportBase.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/ReportContext.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ReportContext.rb -- The TaskJuggler III Project Management Software

data/lib/taskjuggler/reports/ReportTable.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby -w
+# frozen_string_literal: true
 # encoding: UTF-8
 #
 # = ReportTable.rb -- The TaskJuggler III Project Management Software
@@ -47,7 +48,7 @@ class TaskJuggler
       # True if the report does not rely on the data of other files.
       @selfcontained = false
       # Path to the auxiliary data directory.
-      @auxDir = ''
+      @auxDir = +''
     end
 
     # This function should only be called by the ReportTableColumn constructor.