taskinator 0.3.16 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 231c6c9f1bdcf8bb1a7fb38c0ebd0c893f61f49051d94ace5714233a207ad651
-  data.tar.gz: 9c66bf91f8420f3fff69487e095a5c36986409f7249224f03ba0b53fdd427190
+  metadata.gz: a5f30cdfcc1ec3f517d2346f5eb27549cf27ed18ab830692e3747fdb1a5244e8
+  data.tar.gz: '08299d0e337897c9efcb2080debec16072459d6a2a9fdfb8218c2bc296652a25'
 SHA512:
-  metadata.gz: 0e322ccc3214ed171bd75b14b4ebaa7e51c1e1ba33b3f7f292c707059f166566a8b8c08235442d26922b0cd8a8c2affa320af03d069d33b0fce4d9ffe7485e95
-  data.tar.gz: d16a3220d1be357c77e7a47d3e2c426a99549c3d350979f534a176ec3919444551956d4d41e6b7389e245fe39c1286d7ef60e6f07b1155f3aeae7e9cdce1398b
+  metadata.gz: 6d3c829ff6913bfc9c7bd41736a75b43119ebb50337eb666970e6133cbc3ee466291011c72b6213e7182111c9899706c1a241f2b3e4579474a6c1c7513e6c4d6
+  data.tar.gz: 82c7058f70249413193d1699b8ad49e300d858d6a2d90f12c63667131399c9e33358342f6d28f36a8fd3f98d4e31c6b5a98dd4735105484e917d8262825243a2

data/.travis.yml

@@ -1,15 +1,16 @@
+os: linux
+dist: xenial
 language: ruby
-sudo: false  # See http://docs.travis-ci.com/user/migrating-from-legacy
 cache: bundler
 
 services:
-  - redis-server
+  - redis
 
 rvm:
-  - 2.4.10
   - 2.5.8
   - 2.6.6
   - 2.7.2
+  - 3.0.0
 
 script: 'bundle exec rake spec'
 

data/CHANGELOG.md

@@ -1,3 +1,51 @@
+v0.4.0 - 4 Mar 2021
+---
+Bug fix `job` tasks which have no arguments to the `perform` method.
+Added support for having `perform` method as a class method.
+
+v0.3.16 - 17 Feb 2021
+---
+Bug fix to deincrement pending counts for sequential tasks.
+Bug fix to allow concurrent tasks to be retried (via Resque) and to complete processes.
+
+v0.3.15 - 22 Nov 2018
+---
+Updated dependencies.
+
+v0.3.14 - 13 Jul 2018
+---
+Updated dependencies.
+Removed gemnasium.
+
+v0.3.13 - 23 Sep 2017
+---
+Updated dependencies.
+
+v0.3.12 - 23 Sep 2017
+---
+Spec fixes.
+Updated dependencies.
+
+v0.3.11 - 1 Nov 2016
+---
+Removed `redis-semaphore` gem and use INCRBY to track pending concurrent tasks instead.
+Added instrumentation using statsd.
+Bug fixes to key expiry logic.
+Refactored process and task state transistions.
+
+v0.3.10 - 1 Nov 2016
+---
+Added support for serializing to XML.
+Improvements to process and task states.
+
+v0.3.9 - 12 Sep 2016
+---
+Added benchmark for redis-mutex.
+
+v0.3.7 - 18 Aug 2016
+---
+Bug fix to `option?` method.
+
 v0.3.6 - 11 Nov 2015
 ---
 Added visitor for performing clean up of completed processes/tasks.

data/Gemfile.lock

@@ -1,14 +1,13 @@
 PATH
   remote: .
   specs:
-    taskinator (0.3.16)
+    taskinator (0.4.0)
       builder (>= 3.2.2)
       connection_pool (>= 2.2.0)
       globalid (~> 0.3)
       json (>= 1.8.2)
       redis (>= 3.2.1)
       redis-namespace (>= 1.5.2)
-      redis-semaphore (>= 0.2.4)
       statsd-ruby (~> 1.4.0)
       thwait (~> 0.2)
 
@@ -44,7 +43,7 @@ GEM
       concurrent-ruby (~> 1.0)
     json (2.5.1)
     method_source (1.0.0)
-    minitest (5.14.3)
+    minitest (5.14.4)
     mono_logger (1.1.0)
     multi_json (1.15.0)
     mustermann (1.1.1)
@@ -62,8 +61,6 @@ GEM
     redis (4.2.5)
     redis-namespace (1.8.1)
       redis (>= 3.0.4)
-    redis-semaphore (0.3.1)
-      redis
     resque (2.0.0)
       mono_logger (~> 1.0)
       multi_json (~> 1.0)
@@ -142,4 +139,4 @@ DEPENDENCIES
   taskinator!
 
 BUNDLED WITH
-   2.2.11
+   2.2.13

data/lib/taskinator.rb

@@ -1,7 +1,6 @@
 require 'json'
 require 'yaml'
 require 'securerandom'
-require 'redis-semaphore'
 require 'benchmark'
 require 'delegate'
 

data/lib/taskinator/task.rb

@@ -230,12 +230,12 @@ module Taskinator
         # NNB: if other job types are required, may need to implement how they get invoked here!
         # FIXME: possible implement using ActiveJob instead, so it doesn't matter how the worker is implemented
 
-        if job.instance_of?(Module)
+        if job.respond_to?(:perform)
           # resque
-          job.perform(args)
+          job.perform(*args)
         else
           # delayedjob and sidekiq
-          job.new.perform(args)
+          job.new.perform(*args)
         end
 
         # ASSUMPTION: when the job returns, the task is considered to be complete

data/lib/taskinator/version.rb

@@ -1,3 +1,3 @@
 module Taskinator
-  VERSION = "0.3.16"
+  VERSION = "0.4.0"
 end

data/spec/taskinator/task_spec.rb

@@ -334,13 +334,23 @@ describe Taskinator::Task do
       end
     end
 
-    subject { Taskinator::Task.define_job_task(process, TestJob, {:a => 1, :b => 2}) }
+    class TestJobClassNoArgs
+      def perform
+      end
+    end
+
+    module TestJobModuleNoArgs
+      def self.perform
+      end
+    end
+
+    subject { Taskinator::Task.define_job_task(process, TestJob, [1, {:a => 1, :b => 2}]) }
 
     it_should_behave_like "a task", Taskinator::Task::Job
 
     describe ".define_job_task" do
       it "sets the queue to use" do
-        task = Taskinator::Task.define_job_task(process, TestJob, {:a => 1, :b => 2}, :queue => :foo)
+        task = Taskinator::Task.define_job_task(process, TestJob, [1, {:a => 1, :b => 2}], :queue => :foo)
         expect(task.queue).to eq(:foo)
       end
     end
@@ -367,23 +377,37 @@ describe Taskinator::Task do
 
     describe "#start" do
       it {
-        task = Taskinator::Task.define_job_task(process, TestJobClass, {:a => 1, :b => 2})
+        task = Taskinator::Task.define_job_task(process, TestJobClass, [1, {:a => 1, :b => 2}])
+        expect(process).to receive(:task_completed).with(task)
+        expect_any_instance_of(TestJobClass).to receive(:perform).with(1, {:a => 1, :b => 2})
+        task.start!
+      }
+
+      it {
+        task = Taskinator::Task.define_job_task(process, TestJobModule, [2, {:a => 1, :b => 2}])
+        expect(process).to receive(:task_completed).with(task)
+        expect(TestJobModule).to receive(:perform).with(2, {:a => 1, :b => 2})
+        task.start!
+      }
+
+      it {
+        task = Taskinator::Task.define_job_task(process, TestJobClassNoArgs, nil)
         expect(process).to receive(:task_completed).with(task)
-        expect_any_instance_of(TestJobClass).to receive(:perform).with({:a => 1, :b => 2})
+        expect_any_instance_of(TestJobClassNoArgs).to receive(:perform).and_call_original
         task.start!
       }
 
       it {
-        task = Taskinator::Task.define_job_task(process, TestJobModule, {:a => 1, :b => 2})
+        task = Taskinator::Task.define_job_task(process, TestJobModuleNoArgs, nil)
         expect(process).to receive(:task_completed).with(task)
-        expect(TestJobModule).to receive(:perform).with({:a => 1, :b => 2})
+        expect(TestJobModuleNoArgs).to receive(:perform).and_call_original
         task.start!
       }
 
       it "is instrumented" do
         allow(process).to receive(:task_completed).with(subject)
 
-        allow(TestJob).to receive(:perform).with({:a => 1, :b => 2})
+        allow(TestJob).to receive(:perform).with(1, {:a => 1, :b => 2})
 
         instrumentation_block = SpecSupport::Block.new
 

data/taskinator.gemspec

@@ -23,7 +23,6 @@ Gem::Specification.new do |spec|
   # core
   spec.add_dependency 'redis'                       , '>= 3.2.1'
   spec.add_dependency 'redis-namespace'             , '>= 1.5.2'
-  spec.add_dependency 'redis-semaphore'             , '>= 0.2.4'
   spec.add_dependency 'connection_pool'             , '>= 2.2.0'
   spec.add_dependency 'json'                        , '>= 1.8.2'
   spec.add_dependency 'builder'                     , '>= 3.2.2'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taskinator
 version: !ruby/object:Gem::Version
-  version: 0.3.16
+  version: 0.4.0
 platform: ruby
 authors:
 - Chris Stefano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-17 00:00:00.000000000 Z
+date: 2021-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -38,20 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.2
-- !ruby/object:Gem::Dependency
-  name: redis-semaphore
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.2.4
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.2.4
 - !ruby/object:Gem::Dependency
   name: connection_pool
   requirement: !ruby/object:Gem::Requirement