taskinator 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f681b5a701e5f68d9bb53ac6edf88480c7ddbfa9
-  data.tar.gz: 0b2f8046ada412f50927cd76d4989f98dfeff452
+  metadata.gz: 75ca53362ea028543eae463a901056c08049ecd7
+  data.tar.gz: 7971999d4c6c962c057329ba215394af3830ac5f
 SHA512:
-  metadata.gz: ed37c8d1d8974b9bb22ab1b95baa4448e16ecf2faebbe3a72c815b692ac8286714849d2ee8662f2b9c78cfcb3066ac183fb5da0983006f9ed51046e193bdcdd9
-  data.tar.gz: 720b6d27cce9bf6728d333faf65d4db46e3c91cc326783465d7133fd86673fa3ec57d5c19646028c0781c124afa36e3d89bc68b31cec6a13b79024cd96214a44
+  metadata.gz: ae31ec1d8ce1ca9c16aa38425150525c3b7c9e51cc2991935ea42522e63f05e217b3e179403eebcd9fc2d48d8c512375074dc53fd3ee2c262aeb19effd146179
+  data.tar.gz: aa3e70be0f952329ce8857d1e74aac32395f27c72848af95aad81a61e6adbd8098933d8ee38ec6b9e8f792e5f82684c02afddf9a51b91ffcc63b2408f64b1783

data/Gemfile.lock

@@ -8,7 +8,7 @@ GIT
 PATH
   remote: .
   specs:
-    taskinator (0.0.8)
+    taskinator (0.0.9)
       connection_pool (>= 2.0.0)
       json (>= 1.8.1)
       redis (>= 3.0.6)

data/lib/taskinator/definition/builder.rb

@@ -24,7 +24,7 @@ module Taskinator
         raise ArgumentError, 'block' unless block_given?
 
         sub_process = Process.define_sequential_process_for(@definition, options)
-        Builder.new(define_sub_process_task(@process, sub_process, options), @definition, @args).instance_eval(&block)
+        Builder.new(define_sub_process_task(@process, sub_process, options), @definition, *@args).instance_eval(&block)
       end
 
       # defines a sub process of tasks which are executed concurrently
@@ -32,7 +32,7 @@ module Taskinator
         raise ArgumentError, 'block' unless block_given?
 
         sub_process = Process.define_concurrent_process_for(@definition, complete_on, options)
-        Builder.new(define_sub_process_task(@process, sub_process, options), @definition, @args).instance_eval(&block)
+        Builder.new(define_sub_process_task(@process, sub_process, options), @definition, *@args).instance_eval(&block)
       end
 
       # dynamically defines tasks, using the given @iterator method
@@ -43,7 +43,7 @@ module Taskinator
         raise ArgumentError, 'block' unless block_given?
 
         @executor.send(method, *[*@args, options]) do |*args|
-          Builder.new(@process, @definition, args).instance_eval(&block)
+          Builder.new(@process, @definition, *args).instance_eval(&block)
         end
       end
 
@@ -76,7 +76,7 @@ module Taskinator
         # TODO: decide whether the sub process to dynamically receive arguments
 
         sub_process = definition.create_process(*@args)
-        Builder.new(define_sub_process_task(@process, sub_process, options), definition, @args)
+        Builder.new(define_sub_process_task(@process, sub_process, options), definition, *@args)
       end
 
     private

data/lib/taskinator/job_worker.rb

@@ -13,6 +13,7 @@ module Taskinator
         task.perform &block
         task.complete!
       rescue Exception => e
+        Taskinator.logger.error(e)
         task.fail!(e)
         raise e
       end

data/lib/taskinator/process.rb

@@ -57,12 +57,17 @@ module Taskinator
       state :initial do
         event :enqueue, :transitions_to => :enqueued
         event :start, :transitions_to => :processing
+
+        # need to be able to complete, for when there are no tasks
+        event :complete, :transitions_to => :completed, :if => :no_tasks_defined?
+
         event :cancel, :transitions_to => :cancelled
         event :fail, :transitions_to => :failed
       end
 
       state :enqueued do
         event :start, :transitions_to => :processing
+        event :complete, :transitions_to => :completed, :if => :no_tasks_defined?
         event :cancel, :transitions_to => :cancelled
         event :fail, :transitions_to => :failed
       end
@@ -89,15 +94,25 @@ module Taskinator
 
       on_error do |error, from, to, event, *args|
         Taskinator.logger.error("PROCESS: #{self.class.name}:#{uuid} :: #{error.message}")
+        Taskinator.logger.debug(error.backtrace)
         fail!(error)
       end
     end
 
+    def no_tasks_defined?
+      tasks.empty?
+    end
+
     def tasks_completed?(*args)
       # subclasses must implement this method
       raise NotImplementedError
     end
 
+    def task_failed(task, error)
+      # for now, fail this process
+      fail!(error)
+    end
+
     # include after defining the workflow
     # since the load and persist state methods
     # need to override the ones defined by workflow
@@ -114,6 +129,13 @@ module Taskinator
       parent.complete! unless parent.nil?
     end
 
+    # callback for when the process has failed
+    def on_failed_entry(*args)
+      # notify the parent task (if there is one) that this process has failed
+      # note: parent may be a proxy, so explicity check for nil?
+      parent.fail!(*args) unless parent.nil?
+    end
+
     class Sequential < Process
       def start
         task = tasks.first
@@ -157,7 +179,7 @@ module Taskinator
 
       def task_completed(task)
         # when complete on first, then don't bother with subsequent tasks completing
-        return if completed?
+        return if completed? || failed?
         complete! if can_complete?
       end
 

data/lib/taskinator/process_worker.rb

@@ -10,6 +10,7 @@ module Taskinator
       begin
         process.start!
       rescue Exception => e
+        Taskinator.logger.error(e)
         process.fail!(e)
         raise e
       end

data/lib/taskinator/task.rb

@@ -60,6 +60,10 @@ module Taskinator
 
       state :enqueued do
         event :start, :transitions_to => :processing
+
+        # need to be able to complete, for when sub-tasks have no tasks
+        event :complete, :transitions_to => :completed, :if => :can_complete_task?
+
         event :fail, :transitions_to => :failed
       end
 
@@ -77,6 +81,7 @@ module Taskinator
 
       on_error do |error, from, to, event, *args|
         Taskinator.logger.error("TASK: #{self.class.name}:#{uuid} :: #{error.message}")
+        Taskinator.logger.debug(error.backtrace)
         fail!(error)
       end
     end
@@ -101,6 +106,12 @@ module Taskinator
       process.task_completed(self)
     end
 
+    # callback for when the task has failed
+    def on_failed_entry(*args)
+      # notify the process that this task has failed
+      process.task_failed(self, args.last)
+    end
+
     # helper method, delegating to process
     def paused?
       process.paused?

data/lib/taskinator/task_worker.rb

@@ -11,6 +11,7 @@ module Taskinator
         task.start!
         task.complete! if task.can_complete?
       rescue Exception => e
+        Taskinator.logger.error(e)
         task.fail!(e)
         raise e
       end

data/lib/taskinator/version.rb

@@ -1,3 +1,3 @@
 module Taskinator
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/taskinator/process_spec.rb

@@ -157,13 +157,21 @@ describe Taskinator::Process do
     end
 
     describe "#parent" do
-      it "notifies parent" do
+      it "notifies parent when completed" do
         allow(subject).to receive(:tasks_completed?) { true }
         subject.parent = double('parent')
         expect(subject.parent).to receive(:complete!)
         subject.start!
         subject.complete!
       end
+
+      it "notifies parent when failed" do
+        allow(subject).to receive(:tasks_completed?) { true }
+        subject.parent = double('parent')
+        expect(subject.parent).to receive(:fail!)
+        subject.start!
+        subject.fail!
+      end
     end
 
     describe "persistence" do
@@ -351,6 +359,16 @@ describe Taskinator::Process do
       end
     end
 
+    describe "#task_failed" do
+      it "fails when tasks fail" do
+        tasks.each {|t| subject.tasks << t }
+
+        expect(subject).to receive(:fail!).with(StandardError)
+
+        subject.task_failed(tasks.first, StandardError)
+      end
+    end
+
     describe "#tasks_completed?" do
 
       describe "complete on first" do

data/spec/taskinator/task_spec.rb

@@ -96,6 +96,7 @@ describe Taskinator::Task do
         it { expect(subject).to respond_to(:fail!) }
         it {
           expect(subject).to receive(:fail).with(StandardError)
+          expect(process).to receive(:task_failed).with(subject, StandardError)
           subject.start!
           subject.fail!(StandardError)
         }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taskinator
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Chris Stefano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-11 00:00:00.000000000 Z
+date: 2014-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis