taskinator 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e525f7ac6b173f06d6a4e9a3bcf498bfdde1e434
-  data.tar.gz: 13c8c943739f8cb17474cac9a7634a37dcf95a1e
+  metadata.gz: 51c713c1cb5cfa95439381d7f120bfa2bfb846b6
+  data.tar.gz: 79d1bcb30bae42edad8428fefc19e4870f0c5024
 SHA512:
-  metadata.gz: 4f8cab5e41d5b606778a1ea67178cfb68c7143ec447d5f3a3ef793ee26e0c45d58fcb1e5152b251a76a161f7247b32d5be6432a0cfc402cb1bb37112ce7f05c8
-  data.tar.gz: 526147b769e9b37e05e6fd59e8aafbaed5b64cbd00a5a2910f99b1fbd6bdeae5fb238ad0950bd1bb93f3efc0c8a47c7d835437db08d166803a27f8c32a518e05
+  metadata.gz: a2ad95201f5f020d97f731122071a57a3aa092163594a2bc72982950596589af3deb97daebd082c32ad9959695785f36018c730428d4638eb50f27cf4bf8a869
+  data.tar.gz: 023087cad85ee39f7cbea9310277b8e382c4926696677a89ebd9c5889a6ff48e9d60c59c085ff7851f4d368330ad6976963a0cb7d741bffb79cdde424b36ab52

data/Gemfile.lock

@@ -8,7 +8,7 @@ GIT
 PATH
   remote: .
   specs:
-    taskinator (0.0.13)
+    taskinator (0.0.14)
       connection_pool (>= 2.0.0)
       json (>= 1.8.1)
       redis (>= 3.0.6)

data/lib/taskinator/definition/builder.rb

@@ -42,7 +42,13 @@ module Taskinator
         raise NoMethodError, method unless @executor.respond_to?(method)
         raise ArgumentError, 'block' unless block_given?
 
-        @executor.send(method, *[*@args, options]) do |*args|
+        #
+        # `for_each` is an exception, since it invokes the definition
+        # in order to yield elements to the builder, and any options passed
+        # are included with the builder options
+        #
+        method_args = options.any? ? [*@args, options] : @args
+        @executor.send(method, *method_args) do |*args|
           Builder.new(@process, @definition, *args).instance_eval(&block)
         end
       end

data/lib/taskinator/definition.rb

@@ -7,6 +7,9 @@ module Taskinator
       define_singleton_method :_create_process_ do |args, options={}|
 
         # TODO: better validation of arguments
+
+        # FIXME: arg_list should only contain an array of symbols
+
         raise ArgumentError, "wrong number of arguments (#{args.length} for #{arg_list.length})" if args.length < arg_list.length
 
         process = Process.define_sequential_process_for(self)

data/lib/taskinator/persistence.rb

@@ -93,7 +93,8 @@ module Taskinator
       end
 
       # persists the error information
-      def fail(error)
+      def fail(error=nil)
+        return unless error
         Taskinator.redis do |conn|
           conn.hmset(
             self.key,

data/lib/taskinator/tasks.rb

@@ -35,7 +35,7 @@ module Taskinator
       return to_enum(__method__) unless block_given?
 
       current = @head
-      while current != nil
+      while current
         yield current
         current = current.next
       end

data/lib/taskinator/version.rb

@@ -1,3 +1,3 @@
 module Taskinator
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/spec/taskinator/definition/builder_spec.rb

@@ -99,7 +99,7 @@ describe Taskinator::Definition::Builder do
         @executor = executor
       end
 
-      expect(executor).to receive(:iterator_method).with(*[*args, {}]) do |*a, &block|
+      expect(executor).to receive(:iterator_method).with(*args) do |*a, &block|
         3.times(&block)
       end
 

data/spec/taskinator/definition_spec.rb

@@ -41,7 +41,7 @@ describe Taskinator::Definition do
       allow(block).to receive(:to_proc) {
         Proc.new {|*args| }
       }
-      subject.define_process &block
+      subject.define_process(&block)
 
       expect(subject.create_process).to be_a(Taskinator::Process)
     end

data/spec/taskinator/process_spec.rb

@@ -144,13 +144,13 @@ describe Taskinator::Process do
       describe "#fail!" do
         it { expect(subject).to respond_to(:fail!) }
         it {
-          expect(subject).to receive(:fail).with(StandardError)
+          expect(subject).to receive(:fail)
           subject.start!
-          subject.fail!(StandardError)
+          subject.fail!
         }
         it {
           subject.start!
-          subject.fail!(StandardError)
+          subject.fail!
           expect(subject.current_state.name).to eq(:failed)
         }
       end
@@ -363,9 +363,11 @@ describe Taskinator::Process do
       it "fails when tasks fail" do
         tasks.each {|t| subject.tasks << t }
 
-        expect(subject).to receive(:fail!).with(StandardError)
+        error = StandardError.new
 
-        subject.task_failed(tasks.first, StandardError)
+        expect(subject).to receive(:fail!).with(error)
+
+        subject.task_failed(tasks.first, error)
       end
     end
 

data/spec/taskinator/task_spec.rb

@@ -95,14 +95,15 @@ describe Taskinator::Task do
       describe "#fail!" do
         it { expect(subject).to respond_to(:fail!) }
         it {
-          expect(subject).to receive(:fail).with(StandardError)
-          expect(process).to receive(:task_failed).with(subject, StandardError)
+          error = StandardError.new
+          expect(subject).to receive(:fail).with(error)
+          expect(process).to receive(:task_failed).with(subject, error)
           subject.start!
-          subject.fail!(StandardError)
+          subject.fail!(error)
         }
         it {
           subject.start!
-          subject.fail!(StandardError)
+          subject.fail!
           expect(subject.current_state.name).to eq(:failed)
         }
       end
@@ -171,8 +172,9 @@ describe Taskinator::Task do
       end
 
       it "handles failure" do
-        allow(subject.executor).to receive(subject.method).with(*subject.args).and_raise(StandardError)
-        expect(subject).to receive(:fail!).with(StandardError)
+        error = StandardError.new
+        allow(subject.executor).to receive(subject.method).with(*subject.args).and_raise(error)
+        expect(subject).to receive(:fail!).with(error)
         subject.start!
       end
     end
@@ -278,8 +280,9 @@ describe Taskinator::Task do
       end
 
       it "handles failure" do
-        allow(sub_process).to receive(:start!).and_raise(StandardError)
-        expect(subject).to receive(:fail!).with(StandardError)
+        error = StandardError.new
+        allow(sub_process).to receive(:start!).and_raise(error)
+        expect(subject).to receive(:fail!).with(error)
         subject.start!
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taskinator
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Chris Stefano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-11 00:00:00.000000000 Z
+date: 2015-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis