tasker-engine 1.0.5 → 1.0.6

data/lib/generators/tasker/templates/task_config.yaml.erb

@@ -8,17 +8,17 @@ module_namespace: <%= @module_namespace %>
 task_handler_class: <%= @task_handler_class %>
 description: "<%= @description || "Generated task handler for #{@task_name}" %>"
 
-default_dependent_system: <%= @dependent_system %>
+default_dependent_system: '<%= @dependent_system || 'default_system' %>'
 named_steps:
-<% if @steps && @steps.any? -%>
-<% @steps.each do |step| -%>
+<% if @steps && @steps.any? %>
+<% @steps.each do |step| %>
   - <%= step %>
-<% end -%>
-<% else -%>
+<% end %>
+<% else %>
   - fetch_data
   - process_data
   - complete_task
-<% end -%>
+<% end %>
 
 schema:
   type: object
@@ -29,16 +29,16 @@ schema:
       type: integer
 
 step_templates:
-<% if @steps && @steps.any? -%>
-<% @steps.each_with_index do |step, index| -%>
+<% if @steps && @steps.any? %>
+<% @steps.each_with_index do |step, index| %>
   - name: <%= step %>
     description: <%= step.humanize %> step
     handler_class: <%= @module_namespace ? "#{@module_namespace}::" : '' %><%= @task_handler_class %>::<%= step.classify %>StepHandler
-<% if index > 0 -%>
+<% if index > 0 %>
     depends_on_step: <%= @steps[index - 1] %>
-<% end -%>
-<% end -%>
-<% else -%>
+<% end %>
+<% end %>
+<% else %>
   - name: fetch_data
     description: Fetch required data from dependent system
     handler_class: <%= @module_namespace ? "#{@module_namespace}::" : '' %><%= @task_handler_class %>::FetchDataStepHandler
@@ -63,55 +63,55 @@ step_templates:
     description: Complete the task with processed data
     depends_on_step: process_data
     handler_class: <%= @module_namespace ? "#{@module_namespace}::" : '' %><%= @task_handler_class %>::CompleteTaskStepHandler
-<% end -%>
+<% end %>
 
 environments:
   development:
     step_templates:
-<% if @steps && @steps.any? -%>
-<% first_step = @steps.first -%>
+<% if @steps && @steps.any? %>
+<% first_step = @steps.first %>
       - name: <%= first_step %>
         handler_config:
           params:
             debug: true
-<% else -%>
+<% else %>
       - name: fetch_data
         handler_config:
           url: http://localhost:3000/api/data
           params:
             id: 1
             debug: true
-<% end -%>
+<% end %>
 
   test:
     step_templates:
-<% if @steps && @steps.any? -%>
-<% first_step = @steps.first -%>
+<% if @steps && @steps.any? %>
+<% first_step = @steps.first %>
       - name: <%= first_step %>
         handler_config:
           params:
             test_mode: true
-<% else -%>
+<% else %>
       - name: fetch_data
         handler_config:
           url: http://test-api.example.com/data
           params:
             id: 1
             test_mode: true
-<% end -%>
+<% end %>
 
   production:
     step_templates:
-<% if @steps && @steps.any? -%>
-<% first_step = @steps.first -%>
+<% if @steps && @steps.any? %>
+<% first_step = @steps.first %>
       - name: <%= first_step %>
         handler_config:
           params: {}
-<% else -%>
+<% else %>
       - name: fetch_data
         handler_config:
           url: https://api.example.com/data
           params:
             id: 1
             api_key: ${API_KEY}
-<% end -%>
+<% end %>

data/lib/generators/tasker/templates/task_handler.rb.erb

@@ -19,9 +19,10 @@ module <%= @module_namespace %>
         connection.get("/data/#{input_id}")
       end
 
-      def process_results(_task, _sequence, step)
+      def process_results(step, response, initial_results)
         # Extract the response ID from the API response
-        step.results = { response_id: step.results.deep_symbolize_keys.dig(:data, :id) }
+        data = JSON.parse(response.body)
+        step.results = { response_id: data.deep_symbolize_keys.dig(:data, :id) }
       end
     end
 

data/lib/generators/tasker/templates/task_handler_spec.rb.erb

@@ -5,26 +5,17 @@ require 'rails_helper'
 RSpec.describe <%= @module_namespace ? "#{@module_namespace}::" : '' %><%= @task_handler_class %> do
   let(:stubs) { Faraday::Adapter::Test::Stubs.new }
   let(:connection) { Faraday.new { |b| b.adapter(:test, stubs) } }
-  let(:task_handler) do
-    handler = described_class.new
-    mock_connection = connection # Capture connection in closure
-    original_get_step_handler = handler.method(:get_step_handler)
-    handler.define_singleton_method(:get_step_handler) do |step|
-      step_handler = original_get_step_handler.call(step)
-      step_handler.instance_variable_set(:@connection, mock_connection)
-      step_handler
-    end
-    handler
-  end
+  let(:task_handler) { create_api_task_handler_with_connection(described_class, connection) }
   let(:yaml_path) { described_class.yaml_path }
-  let(:yaml_config) { YAML.load_file(yaml_path) }
+  let(:yaml_config) { described_class.config }
   let(:handler_class) { described_class }
+  let(:input_id) { 1 }
   let(:task_request) do
     Tasker::Types::TaskRequest.new(
       name: "<%= @task_name %>",
       namespace: "<%= @namespace_name || 'default' %>",
       version: "<%= @version || '0.1.0' %>",
-      context: { "input_id" => "123" },
+      context: { "input_id" => input_id },
       initiator: "user",
       reason: "test",
       source_system: "test_system"
@@ -33,6 +24,33 @@ RSpec.describe <%= @module_namespace ? "#{@module_namespace}::" : '' %><%= @task
   let(:task) { task_handler.initialize_task!(task_request) }
   let(:factory) { Tasker::HandlerFactory.instance }
 
+  before do
+    # Register handler with namespace + version support
+    factory.register(
+      "<%= @task_name %>",
+      described_class,
+      namespace_name: "<%= @namespace_name || 'default' %>",
+      version: "<%= @version || '0.1.0' %>",
+      replace: true
+    )
+    # Stub data endpoint
+    stubs.get("/data/#{input_id}") do |_env|
+      [
+        200,
+        { 'Content-Type' => 'application/json' },
+        { data: { id: input_id } }.to_json
+      ]
+    end
+    # Stub data endpoint
+    stubs.get("/data") do |_env|
+      [
+        200,
+        { 'Content-Type' => 'application/json' },
+        { data: [ { id: input_id } ] }.to_json
+      ]
+    end
+  end
+
   describe '#initialize' do
     it 'loads the task configuration from YAML' do
       expect(task_handler.config).to be_a(Hash)
@@ -104,36 +122,6 @@ RSpec.describe <%= @module_namespace ? "#{@module_namespace}::" : '' %><%= @task
   end
 
   describe 'complete workflow' do
-    before do
-      # Register handler with namespace + version support
-      factory.register(
-        "<%= @task_name %>",
-        described_class,
-        namespace_name: "<%= @namespace_name || 'default' %>",
-        version: "<%= @version || '0.1.0' %>"
-      )
-      stubs.get("/data") do |env|
-        Faraday::Response.new(
-          Faraday::Env.from(
-            status: 200,
-            response_headers: { 'Content-Type' => 'application/json' },
-            body: { data: { id: 123 } }.to_json,
-            url: env.url
-          )
-        )
-      end
-      stubs.get("/data/123") do |env|
-        Faraday::Response.new(
-          Faraday::Env.from(
-            status: 200,
-            response_headers: { 'Content-Type' => 'application/json' },
-            body: { data: { id: 123 } }.to_json,
-            url: env.url
-          )
-        )
-      end
-    end
-
     it 'can handle the task' do
       expect(task).to be_valid
       expect(task.save).to be_truthy
@@ -157,3 +145,21 @@ RSpec.describe <%= @module_namespace ? "#{@module_namespace}::" : '' %><%= @task
     end
   end
 end
+
+# Create task handler with connection stubbing (for API integration tests)
+def create_api_task_handler_with_connection(handler_class, connection)
+  handler = handler_class.new
+
+  # Override get_step_handler to inject the mocked connection
+  original_get_step_handler = handler.method(:get_step_handler)
+  handler.define_singleton_method(:get_step_handler) do |step|
+    step_handler = original_get_step_handler.call(step)
+
+    # For API step handlers, override the connection that was built during initialization
+    step_handler.instance_variable_set(:@connection, connection) if step_handler.is_a?(Tasker::StepHandler::Api)
+
+    step_handler
+  end
+
+  handler
+end

data/lib/tasker/analysis/runtime_graph_analyzer.rb

@@ -127,7 +127,7 @@ module Tasker
       # @return [Tasker::Types::DependencyGraphConfig] Configuration for calculations
       # @api private
       def dependency_graph_config
-        @dependency_graph_config ||= Tasker.configuration.dependency_graph
+        @dependency_graph_config ||= Tasker::Configuration.configuration.dependency_graph
       end
 
       # Generate cache version based on task state for intelligent cache invalidation

data/lib/tasker/authentication/coordinator.rb

@@ -24,7 +24,7 @@ module Tasker
         private
 
         def build_authenticator
-          auth_config = Tasker.configuration.auth
+          auth_config = Tasker::Configuration.configuration.auth
 
           if auth_config.authentication_enabled
             build_custom_authenticator(auth_config)
@@ -43,7 +43,7 @@ module Tasker
 
           # Instantiate the host app's authenticator
           klass = authenticator_class.constantize
-          # Pass empty options hash for now - authenticators can get config from Tasker.configuration
+          # Pass empty options hash for now - authenticators can get config from Tasker::Configuration.configuration
           authenticator = klass.new({})
 
           # Validate it implements the interface

data/lib/tasker/authorization/base_coordinator.rb

@@ -100,7 +100,7 @@ module Tasker
       #
       # @return [Boolean] True if authorization is enabled
       def authorization_enabled?
-        Tasker.configuration.auth.authorization_enabled
+        Tasker::Configuration.configuration.auth.authorization_enabled
       end
 
       # The user object for authorization checks

data/lib/tasker/authorization.rb

@@ -19,7 +19,7 @@ module Tasker
   # - User model integration via the Authorizable concern
   #
   # @example Basic configuration
-  #   Tasker.configuration do |config|
+  #   Tasker::Configuration.configuration do |config|
   #     config.auth do |auth|
   #       auth.enabled = true
   #       auth.coordinator_class = 'MyAuthorizationCoordinator'

data/lib/tasker/concerns/authenticatable.rb

@@ -34,7 +34,7 @@ module Tasker
       end
 
       def skip_authentication?
-        !Tasker.configuration.auth.authentication_enabled
+        !Tasker::Configuration.configuration.auth.authentication_enabled
       end
     end
   end

data/lib/tasker/concerns/controller_authorizable.rb

@@ -66,10 +66,10 @@ module Tasker
       #
       # @return [BaseCoordinator] New coordinator instance
       def build_authorization_coordinator
-        coordinator_class = Tasker.configuration.auth.authorization_coordinator_class.constantize
+        coordinator_class = Tasker::Configuration.configuration.auth.authorization_coordinator_class.constantize
         coordinator_class.new(current_tasker_user)
       rescue NameError => e
-        coordinator_class_name = Tasker.configuration.auth.authorization_coordinator_class
+        coordinator_class_name = Tasker::Configuration.configuration.auth.authorization_coordinator_class
         raise Tasker::Authorization::ConfigurationError,
               "Authorization coordinator class '#{coordinator_class_name}' not found: #{e.message}"
       end
@@ -117,7 +117,7 @@ module Tasker
       #
       # @return [Boolean] True if authorization should be skipped
       def skip_authorization?
-        !Tasker.configuration.auth.authorization_enabled
+        !Tasker::Configuration.configuration.auth.authorization_enabled
       end
     end
   end

data/lib/tasker/concerns/structured_logging.rb

@@ -322,7 +322,7 @@ module Tasker
       def extract_standard_context
         context = {
           environment: Rails.env,
-          tasker_version: Tasker::VERSION
+          tasker_version: Tasker::Version
         }
 
         # Add process/thread info if available
@@ -380,7 +380,7 @@ module Tasker
       #
       # @return [Tasker::Types::TelemetryConfig] Telemetry configuration
       def telemetry_config
-        @telemetry_config ||= Tasker.configuration.telemetry
+        @telemetry_config ||= Tasker::Configuration.configuration.telemetry
       end
     end
   end

data/lib/tasker/events/definition_loader.rb

@@ -103,7 +103,7 @@ module Tasker
           metadata = {}
 
           # Load custom events from configured directories if they exist
-          Tasker.configuration.engine.custom_events_directories.each do |directory_path|
+          Tasker::Configuration.configuration.engine.custom_events_directories.each do |directory_path|
             absolute_path = File.expand_path(directory_path, Rails.root)
 
             if File.directory?(absolute_path)

data/lib/tasker/events/subscribers/metrics_subscriber.rb

@@ -79,7 +79,7 @@ module Tasker
         # @return [Boolean] True if the event should be processed
         def should_process_event?(event_constant)
           # Only process if telemetry is enabled
-          return false unless Tasker.configuration.telemetry.enabled
+          return false unless Tasker::Configuration.configuration.telemetry.enabled
 
           # Convert constant to event name if needed
           event_name = event_constant.respond_to?(:name) ? event_constant.name : event_constant.to_s

data/lib/tasker/events/subscribers/telemetry_subscriber.rb

@@ -146,7 +146,7 @@ module Tasker
         # Override BaseSubscriber to add telemetry-specific filtering
         def should_process_event?(event_constant)
           # Get configuration once for efficiency
-          config = Tasker.configuration
+          config = Tasker::Configuration.configuration
 
           # Only process if telemetry is enabled
           return false unless config.telemetry.enabled
@@ -163,7 +163,7 @@ module Tasker
 
         # Check if telemetry is enabled
         def telemetry_enabled?
-          Tasker.configuration.telemetry.enabled != false
+          Tasker::Configuration.configuration.telemetry.enabled != false
         end
 
         # Create a simple span for events that don't need complex hierarchy
@@ -296,7 +296,7 @@ module Tasker
         #
         # @return [OpenTelemetry::Tracer] The tracer instance
         def create_tracer
-          config = Tasker.configuration
+          config = Tasker::Configuration.configuration
           ::OpenTelemetry.tracer_provider.tracer(
             config.telemetry.service_name,
             config.telemetry.service_version
@@ -309,7 +309,7 @@ module Tasker
         # @return [Hash] OpenTelemetry-compatible attributes
         def convert_attributes_for_otel(attributes)
           result = {}
-          config = Tasker.configuration
+          config = Tasker::Configuration.configuration
           service_name = config.telemetry.service_name
 
           # Filter sensitive data first
@@ -371,7 +371,7 @@ module Tasker
         # @param attributes [Hash] The attributes to filter
         # @return [Hash] The filtered attributes
         def filter_sensitive_attributes(attributes)
-          filter = Tasker.configuration.telemetry.parameter_filter
+          filter = Tasker::Configuration.configuration.telemetry.parameter_filter
           return attributes unless filter
 
           filtered_data = {}

data/lib/tasker/health/readiness_checker.rb

@@ -25,7 +25,7 @@ module Tasker
       #
       # @param timeout [Float] Maximum time to wait for checks (default: 5.0 seconds)
       def initialize(timeout: nil)
-        @timeout = timeout || Tasker.configuration.health.readiness_timeout_seconds
+        @timeout = timeout || Tasker::Configuration.configuration.health.readiness_timeout_seconds
       end
 
       # Class method for simple readiness check

data/lib/tasker/health/status_checker.rb

@@ -25,7 +25,7 @@ module Tasker
       #
       # @param cache_duration [Integer] Cache duration in seconds (default from config)
       def initialize(cache_duration: nil)
-        @cache_duration = cache_duration || Tasker.configuration.health.cache_duration_seconds
+        @cache_duration = cache_duration || Tasker::Configuration.configuration.health.cache_duration_seconds
       end
 
       # Class method for status check

data/lib/tasker/logging/correlation_id_generator.rb

@@ -66,7 +66,7 @@ module Tasker
         #   id = from_headers(request.headers)
         #   id = from_headers(env, 'X-Request-ID')
         def from_headers(headers, header_name = nil)
-          header_name ||= Tasker.configuration.telemetry.correlation_id_header
+          header_name ||= Tasker::Configuration.configuration.telemetry.correlation_id_header
 
           # Handle different header formats (rack vs rails)
           header_value = headers[header_name] ||

data/lib/tasker/orchestration/backoff_calculator.rb

@@ -50,7 +50,7 @@ module Tasker
       #
       # @return [Tasker::Types::BackoffConfig] The backoff configuration
       def backoff_config
-        @backoff_config ||= Tasker.configuration.backoff
+        @backoff_config ||= Tasker::Configuration.configuration.backoff
       end
 
       # Extract Retry-After header from response context

data/lib/tasker/orchestration/connection_builder.rb

@@ -20,7 +20,7 @@ module Tasker
 
         Rails.logger.debug do
           "ConnectionBuilder: Building connection to #{config.url} " \
-            "with #{config.params.keys.size} params and #{config.headers.keys.size} headers"
+            "with #{config.params} params and #{config.headers} headers"
         end
 
         connection = Faraday.new(

data/lib/tasker/orchestration/connection_pool_intelligence.rb

@@ -19,7 +19,7 @@ module Tasker
     #   concurrency = ConnectionPoolIntelligence.intelligent_concurrency_for_step_executor
     #
     # @example With custom configuration
-    #   config = Tasker.configuration.execution
+    #   config = Tasker::Configuration.configuration.execution
     #   config.connection_pressure_factors = { high: 0.3, critical: 0.1 }
     #   concurrency = ConnectionPoolIntelligence.intelligent_concurrency_for_step_executor
     class ConnectionPoolIntelligence
@@ -91,7 +91,7 @@ module Tasker
       # @return [Integer] Safe concurrency level for step execution
       def self.intelligent_concurrency_for_step_executor
         health_data = assess_connection_health
-        config = Tasker.configuration.execution
+        config = Tasker::Configuration.configuration.execution
 
         # Get base recommendation from Rails pool analysis
         base_recommendation = health_data[:recommended_concurrency]
@@ -135,7 +135,7 @@ module Tasker
         pressure = assess_pressure(pool_stat)
 
         # ✅ CONFIGURABLE: Pressure response factors (environment-dependent)
-        pressure_config = Tasker.configuration.execution.connection_pressure_factors
+        pressure_config = Tasker::Configuration.configuration.execution.connection_pressure_factors
         factor = pressure_config[pressure] || 0.5
 
         base_recommendation = [pool_stat[:available] * factor, 12].min.floor

data/lib/tasker/orchestration/step_executor.rb

@@ -22,11 +22,11 @@ module Tasker
       include Tasker::Concerns::StructuredLogging
 
       # Configuration-driven execution settings
-      # These delegate to Tasker.configuration.execution for configurable values
+      # These delegate to Tasker::Configuration.configuration.execution for configurable values
       # while maintaining architectural constants for Ruby-specific optimizations
 
       def execution_config
-        @execution_config ||= Tasker.configuration.execution
+        @execution_config ||= Tasker::Configuration.configuration.execution
       end
 
       # Execute a collection of viable steps

data/lib/tasker/orchestration/task_finalizer.rb

@@ -440,7 +440,7 @@ module Tasker
           #
           # @return [Tasker::Types::BackoffConfig] The backoff configuration
           def backoff_config
-            @backoff_config ||= Tasker.configuration.backoff
+            @backoff_config ||= Tasker::Configuration.configuration.backoff
           end
 
           # Frozen hash for O(1) delay lookups with descriptive comments

data/lib/tasker/registry/base_registry.rb

@@ -16,7 +16,7 @@ module Tasker
 
       def initialize
         @mutex = Mutex.new
-        @telemetry_config = Tasker.configuration.telemetry
+        @telemetry_config = Tasker::Configuration.configuration.telemetry
         @registry_name = self.class.name.demodulize.underscore
         @created_at = Time.current
       end

data/lib/tasker/task_builder.rb

@@ -411,7 +411,7 @@ module Tasker
       #
       # @return [String] The path to the YAML file
       def yaml_path
-        @yaml_path ||= Rails.root.join("config/#{Tasker.configuration.engine.task_config_directory}/#{task_name}.yaml")
+        @yaml_path ||= Rails.root.join("config/#{Tasker::Configuration.configuration.engine.task_config_directory}/#{task_name}.yaml")
       end
 
       # Load the configuration from the YAML file

data/lib/tasker/telemetry/intelligent_cache_manager.rb

@@ -51,7 +51,7 @@ module Tasker
       #
       # @param config [Tasker::Types::CacheConfig, nil] Cache configuration
       def initialize(config = nil)
-        @config = config || Tasker.configuration.cache
+        @config = config || Tasker::Configuration.configuration.cache
 
         # Use unified cache strategy for capability detection
         @cache_strategy = Tasker::CacheStrategy.detect

data/lib/tasker/telemetry/metric_types.rb

@@ -100,9 +100,25 @@ module Tasker
         #
         # @return [String] Human-readable description
         def description
-          label_str = labels.empty? ? '' : labels.inspect
+          label_str = labels.empty? ? '' : format_labels_for_description(labels)
           "#{name}#{label_str} = #{value} (counter)"
         end
+
+        private
+
+        # Format labels consistently across Ruby versions
+        # Uses the older Ruby hash syntax for backward compatibility with tests
+        #
+        # @param labels_hash [Hash] The labels hash to format
+        # @return [String] Formatted label string
+        def format_labels_for_description(labels_hash)
+          return '' if labels_hash.empty?
+
+          formatted_pairs = labels_hash.map do |key, value|
+            ":#{key}=>#{value.inspect}"
+          end
+          "{#{formatted_pairs.join(', ')}}"
+        end
       end
 
       # Gauge represents a metric value that can go up or down
@@ -212,9 +228,25 @@ module Tasker
         #
         # @return [String] Human-readable description
         def description
-          label_str = labels.empty? ? '' : labels.inspect
+          label_str = labels.empty? ? '' : format_labels_for_description(labels)
           "#{name}#{label_str} = #{value} (gauge)"
         end
+
+        private
+
+        # Format labels consistently across Ruby versions
+        # Uses the older Ruby hash syntax for backward compatibility with tests
+        #
+        # @param labels_hash [Hash] The labels hash to format
+        # @return [String] Formatted label string
+        def format_labels_for_description(labels_hash)
+          return '' if labels_hash.empty?
+
+          formatted_pairs = labels_hash.map do |key, value|
+            ":#{key}=>#{value.inspect}"
+          end
+          "{#{formatted_pairs.join(', ')}}"
+        end
       end
 
       # Histogram represents a metric that samples observations and counts them in buckets
@@ -346,21 +378,37 @@ module Tasker
           }
         end
 
+        # Reset the histogram (primarily for testing)
+        #
+        # @return [void]
+        def reset!
+          @count.value = 0
+          @sum.set(0.0)
+          @bucket_counts.each { |bucket| bucket.value = 0 }
+        end
+
         # Get a description of this metric for debugging
         #
         # @return [String] Human-readable description
         def description
-          label_str = labels.empty? ? '' : labels.inspect
+          label_str = labels.empty? ? '' : format_labels_for_description(labels)
           "#{name}#{label_str} = #{count} observations, avg: #{average.round(3)} (histogram)"
         end
 
-        # Reset the histogram (primarily for testing)
+        private
+
+        # Format labels consistently across Ruby versions
+        # Uses the older Ruby hash syntax for backward compatibility with tests
         #
-        # @return [void]
-        def reset!
-          @count.value = 0
-          @sum.set(0.0)
-          @bucket_counts.each { |bucket| bucket.value = 0 }
+        # @param labels_hash [Hash] The labels hash to format
+        # @return [String] Formatted label string
+        def format_labels_for_description(labels_hash)
+          return '' if labels_hash.empty?
+
+          formatted_pairs = labels_hash.map do |key, value|
+            ":#{key}=>#{value.inspect}"
+          end
+          "{#{formatted_pairs.join(', ')}}"
         end
       end
     end