tapyrus 0.2.7 → 0.2.8

data/lib/tapyrus/bloom_filter.rb

@@ -1,4 +1,4 @@
-require "murmurhash3"
+require 'murmurhash3'
 module Tapyrus
   class BloomFilter
     LN2_SQUARED = 0.4804530139182014246671025263266649717305529515945455 # log(2) ** 2
@@ -23,6 +23,7 @@ module Tapyrus
       # The size S of the filter in bytes is given by (-1 / pow(log(2), 2) * N * log(P)) / 8
       len = [[(-elements_length * Math.log(fp_rate) / (LN2_SQUARED * 8)).to_i, MAX_BLOOM_FILTER_SIZE].min, 1].max
       filter = Array.new(len, 0)
+
       # The number of hash functions required is given by S * 8 / N * log(2)
       hash_funcs = [[(filter.size * 8 * LN2 / elements_length).to_i, MAX_HASH_FUNCS].min, 1].max
       BloomFilter.new(filter, hash_funcs, tweak)
@@ -59,8 +60,9 @@ module Tapyrus
     end
 
     private
+
     def to_hash(data, i)
-      MurmurHash3::V32.str_hash(data, (i * 0xfba4c795 + tweak) & 0xffffffff)  % (filter.length * 8)
+      MurmurHash3::V32.str_hash(data, (i * 0xfba4c795 + tweak) & 0xffffffff) % (filter.length * 8)
     end
 
     def set_bit(data)
@@ -72,7 +74,7 @@ module Tapyrus
     end
 
     def full?
-      @full |= filter.all? {|byte| byte == 0xff}
+      @full |= filter.all? { |byte| byte == 0xff }
     end
   end
 end

data/lib/tapyrus/chain_params.rb

@@ -1,10 +1,8 @@
 require 'yaml'
 
 module Tapyrus
-
   # Network parameter class
   class ChainParams
-
     attr_reader :network
     attr_reader :magic_head
     attr_reader :message_magic
@@ -63,5 +61,4 @@ module Tapyrus
 
     private_class_method :init
   end
-
-end
+end

data/lib/tapyrus/chainparams/dev.yml

@@ -1,4 +1,5 @@
---- !ruby/object:Tapyrus::ChainParams
+---
+!ruby/object:Tapyrus::ChainParams
 network: "dev"
 magic_head: "0b110907"
 message_magic: "Tapyrus Signed Message:\n"
@@ -26,4 +27,4 @@ target_spacing: 600 # block interval
 max_money: 21000000
 bip34_height: 227931
 dns_seeds:
-bip44_coin_type: 1
+bip44_coin_type: 1

data/lib/tapyrus/chainparams/prod.yml

@@ -1,4 +1,5 @@
---- !ruby/object:Tapyrus::ChainParams
+---
+!ruby/object:Tapyrus::ChainParams
 network: "prod"
 magic_head: "f9beb4d9"
 message_magic: "Tapyrus Signed Message:\n"
@@ -26,4 +27,4 @@ target_spacing: 600 # block interval
 max_money: 21000000
 bip34_height: 227931
 dns_seeds:
-bip44_coin_type: 0
+bip44_coin_type: 0

data/lib/tapyrus/constants.rb

@@ -1,20 +1,23 @@
 module Tapyrus
-
   COIN = 100_000_000
   MAX_MONEY = 21_000_000 * COIN
 
   # The maximum allowed size for a serialized block, in bytes (only for buffer size limits)
   MAX_BLOCK_SERIALIZED_SIZE = 4_000_000
+
   # The maximum allowed weight for a block, see BIP 141 (network rule)
   MAX_BLOCK_WEIGHT = 4_000_000
+
   # The maximum allowed number of signature check operations in a block (network rule)
   MAX_BLOCK_SIGOPS_COST = 80_000
+
   # Coinbase transaction outputs can only be spent after this number of new blocks (network rule)
   COINBASE_MATURITY = 100
   WITNESS_SCALE_FACTOR = 4
 
   # 60 is the lower bound for the size of a valid serialized Tx
   MIN_TRANSACTION_WEIGHT = WITNESS_SCALE_FACTOR * 60
+
   # 10 is the lower bound for the size of a serialized Tx
   MIN_SERIALIZABLE_TRANSACTION_WEIGHT = WITNESS_SCALE_FACTOR * 10
 
@@ -26,11 +29,11 @@ module Tapyrus
   DUST_RELAY_TX_FEE = 3000
 
   # script verify flags
-  SCRIPT_VERIFY_NONE      = 0
-  SCRIPT_VERIFY_P2SH      = (1 << 0)
+  SCRIPT_VERIFY_NONE = 0
+  SCRIPT_VERIFY_P2SH = (1 << 0)
   SCRIPT_VERIFY_STRICTENC = (1 << 1)
-  SCRIPT_VERIFY_DERSIG    = (1 << 2)
-  SCRIPT_VERIFY_LOW_S     = (1 << 3)
+  SCRIPT_VERIFY_DERSIG = (1 << 2)
+  SCRIPT_VERIFY_LOW_S = (1 << 3)
   SCRIPT_VERIFY_NULLDUMMY = (1 << 4)
   SCRIPT_VERIFY_SIGPUSHONLY = (1 << 5)
   SCRIPT_VERIFY_MINIMALDATA = (1 << 6)
@@ -45,24 +48,27 @@ module Tapyrus
   MANDATORY_SCRIPT_VERIFY_FLAGS = SCRIPT_VERIFY_P2SH
 
   # Standard script verification flags that standard transactions will comply with.
-  STANDARD_SCRIPT_VERIFY_FLAGS = [MANDATORY_SCRIPT_VERIFY_FLAGS,
-                                  SCRIPT_VERIFY_DERSIG,
-                                  SCRIPT_VERIFY_STRICTENC,
-                                  SCRIPT_VERIFY_MINIMALDATA,
-                                  SCRIPT_VERIFY_NULLDUMMY,
-                                  SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS,
-                                  SCRIPT_VERIFY_CLEANSTACK,
-                                  SCRIPT_VERIFY_MINIMALIF,
-                                  SCRIPT_VERIFY_NULLFAIL,
-                                  SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY,
-                                  SCRIPT_VERIFY_CHECKSEQUENCEVERIFY,
-                                  SCRIPT_VERIFY_LOW_S,
-                                  SCRIPT_VERIFY_CONST_SCRIPTCODE].inject(SCRIPT_VERIFY_NONE){|flags, f| flags |= f}
+  STANDARD_SCRIPT_VERIFY_FLAGS =
+    [
+      MANDATORY_SCRIPT_VERIFY_FLAGS,
+      SCRIPT_VERIFY_DERSIG,
+      SCRIPT_VERIFY_STRICTENC,
+      SCRIPT_VERIFY_MINIMALDATA,
+      SCRIPT_VERIFY_NULLDUMMY,
+      SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS,
+      SCRIPT_VERIFY_CLEANSTACK,
+      SCRIPT_VERIFY_MINIMALIF,
+      SCRIPT_VERIFY_NULLFAIL,
+      SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY,
+      SCRIPT_VERIFY_CHECKSEQUENCEVERIFY,
+      SCRIPT_VERIFY_LOW_S,
+      SCRIPT_VERIFY_CONST_SCRIPTCODE
+    ].inject(SCRIPT_VERIFY_NONE) { |flags, f| flags |= f }
 
   # for script
 
   # Maximum script length in bytes
-  MAX_SCRIPT_SIZE = 10000
+  MAX_SCRIPT_SIZE = 10_000
 
   # Maximum number of public keys per multisig
   MAX_PUBKEYS_PER_MULTISIG = 20
@@ -77,7 +83,7 @@ module Tapyrus
   MAX_STACK_SIZE = 1000
 
   # Threshold for nLockTime: below this value it is interpreted as block number, otherwise as UNIX timestamp.
-  LOCKTIME_THRESHOLD = 500000000
+  LOCKTIME_THRESHOLD = 500_000_000
 
   # Signature hash types/flags
   SIGHASH_TYPE = { all: 1, none: 2, single: 3, anyonecanpay: 128 }
@@ -153,7 +159,7 @@ module Tapyrus
   ERRCODES_MAP = Hash[*constants.grep(/^SCRIPT_ERR_/).map { |c| [const_get(c), c.to_s] }.flatten]
   NAME_MAP = Hash[*constants.grep(/^SCRIPT_ERR_/).map { |c| [c.to_s, const_get(c)] }.flatten]
 
-  COINBASE_WTXID = '00'* 32
+  COINBASE_WTXID = '00' * 32
 
   # for message
   MESSAGE_HEADER_SIZE = 24
@@ -169,5 +175,5 @@ module Tapyrus
 
   BIP32_EXTKEY_WITH_VERSION_SIZE = 78
 
-  HARDENED_THRESHOLD = 2147483648 # 2**31
-end
+  HARDENED_THRESHOLD = 2_147_483_648 # 2**31
+end

data/lib/tapyrus/errors.rb

@@ -1,7 +1,6 @@
 module Tapyrus
   module Errors
     module Messages
-
       INVALID_PUBLIC_KEY = 'Invalid public key.'
       INVALID_BIP32_PRIV_PREFIX = 'Invalid BIP32 private key prefix. prefix must be 0x00.'
       INVALID_BIP32_FINGERPRINT = 'Invalid parent fingerprint.'
@@ -11,7 +10,6 @@ module Tapyrus
 
       INVALID_PRIV_KEY = 'Private key is not in range [1..n-1].'
       INVALID_CHECKSUM = 'Invalid checksum.'
-
     end
   end
-end
+end

data/lib/tapyrus/ext.rb

@@ -2,4 +2,4 @@ module Tapyrus
   module Ext
     autoload :JsonParser, 'tapyrus/ext/json_parser'
   end
-end
+end

data/lib/tapyrus/ext/ecdsa.rb

@@ -12,7 +12,6 @@ class ::ECDSA::Point
 end
 
 module ::ECDSA::Format::PointOctetString
-
   def self.decode(string, group, allow_hybrid: false)
     string = string.dup.force_encoding('BINARY')
 
@@ -29,11 +28,12 @@ module ::ECDSA::Format::PointOctetString
     when 4
       decode_uncompressed string, group
     when 6..7
-      raise ECDSA::Format::DecodeError, 'Unrecognized start byte for point octet string: 0x%x' % string[0].ord unless allow_hybrid
+      unless allow_hybrid
+        raise ECDSA::Format::DecodeError, 'Unrecognized start byte for point octet string: 0x%x' % string[0].ord
+      end
       decode_uncompressed string, group if allow_hybrid
     else
       raise ECDSA::Format::DecodeError, 'Unrecognized start byte for point octet string: 0x%x' % string[0].ord
     end
   end
-
-end
+end

data/lib/tapyrus/ext/json_parser.rb

@@ -2,11 +2,9 @@ require 'json/pure'
 
 module Tapyrus
   module Ext
-
     # Extension of JSON::Pure::Parser.
     # This class convert Float value to String value.
     class JsonParser < JSON::Pure::Parser
-
       def parse_value
         case
         when scan(FLOAT)
@@ -41,7 +39,6 @@ module Tapyrus
           UNPARSED
         end
       end
-
     end
   end
-end
+end

data/lib/tapyrus/ext_key.rb

@@ -1,5 +1,4 @@
 module Tapyrus
-
   # Integers modulo the order of the curve(secp256k1)
   CURVE_ORDER = ECDSA::Group::Secp256k1.order
 
@@ -45,8 +44,8 @@ module Tapyrus
 
     # serialize extended private key
     def to_payload
-      version.htb << [depth].pack('C') << parent_fingerprint.htb <<
-          [number].pack('N') << chain_code << [0x00].pack('C') << key.priv_key.htb
+      version.htb << [depth].pack('C') << parent_fingerprint.htb << [number].pack('N') << chain_code <<
+        [0x00].pack('C') << key.priv_key.htb
     end
 
     # Base58 encoded extended private key
@@ -108,8 +107,7 @@ module Tapyrus
       raise 'invalid key' if left >= CURVE_ORDER
       child_priv = (left + key.priv_key.to_i(16)) % CURVE_ORDER
       raise 'invalid key ' if child_priv >= CURVE_ORDER
-      new_key.key = Tapyrus::Key.new(
-          priv_key: child_priv.to_even_length_hex.rjust(64, '0'), key_type: key_type)
+      new_key.key = Tapyrus::Key.new(priv_key: child_priv.to_even_length_hex.rjust(64, '0'), key_type: key_type)
       new_key.chain_code = l[32..-1]
       new_key.ver = version
       new_key
@@ -147,10 +145,14 @@ module Tapyrus
       ext_key.parent_fingerprint = buf.read(4).bth
       ext_key.number = buf.read(4).unpack('N').first
       if ext_key.depth == 0
-        raise ArgumentError, Errors::Messages::INVALID_BIP32_FINGERPRINT unless ext_key.parent_fingerprint == ExtKey::MASTER_FINGERPRINT
+        unless ext_key.parent_fingerprint == ExtKey::MASTER_FINGERPRINT
+          raise ArgumentError, Errors::Messages::INVALID_BIP32_FINGERPRINT
+        end
         raise ArgumentError, Errors::Messages::INVALID_BIP32_ZERO_INDEX if ext_key.number > 0
       end
-      raise ArgumentError, Errors::Messages:: INVALID_BIP32_ZERO_DEPTH if ext_key.parent_fingerprint == ExtKey::MASTER_FINGERPRINT && ext_key.depth > 0
+      if ext_key.parent_fingerprint == ExtKey::MASTER_FINGERPRINT && ext_key.depth > 0
+        raise ArgumentError, Errors::Messages::INVALID_BIP32_ZERO_DEPTH
+      end
       ext_key.chain_code = buf.read(32)
       raise ArgumentError, Errors::Messages::INVALID_BIP32_PRIV_PREFIX unless buf.read(1).bth == '00' # 0x00
       ext_key.key = Tapyrus::Key.new(priv_key: buf.read(32).bth, key_type: Tapyrus::Key::TYPES[:compressed])
@@ -166,33 +168,34 @@ module Tapyrus
     def self.version_from_purpose(purpose)
       v = purpose - Tapyrus::HARDENED_THRESHOLD
       case v
-        when 49
-          Tapyrus.chain_params.bip49_privkey_p2wpkh_p2sh_version
-        when 84
-          Tapyrus.chain_params.bip84_privkey_p2wpkh_version
-        else
-          Tapyrus.chain_params.extended_privkey_version
+      when 49
+        Tapyrus.chain_params.bip49_privkey_p2wpkh_p2sh_version
+      when 84
+        Tapyrus.chain_params.bip84_privkey_p2wpkh_version
+      else
+        Tapyrus.chain_params.extended_privkey_version
       end
     end
 
     # check whether +version+ is supported version bytes.
     def self.support_version?(version)
       p = Tapyrus.chain_params
-      [p.bip49_privkey_p2wpkh_p2sh_version, p.bip84_privkey_p2wpkh_version, p.extended_privkey_version].include?(version)
+      [p.bip49_privkey_p2wpkh_p2sh_version, p.bip84_privkey_p2wpkh_version, p.extended_privkey_version].include?(
+        version
+      )
     end
 
     # convert privkey version to pubkey version
     def priv_ver_to_pub_ver
       case version
-        when Tapyrus.chain_params.bip49_privkey_p2wpkh_p2sh_version
-          Tapyrus.chain_params.bip49_pubkey_p2wpkh_p2sh_version
-        when Tapyrus.chain_params.bip84_privkey_p2wpkh_version
-          Tapyrus.chain_params.bip84_pubkey_p2wpkh_version
-        else
-          Tapyrus.chain_params.extended_pubkey_version
+      when Tapyrus.chain_params.bip49_privkey_p2wpkh_p2sh_version
+        Tapyrus.chain_params.bip49_pubkey_p2wpkh_p2sh_version
+      when Tapyrus.chain_params.bip84_privkey_p2wpkh_version
+        Tapyrus.chain_params.bip84_pubkey_p2wpkh_version
+      else
+        Tapyrus.chain_params.extended_pubkey_version
       end
     end
-
   end
 
   # BIP-32 Extended public key
@@ -208,8 +211,7 @@ module Tapyrus
 
     # serialize extended pubkey
     def to_payload
-      version.htb << [depth].pack('C') <<
-          parent_fingerprint.htb << [number].pack('N') << chain_code << pub.htb
+      version.htb << [depth].pack('C') << parent_fingerprint.htb << [number].pack('N') << chain_code << pub.htb
     end
 
     def pub
@@ -269,7 +271,7 @@ module Tapyrus
       l = Tapyrus.hmac_sha512(chain_code, data)
       left = l[0..31].bth.to_i(16)
       raise 'invalid key' if left >= CURVE_ORDER
-      p1 = Tapyrus::Secp256k1::GROUP.generator.multiply_by_scalar(left)
+      p1 = Tapyrus::Key.new(priv_key: left.to_s(16), key_type: Tapyrus::Key::TYPES[:uncompressed]).to_point
       p2 = Tapyrus::Key.new(pubkey: pubkey, key_type: key_type).to_point
       new_key.pubkey = (p1 + p2).to_hex
       new_key.chain_code = l[32..-1]
@@ -309,10 +311,14 @@ module Tapyrus
       ext_pubkey.parent_fingerprint = buf.read(4).bth
       ext_pubkey.number = buf.read(4).unpack('N').first
       if ext_pubkey.depth == 0
-        raise ArgumentError, Errors::Messages::INVALID_BIP32_FINGERPRINT unless ext_pubkey.parent_fingerprint == ExtKey::MASTER_FINGERPRINT
+        unless ext_pubkey.parent_fingerprint == ExtKey::MASTER_FINGERPRINT
+          raise ArgumentError, Errors::Messages::INVALID_BIP32_FINGERPRINT
+        end
         raise ArgumentError, Errors::Messages::INVALID_BIP32_ZERO_INDEX if ext_pubkey.number > 0
       end
-      raise ArgumentError, Errors::Messages::INVALID_BIP32_ZERO_DEPTH if ext_pubkey.parent_fingerprint == ExtKey::MASTER_FINGERPRINT && ext_pubkey.depth > 0
+      if ext_pubkey.parent_fingerprint == ExtKey::MASTER_FINGERPRINT && ext_pubkey.depth > 0
+        raise ArgumentError, Errors::Messages::INVALID_BIP32_ZERO_DEPTH
+      end
       ext_pubkey.chain_code = buf.read(32)
       ext_pubkey.pubkey = Tapyrus::Key.new(pubkey: buf.read(33).bth).pubkey
       ext_pubkey
@@ -336,12 +342,12 @@ module Tapyrus
     def self.version_from_purpose(purpose)
       v = purpose - Tapyrus::HARDENED_THRESHOLD
       case v
-        when 49
-          Tapyrus.chain_params.bip49_pubkey_p2wpkh_p2sh_version
-        when 84
-          Tapyrus.chain_params.bip84_pubkey_p2wpkh_version
-        else
-          Tapyrus.chain_params.extended_pubkey_version
+      when 49
+        Tapyrus.chain_params.bip49_pubkey_p2wpkh_p2sh_version
+      when 84
+        Tapyrus.chain_params.bip84_pubkey_p2wpkh_version
+      else
+        Tapyrus.chain_params.extended_pubkey_version
       end
     end
 
@@ -350,7 +356,5 @@ module Tapyrus
       p = Tapyrus.chain_params
       [p.bip49_pubkey_p2wpkh_p2sh_version, p.bip84_pubkey_p2wpkh_version, p.extended_pubkey_version].include?(version)
     end
-
   end
-
 end

data/lib/tapyrus/key.rb

@@ -2,10 +2,8 @@
 # https://github.com/lian/bitcoin-ruby/blob/master/COPYING
 
 module Tapyrus
-
   # tapyrus key class
   class Key
-
     PUBLIC_KEY_SIZE = 65
     COMPRESSED_PUBLIC_KEY_SIZE = 33
     SIGNATURE_SIZE = 72
@@ -18,9 +16,10 @@ module Tapyrus
     attr_accessor :key_type
     attr_reader :secp256k1_module
 
-    TYPES = {uncompressed: 0x00, compressed: 0x01, p2pkh: 0x10, p2wpkh: 0x11, p2wpkh_p2sh: 0x12}
+    TYPES = { uncompressed: 0x00, compressed: 0x01, p2pkh: 0x10, p2wpkh: 0x11, p2wpkh_p2sh: 0x12 }
 
     MIN_PRIV_KEY_MOD_ORDER = 0x01
+
     # Order of secp256k1's generator minus 1.
     MAX_PRIV_KEY_MOD_ORDER = ECDSA::Group::Secp256k1.order - 1
 
@@ -31,18 +30,18 @@ module Tapyrus
     # @param [Boolean] compressed [Deprecated] whether public key is compressed.
     # @return [Tapyrus::Key] a key object.
     def initialize(priv_key: nil, pubkey: nil, key_type: nil, compressed: true, allow_hybrid: false)
-      puts "[Warning] Use key_type parameter instead of compressed. compressed parameter removed in the future." if key_type.nil? && !compressed.nil? && pubkey.nil?
+      if key_type.nil? && !compressed.nil? && pubkey.nil?
+        puts '[Warning] Use key_type parameter instead of compressed. compressed parameter removed in the future.'
+      end
       if key_type
         @key_type = key_type
         compressed = @key_type != TYPES[:uncompressed]
       else
         @key_type = compressed ? TYPES[:compressed] : TYPES[:uncompressed]
       end
-      @secp256k1_module =  Tapyrus.secp_impl
+      @secp256k1_module = Tapyrus.secp_impl
       @priv_key = priv_key
-      if @priv_key
-        raise ArgumentError, Errors::Messages::INVALID_PRIV_KEY unless validate_private_key_range(@priv_key)
-      end
+      raise ArgumentError, Errors::Messages::INVALID_PRIV_KEY unless validate_private_key_range(@priv_key) if @priv_key
       if pubkey
         @pubkey = pubkey
       else
@@ -66,7 +65,9 @@ module Tapyrus
       data = hex[2...-8].htb
       checksum = hex[-8..-1]
       raise ArgumentError, 'invalid version' unless version == Tapyrus.chain_params.privkey_version
-      raise ArgumentError, Errors::Messages::INVALID_CHECKSUM unless Tapyrus.calc_checksum(version + data.bth) == checksum
+      unless Tapyrus.calc_checksum(version + data.bth) == checksum
+        raise ArgumentError, Errors::Messages::INVALID_CHECKSUM
+      end
       key_len = data.bytesize
       if key_len == COMPRESSED_PUBLIC_KEY_SIZE && data[-1].unpack('C').first == 1
         key_type = TYPES[:compressed]
@@ -95,7 +96,7 @@ module Tapyrus
     # @param [Symbol] algo Algorithms used for verification. Either :ecdsa or :schnorr is supported. default value is :ecdsa.
     # @return [String] signature data with binary format
     def sign(data, low_r = true, extra_entropy = nil, algo: :ecdsa)
-      raise ArgumentError, "Unsupported algorithm has been specified." unless SIG_ALGO.include?(algo)
+      raise ArgumentError, 'Unsupported algorithm has been specified.' unless SIG_ALGO.include?(algo)
       case algo
       when :ecdsa
         sign_ecdsa(data, low_r, extra_entropy)
@@ -114,7 +115,7 @@ module Tapyrus
     def verify(sig, origin, algo: :ecdsa)
       return false unless valid_pubkey?
       begin
-        raise ArgumentError, "Unsupported algorithm has been specified." unless SIG_ALGO.include?(algo)
+        raise ArgumentError, 'Unsupported algorithm has been specified.' unless SIG_ALGO.include?(algo)
         sig = ecdsa_signature_parse_der_lax(sig) if algo == :ecdsa
         secp256k1_module.verify_sig(origin, sig, pubkey, algo: algo)
       rescue Exception
@@ -150,12 +151,12 @@ module Tapyrus
       p = pubkey.htb
       return false if p.bytesize < COMPRESSED_PUBLIC_KEY_SIZE
       case p[0]
-        when "\x04"
-          return false unless p.bytesize == PUBLIC_KEY_SIZE
-        when "\x02", "\x03"
-          return false unless p.bytesize == COMPRESSED_PUBLIC_KEY_SIZE
-        else
-          return false
+      when "\x04"
+        return false unless p.bytesize == PUBLIC_KEY_SIZE
+      when "\x02", "\x03"
+        return false unless p.bytesize == COMPRESSED_PUBLIC_KEY_SIZE
+      else
+        return false
       end
       true
     end
@@ -172,16 +173,17 @@ module Tapyrus
       len_r = s[3]
       len_s = s[5 + len_r]
       val_s = s.slice(6 + len_r, len_s)
+
+      # prettier-ignore
       max_mod_half_order = [
-          0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff,
-          0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,
-          0x5d,0x57,0x6e,0x73,0x57,0xa4,0x50,0x1d,
-          0xdf,0xe9,0x2f,0x46,0x68,0x1b,0x20,0xa0]
-      compare_big_endian(val_s, [0]) > 0 &&
-          compare_big_endian(val_s, max_mod_half_order) <= 0
+          0x7f, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+          0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+          0x5d, 0x57, 0x6e, 0x73, 0x57, 0xa4, 0x50, 0x1d,
+          0xdf, 0xe9, 0x2f, 0x46, 0x68, 0x1b, 0x20, 0xa0
+      ]
+      compare_big_endian(val_s, [0]) > 0 && compare_big_endian(val_s, max_mod_half_order) <= 0
     end
 
-
     # check +sig+ is correct der encoding.
     # This function is consensus-critical since BIP66.
     # @param [String] sig a signature data with binary format.
@@ -233,15 +235,11 @@ module Tapyrus
     def self.compare_big_endian(c1, c2)
       c1, c2 = c1.dup, c2.dup # Clone the arrays
 
-      while c1.size > c2.size
-        return 1 if c1.shift > 0
-      end
+      return 1 if c1.shift > 0 while c1.size > c2.size
 
-      while c2.size > c1.size
-        return -1 if c2.shift > 0
-      end
+      return -1 if c2.shift > 0 while c2.size > c1.size
 
-      c1.size.times{|idx| return c1[idx] - c2[idx] if c1[idx] != c2[idx] }
+      c1.size.times { |idx| return c1[idx] - c2[idx] if c1[idx] != c2[idx] }
       0
     end
 
@@ -267,7 +265,7 @@ module Tapyrus
     def ecdsa_signature_parse_der_lax(sig)
       sig_array = sig.unpack('C*')
       len_r = sig_array[3]
-      r = sig_array[4...(len_r+4)].pack('C*').bth
+      r = sig_array[4...(len_r + 4)].pack('C*').bth
       len_s = sig_array[len_r + 5]
       s = sig_array[(len_r + 6)...(len_r + 6 + len_s)].pack('C*').bth
       ECDSA::Signature.new(r.to_i(16), s.to_i(16)).to_der
@@ -291,13 +289,11 @@ module Tapyrus
         counter = 1
         until sig_has_low_r?(sig)
           extra_entropy = [counter].pack('I*').bth.ljust(64, '0').htb
-          sig = secp256k1_module.sign_data(data, priv_key, extra_entropy,  algo: :ecdsa)
+          sig = secp256k1_module.sign_data(data, priv_key, extra_entropy, algo: :ecdsa)
           counter += 1
         end
       end
       sig
     end
-
   end
-
 end