tapioca 0.8.3 → 0.9.0

data/lib/tapioca/helpers/sorbet_helper.rb

@@ -1,9 +1,6 @@
 # typed: strict
 # frozen_string_literal: true
 
-require "pathname"
-require "shellwords"
-
 module Tapioca
   module SorbetHelper
     extend T::Sig
@@ -20,6 +17,8 @@ module Tapioca
 
     SORBET_EXE_PATH_ENV_VAR = "TAPIOCA_SORBET_EXE"
 
+    SORBET_PAYLOAD_URL = "https://github.com/sorbet/sorbet/tree/master/rbi"
+
     FEATURE_REQUIREMENTS = T.let({
       to_ary_nil_support: ::Gem::Requirement.new(">= 0.5.9220"),         # https://github.com/sorbet/sorbet/pull/4706
       print_payload_sources: ::Gem::Requirement.new(">= 0.5.9818"),      # https://github.com/sorbet/sorbet/pull/5504

data/lib/tapioca/helpers/test/content.rb

@@ -1,8 +1,6 @@
 # typed: strict
 # frozen_string_literal: true
 
-require "fileutils"
-
 module Tapioca
   module Helpers
     module Test

data/lib/tapioca/helpers/test/template.rb

@@ -1,8 +1,6 @@
 # typed: strict
 # frozen_string_literal: true
 
-require "erb"
-
 module Tapioca
   module Helpers
     module Test

data/lib/tapioca/internal.rb

@@ -1,32 +1,54 @@
 # typed: strict
 # frozen_string_literal: true
 
+require "set"
+
 require "tapioca"
 require "tapioca/runtime/reflection"
 require "tapioca/runtime/trackers"
+
+require "bundler"
+require "erb"
+require "etc"
+require "fileutils"
+require "json"
+require "logger"
+require "net/http"
+require "netrc"
+require "parallel"
+require "pathname"
+require "shellwords"
+require "spoom"
+require "tempfile"
+require "thor"
+require "yaml"
+require "yard-sorbet"
+
 require "tapioca/runtime/dynamic_mixin_compiler"
 require "tapioca/helpers/gem_helper"
 require "tapioca/runtime/loader"
+
 require "tapioca/helpers/sorbet_helper"
-require "tapioca/helpers/type_variable_helper"
-require "tapioca/sorbet_ext/generic_name_patch"
+require "tapioca/helpers/rbi_helper"
 require "tapioca/sorbet_ext/fixed_hash_patch"
+require "tapioca/sorbet_ext/name_patch"
+require "tapioca/sorbet_ext/generic_name_patch"
 require "tapioca/runtime/generic_type_registry"
+
 require "tapioca/helpers/cli_helper"
 require "tapioca/helpers/config_helper"
-require "tapioca/helpers/signatures_helper"
-require "tapioca/helpers/rbi_helper"
-require "tapioca/helpers/shims_helper"
+require "tapioca/helpers/rbi_files_helper"
+require "tapioca/helpers/env_helper"
+
 require "tapioca/repo_index"
-require "tapioca/commands"
-require "tapioca/cli"
 require "tapioca/gemfile"
 require "tapioca/executor"
+
 require "tapioca/static/symbol_table_parser"
 require "tapioca/static/symbol_loader"
-require "tapioca/gem/events"
-require "tapioca/gem/listeners"
-require "tapioca/gem/pipeline"
-require "tapioca/dsl/compiler"
-require "tapioca/dsl/pipeline"
 require "tapioca/static/requires_compiler"
+
+require "tapioca/gem"
+require "tapioca/dsl"
+require "tapioca/commands"
+require "tapioca/cli"

data/lib/tapioca/rbi_ext/model.rb

@@ -72,7 +72,7 @@ module RBI
       ).void
     end
     def create_type_variable(name, type:, variance: :invariant, fixed: nil, upper: nil, lower: nil)
-      value = Tapioca::TypeVariableHelper.serialize_type_variable(type, variance, fixed, upper, lower)
+      value = Tapioca::RBIHelper.serialize_type_variable(type, variance, fixed, upper, lower)
       create_node(RBI::TypeMember.new(name, value))
     end
 
@@ -86,7 +86,7 @@ module RBI
       ).void
     end
     def create_method(name, parameters: [], return_type: "T.untyped", class_method: false, visibility: RBI::Public.new)
-      return unless valid_method_name?(name)
+      return unless Tapioca::RBIHelper.valid_method_name?(name)
 
       sig = RBI::Sig.new(return_type: return_type)
       method = RBI::Method.new(name, sigs: [sig], is_singleton: class_method, visibility: visibility)
@@ -99,19 +99,6 @@ module RBI
 
     private
 
-    SPECIAL_METHOD_NAMES = T.let(
-      ["!", "~", "+@", "**", "-@", "*", "/", "%", "+", "-", "<<", ">>", "&", "|", "^", "<", "<=", "=>", ">", ">=",
-       "==", "===", "!=", "=~", "!~", "<=>", "[]", "[]=", "`",].freeze,
-      T::Array[String]
-    )
-
-    sig { params(name: String).returns(T::Boolean) }
-    def valid_method_name?(name)
-      return true if SPECIAL_METHOD_NAMES.include?(name)
-
-      !!name.match(/^[a-zA-Z_][[:word:]]*[?!=]?$/)
-    end
-
     sig { returns(T::Hash[String, RBI::Node]) }
     def nodes_cache
       T.must(@nodes_cache ||= T.let({}, T.nilable(T::Hash[String, Node])))

data/lib/tapioca/runtime/dynamic_mixin_compiler.rb

@@ -35,22 +35,24 @@ module Tapioca
             # before the actual include
             before = singleton_class.ancestors
             # Call the actual `include` method with the supplied module
-            super(mod).tap do
-              # Take a snapshot of the list of singleton class ancestors
-              # after the actual include
-              after = singleton_class.ancestors
-              # The difference is the modules that are added to the list
-              # of ancestors of the singleton class. Those are all the
-              # modules that were `extend`ed due to the `include` call.
-              #
-              # We record those modules on our lookup table keyed by
-              # the included module with the values being all the modules
-              # that that module pulls into the singleton class.
-              #
-              # We need to reverse the order, since the extend order should
-              # be the inverse of the ancestor order. That is, earlier
-              # extended modules would be later in the ancestor chain.
-              mixins_from_modules[mod] = (after - before).reverse!
+            ::Tapioca::Runtime::Trackers::Mixin.with_disabled_registration do
+              super(mod).tap do
+                # Take a snapshot of the list of singleton class ancestors
+                # after the actual include
+                after = singleton_class.ancestors
+                # The difference is the modules that are added to the list
+                # of ancestors of the singleton class. Those are all the
+                # modules that were `extend`ed due to the `include` call.
+                #
+                # We record those modules on our lookup table keyed by
+                # the included module with the values being all the modules
+                # that that module pulls into the singleton class.
+                #
+                # We need to reverse the order, since the extend order should
+                # be the inverse of the ancestor order. That is, earlier
+                # extended modules would be later in the ancestor chain.
+                mixins_from_modules[mod] = (after - before).reverse!
+              end
             end
           rescue Exception # rubocop:disable Lint/RescueException
             # this is a best effort, bail if we can't perform this

data/lib/tapioca/runtime/reflection.rb

@@ -20,6 +20,8 @@ module Tapioca
       PRIVATE_INSTANCE_METHODS_METHOD = T.let(Module.instance_method(:private_instance_methods), UnboundMethod)
       METHOD_METHOD = T.let(Kernel.instance_method(:method), UnboundMethod)
 
+      REQUIRED_FROM_LABELS = T.let(["<top (required)>", "<main>"].freeze, T::Array[String])
+
       sig do
         params(
           symbol: String,
@@ -152,6 +154,31 @@ module Tapioca
 
         T.unsafe(result)
       end
+
+      # Examines the call stack to identify the closest location where a "require" is performed
+      # by searching for the label "<top (required)>". If none is found, it returns the location
+      # labeled "<main>", which is the original call site.
+      sig { returns(String) }
+      def required_from_location
+        locations = Kernel.caller_locations
+        return "" unless locations
+
+        required_location = locations.find { |loc| REQUIRED_FROM_LABELS.include?(loc.label) }
+        return "" unless required_location
+
+        required_location.absolute_path || ""
+      end
+
+      sig { params(constant: Module).returns(T.nilable(String)) }
+      def constant_name_from_singleton_class(constant)
+        constant.to_s.match("#<Class:(.+)>")&.captures&.first
+      end
+
+      sig { params(constant: Module).returns(T.nilable(BasicObject)) }
+      def constant_from_singleton_class(constant)
+        constant_name = constant_name_from_singleton_class(constant)
+        constantize(constant_name) if constant_name
+      end
     end
   end
 end

data/lib/tapioca/runtime/trackers/constant_definition.rb

@@ -1,8 +1,6 @@
 # typed: true
 # frozen_string_literal: true
 
-require "set"
-
 module Tapioca
   module Runtime
     module Trackers
@@ -12,6 +10,12 @@ module Tapioca
       # available in the ruby runtime without extra accounting.
       module ConstantDefinition
         extend Reflection
+        extend T::Sig
+
+        class ConstantLocation < T::Struct
+          const :lineno, Integer
+          const :path, String
+        end
 
         @class_files = {}
 
@@ -20,13 +24,19 @@ module Tapioca
           unless tp.self.singleton_class?
             key = name_of(tp.self)
             file = tp.path
+            lineno = tp.lineno
+
             if file == "(eval)"
-              file = T.must(caller_locations)
+              caller_location = T.must(caller_locations)
                 .drop_while { |loc| loc.path == "(eval)" }
-                .first&.path
+                .first
+
+              file = caller_location&.path
+              lineno = caller_location&.lineno
             end
+
             @class_files[key] ||= Set.new
-            @class_files[key] << file
+            @class_files[key] << ConstantLocation.new(path: T.must(file), lineno: T.must(lineno))
           end
         end
 
@@ -35,8 +45,8 @@ module Tapioca
         # or where metaprogramming was used via +eval+, etc.
         def self.files_for(klass)
           name = String === klass ? klass : name_of(klass)
-          files = @class_files[name]
-          files || Set.new
+          files = @class_files.fetch(name, [])
+          files.map(&:path).to_set
         end
       end
     end

data/lib/tapioca/runtime/trackers/mixin.rb

@@ -7,7 +7,9 @@ module Tapioca
       module Mixin
         extend T::Sig
 
-        @mixin_map = {}.compare_by_identity
+        @constants_to_mixin_locations = {}.compare_by_identity
+        @mixins_to_constants = {}.compare_by_identity
+        @enabled = true
 
         class Type < T::Enum
           enums do
@@ -17,24 +19,38 @@ module Tapioca
           end
         end
 
+        sig do
+          type_parameters(:Result)
+            .params(block: T.proc.returns(T.type_parameter(:Result)))
+            .returns(T.type_parameter(:Result))
+        end
+        def self.with_disabled_registration(&block)
+          @enabled = false
+
+          block.call
+        ensure
+          @enabled = true
+        end
+
         sig do
           params(
             constant: Module,
-            mod: Module,
+            mixin: Module,
             mixin_type: Type,
-            locations: T.nilable(T::Array[Thread::Backtrace::Location])
           ).void
         end
-        def self.register(constant, mod, mixin_type, locations)
-          locations ||= []
-          locations.map!(&:absolute_path).uniq!
-          locs = mixin_locations_for(constant)
-          locs.fetch(mixin_type).store(mod, T.cast(locations, T::Array[String]))
+        def self.register(constant, mixin, mixin_type)
+          return unless @enabled
+
+          location = Reflection.required_from_location
+
+          constants = constants_with_mixin(mixin)
+          constants.fetch(mixin_type).store(constant, location)
         end
 
-        sig { params(constant: Module).returns(T::Hash[Type, T::Hash[Module, T::Array[String]]]) }
-        def self.mixin_locations_for(constant)
-          @mixin_map[constant] ||= {
+        sig { params(mixin: Module).returns(T::Hash[Type, T::Hash[Module, String]]) }
+        def self.constants_with_mixin(mixin)
+          @mixins_to_constants[mixin] ||= {
             Type::Prepend => {}.compare_by_identity,
             Type::Include => {}.compare_by_identity,
             Type::Extend => {}.compare_by_identity,
@@ -52,8 +68,10 @@ class Module
         constant,
         self,
         Tapioca::Runtime::Trackers::Mixin::Type::Prepend,
-        caller_locations
       )
+
+      register_extend_on_attached_class(constant) if constant.singleton_class?
+
       super
     end
 
@@ -62,8 +80,10 @@ class Module
         constant,
         self,
         Tapioca::Runtime::Trackers::Mixin::Type::Include,
-        caller_locations
       )
+
+      register_extend_on_attached_class(constant) if constant.singleton_class?
+
       super
     end
 
@@ -72,9 +92,24 @@ class Module
         obj,
         self,
         Tapioca::Runtime::Trackers::Mixin::Type::Extend,
-        caller_locations
       ) if Module === obj
       super
     end
+
+    private
+
+    # Including or prepending on a singleton class is functionally equivalent to extending the
+    # attached class. Registering the mixin as an extend on the attached class ensures that
+    # this mixin can be found whether searching for an include/prepend on the singleton class
+    # or an extend on the attached class.
+    def register_extend_on_attached_class(constant)
+      attached_class = Tapioca::Runtime::Reflection.constant_from_singleton_class(constant)
+
+      Tapioca::Runtime::Trackers::Mixin.register(
+        T.cast(attached_class, Module),
+        self,
+        Tapioca::Runtime::Trackers::Mixin::Type::Extend,
+      ) if attached_class
+    end
   end)
 end

data/lib/tapioca/sorbet_ext/generic_name_patch.rb

@@ -1,9 +1,6 @@
 # typed: true
 # frozen_string_literal: true
 
-require "tapioca/sorbet_ext/name_patch"
-require "tapioca/helpers/sorbet_helper"
-
 module T
   module Generic
     # This module intercepts calls to generic type instantiations and type variable definitions.
@@ -174,7 +171,7 @@ module Tapioca
       lower = bounds[:lower].to_s if bounds.key?(:lower)
       upper = bounds[:upper].to_s if bounds.key?(:upper)
 
-      TypeVariableHelper.serialize_type_variable(
+      RBIHelper.serialize_type_variable(
         @type.serialize,
         @variance,
         fixed,

data/lib/tapioca/static/requires_compiler.rb

@@ -1,8 +1,6 @@
 # typed: strict
 # frozen_string_literal: true
 
-require "spoom"
-
 module Tapioca
   module Static
     class RequiresCompiler

data/lib/tapioca/static/symbol_loader.rb

@@ -1,9 +1,6 @@
 # typed: strict
 # frozen_string_literal: true
 
-require "json"
-require "tempfile"
-
 module Tapioca
   module Static
     module SymbolLoader
@@ -22,12 +19,21 @@ module Tapioca
           T.must(@payload_symbols)
         end
 
-        sig { returns(T::Set[String]) }
-        def engine_symbols
-          unless @engine_symbols
-            @engine_symbols = T.let(load_engine_symbols, T.nilable(T::Set[String]))
+        sig { params(gem: Gemfile::GemSpec).returns(T::Set[String]) }
+        def engine_symbols(gem)
+          gem_engine = engines.find do |engine|
+            gem.contains_path?(engine.config.root.to_s)
+          end
+
+          return Set.new unless gem_engine
+
+          paths = gem_engine.config.eager_load_paths.flat_map do |load_path|
+            Pathname.glob("#{load_path}/**/*.rb")
           end
-          T.must(@engine_symbols)
+
+          symbols_from_paths(paths)
+        rescue
+          Set.new
         end
 
         sig { params(gem: Gemfile::GemSpec).returns(T::Set[String]) }
@@ -37,31 +43,21 @@ module Tapioca
 
         private
 
-        sig { params(input: String, table_type: String).returns(String) }
-        def symbol_table_json_from(input, table_type: "symbol-table-json")
-          sorbet("--no-config", "--quiet", "--print=#{table_type}", input).out
-        end
-
-        sig { returns(T::Set[String]) }
-        def load_engine_symbols
-          return Set.new unless Object.const_defined?("Rails::Engine")
-
-          engine = descendants_of(Object.const_get("Rails::Engine"))
-            .reject(&:abstract_railtie?)
-            .find do |klass|
-              name = name_of(klass)
-              !name.nil? && payload_symbols.include?(name)
-            end
+        sig { returns(T::Array[T.class_of(Rails::Engine)]) }
+        def engines
+          @engines = T.let(@engines, T.nilable(T::Array[T.class_of(Rails::Engine)]))
 
-          return Set.new unless engine
-
-          paths = engine.config.eager_load_paths.flat_map do |load_path|
-            Pathname.glob("#{load_path}/**/*.rb")
+          @engines ||= if Object.const_defined?("Rails::Engine")
+            descendants_of(Object.const_get("Rails::Engine"))
+              .reject(&:abstract_railtie?)
+          else
+            []
           end
+        end
 
-          symbols_from_paths(paths)
-        rescue
-          Set.new
+        sig { params(input: String, table_type: String).returns(String) }
+        def symbol_table_json_from(input, table_type: "symbol-table-json")
+          sorbet("--no-config", "--quiet", "--print=#{table_type}", input).out
         end
 
         sig { params(paths: T::Array[Pathname]).returns(T::Set[String]) }

data/lib/tapioca/static/symbol_table_parser.rb

@@ -1,9 +1,6 @@
 # typed: strict
 # frozen_string_literal: true
 
-require "json"
-require "tempfile"
-
 module Tapioca
   module Static
     class SymbolTableParser

data/lib/tapioca/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Tapioca
-  VERSION = "0.8.3"
+  VERSION = "0.9.0"
 end

data/lib/tapioca.rb

@@ -43,6 +43,9 @@ module Tapioca
     "activesupport" => "false",
   }.freeze, T::Hash[String, String])
 
+  DEFAULT_RBI_MAX_LINE_LENGTH = 120
+  DEFAULT_ENVIRONMENT = "development"
+
   CENTRAL_REPO_ROOT_URI = "https://raw.githubusercontent.com/Shopify/rbi-central/main"
   CENTRAL_REPO_INDEX_PATH = "index.json"
   CENTRAL_REPO_ANNOTATIONS_DIR = "rbi/annotations"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tapioca
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.9.0
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-06-28 00:00:00.000000000 Z
+date: 2022-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -27,6 +27,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.17.3
+- !ruby/object:Gem::Dependency
+  name: netrc
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.11.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
@@ -153,10 +167,11 @@ files:
 - lib/tapioca/cli.rb
 - lib/tapioca/commands.rb
 - lib/tapioca/commands/annotations.rb
+- lib/tapioca/commands/check_shims.rb
 - lib/tapioca/commands/command.rb
+- lib/tapioca/commands/configure.rb
 - lib/tapioca/commands/dsl.rb
 - lib/tapioca/commands/gem.rb
-- lib/tapioca/commands/init.rb
 - lib/tapioca/commands/require.rb
 - lib/tapioca/commands/todo.rb
 - lib/tapioca/dsl.rb
@@ -192,13 +207,14 @@ files:
 - lib/tapioca/dsl/extensions/frozen_record.rb
 - lib/tapioca/dsl/helpers/active_record_column_type_helper.rb
 - lib/tapioca/dsl/helpers/active_record_constants_helper.rb
-- lib/tapioca/dsl/helpers/param_helper.rb
 - lib/tapioca/dsl/pipeline.rb
 - lib/tapioca/executor.rb
+- lib/tapioca/gem.rb
 - lib/tapioca/gem/events.rb
 - lib/tapioca/gem/listeners.rb
 - lib/tapioca/gem/listeners/base.rb
 - lib/tapioca/gem/listeners/dynamic_mixins.rb
+- lib/tapioca/gem/listeners/foreign_constants.rb
 - lib/tapioca/gem/listeners/methods.rb
 - lib/tapioca/gem/listeners/mixins.rb
 - lib/tapioca/gem/listeners/remove_empty_payload_scopes.rb
@@ -214,16 +230,15 @@ files:
 - lib/tapioca/gemfile.rb
 - lib/tapioca/helpers/cli_helper.rb
 - lib/tapioca/helpers/config_helper.rb
+- lib/tapioca/helpers/env_helper.rb
 - lib/tapioca/helpers/gem_helper.rb
+- lib/tapioca/helpers/rbi_files_helper.rb
 - lib/tapioca/helpers/rbi_helper.rb
-- lib/tapioca/helpers/shims_helper.rb
-- lib/tapioca/helpers/signatures_helper.rb
 - lib/tapioca/helpers/sorbet_helper.rb
 - lib/tapioca/helpers/test/content.rb
 - lib/tapioca/helpers/test/dsl_compiler.rb
 - lib/tapioca/helpers/test/isolation.rb
 - lib/tapioca/helpers/test/template.rb
-- lib/tapioca/helpers/type_variable_helper.rb
 - lib/tapioca/internal.rb
 - lib/tapioca/rbi_ext/model.rb
 - lib/tapioca/rbi_formatter.rb

data/lib/tapioca/dsl/helpers/param_helper.rb

@@ -1,55 +0,0 @@
-# typed: strict
-# frozen_string_literal: true
-
-require "tapioca/helpers/signatures_helper"
-
-module Tapioca
-  module Dsl
-    module Helpers
-      module ParamHelper
-        extend T::Sig
-        include SignaturesHelper
-
-        sig { params(name: String, type: String).returns(RBI::TypedParam) }
-        def create_param(name, type:)
-          create_typed_param(RBI::Param.new(name), type)
-        end
-
-        sig { params(name: String, type: String, default: String).returns(RBI::TypedParam) }
-        def create_opt_param(name, type:, default:)
-          create_typed_param(RBI::OptParam.new(name, default), type)
-        end
-
-        sig { params(name: String, type: String).returns(RBI::TypedParam) }
-        def create_rest_param(name, type:)
-          create_typed_param(RBI::RestParam.new(name), type)
-        end
-
-        sig { params(name: String, type: String).returns(RBI::TypedParam) }
-        def create_kw_param(name, type:)
-          create_typed_param(RBI::KwParam.new(name), type)
-        end
-
-        sig { params(name: String, type: String, default: String).returns(RBI::TypedParam) }
-        def create_kw_opt_param(name, type:, default:)
-          create_typed_param(RBI::KwOptParam.new(name, default), type)
-        end
-
-        sig { params(name: String, type: String).returns(RBI::TypedParam) }
-        def create_kw_rest_param(name, type:)
-          create_typed_param(RBI::KwRestParam.new(name), type)
-        end
-
-        sig { params(name: String, type: String).returns(RBI::TypedParam) }
-        def create_block_param(name, type:)
-          create_typed_param(RBI::BlockParam.new(name), type)
-        end
-
-        sig { params(param: RBI::Param, type: String).returns(RBI::TypedParam) }
-        def create_typed_param(param, type)
-          RBI::TypedParam.new(param: param, type: sanitize_signature_types(type))
-        end
-      end
-    end
-  end
-end