tapioca 0.11.14 → 0.11.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52388d4c8afe40a2b6807e54bf1dd09701cb016ca1fed7ce5d3a691c3f93e0e5
-  data.tar.gz: 18550aa93626f63257b387154585dc2ae9e74c5aa17c7d4e2b82702bf5ce5b2b
+  metadata.gz: 38dec6aff4cfc2907111dda6a6ee1411d5ae7bf58f467a7e8a47094a606f7593
+  data.tar.gz: aa5c4ce427eb9e33513ef4b42f69572030c21be2ea12367abc1755fda0c76202
 SHA512:
-  metadata.gz: c0be5c5d8108519bbda67d2498ff032273ad855a45c464a5a0acf0780412e7f4d3ee706322ef287fd2882ee0083f3c3fe1ab67611a16a6f45f5aa5a7aeb1a709
-  data.tar.gz: 6a87ab2319905c976cfb0b6a004c12d613a9200269268c6c452f8f7ba9175a1b7fd29c5d32de945a04614aff1de037463ad3c0fd090f883770a7f72d7f2f1476
+  metadata.gz: 1640eb00441de0826936170a8e40010ab5bf3567329ad64e283d8cad4161a37ff16cf02cea1e41eba50816a6f315af8db69be70b65249b61b015532d86c6da05
+  data.tar.gz: 410060c7ef464f8fe07b28582cef2a86875fa80ff319051aaea31946cd96ad1e40b07c56165421e99b0d300ea19223a3f20756a520a2cb6bd9c76bf16abca230

data/lib/tapioca/dsl/compilers/action_text.rb

@@ -0,0 +1,100 @@
+# typed: strict
+# frozen_string_literal: true
+
+begin
+  require "action_text"
+rescue LoadError
+  return
+end
+
+module Tapioca
+  module Dsl
+    module Compilers
+      # `Tapioca::Dsl::Compilers::ActionText` decorates RBI files for subclasses of
+      # `ActiveRecord::Base` that declare [has_rich_text](https://edgeguides.rubyonrails.org/action_text_overview.html#creating-rich-text-content)
+      #
+      # For example, with the following `ActiveRecord::Base` subclass:
+      #
+      # ~~~rb
+      # class Post < ApplicationRecord
+      #  has_rich_text :body
+      #  has_rich_text :title, encrypted: true
+      # end
+      # ~~~
+      #
+      # this compiler will produce the RBI file `post.rbi` with the following content:
+      #
+      # ~~~rbi
+      # # typed: strong
+      #
+      # class Post
+      #  sig { returns(ActionText::RichText) }
+      #  def body; end
+      #
+      #  sig { params(value: T.nilable(T.any(ActionText::RichText, String))).returns(T.untyped) }
+      #  def body=(value); end
+      #
+      #  sig { returns(T::Boolean) }
+      #  def body?; end
+      #
+      #  sig { returns(ActionText::EncryptedRichText) }
+      #  def title; end
+      #
+      #  sig { params(value: T.nilable(T.any(ActionText::EncryptedRichText, String))).returns(T.untyped) }
+      #  def title=(value); end
+      #
+      #  sig { returns(T::Boolean) }
+      #  def title?; end
+      # end
+      # ~~~
+      class ActionText < Compiler
+        extend T::Sig
+
+        ConstantType = type_member { { fixed: T.class_of(::ActiveRecord::Base) } }
+
+        sig { override.void }
+        def decorate
+          root.create_path(constant) do |scope|
+            self.class.action_text_associations(constant).each do |name|
+              reflection = constant.reflections.fetch(name)
+              type = reflection.options.fetch(:class_name)
+              name = reflection.name.to_s.sub("rich_text_", "")
+              scope.create_method(
+                name,
+                return_type: type,
+              )
+              scope.create_method(
+                "#{name}?",
+                return_type: "T::Boolean",
+              )
+              scope.create_method(
+                "#{name}=",
+                parameters: [create_param("value", type: "T.nilable(T.any(#{type}, String))")],
+                return_type: "T.untyped",
+              )
+            end
+          end
+        end
+
+        class << self
+          extend T::Sig
+
+          sig { params(constant: T.class_of(::ActiveRecord::Base)).returns(T::Array[String]) }
+          def action_text_associations(constant)
+            # Implementation copied from https://github.com/rails/rails/blob/31052d0e518b9da103eea2f79d250242ed1e3705/actiontext/lib/action_text/attribute.rb#L66
+            constant.reflect_on_all_associations(:has_one)
+              .map(&:name).map(&:to_s)
+              .select { |n| n.start_with?("rich_text_") }
+          end
+
+          sig { override.returns(T::Enumerable[Module]) }
+          def gather_constants
+            descendants_of(::ActiveRecord::Base)
+              .reject(&:abstract_class?)
+              .select { |c| action_text_associations(c).any? }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/tapioca/dsl/compilers/active_job.rb

@@ -83,6 +83,7 @@ module Tapioca
         end
         def perform_later_parameters(parameters, constant_name)
           if ::Gem::Requirement.new(">= 7.0").satisfied_by?(::ActiveJob.gem_version)
+            parameters.reject! { |typed_param| RBI::BlockParam === typed_param.param }
             parameters + [create_block_param(
               "block",
               type: "T.nilable(T.proc.params(job: #{constant_name}).void)",

data/lib/tapioca/dsl/compilers/active_model_attributes.rb

@@ -72,9 +72,9 @@ module Tapioca
         def attribute_methods_for_constant
           patterns = if constant.respond_to?(:attribute_method_patterns)
             # https://github.com/rails/rails/pull/44367
-            T.unsafe(constant).attribute_method_patterns
+            constant.attribute_method_patterns
           else
-            constant.attribute_method_matchers
+            T.unsafe(constant).attribute_method_matchers
           end
           patterns.flat_map do |pattern|
             constant.attribute_types.filter_map do |name, value|
@@ -101,8 +101,13 @@ module Tapioca
           HANDLED_METHOD_TARGETS.include?(target.to_s)
         end
 
-        sig { params(attribute_type_value: ::ActiveModel::Type::Value).returns(::String) }
+        sig { params(attribute_type_value: T.untyped).returns(::String) }
         def type_for(attribute_type_value)
+          # This guarantees that the type will remain as T.untyped for attributes in the following form:
+          # attribute :name
+          # This is because for a generic attribute with no specified type, ActiveModel::Type::Value.new is returned
+          return "T.untyped" if attribute_type_value.instance_of?(ActiveModel::Type::Value)
+
           type = case attribute_type_value
           when ActiveModel::Type::Boolean
             "T::Boolean"
@@ -119,8 +124,7 @@ module Tapioca
           when ActiveModel::Type::String
             "::String"
           else
-            # we don't want untyped to be wrapped by T.nilable, so just return early
-            return "T.untyped"
+            attribute_type_value.class.name.to_s
           end
 
           as_nilable_type(type)

data/lib/tapioca/dsl/compilers/active_record_columns.rb

@@ -108,6 +108,11 @@ module Tapioca
         def decorate
           return unless constant.table_exists?
 
+          # We need to call this to ensure that some attribute aliases are defined, e.g.
+          # `id_value` as an alias for `id`.
+          # I think this is a regression on Rails 7.1, but we are where we are.
+          constant.define_attribute_methods
+
           root.create_path(constant) do |model|
             model.create_module(AttributeMethodsModuleName) do |mod|
               (constant.attribute_names + ["id"]).uniq.each do |attribute_name|
@@ -119,9 +124,9 @@ module Tapioca
                 column_name = column_name.to_s
                 patterns = if constant.respond_to?(:attribute_method_patterns)
                   # https://github.com/rails/rails/pull/44367
-                  T.unsafe(constant).attribute_method_patterns
+                  constant.attribute_method_patterns
                 else
-                  constant.attribute_method_matchers
+                  T.unsafe(constant).attribute_method_matchers
                 end
                 new_method_names = patterns.map { |m| m.method_name(attribute_name) }
                 old_method_names = patterns.map { |m| m.method_name(column_name) }

data/lib/tapioca/dsl/compilers/active_record_delegated_types.rb

@@ -110,11 +110,10 @@ module Tapioca
             return_type: "ActiveSupport::StringInquirer",
           )
 
-          return_type = sorbet_supports?(:generic_class) ? "T::Class[T.anything]" : "Class"
           mod.create_method(
             "#{role}_class",
             parameters: [],
-            return_type: return_type,
+            return_type: "T::Class[T.anything]",
           )
 
           mod.create_method(

data/lib/tapioca/dsl/compilers/graphql_input_object.rb

@@ -55,7 +55,10 @@ module Tapioca
           root.create_path(constant) do |input_object|
             arguments.each do |argument|
               name = argument.keyword.to_s
-              input_object.create_method(name, return_type: Helpers::GraphqlTypeHelper.type_for(argument, constant))
+              input_object.create_method(
+                name,
+                return_type: Helpers::GraphqlTypeHelper.type_for_argument(argument, constant),
+              )
             end
           end
         end

data/lib/tapioca/dsl/compilers/graphql_mutation.rb

@@ -76,7 +76,7 @@ module Tapioca
         def argument_type(argument, constant)
           return "T.untyped" unless argument
 
-          Helpers::GraphqlTypeHelper.type_for(argument, constant)
+          Helpers::GraphqlTypeHelper.type_for_argument(argument, constant)
         end
 
         class << self

data/lib/tapioca/dsl/helpers/active_record_column_type_helper.rb

@@ -85,6 +85,9 @@ module Tapioca
             "::String"
           when ActiveRecord::Type::Serialized
             serialized_column_type(column_type)
+          when defined?(ActiveRecord::Normalization::NormalizedValueType) &&
+            ActiveRecord::Normalization::NormalizedValueType
+            type_for_activerecord_value(column_type.cast_type)
           when defined?(ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Uuid) &&
             ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Uuid
             "::String"

data/lib/tapioca/dsl/helpers/graphql_type_helper.rb

@@ -15,7 +15,7 @@ module Tapioca
             constant: T.any(T.class_of(GraphQL::Schema::Mutation), T.class_of(GraphQL::Schema::InputObject)),
           ).returns(String)
         end
-        def type_for(argument, constant)
+        def type_for_argument(argument, constant)
           type = if argument.loads
             loads_type = ::GraphQL::Schema::Wrapper.new(argument.loads)
             loads_type = loads_type.to_list_type if argument.type.list?
@@ -25,6 +25,36 @@ module Tapioca
             argument.type
           end
 
+          prepare = argument.prepare
+          prepare_method = if prepare
+            if constant.respond_to?(prepare)
+              constant.method(prepare)
+            end
+          end
+
+          type_for(
+            type,
+            ignore_nilable_wrapper: has_replaceable_default?(argument),
+            prepare_method: prepare_method,
+          )
+        end
+
+        sig do
+          params(
+            type: T.any(
+              GraphQL::Schema::Wrapper,
+              T.class_of(GraphQL::Schema::Scalar),
+              T.class_of(GraphQL::Schema::Enum),
+              T.class_of(GraphQL::Schema::Union),
+              T.class_of(GraphQL::Schema::Object),
+              T.class_of(GraphQL::Schema::Interface),
+              T.class_of(GraphQL::Schema::InputObject),
+            ),
+            ignore_nilable_wrapper: T::Boolean,
+            prepare_method: T.nilable(Method),
+          ).returns(String)
+        end
+        def type_for(type, ignore_nilable_wrapper: false, prepare_method: nil)
           unwrapped_type = type.unwrap
 
           parsed_type = case unwrapped_type
@@ -65,14 +95,11 @@ module Tapioca
             "T.untyped"
           end
 
-          if argument.prepare.is_a?(Symbol) || argument.prepare.is_a?(String)
-            if constant.respond_to?(argument.prepare)
-              prepare_method = constant.method(argument.prepare)
-              prepare_signature = Runtime::Reflection.signature_of(prepare_method)
-
-              if valid_return_type?(prepare_signature&.return_type)
-                parsed_type = prepare_signature.return_type&.to_s
-              end
+          if prepare_method
+            prepare_signature = Runtime::Reflection.signature_of(prepare_method)
+            prepare_return_type = prepare_signature&.return_type
+            if valid_return_type?(prepare_return_type)
+              parsed_type = prepare_return_type&.to_s
             end
           end
 
@@ -80,7 +107,7 @@ module Tapioca
             parsed_type = "T::Array[#{parsed_type}]"
           end
 
-          unless type.non_null? || has_replaceable_default?(argument)
+          unless type.non_null? || ignore_nilable_wrapper
             parsed_type = RBIHelper.as_nilable_type(parsed_type)
           end
 

data/lib/tapioca/gem/pipeline.rb

@@ -271,9 +271,7 @@ module Tapioca
 
         klass = class_of(value)
 
-        klass_name = if klass == ObjectSpace::WeakMap
-          sorbet_supports?(:non_generic_weak_map) ? "ObjectSpace::WeakMap" : "ObjectSpace::WeakMap[T.untyped]"
-        elsif T::Generic === klass
+        klass_name = if T::Generic === klass
           generic_name_of(klass)
         else
           name_of(klass)

data/lib/tapioca/helpers/sorbet_helper.rb

@@ -24,8 +24,6 @@ module Tapioca
     FEATURE_REQUIREMENTS = T.let(
       {
         # feature_name: ::Gem::Requirement.new(">= ___"), # https://github.com/sorbet/sorbet/pull/___
-        non_generic_weak_map: ::Gem::Requirement.new(">= 0.5.10587"), # https://github.com/sorbet/sorbet/pull/6610
-        generic_class: ::Gem::Requirement.new(">= 0.5.10820"), # https://github.com/sorbet/sorbet/pull/6781
       }.freeze,
       T::Hash[Symbol, ::Gem::Requirement],
     )

data/lib/tapioca/internal.rb

@@ -32,7 +32,6 @@ require "tapioca/helpers/git_attributes"
 require "tapioca/helpers/sorbet_helper"
 require "tapioca/helpers/rbi_helper"
 require "tapioca/sorbet_ext/backcompat_patches"
-require "tapioca/sorbet_ext/fixed_hash_patch"
 require "tapioca/sorbet_ext/name_patch"
 require "tapioca/sorbet_ext/generic_name_patch"
 require "tapioca/sorbet_ext/proc_bind_patch"

data/lib/tapioca/sorbet_ext/backcompat_patches.rb

@@ -1,24 +1,6 @@
 # typed: true
 # frozen_string_literal: true
 
-unless defined?(T.anything)
-  module T
-    class << self
-      def anything
-        T.untyped
-      end
-    end
-  end
-end
+# This file contains patches to make Tapioca work with older versions of Sorbet.
 
-unless defined?(T::Class)
-  module T
-    module Class
-      class << self
-        def [](type)
-          T.untyped
-        end
-      end
-    end
-  end
-end
+# NOTE: If there is currently no need for any patches, this file will be empty.

data/lib/tapioca/sorbet_ext/generic_name_patch.rb

@@ -18,32 +18,26 @@ module T
         Tapioca::Runtime::GenericTypeRegistry.register_type(constant, types)
       end
 
-      def type_member(variance = :invariant, fixed: nil, lower: nil, upper: nil, &bounds_proc)
+      def type_member(variance = :invariant, &bounds_proc)
         # `T::Generic#type_member` just instantiates a `T::Type::TypeMember` instance and returns it.
         # We use that when registering the type member and then later return it from this method.
         Tapioca::TypeVariableModule.new(
           T.cast(self, Module),
           Tapioca::TypeVariableModule::Type::Member,
           variance,
-          fixed,
-          lower,
-          upper,
           bounds_proc,
         ).tap do |type_variable|
           Tapioca::Runtime::GenericTypeRegistry.register_type_variable(self, type_variable)
         end
       end
 
-      def type_template(variance = :invariant, fixed: nil, lower: nil, upper: nil, &bounds_proc)
+      def type_template(variance = :invariant, &bounds_proc)
         # `T::Generic#type_template` just instantiates a `T::Type::TypeTemplate` instance and returns it.
         # We use that when registering the type template and then later return it from this method.
         Tapioca::TypeVariableModule.new(
           T.cast(self, Module),
           Tapioca::TypeVariableModule::Type::Template,
           variance,
-          fixed,
-          lower,
-          upper,
           bounds_proc,
         ).tap do |type_variable|
           Tapioca::Runtime::GenericTypeRegistry.register_type_variable(self, type_variable)
@@ -57,9 +51,6 @@ module T
             T.cast(self, Module),
             Tapioca::TypeVariableModule::Type::HasAttachedClass,
             variance,
-            nil,
-            nil,
-            nil,
             bounds_proc,
           ),
         )
@@ -93,29 +84,9 @@ module T
   end
 
   module Utils
-    # This duplication is required to preserve backwards compatibility with sorbet-runtime versions prior to the
-    # introduction of the `Private` module in https://github.com/sorbet/sorbet/pull/6559.
-    if defined?(T::Utils::Private)
-      module Private
-        module PrivateCoercePatch
-          def coerce_and_check_module_types(val, check_val, check_module_type)
-            if val.is_a?(Tapioca::TypeVariableModule)
-              val.coerce_to_type_variable
-            elsif val.respond_to?(:__tapioca_override_type)
-              val.__tapioca_override_type
-            else
-              super
-            end
-          end
-        end
-
-        class << self
-          prepend(PrivateCoercePatch)
-        end
-      end
-    else
-      module CoercePatch
-        def coerce(val)
+    module Private
+      module PrivateCoercePatch
+        def coerce_and_check_module_types(val, check_val, check_module_type)
           if val.is_a?(Tapioca::TypeVariableModule)
             val.coerce_to_type_variable
           elsif val.respond_to?(:__tapioca_override_type)
@@ -127,7 +98,7 @@ module T
       end
 
       class << self
-        prepend(CoercePatch)
+        prepend(PrivateCoercePatch)
       end
     end
   end
@@ -159,35 +130,27 @@ module Tapioca
       end
     end
 
+    DEFAULT_BOUNDS_PROC = T.let(-> { {} }, T.proc.returns(T::Hash[Symbol, T.untyped]))
+
     sig { returns(Type) }
     attr_reader :type
 
-    # rubocop:disable Metrics/ParameterLists
     sig do
       params(
         context: Module,
         type: Type,
         variance: Symbol,
-        fixed: T.untyped,
-        lower: T.untyped,
-        upper: T.untyped,
         bounds_proc: T.nilable(T.proc.returns(T::Hash[Symbol, T.untyped])),
       ).void
     end
-    def initialize(context, type, variance, fixed, lower, upper, bounds_proc)
+    def initialize(context, type, variance, bounds_proc)
       @context = context
       @type = type
       @variance = variance
-      @bounds_proc = if bounds_proc
-        bounds_proc
-      else
-        build_bounds_proc(fixed, lower, upper)
-      end
+      @bounds_proc = bounds_proc || DEFAULT_BOUNDS_PROC
 
       super()
     end
-    # rubocop:enable Metrics/ParameterLists
-
     sig { returns(T.nilable(String)) }
     def name
       constant_name = super
@@ -221,19 +184,6 @@ module Tapioca
 
     private
 
-    sig do
-      params(fixed: T.untyped, lower: T.untyped, upper: T.untyped)
-        .returns(T.proc.returns(T::Hash[Symbol, T.untyped]))
-    end
-    def build_bounds_proc(fixed, lower, upper)
-      bounds = {}
-      bounds[:fixed] = fixed unless fixed.nil?
-      bounds[:lower] = lower unless lower.nil?
-      bounds[:upper] = upper unless upper.nil?
-
-      -> { bounds }
-    end
-
     sig { returns(T::Hash[Symbol, T.untyped]) }
     def bounds
       @bounds ||= @bounds_proc.call

data/lib/tapioca/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Tapioca
-  VERSION = "0.11.14"
+  VERSION = "0.11.16"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tapioca
 version: !ruby/object:Gem::Version
-  version: 0.11.14
+  version: 0.11.16
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-12-18 00:00:00.000000000 Z
+date: 2024-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -81,14 +81,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.10187
+        version: 0.5.10820
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.10187
+        version: 0.5.10820
 - !ruby/object:Gem::Dependency
   name: spoom
   requirement: !ruby/object:Gem::Requirement
@@ -173,6 +173,7 @@ files:
 - lib/tapioca/dsl/compilers/aasm.rb
 - lib/tapioca/dsl/compilers/action_controller_helpers.rb
 - lib/tapioca/dsl/compilers/action_mailer.rb
+- lib/tapioca/dsl/compilers/action_text.rb
 - lib/tapioca/dsl/compilers/active_job.rb
 - lib/tapioca/dsl/compilers/active_model_attributes.rb
 - lib/tapioca/dsl/compilers/active_model_secure_password.rb
@@ -265,7 +266,6 @@ files:
 - lib/tapioca/runtime/trackers/required_ancestor.rb
 - lib/tapioca/runtime/trackers/tracker.rb
 - lib/tapioca/sorbet_ext/backcompat_patches.rb
-- lib/tapioca/sorbet_ext/fixed_hash_patch.rb
 - lib/tapioca/sorbet_ext/generic_name_patch.rb
 - lib/tapioca/sorbet_ext/name_patch.rb
 - lib/tapioca/sorbet_ext/proc_bind_patch.rb
@@ -293,7 +293,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.22
+rubygems_version: 3.5.4
 signing_key: 
 specification_version: 4
 summary: A Ruby Interface file generator for gems, core types and the Ruby standard

data/lib/tapioca/sorbet_ext/fixed_hash_patch.rb

@@ -1,20 +0,0 @@
-# typed: true
-# frozen_string_literal: true
-
-module T
-  module Types
-    class FixedHash
-      def name
-        entries = @types.map do |(k, v)|
-          if Symbol === k && ":#{k}" == k.inspect
-            "#{k}: #{v}"
-          else
-            "#{k.inspect} => #{v}"
-          end
-        end
-
-        "{#{entries.join(", ")}}"
-      end
-    end
-  end
-end