tapioca 0.10.1 → 0.10.2

data/lib/tapioca/dsl/compilers/identity_cache.rb

@@ -66,7 +66,7 @@ module Tapioca
 
         COLLECTION_TYPE = T.let(
           ->(type) { "T::Array[::#{type}]" },
-          T.proc.params(type: T.any(Module, String)).returns(String)
+          T.proc.params(type: T.any(Module, String)).returns(String),
         )
 
         ConstantType = type_member { { fixed: T.class_of(::ActiveRecord::Base) } }
@@ -116,7 +116,7 @@ module Tapioca
         sig do
           params(
             field: T.untyped,
-            returns_collection: T::Boolean
+            returns_collection: T::Boolean,
           ).returns(String)
         end
         def type_for_field(field, returns_collection:)
@@ -134,7 +134,7 @@ module Tapioca
           params(
             field: T.untyped,
             klass: RBI::Scope,
-            returns_collection: T::Boolean
+            returns_collection: T::Boolean,
           ).void
         end
         def create_fetch_field_methods(field, klass, returns_collection:)
@@ -152,7 +152,7 @@ module Tapioca
         sig do
           params(
             field: T.untyped,
-            klass: RBI::Scope
+            klass: RBI::Scope,
           ).void
         end
         def create_fetch_by_methods(field, klass)
@@ -168,7 +168,7 @@ module Tapioca
         sig do
           params(
             field: T.untyped,
-            klass: RBI::Scope
+            klass: RBI::Scope,
           ).void
         end
         def create_index_fetch_by_methods(field, klass)
@@ -187,21 +187,21 @@ module Tapioca
               "#{name}!",
               class_method: true,
               parameters: parameters,
-              return_type: type
+              return_type: type,
             )
 
             klass.create_method(
               name,
               class_method: true,
               parameters: parameters,
-              return_type: as_nilable_type(type)
+              return_type: as_nilable_type(type),
             )
           else
             klass.create_method(
               name,
               class_method: true,
               parameters: parameters,
-              return_type: COLLECTION_TYPE.call(constant)
+              return_type: COLLECTION_TYPE.call(constant),
             )
           end
 
@@ -213,7 +213,7 @@ module Tapioca
                 create_param("index_values", type: "T::Enumerable[T.untyped]"),
                 create_kw_opt_param("includes", default: "nil", type: "T.untyped"),
               ],
-              return_type: COLLECTION_TYPE.call(constant)
+              return_type: COLLECTION_TYPE.call(constant),
             )
           end
         end
@@ -221,7 +221,7 @@ module Tapioca
         sig do
           params(
             field: T.untyped,
-            klass: RBI::Scope
+            klass: RBI::Scope,
           ).void
         end
         def create_aliased_fetch_by_methods(field, klass)
@@ -238,7 +238,7 @@ module Tapioca
             "fetch_#{suffix}",
             class_method: true,
             parameters: parameters,
-            return_type: type
+            return_type: type,
           )
 
           if length == 1
@@ -246,7 +246,7 @@ module Tapioca
               "fetch_multi_#{suffix}",
               class_method: true,
               parameters: [create_param("keys", type: "T::Enumerable[T.untyped]")],
-              return_type: COLLECTION_TYPE.call(multi_type)
+              return_type: COLLECTION_TYPE.call(multi_type),
             )
           end
         end

data/lib/tapioca/dsl/compilers/protobuf.rb

@@ -37,7 +37,7 @@ module Tapioca
       #   sig { returns(Integer) }
       #   def customer_id; end
       #
-      #   sig { params(month: Integer).returns(Integer) }
+      #   sig { params(value: Integer).returns(Integer) }
       #   def customer_id=(value); end
       #
       #   sig { returns(Integer) }
@@ -169,7 +169,7 @@ module Tapioca
 
         sig do
           params(
-            descriptor: Google::Protobuf::FieldDescriptor
+            descriptor: Google::Protobuf::FieldDescriptor,
           ).returns(String)
         end
         def type_of(descriptor)
@@ -223,7 +223,7 @@ module Tapioca
                 name: descriptor.name,
                 type: type,
                 init_type: "T.nilable(T.any(#{type}, T::Hash[#{key_type}, #{value_type}]))",
-                default: "Google::Protobuf::Map.new(#{default_args.join(", ")})"
+                default: "Google::Protobuf::Map.new(#{default_args.join(", ")})",
               )
             else
               elem_type = type_of(descriptor)
@@ -236,7 +236,7 @@ module Tapioca
                 name: descriptor.name,
                 type: type,
                 init_type: "T.nilable(T.any(#{type}, T::Array[#{elem_type}]))",
-                default: "Google::Protobuf::RepeatedField.new(#{default_args.join(", ")})"
+                default: "Google::Protobuf::RepeatedField.new(#{default_args.join(", ")})",
               )
             end
           else
@@ -248,7 +248,7 @@ module Tapioca
               name: descriptor.name,
               type: type,
               init_type: nilable_type,
-              default: "nil"
+              default: "nil",
             )
           end
         end
@@ -264,13 +264,13 @@ module Tapioca
 
           klass.create_method(
             field.name,
-            return_type: field.type
+            return_type: field.type,
           )
 
           klass.create_method(
             "#{field.name}=",
             parameters: [create_param("value", type: field.type)],
-            return_type: "void"
+            return_type: "void",
           )
 
           field
@@ -279,13 +279,13 @@ module Tapioca
         sig do
           params(
             klass: RBI::Scope,
-            desc: Google::Protobuf::OneofDescriptor
+            desc: Google::Protobuf::OneofDescriptor,
           ).void
         end
         def create_oneof_method(klass, desc)
           klass.create_method(
             desc.name,
-            return_type: "T.nilable(Symbol)"
+            return_type: "T.nilable(Symbol)",
           )
         end
       end

data/lib/tapioca/dsl/compilers/rails_generators.rb

@@ -43,7 +43,7 @@ module Tapioca
 
         BUILT_IN_MATCHER = T.let(
           /::(ActionMailbox|ActionText|ActiveRecord|Rails)::Generators/,
-          Regexp
+          Regexp,
         )
 
         ConstantType = type_member { { fixed: T.class_of(::Rails::Generators::Base) } }
@@ -86,7 +86,7 @@ module Tapioca
           klass.create_method(
             argument.name,
             parameters: [],
-            return_type: type_for(argument)
+            return_type: type_for(argument),
           )
         end
 

data/lib/tapioca/dsl/compilers/sidekiq_worker.rb

@@ -87,7 +87,7 @@ module Tapioca
           params(
             worker: RBI::Scope,
             method_name: String,
-            parameters: T::Array[RBI::TypedParam]
+            parameters: T::Array[RBI::TypedParam],
           ).void
         end
         def generate_perform_method(worker, method_name, parameters)

data/lib/tapioca/dsl/compilers/smart_properties.rb

@@ -69,7 +69,7 @@ module Tapioca
         def decorate
           properties = T.let(
             T.unsafe(constant).properties,
-            ::SmartProperties::PropertyCollection
+            ::SmartProperties::PropertyCollection,
           )
           return if properties.keys.empty?
 
@@ -103,7 +103,7 @@ module Tapioca
         sig do
           params(
             mod: RBI::Scope,
-            property: ::SmartProperties::Property
+            property: ::SmartProperties::Property,
           ).void
         end
         def generate_methods_for_property(mod, property)

data/lib/tapioca/dsl/compilers/state_machines.rb

@@ -186,7 +186,7 @@ module Tapioca
         def define_activerecord_methods(instance_module)
           instance_module.create_method(
             "changed_for_autosave?",
-            return_type: "T::Boolean"
+            return_type: "T::Boolean",
           )
         end
 
@@ -195,7 +195,7 @@ module Tapioca
           machine.states.each do |state|
             instance_module.create_method(
               "#{state.qualified_name}?",
-              return_type: "T::Boolean"
+              return_type: "T::Boolean",
             )
           end
         end
@@ -205,22 +205,22 @@ module Tapioca
           machine.events.each do |event|
             instance_module.create_method(
               "can_#{event.qualified_name}?",
-              return_type: "T::Boolean"
+              return_type: "T::Boolean",
             )
             instance_module.create_method(
               "#{event.qualified_name}_transition",
               parameters: [create_rest_param("args", type: "T.untyped")],
-              return_type: "T.nilable(::StateMachines::Transition)"
+              return_type: "T.nilable(::StateMachines::Transition)",
             )
             instance_module.create_method(
               event.qualified_name.to_s,
               parameters: [create_rest_param("args", type: "T.untyped")],
-              return_type: "T::Boolean"
+              return_type: "T::Boolean",
             )
             instance_module.create_method(
               "#{event.qualified_name}!",
               parameters: [create_rest_param("args", type: "T.untyped")],
-              return_type: "T::Boolean"
+              return_type: "T::Boolean",
             )
           end
         end
@@ -229,19 +229,19 @@ module Tapioca
           params(
             instance_module: RBI::Module,
             machine: ::StateMachines::Machine,
-            state_type: String
+            state_type: String,
           ).void
         end
         def define_state_accessor(instance_module, machine, state_type)
           attribute = machine.attribute.to_s
           instance_module.create_method(
             attribute,
-            return_type: state_type
+            return_type: state_type,
           )
           instance_module.create_method(
             "#{attribute}=",
             parameters: [create_param("value", type: state_type)],
-            return_type: state_type
+            return_type: state_type,
           )
         end
 
@@ -250,7 +250,7 @@ module Tapioca
           instance_module.create_method(
             "#{machine.name}?",
             parameters: [create_param("state", type: "T.any(String, Symbol)")],
-            return_type: "T::Boolean"
+            return_type: "T::Boolean",
           )
         end
 
@@ -264,12 +264,12 @@ module Tapioca
           instance_module.create_method(
             events_attribute,
             parameters: [create_rest_param("args", type: "T.untyped")],
-            return_type: "T::Array[T.any(String, Symbol)]"
+            return_type: "T::Array[T.any(String, Symbol)]",
           )
           instance_module.create_method(
             transitions_attribute,
             parameters: [create_rest_param("args", type: "T.untyped")],
-            return_type: "T::Array[::StateMachines::Transition]"
+            return_type: "T::Array[::StateMachines::Transition]",
           )
           instance_module.create_method(
             "fire_#{event_attribute}",
@@ -277,26 +277,26 @@ module Tapioca
               create_param("event", type: "T.any(String, Symbol)"),
               create_rest_param("args", type: "T.untyped"),
             ],
-            return_type: "T::Boolean"
+            return_type: "T::Boolean",
           )
           if machine.action
             instance_module.create_method(
               event_attribute,
-              return_type: "T.nilable(Symbol)"
+              return_type: "T.nilable(Symbol)",
             )
             instance_module.create_method(
               "#{event_attribute}=",
               parameters: [create_param("value", type: "T.any(String, Symbol)")],
-              return_type: "T.any(String, Symbol)"
+              return_type: "T.any(String, Symbol)",
             )
             instance_module.create_method(
               event_transition_attribute,
-              return_type: "T.nilable(::StateMachines::Transition)"
+              return_type: "T.nilable(::StateMachines::Transition)",
             )
             instance_module.create_method(
               "#{event_transition_attribute}=",
               parameters: [create_param("value", type: "::StateMachines::Transition")],
-              return_type: "::StateMachines::Transition"
+              return_type: "::StateMachines::Transition",
             )
           end
         end
@@ -308,7 +308,7 @@ module Tapioca
           instance_module.create_method(
             paths_attribute,
             parameters: [create_rest_param("args", type: "T.untyped")],
-            return_type: "T::Array[::StateMachines::Transition]"
+            return_type: "T::Array[::StateMachines::Transition]",
           )
         end
 
@@ -316,7 +316,7 @@ module Tapioca
           params(
             instance_module: RBI::Module,
             class_module: RBI::Module,
-            machine: ::StateMachines::Machine
+            machine: ::StateMachines::Machine,
           ).void
         end
         def define_name_helpers(instance_module, class_module, machine)
@@ -326,20 +326,20 @@ module Tapioca
           class_module.create_method(
             "human_#{name_attribute}",
             parameters: [create_param("state", type: "T.any(String, Symbol)")],
-            return_type: "String"
+            return_type: "String",
           )
           class_module.create_method(
             "human_#{event_name_attribute}",
             parameters: [create_param("event", type: "T.any(String, Symbol)")],
-            return_type: "String"
+            return_type: "String",
           )
           instance_module.create_method(
             name_attribute,
-            return_type: "T.any(String, Symbol)"
+            return_type: "T.any(String, Symbol)",
           )
           instance_module.create_method(
             "human_#{name_attribute}",
-            return_type: "String"
+            return_type: "String",
           )
         end
 
@@ -354,7 +354,7 @@ module Tapioca
               class_module.create_method(
                 method.to_s,
                 parameters: [create_rest_param("states", type: "T.any(String, Symbol)")],
-                return_type: "T.untyped"
+                return_type: "T.untyped",
               )
             end
         end

data/lib/tapioca/dsl/compilers/url_helpers.rb

@@ -154,7 +154,7 @@ module Tapioca
               mod.create_method(
                 method.to_s,
                 parameters: [create_rest_param("args", type: "T.untyped")],
-                return_type: "String"
+                return_type: "String",
               )
             end
           end

data/lib/tapioca/dsl/compilers.rb

@@ -15,7 +15,7 @@ module Tapioca
           "#{name}::", # compilers in this namespace
           "::", # compilers that need to be fully namespaced
         ],
-        T::Array[String]
+        T::Array[String],
       )
     end
   end

data/lib/tapioca/dsl/pipeline.rb

@@ -36,7 +36,7 @@ module Tapioca
       )
         @active_compilers = T.let(
           gather_active_compilers(requested_compilers, excluded_compilers),
-          T::Enumerable[T.class_of(Compiler)]
+          T::Enumerable[T.class_of(Compiler)],
         )
         @requested_constants = requested_constants
         @error_handler = error_handler
@@ -46,7 +46,7 @@ module Tapioca
 
       sig do
         type_parameters(:T).params(
-          blk: T.proc.params(constant: Module, rbi: RBI::File).returns(T.type_parameter(:T))
+          blk: T.proc.params(constant: Module, rbi: RBI::File).returns(T.type_parameter(:T)),
         ).returns(T::Array[T.type_parameter(:T)])
       end
       def run(&blk)
@@ -63,7 +63,7 @@ module Tapioca
 
         result = Executor.new(
           constants_to_process,
-          number_of_workers: @number_of_workers
+          number_of_workers: @number_of_workers,
         ).run_in_parallel do |constant|
           rbi = rbi_for_constant(constant)
           next if rbi.nil?
@@ -105,7 +105,7 @@ module Tapioca
       sig do
         params(
           requested_compilers: T::Array[T.class_of(Compiler)],
-          excluded_compilers: T::Array[T.class_of(Compiler)]
+          excluded_compilers: T::Array[T.class_of(Compiler)],
         ).returns(T::Enumerable[T.class_of(Compiler)])
       end
       def gather_active_compilers(requested_compilers, excluded_compilers)
@@ -146,6 +146,7 @@ module Tapioca
         constants_by_name
           .keys
           .map { |name| T.cast(Runtime::Reflection.constantize(name), Module) }
+          .select { |mod| Runtime::Reflection.constant_defined?(mod) }
           .to_set
       end
 

data/lib/tapioca/executor.rb

@@ -16,13 +16,13 @@ module Tapioca
       # one has at least 4 items to process
       @number_of_workers = T.let(
         number_of_workers || [Etc.nprocessors, (queue.length.to_f / MINIMUM_ITEMS_PER_WORKER).ceil].min,
-        Integer
+        Integer,
       )
     end
 
     sig do
       type_parameters(:T).params(
-        block: T.proc.params(item: T.untyped).returns(T.type_parameter(:T))
+        block: T.proc.params(item: T.untyped).returns(T.type_parameter(:T)),
       ).returns(T::Array[T.type_parameter(:T)])
     end
     def run_in_parallel(&block)

data/lib/tapioca/gem/events.rb

@@ -124,7 +124,7 @@ module Tapioca
           method: UnboundMethod,
           node: RBI::Method,
           signature: T.untyped,
-          parameters: T::Array[[Symbol, String]]
+          parameters: T::Array[[Symbol, String]],
         ).void.checked(:never)
       end
       def initialize(symbol, constant, method, node, signature, parameters) # rubocop:disable Metrics/ParameterLists

data/lib/tapioca/gem/listeners/foreign_constants.rb

@@ -24,7 +24,7 @@ module Tapioca
           # The way we identify these "foreign constants" is by asking the mixin tracker which
           # constants have mixed in the current module that we are handling. We add all the
           # constants that we discover to the pipeline to be processed.
-          Runtime::Trackers::Mixin.constants_with_mixin(mixin).each_value do |location_info|
+          Runtime::Trackers::Mixin.constants_with_mixin(mixin).each do |mixin_type, location_info|
             location_info.each do |constant, location|
               next unless mixed_in_by_gem?(location)
 
@@ -35,10 +35,11 @@ module Tapioca
               # base constant. Then, generate RBIs as if the base constant is extending the mixin,
               # which is functionally equivalent to including or prepending to the singleton class.
               if !name && constant.singleton_class?
-                attached_class = attached_class_of(constant)
+                attached_class = Runtime::Trackers::Mixin.resolve_to_attached_class(constant, mixin, mixin_type)
                 next unless attached_class
 
                 constant = attached_class
+                name = @pipeline.name_of(constant)
               end
 
               @pipeline.push_foreign_constant(name, constant) if name

data/lib/tapioca/gem/listeners/methods.rb

@@ -28,7 +28,7 @@ module Tapioca
             tree: RBI::Tree,
             module_name: String,
             mod: Module,
-            for_visibility: T::Array[Symbol]
+            for_visibility: T::Array[Symbol],
           ).void
         end
         def compile_directly_owned_methods(tree, module_name, mod, for_visibility = [:public, :protected, :private])
@@ -57,7 +57,7 @@ module Tapioca
             symbol_name: String,
             constant: Module,
             method: T.nilable(UnboundMethod),
-            visibility: RBI::Visibility
+            visibility: RBI::Visibility,
           ).void
         end
         def compile_method(tree, symbol_name, constant, method, visibility = RBI::Public.new)
@@ -112,7 +112,7 @@ module Tapioca
           rbi_method = RBI::Method.new(
             method_name,
             is_singleton: constant.singleton_class?,
-            visibility: visibility
+            visibility: visibility,
           )
 
           sanitized_parameters.each do |type, name|

data/lib/tapioca/gem/listeners/mixins.rb

@@ -36,7 +36,7 @@ module Tapioca
             tree: RBI::Tree,
             constant: Module,
             mods: T::Array[Module],
-            mixin_type: Runtime::Trackers::Mixin::Type
+            mixin_type: Runtime::Trackers::Mixin::Type,
           ).void
         end
         def add_mixins(tree, constant, mods, mixin_type)
@@ -69,15 +69,11 @@ module Tapioca
           params(
             constant: Module,
             mixin: Module,
-            mixin_type: Runtime::Trackers::Mixin::Type
+            mixin_type: Runtime::Trackers::Mixin::Type,
           ).returns(T::Boolean)
         end
         def mixed_in_by_gem?(constant, mixin, mixin_type)
-          mixin_location =
-            T.cast(
-              Runtime::Trackers::Mixin.constants_with_mixin(mixin).dig(mixin_type, constant),
-              T.nilable(String)
-            )
+          mixin_location = Runtime::Trackers::Mixin.mixin_location(mixin, mixin_type, constant)
 
           return true if mixin_location.nil?
 

data/lib/tapioca/gem/listeners/source_location.rb

@@ -61,7 +61,7 @@ module Tapioca
             gem_name: gem.name,
             gem_version: version,
             path: path.to_s,
-            line_number: line.to_s
+            line_number: line.to_s,
           )
           node.comments << RBI::Comment.new("") if node.comments.any?
           node.comments << RBI::Comment.new(uri.to_s)

data/lib/tapioca/gem/listeners/subconstants.rb

@@ -26,7 +26,7 @@ module Tapioca
             # Don't compile modules of Object because Object::Foo == Foo
             # Don't compile modules of BasicObject because BasicObject::BasicObject == BasicObject
             next if (Object == constant || BasicObject == constant) && Module === subconstant
-            next unless subconstant
+            next unless Runtime::Reflection.constant_defined?(subconstant)
 
             @pipeline.push_constant(name, subconstant)
           end

data/lib/tapioca/gem/listeners/yard_doc.rb

@@ -43,7 +43,7 @@ module Tapioca
           separator = event.constant.singleton_class? ? "." : "#"
           event.node.comments = documentation_comments(
             "#{event.symbol}#{separator}#{event.node.name}",
-            sigs: event.node.sigs
+            sigs: event.node.sigs,
           )
         end
 

data/lib/tapioca/gem/pipeline.rb

@@ -91,7 +91,7 @@ module Tapioca
           method: UnboundMethod,
           node: RBI::Method,
           signature: T.untyped,
-          parameters: T::Array[[Symbol, String]]
+          parameters: T::Array[[Symbol, String]],
         ).void.checked(:never)
       end
       def push_method(symbol, constant, method, node, signature, parameters) # rubocop:disable Metrics/ParameterLists
@@ -162,7 +162,7 @@ module Tapioca
         return if symbol_in_payload?(symbol) && !@bootstrap_symbols.include?(symbol)
 
         constant = constantize(symbol)
-        push_constant(symbol, constant) if constant
+        push_constant(symbol, constant) if Runtime::Reflection.constant_defined?(constant)
       end
 
       sig { params(event: Gem::ConstantFound).void.checked(:never) }
@@ -260,6 +260,7 @@ module Tapioca
         return if klass_name&.start_with?("T::Types::", "T::Private::")
 
         type_name = klass_name || "T.untyped"
+        type_name = "T.untyped" if type_name == "NilClass"
         node = RBI::Const.new(name, "T.let(T.unsafe(nil), #{type_name})")
         push_const(name, klass, node)
         @root << node
@@ -321,7 +322,7 @@ module Tapioca
           next unless superclass_name
 
           resolved_superclass = constantize(superclass_name)
-          next unless Module === resolved_superclass
+          next unless Module === resolved_superclass && Runtime::Reflection.constant_defined?(resolved_superclass)
           next if name_of(resolved_superclass) == constant_name
 
           # We found a suitable superclass
@@ -390,6 +391,9 @@ module Tapioca
         type_variables = Runtime::GenericTypeRegistry.lookup_type_variables(constant)
         return type_name unless type_variables
 
+        type_variables = type_variables.reject(&:fixed?)
+        return type_name if type_variables.empty?
+
         type_variable_names = type_variables.map { "T.untyped" }.join(", ")
 
         "#{type_name}[#{type_variable_names}]"