tankard 0.1.0 → 0.2.0

data/spec/tankard/request_spec.rb

@@ -1,49 +1,51 @@
 require 'spec_helper'
 
 describe Tankard::Request do
-  
-  let(:request) { Tankard::Request.new("abc123") }
 
-  describe "#get" do
+  let(:request) { Tankard::Request.new('abc123') }
 
-    context "request status is not 200 or 401" do
+  describe '#get' do
 
-      it "raises a Tankard::Error::HttpError" do
-        stub_get("test?key=abc123").to_return(status: [404, "Not Found"])
-        expect { request.get("test") }.to raise_error(Tankard::Error::HttpError)
+    context 'request status is not 200 or 401' do
+
+      it 'raises a Tankard::Error::HttpError' do
+        stub_get('test?key=abc123').to_return(status: [404, 'Not Found'])
+        expect { request.get('test') }.to raise_error(Tankard::Error::HttpError)
       end
     end
 
-    context "request status is 401" do
+    context 'request status is 401' do
 
-      it "raises a Tankard::Error::ApiKeyUnauthorized error" do
-        stub_get("test?key=abc123").to_return(status: [401, "Unauthorized"])
-        expect { request.get("test") }.to raise_error(Tankard::Error::ApiKeyUnauthorized)
+      it 'raises a Tankard::Error::ApiKeyUnauthorized error' do
+        stub_get('test?key=abc123').to_return(status: [401, 'Unauthorized'])
+        expect { request.get('test') }.to raise_error(Tankard::Error::ApiKeyUnauthorized)
       end
     end
 
-    context "request status is 200" do
+    context 'request status is 200' do
 
-      it "does not raise a Tankard::Error::HttpError" do
-        stub_get("test?key=abc123").to_return(status: 200)
-        expect { request.get("test") }.not_to raise_error(Tankard::Error::HttpError)
+      it 'does not raise a Tankard::Error::HttpError' do
+        # default status when a body is set is 200.
+        # setting it here for readability
+        stub_get('test?key=abc123').to_return(status: 200, body: '{}')
+        expect { request.get('test') }.not_to raise_error
       end
     end
 
-    context "valid json response" do
+    context 'valid json response' do
 
-      it "returns the json decoded body" do
-        stub_get("test?key=abc123").to_return(body: '{ "beer_name": "Smoked Porter" }')
-        expect(request.get("test")["beer_name"]).to eql("Smoked Porter")
+      it 'returns the json decoded body' do
+        stub_get('test?key=abc123').to_return(body: '{ "beer_name": "Smoked Porter" }')
+        expect(request.get('test')['beer_name']).to eql('Smoked Porter')
       end
     end
 
-    context "invalid json response" do
+    context 'invalid json response' do
 
-      it "raises an error" do
-        stub_get("test?key=abc123").to_return(body: '{')
-        expect { request.get("test") }.to raise_error(Tankard::Error::LoadError)
+      it 'raises an error' do
+        stub_get('test?key=abc123').to_return(body: '{')
+        expect { request.get('test') }.to raise_error(Tankard::Error::LoadError)
       end
     end
   end
-end
+end

data/spec/tankard_spec.rb

@@ -2,60 +2,62 @@ require 'spec_helper'
 
 describe Tankard do
 
-  context "when delegating to a client" do
+  context 'when delegating to a client' do
 
     before do
-      Tankard::Client.any_instance.stub(:test).and_return("testing")
+      Tankard::Client.any_instance.stub(:test).and_return('testing')
     end
 
-    it "delegates to Tankard::Client" do
-      expect(Tankard.test).to eql("testing")
+    it 'delegates to Tankard::Client' do
+      expect(Tankard.test).to eql('testing')
     end
 
-    describe ".respond_to?" do
+    describe '.respond_to?' do
 
-      it "delegates to Tankard::Client" do
+      it 'delegates to Tankard::Client' do
         expect(Tankard.respond_to?(:test)).to be_true
       end
     end
 
-    describe ".client" do
+    describe '.client' do
 
-      it "returns a Tankard::Client" do
+      it 'returns a Tankard::Client' do
         expect(Tankard.client).to be_kind_of(Tankard::Client)
       end
 
-      it "does not create a new Tankard::Client when one is already created" do
+      it 'does not create a new Tankard::Client when one is already created' do
         client = Tankard.client
         expect(Tankard.client).to eql(client)
       end
     end
   end
 
-  describe ".configuration" do
+  describe '.configuration' do
 
-    context "when invalid configuration data is provided" do
+    context 'when invalid configuration data is provided' do
 
-      it "raises a configuration error" do
-        expect {
+      it 'raises a configuration error' do
+        expected_error = expect do
           Tankard.configure do |config|
             config.api_key = 1234
           end
-        }.to raise_error(Tankard::Error::ConfigurationError)
+        end
+
+        expected_error.to raise_error(Tankard::Error::ConfigurationError)
       end
     end
 
-    context "when valid configuration data is provided" do
+    context 'when valid configuration data is provided' do
 
       before do
         Tankard.configure do |config|
-          config.api_key = "abc123"
+          config.api_key = 'abc123'
         end
       end
 
-      it "sets the api_key" do
-        expect(Tankard.instance_variable_get(:"@api_key")).to eql("abc123")
+      it 'sets the api_key' do
+        expect(Tankard.instance_variable_get(:"@api_key")).to eql('abc123')
       end
     end
   end
-end
+end

data/tankard.gemspec

@@ -4,30 +4,32 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'tankard/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "tankard"
+  spec.name          = 'tankard'
   spec.version       = Tankard::VERSION
-  spec.authors       = ["Matthew Shafer"]
-  spec.email         = ["matthewshafer@mac.com"]
-  spec.description   = %q{Connector to the BreweryDB api}
-  spec.summary       = %q{Allows easy quering to the breweryDB api}
-  spec.homepage      = "https://github.com/matthewshafer/tankard"
-  spec.license       = "MIT"
+  spec.authors       = ['Matthew Shafer']
+  spec.email         = ['matthewshafer@mac.com']
+  spec.description   = %q(Connector to the BreweryDB api)
+  spec.summary       = %q(Allows easy quering to the breweryDB api)
+  spec.homepage      = 'https://github.com/matthewshafer/tankard'
+  spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.files         = `git ls-files`.split($RS)
+  spec.executables   = spec.files.grep(/^bin\//) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(/^spec\//)
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 2.13.0"
-  spec.add_development_dependency "webmock", "~> 1.11.0"
-  spec.add_development_dependency "simplecov", "~> 0.7.1"
-  spec.add_development_dependency "coveralls", "~> 0.6.4"
-  spec.add_development_dependency "pry", "~> 0.9.12"
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '~> 2.14'
+  spec.add_development_dependency 'webmock', '~> 1.16'
+  spec.add_development_dependency 'simplecov', '~> 0.8'
+  spec.add_development_dependency 'coveralls', '~> 0.7'
+  spec.add_development_dependency 'pry', '~> 0.9.12'
+  spec.add_development_dependency 'rubysl', '~> 2.0' if RUBY_ENGINE == 'rbx'
+  spec.add_development_dependency 'json', '~> 1.8' if RUBY_ENGINE == 'rbx'
+  spec.add_development_dependency 'rubinius-coverage', '~> 2.0' if RUBY_ENGINE == 'rbx'
 
-  spec.add_dependency "atomic", "~> 1.1.0"
-  spec.add_dependency "httpclient", "~> 2.3.3"
-  spec.add_dependency "multi_json", "~> 1.7.2"
-  spec.add_dependency "hashie", "~> 2.0.3"
+  spec.add_dependency 'atomic', '~> 1.1'
+  spec.add_dependency 'httpclient', '~> 2.3'
+  spec.add_dependency 'multi_json', '~> 1.8'
+  spec.add_dependency 'hashie', '~> 2.0'
 end

metadata

@@ -1,169 +1,155 @@
 --- !ruby/object:Gem::Specification
 name: tankard
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Matthew Shafer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-15 00:00:00.000000000 Z
+date: 2014-03-29 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.0
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.0
+        version: '1.16'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.4
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.4
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.12
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.12
 - !ruby/object:Gem::Dependency
   name: atomic
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: httpclient
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.3
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.3
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.2
+        version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.2
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: '2.0'
 description: Connector to the BreweryDB api
 email:
 - matthewshafer@mac.com
@@ -171,9 +157,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -216,17 +203,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Allows easy quering to the breweryDB api