talkable-style 1.2022.0901 → 1.2023.0315

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d4830be54f45cbc4ebc8d118a840485b8e1560493b1857a45bf92ff6f8f59a3
-  data.tar.gz: d61e4577875884649403cee2f656bff3a27aefc1fe9ea20235e68bbe2adf5c86
+  metadata.gz: 6adffdc6ec5f60155f1c0932683efb56ba7639d8a88d0ce1ef880efe08f5f0f8
+  data.tar.gz: 2647eeb1d4843e2e1575def5a44451816f6756a8dbaeb777efacc2c8a44deb44
 SHA512:
-  metadata.gz: 0ed77517276b07231cb23b800be5b0c69ad13505b7fb7370b1ac0bc844ee78460cb978cc4910069f019954af4a83e0b1d8e38af63b6c4a549b2c99d05a1889ac
-  data.tar.gz: 9e6ffb56db0957794a9213da50911903ddbab41e1d446f878d5bfd9747db8265f37514967aaaeb07305822607958a520c622d9b379b86ec1c3edb9eb50ab1ba2
+  metadata.gz: cee7a77d6740c394b9ac592ead368e98402fa4c7cb7c59cc28699fbe24d4d07ec37ffd9ddaea62398898171faa5e1ae72ffda879306669fea642f221d4d5df86
+  data.tar.gz: 1a094de742f5b3adbb453b0c90e7ef84356d0b3346ecd22663baa2d7a6e68394976bf4da9712f0981ebb748f9e570d478dd795fdf5e778a7cfc9712b1c01f9e0

data/config/capybara.yml

@@ -0,0 +1,16 @@
+require: rubocop-capybara
+
+Capybara/CurrentPathExpectation:
+  Enabled: true
+Capybara/MatchStyle:
+  Enabled: true
+Capybara/NegationMatcher:
+  Enabled: true
+Capybara/SpecificActions:
+  Enabled: true
+Capybara/SpecificFinders:
+  Enabled: true
+Capybara/SpecificMatcher:
+  Enabled: true
+Capybara/VisibilityMatcher:
+  Enabled: true

data/config/lint.yml

@@ -38,6 +38,8 @@ Lint/DuplicateElsifCondition:
   Enabled: true
 Lint/DuplicateHashKey:
   Enabled: true
+Lint/DuplicateMagicComment:
+  Enabled: true
 Lint/DuplicateMethods:
   Enabled: true
 Lint/DuplicateRegexpCharacterClassElement:
@@ -226,6 +228,8 @@ Lint/UselessAssignment:
   Enabled: true
 Lint/UselessMethodDefinition:
   Enabled: true
+Lint/UselessRescue:
+  Enabled: true
 Lint/UselessRuby2Keywords:
   Enabled: true
 Lint/UselessSetterCall:

data/config/metrics.yml

@@ -1,2 +1,4 @@
 Metrics/BlockNesting:
   Enabled: true
+Metrics/CollectionLiteralLength:
+  Enabled: true

data/config/rails.yml

@@ -1,5 +1,7 @@
 require: rubocop-rails
 
+Rails/ActionControllerFlashBeforeRender:
+  Enabled: true
 Rails/ActionControllerTestCase:
   Enabled: true
 Rails/ActionFilter:
@@ -12,6 +14,8 @@ Rails/ActiveRecordOverride:
   Enabled: true
 Rails/ActiveSupportAliases:
   Enabled: true
+Rails/ActiveSupportOnLoad:
+  Enabled: true
 Rails/AddColumnIndex:
   Enabled: true
 Rails/AfterCommitOverride:
@@ -71,6 +75,8 @@ Rails/FindById:
   Enabled: true
 Rails/FindEach:
   Enabled: true
+Rails/FreezeTime:
+  Enabled: true
 Rails/HasAndBelongsToMany:
   Enabled: true
 Rails/HelperInstanceVariable:
@@ -79,6 +85,8 @@ Rails/HttpPositionalArguments:
   Enabled: true
 Rails/HttpStatus:
   Enabled: true
+Rails/IgnoredColumnsAssignment:
+  Enabled: true
 Rails/IgnoredSkipActionFilterOption:
   Enabled: true
 Rails/IndexBy:
@@ -140,6 +148,8 @@ Rails/RequestReferer:
   Enabled: true
 Rails/RequireDependency:
   Enabled: true
+Rails/ResponseParsedBody:
+  Enabled: true
 Rails/ReversibleMigration:
   Enabled: true
   Include:
@@ -152,6 +162,8 @@ Rails/ReversibleMigrationMethodDefinition:
   - db/sharded_migrate/*.rb
 Rails/RootJoinChain:
   Enabled: true
+Rails/RootPathnameMethods:
+  Enabled: true
 Rails/RootPublicPath:
   Enabled: true
 Rails/SafeNavigation:
@@ -181,6 +193,10 @@ Rails/TimeZoneAssignment:
   Enabled: true
 Rails/ToFormattedS:
   Enabled: true
+Rails/ToSWithArgument:
+  Enabled: true
+Rails/TopLevelHashWithIndifferentAccess:
+  Enabled: true
 Rails/TransactionExitStatement:
   Enabled: true
 Rails/UniqBeforePluck:
@@ -202,5 +218,7 @@ Rails/WhereEquals:
   Enabled: true
 Rails/WhereExists:
   Enabled: true
+Rails/WhereMissing:
+  Enabled: true
 Rails/WhereNot:
   Enabled: true

data/config/rspec.yml

@@ -2,6 +2,9 @@ require: rubocop-rspec
 
 RSpec:
   Language:
+    Expectations:
+      - will
+      - will_not
     Includes:
       Examples:
         - it_has_behavior
@@ -18,15 +21,13 @@ RSpec/BeNil:
   Enabled: true
 RSpec/BeforeAfterAll:
   Enabled: true
-RSpec/Capybara/CurrentPathExpectation:
-  Enabled: true
 RSpec/Capybara/FeatureMethods:
   Enabled: true
-RSpec/Capybara/SpecificMatcher:
+RSpec/ChangeByZero:
   Enabled: true
-RSpec/Capybara/VisibilityMatcher:
+RSpec/ClassCheck:
   Enabled: true
-RSpec/ChangeByZero:
+RSpec/ContainExactly:
   Enabled: true
 RSpec/ContextMethod:
   Enabled: true
@@ -43,6 +44,8 @@ RSpec/DescribedClass:
   Enabled: true
 RSpec/DescribedClassModuleWrapping:
   Enabled: true
+RSpec/DuplicatedMetadata:
+  Enabled: true
 RSpec/EmptyExampleGroup:
   Enabled: true
   Exclude:
@@ -65,10 +68,14 @@ RSpec/ExpectOutput:
   Enabled: true
 RSpec/FactoryBot/AttributeDefinedStatically:
   Enabled: true
+RSpec/FactoryBot/ConsistentParenthesesStyle:
+  Enabled: true
 RSpec/FactoryBot/CreateList:
   Enabled: true
 RSpec/FactoryBot/FactoryClassName:
   Enabled: true
+RSpec/FactoryBot/FactoryNameStyle:
+  Enabled: true
 RSpec/FactoryBot/SyntaxMethods:
   Enabled: true
 RSpec/FilePath:
@@ -82,6 +89,9 @@ RSpec/HooksBeforeExamples:
   Enabled: true
 RSpec/IdenticalEqualityAssertion:
   Enabled: true
+RSpec/ImplicitSubject:
+  Enabled: true
+  EnforcedStyle: single_statement_only
 RSpec/InstanceSpy:
   Enabled: true
 RSpec/InstanceVariable:
@@ -96,10 +106,14 @@ RSpec/LetBeforeExamples:
   Enabled: true
 RSpec/LetSetup:
   Enabled: true
+RSpec/MatchArray:
+  Enabled: true
 RSpec/MultipleDescribes:
   Enabled: true
 RSpec/MultipleSubjects:
   Enabled: true
+RSpec/NoExpectationExample:
+  Enabled: true
 RSpec/OverwritingSetup:
   Enabled: true
 RSpec/Rails/AvoidSetupHook:
@@ -108,10 +122,18 @@ RSpec/Rails/HaveHttpStatus:
   Enabled: true
 RSpec/Rails/HttpStatus:
   Enabled: true
+RSpec/Rails/InferredSpecType:
+  Enabled: true
+RSpec/Rails/MinitestAssertions:
+  Enabled: true
+RSpec/Rails/TravelAround:
+  Enabled: true
 RSpec/ReceiveCounts:
   Enabled: true
 RSpec/ReceiveNever:
   Enabled: true
+RSpec/RedundantAround:
+  Enabled: true
 RSpec/RepeatedDescription:
   Enabled: true
 RSpec/RepeatedExample:
@@ -130,6 +152,10 @@ RSpec/SharedExamples:
   Enabled: true
 RSpec/SingleArgumentMessageChain:
   Enabled: true
+RSpec/SkipBlockInsideExample:
+  Enabled: true
+RSpec/SortMetadata:
+  Enabled: true
 RSpec/StubbedMock:
   Enabled: true
 RSpec/SubjectDeclaration:

data/config/style.yml

@@ -9,6 +9,8 @@ Style/ArgumentsForwarding:
   Enabled: true
 Style/ArrayCoercion:
   Enabled: true
+Style/ArrayIntersect:
+  Enabled: true
 Style/ArrayJoin:
   Enabled: true
 Style/Attr:
@@ -56,6 +58,10 @@ Style/CombinableLoops:
   Enabled: true
 Style/CommentAnnotation:
   Enabled: true
+Style/ComparableClamp:
+  Enabled: true
+Style/ConcatArrayLiterals:
+  Enabled: true
 Style/ConditionalAssignment:
   Enabled: true
 Style/DateTime:
@@ -64,6 +70,8 @@ Style/DefWithParentheses:
   Enabled: true
 Style/Dir:
   Enabled: true
+Style/DirEmpty:
+  Enabled: true
 Style/DocumentDynamicEvalDefinition:
   Enabled: true
 Style/EachForSimpleLoop:
@@ -96,6 +104,8 @@ Style/ExponentialNotation:
   Enabled: true
 Style/FetchEnvVar:
   Enabled: true
+Style/FileEmpty:
+  Enabled: true
 Style/FileRead:
   Enabled: true
 Style/FileWrite:
@@ -137,6 +147,8 @@ Style/InfiniteLoop:
   Enabled: true
 Style/InverseMethods:
   Enabled: true
+Style/InvertibleUnlessCondition:
+  Enabled: true
 Style/KeywordParametersOrder:
   Enabled: true
 Style/LambdaCall:
@@ -149,12 +161,16 @@ Style/MapCompactWithConditionalBlock:
   Enabled: true
 Style/MapToHash:
   Enabled: true
+Style/MapToSet:
+  Enabled: true
 Style/MethodCallWithoutArgsParentheses:
   Enabled: true
 Style/MethodDefParentheses:
   Enabled: true
 Style/MinMax:
   Enabled: true
+Style/MinMaxComparison:
+  Enabled: true
 Style/MissingRespondToMissing:
   Enabled: true
 Style/MixinGrouping:
@@ -215,6 +231,8 @@ Style/OneLineConditional:
   Enabled: true
 Style/OpenStructUse:
   Enabled: true
+Style/OperatorMethodCall:
+  Enabled: true
 Style/OptionalArguments:
   Enabled: true
 Style/OptionalBooleanParameter:
@@ -243,6 +261,12 @@ Style/RedundantCondition:
   Enabled: true
 Style/RedundantConditional:
   Enabled: true
+Style/RedundantConstantBase:
+  Enabled: true
+Style/RedundantDoubleSplatHashBraces:
+  Enabled: true
+Style/RedundantEach:
+  Enabled: true
 Style/RedundantException:
   Enabled: true
 Style/RedundantFetchBlock:
@@ -251,6 +275,8 @@ Style/RedundantFileExtensionInRequire:
   Enabled: true
 Style/RedundantFreeze:
   Enabled: true
+Style/RedundantHeredocDelimiterQuotes:
+  Enabled: true
 Style/RedundantInitialize:
   Enabled: true
 Style/RedundantInterpolation:
@@ -275,6 +301,10 @@ Style/RedundantSort:
   Enabled: true
 Style/RedundantSortBy:
   Enabled: true
+Style/RedundantStringEscape:
+  Enabled: true
+Style/RequireOrder:
+  Enabled: true
 Style/RescueStandardError:
   Enabled: true
 Style/ReturnNil:

data/default.yml

@@ -5,12 +5,13 @@ AllCops:
   - tmp/**/*
   DisplayCopNames: false
   DisabledByDefault: true
-  TargetRubyVersion: 3.1
+  TargetRubyVersion: 3.2
   TargetRailsVersion: 7.0
   ActiveSupportExtensionsEnabled: true
 
 inherit_from:
   - config/bundler.yml
+  - config/capybara.yml
   - config/discourse.yml
   - config/gitlab-security.yml
   - config/graphql.yml

data/lib/talkable/style/version.rb

@@ -2,6 +2,6 @@
 
 module Talkable
   module Style
-    VERSION = "1.2022.0901"
+    VERSION = "1.2023.0315"
   end
 end

data/shared/.pronto_spell.pws

@@ -629,6 +629,7 @@ ubercart
 ukhova
 uncached
 uncomment
+unencrypted
 unicode
 unionpay
 unmapped

data/talkable-style.gemspec

@@ -25,12 +25,13 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 1.36.0"
-  spec.add_dependency "rubocop-discourse", "~> 2.5.0"
+  spec.add_dependency "rubocop", "~> 1.48.1"
+  spec.add_dependency "rubocop-capybara", "~> 2.17.1"
+  spec.add_dependency "rubocop-discourse", "~> 3.2.0"
   spec.add_dependency "rubocop-gitlab-security", "~> 0.1.1"
-  spec.add_dependency "rubocop-graphql", "~> 0.14.6"
-  spec.add_dependency "rubocop-performance", "~> 1.14.3"
-  spec.add_dependency "rubocop-rails", "~> 2.15.2"
+  spec.add_dependency "rubocop-graphql", "~> 1.0.1"
+  spec.add_dependency "rubocop-performance", "~> 1.16.0"
+  spec.add_dependency "rubocop-rails", "~> 2.18.0"
   spec.add_dependency "rubocop-rake", "~> 0.6.0"
-  spec.add_dependency "rubocop-rspec", "~> 2.12.1"
+  spec.add_dependency "rubocop-rspec", "~> 2.19.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: talkable-style
 version: !ruby/object:Gem::Version
-  version: 1.2022.0901
+  version: 1.2023.0315
 platform: ruby
 authors:
 - Talkable
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-02 00:00:00.000000000 Z
+date: 2023-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.36.0
+        version: 1.48.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.36.0
+        version: 1.48.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.17.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.17.1
 - !ruby/object:Gem::Dependency
   name: rubocop-discourse
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: rubocop-gitlab-security
   requirement: !ruby/object:Gem::Requirement
@@ -58,42 +72,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.6
+        version: 1.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.6
+        version: 1.0.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.3
+        version: 1.16.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.3
+        version: 1.16.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.15.2
+        version: 2.18.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.15.2
+        version: 2.18.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.1
+        version: 2.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.1
+        version: 2.19.0
 description:
 email:
 - dev@talkable.com
@@ -136,6 +150,7 @@ files:
 - README.md
 - Rakefile
 - config/bundler.yml
+- config/capybara.yml
 - config/discourse.yml
 - config/gitlab-security.yml
 - config/graphql.yml
@@ -178,7 +193,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.20
+rubygems_version: 3.4.8
 signing_key:
 specification_version: 4
 summary: Talkable style guides and shared style configs.