talkable-style 1.2021.0415 → 1.2021.1220

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c2a1cc505c346adb64bab3cf7abe423fdcb782a8283dec47ff57273674d390ea
-  data.tar.gz: 1c53b41a66997c91bc3f1d8f17baa3ce3e35917988eebaf359de44bd4b33c992
+  metadata.gz: 1b71d617d9ca6f3ede42a9f9e76753d384e9f59c1d2c7488a86777ec8ac400f5
+  data.tar.gz: 18150a546f5e3a57ef8707a6e1ba81147246cf002d060dcdbfb6ff38a80a6d9b
 SHA512:
-  metadata.gz: 3ea36e81da4f3c2ad262fd91934a0c2c31192a943b2024425b9caeddb980489646da786f111daed864e5a2104e36c416da253227995b900fe661363656b7a55b
-  data.tar.gz: 555896d69d6f151975a5c79c392fe19aa9b76181a3b2ebc0612df946a604a4f173d5b0c41f2014d64161a51bc6a23da337122e707fd7918b526c7ccfd52825c8
+  metadata.gz: 8b666dab2118d75ee4150cbd8f5912ad69968457b2826e85e6db8325c9bfb8408d5726997f66000841ab7de989b1e94a1d49deb94dbbeaa64f6f96d5f966e7f1
+  data.tar.gz: 6038574511d1ad6552d4d14e9bb8ed5ad3f6053a28912e1ab66bf65cfa4c068879a3108f0c45d4a0605b0cffa6be5b4ee122a77306d054cf75c0a6a157ac5c7c

data/default.yml

@@ -11,7 +11,7 @@ AllCops:
   - tmp/**/*
   DisplayCopNames: false
   DisabledByDefault: true
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.0
   TargetRailsVersion: 6.1
 RSpec:
   Language:
@@ -153,6 +153,10 @@ Lint/AmbiguousAssignment:
   Enabled: true
 Lint/AmbiguousOperator:
   Enabled: true
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: true
+Lint/AmbiguousRange:
+  Enabled: true
 Lint/AmbiguousRegexpLiteral:
   Enabled: true
 Lint/BigDecimalNew:
@@ -207,6 +211,8 @@ Lint/EmptyExpression:
   Enabled: true
 Lint/EmptyFile:
   Enabled: true
+Lint/EmptyInPattern:
+  Enabled: true
 Lint/EmptyInterpolation:
   Enabled: true
 Lint/EmptyWhen:
@@ -229,6 +235,8 @@ Lint/IdentityComparison:
   Enabled: true
 Lint/ImplicitStringConcatenation:
   Enabled: true
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Enabled: true
 Lint/IneffectiveAccessModifier:
   Enabled: true
 Lint/InheritException:
@@ -294,6 +302,8 @@ Lint/RegexpAsCondition:
   Enabled: true
 Lint/RequireParentheses:
   Enabled: true
+Lint/RequireRelativeSelfPath:
+  Enabled: true
 Lint/RescueException:
   Enabled: true
 Lint/RescueType:
@@ -361,6 +371,8 @@ Lint/UselessElseWithoutRescue:
   Enabled: true
 Lint/UselessMethodDefinition:
   Enabled: true
+Lint/UselessRuby2Keywords:
+  Enabled: true
 Lint/UselessSetterCall:
   Enabled: true
 Lint/UselessTimes:
@@ -379,6 +391,8 @@ Naming/ConstantName:
   Enabled: true
 Naming/FileName:
   Enabled: true
+Naming/InclusiveLanguage:
+  Enabled: true
 Naming/MemoizedInstanceVariableName:
   Enabled: true
 Naming/MethodName:
@@ -434,6 +448,8 @@ Performance/InefficientHashSearch:
   Enabled: true
 Performance/IoReadlines:
   Enabled: true
+Performance/MapCompact:
+  Enabled: true
 Performance/RangeInclude:
   Enabled: true
 Performance/RedundantBlockCall:
@@ -487,6 +503,8 @@ Rails/ActiveRecordOverride:
   Enabled: true
 Rails/ActiveSupportAliases:
   Enabled: true
+Rails/AddColumnIndex:
+  Enabled: true
 Rails/AfterCommitOverride:
   Enabled: true
 Rails/ApplicationController:
@@ -526,6 +544,8 @@ Rails/EnvironmentComparison:
   Enabled: true
 Rails/Exit:
   Enabled: true
+Rails/ExpandedDateRange:
+  Enabled: true
 Rails/FindBy:
   Enabled: true
 Rails/FindById:
@@ -583,6 +603,8 @@ Rails/RedundantAllowNil:
   Enabled: true
 Rails/RedundantReceiverInWithOptions:
   Enabled: true
+Rails/RedundantTravelBack:
+  Enabled: true
 Rails/ReflectionClassName:
   Enabled: true
 Rails/RelativeDateConstant:
@@ -593,8 +615,18 @@ Rails/RenderPlainText:
   Enabled: true
 Rails/RequestReferer:
   Enabled: true
+Rails/RequireDependency:
+  Enabled: true
 Rails/ReversibleMigration:
   Enabled: true
+  Include:
+  - db/migrate/*.rb
+  - db/sharded_migrate/*.rb
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: true
+  Include:
+  - db/migrate/*.rb
+  - db/sharded_migrate/*.rb
 Rails/SafeNavigation:
   Enabled: true
 Rails/SafeNavigationWithBlank:
@@ -616,6 +648,8 @@ Rails/SquishedSQLHeredocs:
   Enabled: true
 Rails/TimeZone:
   Enabled: true
+Rails/TimeZoneAssignment:
+  Enabled: true
 Rails/UniqBeforePluck:
   Enabled: true
 Rails/UniqueValidationWithoutIndex:
@@ -627,6 +661,8 @@ Rails/UnknownEnv:
   - production
   - staging
   - test
+Rails/UnusedIgnoredColumns:
+  Enabled: true
 Rails/Validation:
   Enabled: true
 Rails/WhereEquals:
@@ -678,6 +714,8 @@ RSpec/DescribedClassModuleWrapping:
   Enabled: true
 RSpec/EmptyExampleGroup:
   Enabled: true
+  Exclude:
+  - spec/requests/api_v2/**/*
 RSpec/EmptyHook:
   Enabled: true
 RSpec/EmptyLineAfterExample:
@@ -688,6 +726,8 @@ RSpec/ExampleWithoutDescription:
   Enabled: true
 RSpec/ExampleWording:
   Enabled: true
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
 RSpec/ExpectInHook:
   Enabled: true
 RSpec/ExpectOutput:
@@ -701,10 +741,14 @@ RSpec/FactoryBot/FactoryClassName:
 RSpec/FilePath:
   Enabled: true
   IgnoreMethods: true
+  Exclude:
+  - spec/requests/api_v2/**/*
 RSpec/Focus:
   Enabled: true
 RSpec/HooksBeforeExamples:
   Enabled: true
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
 RSpec/InstanceSpy:
   Enabled: true
 RSpec/InstanceVariable:
@@ -725,6 +769,8 @@ RSpec/MultipleSubjects:
   Enabled: true
 RSpec/OverwritingSetup:
   Enabled: true
+RSpec/Rails/AvoidSetupHook:
+  Enabled: true
 RSpec/Rails/HttpStatus:
   Enabled: true
 RSpec/ReceiveCounts:
@@ -751,6 +797,8 @@ RSpec/SingleArgumentMessageChain:
   Enabled: true
 RSpec/StubbedMock:
   Enabled: true
+RSpec/SubjectDeclaration:
+  Enabled: true
 RSpec/VariableDefinition:
   Enabled: true
 RSpec/VariableName:
@@ -764,6 +812,8 @@ RSpec/Yield:
 
 Security/Eval:
   Enabled: true
+Security/IoMethods:
+  Enabled: true
 Security/JSONLoad:
   Enabled: true
 Security/MarshalLoad:
@@ -782,7 +832,6 @@ Style/AndOr:
   Enabled: true
 Style/ArgumentsForwarding:
   Enabled: true
-  AllowOnlyRestArgument: false
 Style/ArrayCoercion:
   Enabled: true
 Style/ArrayJoin:
@@ -926,6 +975,8 @@ Style/ModuleFunction:
   Enabled: true
 Style/MultilineIfThen:
   Enabled: true
+Style/MultilineInPatternThen:
+  Enabled: true
 Style/MultilineMemoization:
   Enabled: true
 Style/MultilineMethodSignature:
@@ -958,12 +1009,18 @@ Style/NonNilCheck:
   Enabled: true
 Style/Not:
   Enabled: true
+Style/NumberedParameters:
+  Enabled: true
+Style/NumberedParametersLimit:
+  Enabled: true
 Style/NumericLiteralPrefix:
   Enabled: true
 Style/NumericLiterals:
   Enabled: true
 Style/OneLineConditional:
   Enabled: true
+Style/OpenStructUse:
+  Enabled: true
 Style/OptionalArguments:
   Enabled: true
 Style/OptionalBooleanParameter:
@@ -1016,6 +1073,8 @@ Style/RedundantSelf:
   Enabled: true
 Style/RedundantSelfAssignment:
   Enabled: true
+Style/RedundantSelfAssignmentBranch:
+  Enabled: true
 Style/RedundantSort:
   Enabled: true
 Style/RedundantSortBy:
@@ -1028,6 +1087,8 @@ Style/SafeNavigation:
   Enabled: true
 Style/Sample:
   Enabled: true
+Style/SelectByRegexp:
+  Enabled: true
 Style/SelfAssignment:
   Enabled: true
 Style/SignalException:
@@ -1062,6 +1123,8 @@ Style/SymbolLiteral:
   Enabled: true
 Style/SymbolProc:
   Enabled: true
+Style/TopLevelMethodDefinition:
+  Enabled: true
 Style/TrailingBodyOnClass:
   Enabled: true
 Style/TrailingBodyOnModule:

data/lib/talkable/style/version.rb

@@ -2,6 +2,6 @@
 
 module Talkable
   module Style
-    VERSION = "1.2021.0415"
+    VERSION = "1.2021.1220"
   end
 end

data/shared/.circleci/bin/pronto

@@ -0,0 +1,19 @@
+#!/usr/bin/env bash
+
+if [ -z "$CIRCLE_PULL_REQUEST" ]; then
+  echo "Not a Pull Request, skipping Pronto."
+  exit 0
+fi
+
+export PRONTO_GITHUB_SLUG="$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME"
+export PRONTO_PULL_REQUEST_ID=$(echo "$CIRCLE_PULL_REQUEST" | grep -o 'pull.*' | cut -f2- -d/)
+
+url="https://api.github.com/repos/$PRONTO_GITHUB_SLUG/pulls/$PRONTO_PULL_REQUEST_ID"
+targetBranch=$(curl -H "Authorization: token $PRONTO_GITHUB_ACCESS_TOKEN" "$url" | jq '.base.ref' | tr -d '"')
+
+mkdir ~/.ssh
+ssh-keyscan github.com >> ~/.ssh/known_hosts 2>/dev/null
+git fetch origin "$targetBranch"
+
+cp .pronto_spell.pws ~/.aspell.en.pws
+bundle exec pronto run -f github_pr_review github_status -c origin/"$targetBranch" || true

data/shared/.pronto_spell.pws

@@ -4,10 +4,14 @@ CDATA
 CNAME
 Capfile
 DATEDIFF
+DOCTYPE
 Dockerfile
+FIXME
 Gemfile
 HABTM
+Homebrew
 IPAddr
+Intellipse
 Magadan
 Pragma
 Procfile
@@ -36,9 +40,14 @@ american
 amongst
 analytics
 anonymized
+antialiased
 apollo
 areaspline
 arial
+arrowdown
+arrowleft
+arrowright
+arrowup
 ascii
 asymp
 async
@@ -59,6 +68,7 @@ babelrc
 backend
 backface
 backport
+backreference
 backtraces
 barby
 barcode
@@ -71,7 +81,8 @@ binarylogic
 binlog
 bitfield
 bitfields
-blacklist
+blocklist
+blocklisted
 blockquote
 bogdan
 bohdan
@@ -94,6 +105,7 @@ captcha
 capterra
 capybara
 carawayhome
+cashrewards
 cattr
 cdnjs
 cellpadding
@@ -145,8 +157,11 @@ datestamp
 datetime
 dayjs
 daystamp
+dbconsole
 debounce
+decrypt
 decrypted
+decrypts
 dehtiar
 demandware
 describedby
@@ -223,6 +238,7 @@ googleapis
 googleauth
 googleusercontent
 gotham
+gpgme
 gplus
 grammarly
 graphi
@@ -262,6 +278,7 @@ idiotism
 iemobile
 ifnull
 iframe
+iframes
 inline
 instafeed
 instafeedjs
@@ -275,9 +292,11 @@ itemscope
 itemtype
 iurevych
 ivars
+ivashchenko
 javascript
 jeremy
 jquery
+jshint
 jsonb
 jspdf
 julia
@@ -285,6 +304,7 @@ kaminari
 kassab
 katarina
 kateryna
+keepalive
 keepopen
 kelemen
 keydown
@@ -300,6 +320,8 @@ klaviyo
 komar
 komiko
 kryvoruchko
+kubeconfig
+kubectl
 kubernetes
 labelledby
 laquo
@@ -309,6 +331,7 @@ ldquo
 leaderboard
 lenovo
 leonid
+lilysilk
 lindman
 linecap
 linejoin
@@ -410,10 +433,12 @@ oninput
 onload
 onloadend
 onloadstart
+onmessage
 onprogress
 onreadystatechange
 onsubmit
 ontimeout
+ontouchstart
 opencart
 openssl
 opentype
@@ -449,6 +474,7 @@ preloaded
 preloading
 prepend
 preprocess
+prerendered
 presigned
 prestashop
 prettierrc
@@ -456,6 +482,7 @@ processlist
 procs
 prontolabs
 puravida
+puravidabracelets
 pustovalov
 raquo
 rbenv
@@ -481,6 +508,7 @@ rothy
 rothys
 rowspan
 rspec
+rswag
 rubocop
 rubyonrails
 rybbon
@@ -526,6 +554,8 @@ smallint
 sokoglam
 solano
 solesociety
+sonarjs
+sortablejs
 squareupsandbox
 srcset
 stacey
@@ -570,6 +600,7 @@ truetype
 truthy
 tsconfig
 tspan
+typename
 typeof
 tzinfo
 ubercart
@@ -579,12 +610,14 @@ uncomment
 unicode
 unionpay
 unmapped
+unmark
 unmount
 unordered
 unpermitted
 unpreferred
 unprefixed
 unredeem
+unrefunded
 unscope
 unselected
 unsharded
@@ -638,6 +671,7 @@ xlarge
 xlink
 xmlns
 xshop
+yermolaieva
 ymail
 youtube
 yurii

data/talkable-style.gemspec

@@ -13,6 +13,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = Gem::Requirement.new(">= 2.6.0")
 
   spec.metadata["allowed_push_host"] = "https://rubygems.org"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
@@ -24,9 +25,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 1.12.1"
-  spec.add_dependency "rubocop-performance", "~> 1.10.2"
-  spec.add_dependency "rubocop-rails", "~> 2.9.1"
-  spec.add_dependency "rubocop-rake", "~> 0.5.1"
-  spec.add_dependency "rubocop-rspec", "~> 2.2.0"
+  spec.add_dependency "rubocop", "~> 1.23.0"
+  spec.add_dependency "rubocop-performance", "~> 1.12.0"
+  spec.add_dependency "rubocop-rails", "~> 2.12.4"
+  spec.add_dependency "rubocop-rake", "~> 0.6.0"
+  spec.add_dependency "rubocop-rspec", "~> 2.6.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: talkable-style
 version: !ruby/object:Gem::Version
-  version: 1.2021.0415
+  version: 1.2021.1220
 platform: ruby
 authors:
 - Talkable
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-04-15 00:00:00.000000000 Z
+date: 2021-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,70 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.1
+        version: 1.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.1
+        version: 1.23.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.2
+        version: 1.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.2
+        version: 1.12.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.12.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.12.4
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.6.0
 description:
 email:
 - dev@talkable.com
@@ -96,6 +96,7 @@ files:
 - default.yml
 - lib/talkable/style.rb
 - lib/talkable/style/version.rb
+- shared/.circleci/bin/pronto
 - shared/.pronto_spell.pws
 - shared/.pronto_spell.yml
 - talkable-style.gemspec
@@ -103,6 +104,7 @@ homepage: https://github.com/talkable/talkable-style
 licenses: []
 metadata:
   allowed_push_host: https://rubygems.org
+  rubygems_mfa_required: 'true'
   homepage_uri: https://github.com/talkable/talkable-style
   source_code_uri: https://github.com/talkable/talkable-style
 post_install_message:
@@ -120,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.16
+rubygems_version: 3.2.33
 signing_key:
 specification_version: 4
 summary: Talkable style guides and shared style configs.