tailor 1.4.0 → 1.4.1

data/spec/functional/horizontal_spacing/braces_spec.rb

@@ -4,58 +4,58 @@ require 'tailor/configuration/style'
 
 BRACES = {}
 BRACES['single_line_hash_0_spaces_before_lbrace'] =
-  %Q{thing ={ :one => 'one' }}
+  %(thing ={ :one => 'one' })
 
 BRACES['single_line_hash_2_spaces_before_lbrace'] =
-  %Q{thing =  { :one => 'one' }}
+  %(thing =  { :one => 'one' })
 
 BRACES['single_line_hash_2_spaces_before_rbrace'] =
-  %Q{thing = { :one => 'one'  }}
+  %(thing = { :one => 'one'  })
 
 BRACES['single_line_hash_2_spaces_after_lbrace'] =
-  %Q{thing = {  :one => 'one' }}
+  %(thing = {  :one => 'one' })
 
-BRACES['two_line_hash_2_spaces_before_lbrace'] = %Q{thing1 =
-  thing2 =  { :one => 'one' }}
+BRACES['two_line_hash_2_spaces_before_lbrace'] = %(thing1 =
+  thing2 =  { :one => 'one' })
 
-BRACES['two_line_hash_2_spaces_before_rbrace'] = %Q{thing1 =
-  thing2 = { :one => 'one'  }}
+BRACES['two_line_hash_2_spaces_before_rbrace'] = %(thing1 =
+  thing2 = { :one => 'one'  })
 
 BRACES['two_line_hash_2_spaces_before_lbrace_lonely_braces'] =
-  %Q{thing1 =
+  %(thing1 =
   thing2 =  {
     :one => 'one'
-  }}
+  })
 
 BRACES['space_in_empty_hash_in_string_in_block'] =
-  %Q{[1].map { |n| { :first => "\#{n}-\#{{ }}" } }}
+  %([1].map { |n| { :first => "\#{n}-\#{{ }}" } })
 
 BRACES['single_line_block_2_spaces_before_lbrace'] =
-  %Q{1..10.times  { |n| puts n }}
+  %(1..10.times  { |n| puts n })
 
 BRACES['single_line_block_in_string_interp_2_spaces_before_lbrace'] =
-  %Q{"I did this \#{1..10.times  { |n| puts n }} times."}
+  %("I did this \#{1..10.times  { |n| puts n }} times.")
 
 BRACES['single_line_block_0_spaces_before_lbrace'] =
-  %Q{1..10.times{ |n| puts n }}
+  %(1..10.times{ |n| puts n })
 
 BRACES['two_line_braces_block_2_spaces_before_lbrace'] =
-  %Q{1..10.times  { |n|
-  puts n}}
+  %(1..10.times  { |n|
+  puts n})
 
 BRACES['two_line_braces_block_0_spaces_before_lbrace_trailing_comment'] =
-  %Q{1..10.times{ |n|    # comment
-  puts n}}
+  %(1..10.times{ |n|    # comment
+  puts n})
 
 BRACES['no_space_after_l_before_r_after_string_interp'] =
-  %Q{logger.debug "from \#{current} to \#{new_ver}", {:format => :short}}
+  %(logger.debug "from \#{current} to \#{new_ver}", {:format => :short})
 
 BRACES['no_space_before_consecutive_rbraces'] =
-  %Q{thing = { 'id' => "\#{source}", 'attributes' => { 'height' => "\#{height}"}}}
+  %(thing = { 'id' => "\#{source}", 'attributes' => { 'height' => "\#{height}"}})
 
-describe "Detection of spacing around braces" do
+describe 'Detection of spacing around braces' do
   before do
-    Tailor::Logger.stub(:log)
+    allow(Tailor::Logger).to receive(:log)
     FakeFS.activate!
     File.open(file_name, 'w') { |f| f.write contents }
     critic.check_file(file_name, style.to_hash)
@@ -65,7 +65,7 @@ describe "Detection of spacing around braces" do
     Tailor::Critic.new
   end
 
-  let(:contents) { BRACES[file_name]}
+  let(:contents) { BRACES[file_name] }
 
   let(:style) do
     style = Tailor::Configuration::Style.new
@@ -75,165 +75,165 @@ describe "Detection of spacing around braces" do
     style
   end
 
-  context "single-line Hash" do
-    context "0 spaces before lbrace" do
+  context 'single-line Hash' do
+    context '0 spaces before lbrace' do
       let!(:file_name) { 'single_line_hash_0_spaces_before_lbrace' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 7 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 7 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "2 spaces before lbrace" do
+    context '2 spaces before lbrace' do
       let!(:file_name) { 'single_line_hash_2_spaces_before_lbrace' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 9 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 9 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "2 spaces after lbrace" do
+    context '2 spaces after lbrace' do
       let!(:file_name) { 'single_line_hash_2_spaces_after_lbrace' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_after_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 9 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_after_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 9 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "2 spaces before rbrace" do
+    context '2 spaces before rbrace' do
       let!(:file_name) { 'single_line_hash_2_spaces_before_rbrace' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_rbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 25 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_rbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 25 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
   end
 
-  context "two-line Hash" do
-    context "2 spaces before lbrace" do
+  context 'two-line Hash' do
+    context '2 spaces before lbrace' do
       let!(:file_name) { 'two_line_hash_2_spaces_before_lbrace' }
-      specify { critic.problems[file_name.to_s].size.should be 1 }
-      specify { critic.problems[file_name.to_s].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name.to_s].first[:line].should be 2 }
-      specify { critic.problems[file_name.to_s].first[:column].should be 12 }
-      specify { critic.problems[file_name.to_s].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 2 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 12 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "2 spaces before rbrace" do
+    context '2 spaces before rbrace' do
       let!(:file_name) { 'two_line_hash_2_spaces_before_rbrace' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_rbrace" }
-      specify { critic.problems[file_name].first[:line].should be 2 }
-      specify { critic.problems[file_name].first[:column].should be 28 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_rbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 2 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 28 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "2 spaces before lbrace, lonely braces" do
+    context '2 spaces before lbrace, lonely braces' do
       let!(:file_name) { 'two_line_hash_2_spaces_before_lbrace_lonely_braces' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 2 }
-      specify { critic.problems[file_name].first[:column].should be 12 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 2 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 12 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
   end
 
-  context "single-line block" do
-    context "space in empty Hash" do
+  context 'single-line block' do
+    context 'space in empty Hash' do
       let!(:file_name) { 'space_in_empty_hash_in_string_in_block' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_in_empty_braces" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 36 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_in_empty_braces' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 36 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "0 spaces before lbrace" do
+    context '0 spaces before lbrace' do
       let!(:file_name) { 'single_line_block_0_spaces_before_lbrace' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 11 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 11 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "2 spaces before lbrace" do
+    context '2 spaces before lbrace' do
       let!(:file_name) { 'single_line_block_2_spaces_before_lbrace' }
-      specify { critic.problems[file_name.to_s].size.should be 1 }
-      specify { critic.problems[file_name.to_s].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name.to_s].first[:line].should be 1 }
-      specify { critic.problems[file_name.to_s].first[:column].should be 13 }
-      specify { critic.problems[file_name.to_s].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 13 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
-    context "in String interpolation, 2 spaces before lbrace" do
+    context 'in String interpolation, 2 spaces before lbrace' do
       let!(:file_name) { 'single_line_block_in_string_interp_2_spaces_before_lbrace' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 27 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 27 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
   end
 
-  context "multi-line block" do
-    context "2 spaces before lbrace" do
+  context 'multi-line block' do
+    context '2 spaces before lbrace' do
       let!(:file_name) { 'two_line_braces_block_2_spaces_before_lbrace' }
-      specify { critic.problems[file_name].size.should be 2 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 13 }
-      specify { critic.problems[file_name].first[:level].should be :error }
-      specify { critic.problems[file_name].last[:type].should == "spaces_before_rbrace" }
-      specify { critic.problems[file_name].last[:line].should be 2 }
-      specify { critic.problems[file_name].last[:column].should be 8 }
-      specify { critic.problems[file_name].last[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 2 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 13 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
+      specify { expect(critic.problems[file_name].last[:type]).to eq 'spaces_before_rbrace' }
+      specify { expect(critic.problems[file_name].last[:line]).to eq 2 }
+      specify { expect(critic.problems[file_name].last[:column]).to eq 8 }
+      specify { expect(critic.problems[file_name].last[:level]).to eq :error }
     end
 
-    context "0 spaces before lbrace, with trailing comment" do
+    context '0 spaces before lbrace, with trailing comment' do
       let!(:file_name) { 'two_line_braces_block_0_spaces_before_lbrace_trailing_comment' }
-      specify { critic.problems[file_name].size.should be 2 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_before_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 11 }
-      specify { critic.problems[file_name].first[:level].should be :error }
-      specify { critic.problems[file_name].last[:type].should == "spaces_before_rbrace" }
-      specify { critic.problems[file_name].last[:line].should be 2 }
-      specify { critic.problems[file_name].last[:column].should be 8 }
-      specify { critic.problems[file_name].last[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 2 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 11 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
+      specify { expect(critic.problems[file_name].last[:type]).to eq 'spaces_before_rbrace' }
+      specify { expect(critic.problems[file_name].last[:line]).to eq 2 }
+      specify { expect(critic.problems[file_name].last[:column]).to eq 8 }
+      specify { expect(critic.problems[file_name].last[:level]).to eq :error }
     end
   end
 
-  context "String interpolation" do
-    context "0 spaces after lbrace or before rbrace" do
+  context 'String interpolation' do
+    context '0 spaces after lbrace or before rbrace' do
       let!(:file_name) { 'no_space_after_l_before_r_after_string_interp' }
-      specify { critic.problems[file_name].size.should be 2 }
-      specify { critic.problems[file_name].first[:type].should == "spaces_after_lbrace" }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 47 }
-      specify { critic.problems[file_name].first[:level].should be :error }
-      specify { critic.problems[file_name].last[:type].should == "spaces_before_rbrace" }
-      specify { critic.problems[file_name].last[:line].should be 1 }
-      specify { critic.problems[file_name].last[:column].should be 64 }
-      specify { critic.problems[file_name].last[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 2 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_after_lbrace' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 47 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
+      specify { expect(critic.problems[file_name].last[:type]).to eq 'spaces_before_rbrace' }
+      specify { expect(critic.problems[file_name].last[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].last[:column]).to eq 64 }
+      specify { expect(critic.problems[file_name].last[:level]).to eq :error }
     end
 
-    context "no space before consecutive rbraces" do
+    context 'no space before consecutive rbraces' do
       let(:file_name) { 'no_space_before_consecutive_rbraces' }
       let(:problems) { critic.problems[file_name].select { |p| p[:type] == 'spaces_before_rbrace' } }
-      specify { problems.size.should be 2 }
-      specify { problems.first[:type].should == "spaces_before_rbrace" }
-      specify { problems.first[:line].should be 1 }
-      specify { problems.first[:column].should be 72 }
-      specify { problems.first[:level].should be :error }
-      specify { problems.last[:type].should == "spaces_before_rbrace" }
-      specify { problems.last[:line].should be 1 }
-      specify { problems.last[:column].should be 73 }
-      specify { problems.last[:level].should be :error }
+      specify { expect(problems.size).to eq 2 }
+      specify { expect(problems.first[:type]).to eq 'spaces_before_rbrace' }
+      specify { expect(problems.first[:line]).to eq 1 }
+      specify { expect(problems.first[:column]).to eq 72 }
+      specify { expect(problems.first[:level]).to eq :error }
+      specify { expect(problems.last[:type]).to eq 'spaces_before_rbrace' }
+      specify { expect(problems.last[:line]).to eq 1 }
+      specify { expect(problems.last[:column]).to eq 73 }
+      specify { expect(problems.last[:level]).to eq :error }
     end
   end
 end

data/spec/functional/horizontal_spacing/brackets_spec.rb

@@ -2,22 +2,20 @@ require 'spec_helper'
 require 'tailor/critic'
 require 'tailor/configuration/style'
 
-
 BRACKETS = {}
-BRACKETS['space_in_empty_array'] = %Q{[ ]}
-BRACKETS['simple_array_space_after_lbracket'] = %Q{[ 1, 2, 3]}
-BRACKETS['simple_array_space_before_rbracket'] = %Q{[1, 2, 3 ]}
-BRACKETS['hash_key_ref_space_before_rbracket'] = %Q{thing[:one ]}
-BRACKETS['hash_key_ref_space_after_lbracket'] = %Q{thing[ :one]}
+BRACKETS['space_in_empty_array'] = %([ ])
+BRACKETS['simple_array_space_after_lbracket'] = %([ 1, 2, 3])
+BRACKETS['simple_array_space_before_rbracket'] = %([1, 2, 3 ])
+BRACKETS['hash_key_ref_space_before_rbracket'] = %(thing[:one ])
+BRACKETS['hash_key_ref_space_after_lbracket'] = %(thing[ :one])
 BRACKETS['two_d_array_space_after_lbrackets'] =
-  %Q{[ [1, 2, 3], [ 'a', 'b', 'c']]}
+  %([ [1, 2, 3], [ 'a', 'b', 'c']])
 BRACKETS['two_d_array_space_before_rbrackets'] =
-  %Q{[[1, 2, 3 ], [ 'a', 'b', 'c'] ]}
-
+  %([[1, 2, 3 ], [ 'a', 'b', 'c'] ])
 
 describe 'Detection of spaces around brackets' do
   before do
-    Tailor::Logger.stub(:log)
+    allow(Tailor::Logger).to receive(:log)
     FakeFS.activate!
     File.open(file_name, 'w') { |f| f.write contents }
     critic.check_file(file_name, style.to_hash)
@@ -27,7 +25,7 @@ describe 'Detection of spaces around brackets' do
     Tailor::Critic.new
   end
 
-  let(:contents) { BRACKETS[file_name]}
+  let(:contents) { BRACKETS[file_name] }
 
   let(:style) do
     style = Tailor::Configuration::Style.new
@@ -40,49 +38,49 @@ describe 'Detection of spaces around brackets' do
   context 'Arrays' do
     context 'empty with space inside' do
       let(:file_name) { 'space_in_empty_array' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == 'spaces_after_lbracket' }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 1 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_after_lbracket' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
     context 'space after lbracket' do
       let(:file_name) { 'simple_array_space_after_lbracket' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == 'spaces_after_lbracket' }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 1 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_after_lbracket' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
     context 'space before rbracket' do
       let(:file_name) { 'simple_array_space_before_rbracket' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == 'spaces_before_rbracket' }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 9 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_rbracket' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 9 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
   end
 
   context 'Hash key references' do
     context 'space before rbracket' do
       let(:file_name) { 'hash_key_ref_space_before_rbracket' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == 'spaces_before_rbracket' }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 11 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_before_rbracket' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 11 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
 
     context 'space after lbracket' do
       let(:file_name) { 'hash_key_ref_space_after_lbracket' }
-      specify { critic.problems[file_name].size.should be 1 }
-      specify { critic.problems[file_name].first[:type].should == 'spaces_after_lbracket' }
-      specify { critic.problems[file_name].first[:line].should be 1 }
-      specify { critic.problems[file_name].first[:column].should be 6 }
-      specify { critic.problems[file_name].first[:level].should be :error }
+      specify { expect(critic.problems[file_name].size).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:type]).to eq 'spaces_after_lbracket' }
+      specify { expect(critic.problems[file_name].first[:line]).to eq 1 }
+      specify { expect(critic.problems[file_name].first[:column]).to eq 6 }
+      specify { expect(critic.problems[file_name].first[:level]).to eq :error }
     end
   end
 end