tailor 1.0.1 → 1.1.0

data/features/name_detection.feature

@@ -1,72 +0,0 @@
-Feature: Name detection
-  As a Ruby developer, I want to be able to detect improper class and method
-  names so that I can fix them.
-
-  Background:
-    Given my configuration file ".tailor" looks like:
-    """
-    Tailor.config do |config|
-      config.file_set do |style|
-        style.trailing_newlines 0
-      end
-    end
-    """
-
-  @method_naming @good_files
-  Scenario Outline: Method naming
-    Given <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*0/
-    And the exit status should be 0
-
-  Scenarios: Good method naming
-    | File                         |
-    | naming/ok/single_word_method |
-    | naming/ok/two_word_method    |
-
-  @method_naming @bad_files
-
-  Scenario Outline: Bad method naming
-    Given <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*<Count>/
-    And the output should match /position:  <Position>/
-    And the exit status should be 1
-
-  Scenarios: Bad method naming
-    | File                                                 | Count | Position |
-    | naming/1/one_caps_camel_case_method                  | 1     | 1:4      |
-    | naming/1/one_caps_camel_case_method_trailing_comment | 1     | 1:4      |
-
-  @class_naming @good_files
-
-  Scenario Outline: Good class naming
-    Given <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*0/
-    And the exit status should be 0
-
-  Scenarios: Good class/module naming
-    | File                         |
-    | naming/ok/single_word_class  |
-    | naming/ok/single_word_module |
-    | naming/ok/two_word_class     |
-    | naming/ok/two_word_module    |
-
-  @class_naming @bad_files
-
-  Scenario Outline: Bad class/module naming
-    Given <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*<Count>/
-    And the output should match /position:  <Position>/
-    And the exit status should be 1
-
-  Scenarios: Bad method naming
-    | File                                      | Count | Position |
-    | naming/1/one_screaming_snake_case_class   | 1     | 1:6      |
-    | naming/1/one_screaming_snake_module_class | 1     | 1:7      |
-    | naming/1/two_screaming_snake_case_class   | 1     | 1:6      |
-    | naming/1/two_screaming_snake_module_class | 1     | 1:7      |
-    
-

data/features/support/file_cases/horizontal_spacing_cases.rb

@@ -1,266 +0,0 @@
-H_SPACING_OK = {}
-H_SPACING_1 = {}
-H_SPACING_2 = {}
-
-H_SPACING_OK[:short_line_no_newline] = %Q{'#{'#' * 78}'}
-H_SPACING_OK[:short_line_newline_at_81] =
-  %Q{'#{'#' * 78}'
-}
-
-#-------------------------------------------------------------------------------
-# Hard tabs
-#-------------------------------------------------------------------------------
-H_SPACING_1[:hard_tab] =
-  %Q{def something
-\tputs "something"
-end}
-
-H_SPACING_1[:hard_tab_with_spaces] =
-  %Q{class Thing
-  def something
-\t  puts "something"
-  end
-end}
-
-# This only reports the hard tab problem (and not the indentation problem)
-# because a hard tab is counted as 1 space; here, this is 4 spaces, so it
-# looks correct to the parser.  I'm leaving this behavior, as detecting the
-# hard tab should signal the problem.  If you fix the hard tab and don't
-# fix indentation, tailor will flag you on the indentation on the next run.
-H_SPACING_1[:hard_tab_with_1_indented_space] =
-  %Q{class Thing
-  def something
-\t   puts "something"
-  end
-end}
-
-H_SPACING_2[:hard_tab_with_2_indented_spaces] =
-  %Q{class Thing
-  def something
-\t    puts "something"
-  end
-end}
-
-#-------------------------------------------------------------------------------
-# Long lines
-#-------------------------------------------------------------------------------
-H_SPACING_1[:long_line_no_newline] = %Q{'#{'#' * 79}'}
-H_SPACING_1[:long_line_newline_at_82] =%Q{'#{'#' * 79}'
-}
-
-#-------------------------------------------------------------------------------
-# Trailing whitespace
-#-------------------------------------------------------------------------------
-H_SPACING_1[:empty_line_with_spaces] = %Q{  }
-H_SPACING_1[:empty_line_with_spaces_in_method] = %Q{def thing
-  
-  puts 'something'
-end}
-
-H_SPACING_1[:trailing_spaces_on_def] = %Q{def thing 
-  puts 'something'
-end}
-
-#-------------------------------------------------------------------------------
-# Comma spacing
-#-------------------------------------------------------------------------------
-H_SPACING_1[:no_space_after_comma] = %Q{[1,2]}
-H_SPACING_1[:two_spaces_after_comma] = %Q{[1,  2]}
-H_SPACING_1[:one_space_before_comma] = %Q{[1 ,2]}
-H_SPACING_1[:two_spaces_before_comma] = %Q{[1  , 2]}
-H_SPACING_2[:two_spaces_before_comma_twice] = %Q{[1  , 2  , 3]}
-H_SPACING_2[:two_spaces_after_comma_twice] = %Q{[1,  2,  3]}
-
-H_SPACING_2[:spaces_before_with_trailing_comments] = %Q{[
-  1 ,   # Comment!
-  2 ,   # Another comment.
-}
-
-H_SPACING_OK[:space_after_comma_in_array] = %Q{[1, 2]}
-
-H_SPACING_OK[:trailing_comma] = %Q{def thing(one, two,
-  three)
-end}
-
-H_SPACING_OK[:trailing_comma_with_trailing_comment] =
-  %Q{def thing(one, two,  # Comment!
-  three)
-end}
-
-H_SPACING_OK[:no_before_comma_in_array] = %Q{[1, 2]}
-H_SPACING_OK[:line_ends_with_backslash] =
-  %Q{{ :thing => a_thing,\\
-  :thing2 => another_thing }}
-
-#-------------------------------------------------------------------------------
-# Braces
-#-------------------------------------------------------------------------------
-H_SPACING_OK[:empty_hash] = %Q{{}}
-H_SPACING_OK[:single_line_hash] = %Q{{ :one => 'one' }}
-H_SPACING_OK[:single_line_hash_lonely_braces] = %Q{{
-  :one => 'one'
-}}
-
-H_SPACING_OK[:hash_as_param_in_parens] =
-  %Q{add_headers({ content_length: new_body.length })}
-
-H_SPACING_OK[:two_line_hash] = %Q{{ :one =>
-  'one' }}
-
-H_SPACING_OK[:two_line_hash_trailing_comment] = %Q{{ :one =>    # comment
-  'one' }}
-
-H_SPACING_OK[:three_line_hash] = %Q{{ :one =>
-  'one', :two =>
-  'two' }}
-
-H_SPACING_OK[:single_line_block] = %Q{1..10.times { |n| puts number }}
-H_SPACING_OK[:multi_line_braces_block] = %Q{1..10.times { |n|
-  puts number }}
-
-H_SPACING_OK[:multi_line_qword_using_braces] = %Q{%w{
-  foo
-  bar
-  baz
-}.each do |whatevs|
-  bla
-end}
-
-H_SPACING_OK[:empty_hash_in_multi_line_statement] =
-  %Q{if true
-  {}
-end}
-
-H_SPACING_OK[:multi_line_hash_in_multi_line_statement] =
-  %Q{if true
-  options = {
-    one: 1
-  }
-end}
-
-H_SPACING_OK[:single_line_string_interp] = %Q{`\#{IFCONFIG} | grep \#{ip}`}
-H_SPACING_OK[:single_line_block_in_string_interp] =
-  %Q{"I did this \#{1..10.times { |n| n }} times."}
-
-H_SPACING_OK[:empty_hash_in_string_in_block] =
-  %Q{[1].map { |n| { :first => "\#{n}-\#{{}}" } }}
-
-H_SPACING_OK[:string_interp_with_colonop] =
-  %Q{"\#{::Rails.root}"}
-
-H_SPACING_1[:single_line_hash_2_spaces_before_lbrace] =
-  %Q{thing =  { :one => 'one' }}
-
-H_SPACING_1[:single_line_hash_2_spaces_before_rbrace] =
-  %Q{thing = { :one => 'one'  }}
-
-H_SPACING_1[:single_line_hash_2_spaces_after_lbrace] =
-  %Q{thing = {  :one => 'one' }}
-
-H_SPACING_1[:single_line_hash_0_spaces_before_lbrace] =
-  %Q{thing ={ :one => 'one' }}
-
-H_SPACING_1[:two_line_hash_2_spaces_before_lbrace] = %Q{thing1 =
-  thing2 =  { :one => 'one' }}
-
-H_SPACING_1[:two_line_hash_2_spaces_before_rbrace] = %Q{thing1 =
-  thing2 = { :one => 'one'  }}
-
-H_SPACING_1[:two_line_hash_2_spaces_before_lbrace_lonely_braces] =
-  %Q{thing1 =
-  thing2 =  {
-  :one => 'one'
-}}
-
-H_SPACING_1[:space_in_empty_hash_in_string_in_block] =
-  %Q{[1].map { |n| { :first => "\#{n}-\#{{ }}" } }}
-
-H_SPACING_1[:single_line_block_2_spaces_before_lbrace] =
-  %Q{1..10.times  { |n| puts n }}
-
-H_SPACING_1[:single_line_block_in_string_interp_2_spaces_before_lbrace] =
-  %Q{"I did this \#{1..10.times  { |n| puts n }} times."}
-
-H_SPACING_1[:single_line_block_0_spaces_before_lbrace] =
-  %Q{1..10.times{ |n| puts n }}
-
-H_SPACING_1[:two_line_braces_block_2_spaces_before_lbrace] =
-  %Q{1..10.times  { |n|
-puts n}}
-
-H_SPACING_1[:two_line_braces_block_0_spaces_before_lbrace_trailing_comment] =
-  %Q{1..10.times{ |n|    # comment
-puts n}}
-
-H_SPACING_2[:no_space_after_l_before_r_after_string_interp] =
-  %Q{logger.debug "Upgrading from \#{current_version} to \#{new_version}", {:format => :short}}
-
-H_SPACING_2[:no_space_before_consecutive_rbraces] =
-  %Q{thing = { 'id' => "\#{source}", 'attributes' => { 'height' => "\#{height}"}}}
-
-#-------------------------------------------------------------------------------
-# Brackets
-#-------------------------------------------------------------------------------
-H_SPACING_OK[:empty_array] = %Q{[]}
-H_SPACING_OK[:simple_array] = %Q{[1, 2, 3]}
-H_SPACING_OK[:two_d_array] = %Q{[[1, 2, 3], ['a', 'b', 'c']]}
-H_SPACING_OK[:hash_key_reference] = %Q{thing[:one]}
-H_SPACING_OK[:array_of_symbols] =
-  %Q{transition [:active, :reactivated] => :opened}
-H_SPACING_OK[:array_of_hashes] =
-  %Q{[ { :one => [[1, 2, 3], ['a', 'b', 'c']] },
-  { :two => [[4, 5, 6], ['d', 'e', 'f']] }]}
-
-H_SPACING_OK[:simple_array_lonely_brackets] =
-  %Q{[
-  1, 2,
-  3
-]}
-
-H_SPACING_OK[:simple_nested_array_lonely_brackets] =
-  %Q{def thing
-  [
-    1, 2,
-    3
-  ]
-end}
-
-
-H_SPACING_OK[:empty_array_in_multi_line_statement] =
-  %Q{if true
-  []
-end}
-
-H_SPACING_1[:space_in_empty_array] = %Q{[ ]}
-H_SPACING_1[:simple_array_space_after_lbracket] = %Q{[ 1, 2, 3]}
-H_SPACING_1[:simple_array_space_before_rbracket] = %Q{[1, 2, 3 ]}
-H_SPACING_1[:hash_key_ref_space_before_rbracket] = %Q{thing[:one ]}
-H_SPACING_1[:hash_key_ref_space_after_lbracket] = %Q{thing[ :one]}
-H_SPACING_2[:two_d_array_space_after_lbrackets] =
-  %Q{[ [1, 2, 3], [ 'a', 'b', 'c']]}
-H_SPACING_2[:two_d_array_space_before_rbrackets] =
-  %Q{[[1, 2, 3 ], [ 'a', 'b', 'c'] ]}
-
-#-------------------------------------------------------------------------------
-# Parens
-#-------------------------------------------------------------------------------
-H_SPACING_OK[:empty_parens] = %Q{def thing(); end}
-H_SPACING_OK[:simple_method_call] = %Q{thing(one, two)}
-H_SPACING_OK[:multi_line_method_call] = %Q{thing(one,
-  two)}
-H_SPACING_OK[:multi_line_method_call_lonely_parens] = %Q{thing(
-  one, two
-)}
-
-H_SPACING_1[:simple_method_call_space_after_lparen] = %Q{thing( one, two)}
-H_SPACING_1[:simple_method_call_space_before_rparen] = %Q{thing(one, two )}
-H_SPACING_1[:method_call_space_after_lparen_trailing_comment] =
-  %Q{thing( one, two)    # comment}
-H_SPACING_2[:method_call_space_after_lparen_before_rparen_trailing_comment] =
-  %Q{thing( one, two )    # comment}
-
-H_SPACING_1[:multi_line_method_call_space_after_lparen] = %Q{thing( one,
-  two)}
-H_SPACING_1[:multi_line_method_call_space_after_lparen_trailing_comment] =
-  %Q{thing( one,
-  two)}

data/features/support/file_cases/naming_cases.rb

@@ -1,51 +0,0 @@
-NAMING_OK = {}
-NAMING_1 = {}
-
-NAMING_OK[:single_word_method] =
-  %Q{def thing
-end}
-
-NAMING_OK[:two_word_method] =
-  %Q{def thing_one
-end}
-
-NAMING_1[:one_caps_camel_case_method] =
-  %Q{def thingOne
-end}
-
-NAMING_1[:one_caps_camel_case_method_trailing_comment] =
-  %Q{def thingOne   # comment
-end}
-
-#-------------------------------------------------------------------------------
-NAMING_OK[:single_word_class] =
-  %Q{class Thing
-end}
-
-NAMING_OK[:single_word_module] =
-  %Q{module Thing
-end}
-
-NAMING_OK[:two_word_class] =
-  %Q{class ThingOne
-end}
-
-NAMING_OK[:two_word_module] =
-  %Q{module ThingOne
-end}
-
-NAMING_1[:one_screaming_snake_case_class] =
-  %Q{class Thing_One
-end}
-
-NAMING_1[:one_screaming_snake_module_class] =
-  %Q{module Thing_One
-end}
-
-NAMING_1[:two_screaming_snake_case_class] =
-  %Q{class Thing_One_Again
-end}
-
-NAMING_1[:two_screaming_snake_module_class] =
-  %Q{module Thing_One_Again
-end}

data/features/vertical_spacing.feature

@@ -1,135 +0,0 @@
-Feature: Vertical spacing
-  As a Ruby developer
-  I want to check my Ruby files for vertical spacing
-
-  @bad_files
-  Scenario: Detect lack of newlines
-    Given a file named "not_enough_newlines.rb" with:
-    """
-    def a_method
-      puts 'hi'
-    end
-    """
-    When I run `tailor -d .`
-    Then the output should match /Total Problems.*1/
-    And the output should contain "0 trailing newlines, but should have 1"
-
-  @bad_files
-  Scenario: Detect too many newlines
-    Given a file named "too_many_newlines.rb" with:
-    """
-    def a_method
-      puts 'hi'
-    end
-
-
-    """
-    When I run `tailor -d .`
-    Then the output should match /Total Problems.*1/
-    And the output should contain "2 trailing newlines, but should have 1"
-
-  @good_files
-  Scenario: Doesn't report problem when meeting criteria
-    Given a file named "good_file.rb" with:
-    """
-    def a_method
-      puts 'hi'
-    end
-
-    """
-    When I run `tailor -d .`
-    Then the output should match /Total Problems.*0/
-
-  @multi_line @good_files
-
-  @class_length
-  Scenario Outline: Classes/modules with <= configured lines
-    Given my configuration file ".tailor" looks like:
-    """
-    Tailor.config do |config|
-      config.file_set do |style|
-        style.max_code_lines_in_class 5
-        style.trailing_newlines 0
-      end
-    end
-    """
-    And <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*0/
-    And the exit status should be 0
-
-  Scenarios:
-    | File                                        |
-    | v_spacing/ok/class_five_code_lines          |
-    | v_spacing/ok/embedded_class_five_code_lines |
-
-  @bad_files @class_length
-
-  @multi_line
-  Scenario Outline: Lines with bad spacing around parens
-    Given my configuration file ".tailor" looks like:
-    """
-    Tailor.config do |config|
-      config.file_set do |style|
-        style.max_code_lines_in_class 5
-      end
-    end
-    """
-    And <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*<Problems>/
-    And the output should match /position:  <Position>/
-    And the output should match /position:  <Position 2>/
-    And the exit status should be 1
-
-  Scenarios:
-    | File                              | Position | Position 2 | Problems |
-    | v_spacing/1/class_too_long        | 1:0      |            | 1        |
-    | v_spacing/1/parent_class_too_long | 1:0      |            | 1        |
-
-  @good_files @method_length
-
-  @multi_line
-  Scenario Outline: Methods with <= configured lines
-    Given my configuration file ".tailor" looks like:
-    """
-    Tailor.config do |config|
-      config.file_set do |style|
-        style.max_code_lines_in_method 3
-        style.trailing_newlines 0
-      end
-    end
-    """
-    And <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*0/
-    And the exit status should be 0
-
-  Scenarios:
-    | File                                      |
-    | v_spacing/ok/method_3_code_lines          |
-    | v_spacing/ok/embedded_method_3_code_lines |
-
-  @bad_files @method_length
-
-  @multi_line
-  Scenario Outline: Lines with bad spacing around parens
-    Given my configuration file ".tailor" looks like:
-    """
-    Tailor.config do |config|
-      config.file_set do |style|
-        style.max_code_lines_in_method 3
-      end
-    end
-    """
-    And <File> exists without a newline at the end
-    When I run `tailor -d -c .tailor <File>`
-    Then the output should match /Total Problems.*<Problems>/
-    And the output should match /position:  <Position>/
-    And the output should match /position:  <Position 2>/
-    And the exit status should be 1
-
-  Scenarios:
-    | File                               | Position | Position 2 | Problems |
-    | v_spacing/1/method_too_long        | 1:0      |            | 1        |
-    | v_spacing/1/parent_method_too_long | 1:0      |            | 1        |