tailor 1.0.0.alpha2 → 1.0.0

data/lib/tailor/tailorrc.erb

@@ -80,9 +80,9 @@
 #                         Default:      1
 #
 Tailor.config do |config|
-  config.formatters <%= formatters %>
-  config.file_set '<%= file_list %>' do
-    <% style.each do |rule, value| %><%= rule %> <%= value %>
+  config.formatters "<%= formatters.join(", ") %>"
+  config.file_set '<%= file_list %>' do |style|
+    <% style.each do |rule, value| %>style.<%= rule %> = <%= value %>
     <% end %>
   end
 end

data/lib/tailor/version.rb

@@ -1,3 +1,3 @@
 class Tailor
-  VERSION = '1.0.0.alpha2'
+  VERSION = '1.0.0'
 end

data/m.rb

@@ -0,0 +1,15 @@
+def report_turducken(results, performance_results)
+  stuffing[:log_files] = { "#{File.basename @logger.log_file_location}" =>
+    File.read(@logger.log_file_location).gsub(/(?<f><)(?<q>\/)?(?<w>\w)/,
+      '\k<f>!\k<q>\k<w>') }.merge remote_logs
+
+  begin
+    Stuffer.login(@config[:turducken_server], @config[:turducken_username],
+      @config[:turducken_password])
+    suite_result_url = Stuffer.stuff(stuffing)
+  rescue Errno::ECONNREFUSED
+    @logger.error "Unable to connect to Turducken server!"
+  end
+
+  suite_result_url
+end

data/spec/spec_helper.rb

@@ -6,4 +6,3 @@ SimpleCov.start
 RSpec.configure do |conf|
   conf.include FakeFS::SpecHelpers
 end
-

data/spec/tailor/cli_spec.rb

@@ -8,7 +8,7 @@ describe Tailor::CLI do
 
   let(:config) do
     double "Tailor::Configuration",
-      file_sets: nil, formatters: nil
+      file_sets: nil, formatters: nil, load!: nil
   end
 
   before do
@@ -34,7 +34,7 @@ describe Tailor::CLI do
 
   describe "#initialize" do
     let(:args) { ['last'] }
-    
+
     it "uses Options to parse the args" do
       Tailor::Configuration.stub(:new).and_return config
       Tailor::Critic.stub(:new)
@@ -52,15 +52,14 @@ describe Tailor::CLI do
 
       Tailor::CLI.new(args)
     end
-    
+
     context "options.show_config is true" do
-      
+
     end
-    
+
     context "options.show_config is false" do
-      
+
     end
-    
   end
 
   describe "#execute!" do
@@ -73,7 +72,7 @@ describe Tailor::CLI do
       subject.instance_variable_set(:@critic, critic)
       subject.instance_variable_set(:@reporter, reporter)
     end
-    
+
     after do
       Tailor::Critic.unstub(:new)
       Tailor::Reporter.unstub(:new)
@@ -87,7 +86,7 @@ describe Tailor::CLI do
       critic.stub(:critique).and_yield(problems_for_file, label)
       reporter.stub(:summary_report)
       reporter.should_receive(:file_report).with(problems_for_file, label)
-      
+
       subject.execute!
     end
   end

data/spec/tailor/composite_observable_spec.rb

@@ -0,0 +1,41 @@
+require_relative '../spec_helper'
+require 'tailor/composite_observable'
+
+
+class Tester
+  include Tailor::CompositeObservable
+end
+
+describe Tailor::CompositeObservable do
+  subject { Tester.new }
+
+  describe ".define_observer" do
+    context "observer = 'pants'" do
+      before { Tailor::CompositeObservable.define_observer 'pants' }
+
+      context "observer responds to #pants_update" do
+        it "defines an instance method 'add_pants_observer' that takes 1 arg" do
+          observer = double "Observer", respond_to?: true
+          subject.add_pants_observer(observer)
+        end
+      end
+
+      context "observer does not respond to #pants_update" do
+        it "defines an instance method 'add_pants_observer' that takes 1 arg" do
+          observer = double "Observer", respond_to?: false
+          expect { subject.add_pants_observer(observer) }.
+            to raise_error NoMethodError
+        end
+      end
+
+      it "defines an instance method #notify_pants_observers" do
+        expect { subject.notify_pants_observers }.
+          to_not raise_error
+      end
+
+      it "defines an instance method #pants_changed" do
+        expect { subject.pants_changed }.to_not raise_error
+      end
+    end
+  end
+end

data/spec/tailor/configuration/style_spec.rb

@@ -0,0 +1,197 @@
+require_relative '../../spec_helper'
+require 'tailor/configuration/style'
+
+
+describe Tailor::Configuration::Style do
+  describe ".define_property" do
+    it "defines an instance method that takes 2 params" do
+      Tailor::Configuration::Style.define_property(:test_method)
+      subject.test_method(1, 2)
+    end
+
+    it "allows access to the values via #to_hash" do
+      Tailor::Configuration::Style.define_property(:test_method)
+      subject.test_method(1, level: :pants)
+      subject.to_hash.should include test_method: [1, { level: :pants }]
+    end
+  end
+
+  describe "#initialize" do
+    describe "sets up default values" do
+      describe "allow_camel_case_methods" do
+        specify do
+          subject.instance_variable_get(:@allow_camel_case_methods).should == [
+            false, { level: :error }]
+        end
+      end
+
+      describe "allow_hard_tabs" do
+        specify do
+          subject.instance_variable_get(:@allow_hard_tabs).should == [
+            false, { level: :error }]
+        end
+      end
+
+      describe "allow_screaming_snake_case_classes" do
+        specify do
+          subject.instance_variable_get(:@allow_screaming_snake_case_classes).
+            should == [false, { level: :error }]
+        end
+      end
+
+      describe "allow_trailing_line_spaces" do
+        specify do
+          subject.instance_variable_get(:@allow_trailing_line_spaces).
+            should == [false, { level: :error }]
+        end
+      end
+
+      describe "indentation_spaces" do
+        specify do
+          subject.instance_variable_get(:@indentation_spaces).should == [
+            2, { level: :error }]
+        end
+      end
+
+      describe "max_code_lines_in_class" do
+        specify do
+          subject.instance_variable_get(:@max_code_lines_in_class).should == [
+            300, { level: :error }]
+        end
+      end
+
+      describe "max_code_lines_in_method" do
+        specify do
+          subject.instance_variable_get(:@max_code_lines_in_method).should == [
+            30, { level: :error }]
+        end
+      end
+
+      describe "max_line_length" do
+        specify do
+          subject.instance_variable_get(:@max_line_length).should == [
+            80, { level: :error }]
+        end
+      end
+
+      describe "spaces_after_comma" do
+        specify do
+          subject.instance_variable_get(:@spaces_after_comma).should == [
+            1, { level: :error }]
+        end
+      end
+
+      describe "spaces_after_lbrace" do
+        specify do
+          subject.instance_variable_get(:@spaces_after_lbrace).should == [
+            1, { level: :error }]
+        end
+      end
+
+      describe "spaces_after_lbracket" do
+        specify do
+          subject.instance_variable_get(:@spaces_after_lbracket).should == [
+            0, { level: :error }]
+        end
+      end
+
+      describe "spaces_after_lparen" do
+        specify do
+          subject.instance_variable_get(:@spaces_after_lparen).should == [
+            0, { level: :error }]
+        end
+      end
+
+      describe "spaces_before_comma" do
+        specify do
+          subject.instance_variable_get(:@spaces_before_comma).should == [
+            0, { level: :error }]
+        end
+      end
+
+      describe "spaces_before_lbrace" do
+        specify do
+          subject.instance_variable_get(:@spaces_before_lbrace).should == [
+            1, { level: :error }]
+        end
+      end
+
+      describe "spaces_before_rbrace" do
+        specify do
+          subject.instance_variable_get(:@spaces_before_rbrace).should == [
+            1, { level: :error }]
+        end
+      end
+
+      describe "spaces_before_rbracket" do
+        specify do
+          subject.instance_variable_get(:@spaces_before_rbracket).should == [
+            0, { level: :error }]
+        end
+      end
+
+      describe "spaces_before_rparen" do
+        specify do
+          subject.instance_variable_get(:@spaces_before_rparen).should == [
+            0, { level: :error }]
+        end
+      end
+
+      describe "spaces_in_empty_braces" do
+        specify do
+          subject.instance_variable_get(:@spaces_in_empty_braces).should == [
+            0, { level: :error }]
+        end
+      end
+
+      describe "trailing_newlines" do
+        specify do
+          subject.instance_variable_get(:@trailing_newlines).should == [
+            1, { level: :error }]
+        end
+      end
+    end
+  end
+
+  describe "#to_hash" do
+    let(:default_values) do
+      {
+        :allow_camel_case_methods => [false, { :level => :error }],
+        :allow_hard_tabs => [false, { :level => :error }],
+        :allow_screaming_snake_case_classes => [false, { :level => :error }],
+        :allow_trailing_line_spaces => [false, { :level => :error }],
+        :allow_invalid_ruby => [false, { :level => :warn }],
+        :indentation_spaces => [2, { :level => :error }],
+        :max_code_lines_in_class => [300, { :level => :error }],
+        :max_code_lines_in_method => [30, { :level => :error }],
+        :max_line_length => [80, { :level => :error }],
+        :spaces_after_comma => [1, { :level => :error }],
+        :spaces_after_lbrace => [1, { :level => :error }],
+        :spaces_after_lbracket => [0, { :level => :error }],
+        :spaces_after_lparen => [0, { :level => :error }],
+        :spaces_before_comma => [0, { :level => :error }],
+        :spaces_before_lbrace => [1, { :level => :error }],
+        :spaces_before_rbrace => [1, { :level => :error }],
+        :spaces_before_rbracket => [0, { :level => :error }],
+        :spaces_before_rparen => [0, { :level => :error }],
+        :spaces_in_empty_braces => [0, { :level => :error }],
+        :trailing_newlines => [1, { :level => :error }]
+      }
+    end
+
+    it "returns a Hash of all of the attributes and values" do
+      subject.to_hash.should == default_values
+    end
+
+    context "with a user-added property" do
+      before do
+        Tailor::Configuration::Style.define_property(:long_pants)
+        subject.long_pants(1, level: :warn)
+      end
+
+      it "includes the new property as part of the Hash" do
+        subject.to_hash.should include long_pants: [1, { level: :warn }]
+      end
+    end
+  end
+end

data/spec/tailor/configuration_spec.rb

@@ -28,35 +28,36 @@ describe Tailor::Configuration do
     before do
       subject.instance_variable_set(:@file_sets, {})
     end
-    
+
     it "adds the set of stuff to @file_sets" do
-      subject.file_set(:bobo) do
-        trailing_newlines 2
+      subject.file_set('some_files', :bobo) do |style|
+        style.trailing_newlines 2
       end
 
       subject.instance_variable_get(:@file_sets).should == {
         bobo: {
           file_list: [],
           style: {
-            :allow_camel_case_methods=>false,
-            :allow_hard_tabs=>false,
-            :allow_screaming_snake_case_classes=>false,
-            :allow_trailing_line_spaces=>false,
-            :indentation_spaces=>2,
-            :max_code_lines_in_class=>300,
-            :max_code_lines_in_method=>30,
-            :max_line_length=>80,
-            :spaces_after_comma=>1,
-            :spaces_before_comma=>0,
-            :spaces_before_lbrace=>1,
-            :spaces_after_lbrace=>1,
-            :spaces_before_rbrace=>1,
-            :spaces_in_empty_braces=>0,
-            :spaces_after_lbracket=>0,
-            :spaces_before_rbracket=>0,
-            :spaces_after_lparen=>0,
-            :spaces_before_rparen=>0,
-            :trailing_newlines=>2
+            allow_camel_case_methods: [false, { level: :error }],
+            allow_hard_tabs: [false, { level: :error }],
+            allow_screaming_snake_case_classes: [false, { level: :error }],
+            allow_trailing_line_spaces: [false, { level: :error }],
+            allow_invalid_ruby: [false, { level: :warn }],
+            indentation_spaces: [2, { level: :error }],
+            max_code_lines_in_class: [300, { level: :error }],
+            max_code_lines_in_method: [30, { level: :error }],
+            max_line_length: [80, { level: :error }],
+            spaces_after_comma: [1, { level: :error }],
+            spaces_after_lbrace: [1, { level: :error }],
+            spaces_after_lbracket: [0, { level: :error }],
+            spaces_after_lparen: [0, { level: :error }],
+            spaces_before_comma: [0, { level: :error }],
+            spaces_before_lbrace: [1, { level: :error }],
+            spaces_before_rbrace: [1, { level: :error }],
+            spaces_before_rbracket: [0, { level: :error }],
+            spaces_before_rparen: [0, { level: :error }],
+            spaces_in_empty_braces: [0, { level: :error }],
+            trailing_newlines: [2, { level: :error }]
           }
         }
       }
@@ -78,16 +79,33 @@ describe Tailor::Configuration do
         subject.instance_variable_get(:@config_file).should == 'pants'
       end
     end
-    
+
     context "@config_file is nil" do
-      it "returns DEFAULT_RC_FILE" do
-        subject.config_file
-        subject.instance_variable_get(:@config_file).should ==
-          Tailor::Configuration::DEFAULT_RC_FILE
+      context "DEFAULT_PROJECT_CONFIG exists" do
+        before do
+          File.should_receive(:exists?).with(/\.tailor/).and_return true
+        end
+
+        it "returns Dir.pwd + './tailor'" do
+          subject.config_file
+        end
+      end
+
+      context "DEFAULT_PROJECT_CONFIG does not exist" do
+        before do
+          File.should_receive(:exists?).with(/\.tailor/).and_return false
+          File.should_receive(:exists?).with(/\.tailorrc/).and_return true
+        end
+
+        it "returns DEFAULT_RC_FILE" do
+          subject.config_file
+          subject.instance_variable_get(:@config_file).should ==
+            Tailor::Configuration::DEFAULT_RC_FILE
+        end
       end
     end
   end
-  
+
   describe "#file_list" do
     before do
       FileUtils.mkdir_p 'one/two'
@@ -101,7 +119,7 @@ describe Tailor::Configuration do
           results.last.should match /one\/two\/three.rb/
         end
       end
-      
+
       context "the Array has a directory" do
         context "the directory has files" do
           it "returns all files in the directory" do
@@ -109,7 +127,7 @@ describe Tailor::Configuration do
             results.last.should match /one\/two\/three.rb/
           end
         end
-        
+
         context "the directory is empty" do
           before do
             FileUtils.mkdir 'empty'
@@ -123,7 +141,7 @@ describe Tailor::Configuration do
         end
       end
     end
-    
+
     context "glob is a glob" do
       it "returns all files in the glob" do
         results = subject.file_list('one/**/*.rb')
@@ -137,10 +155,11 @@ describe Tailor::Configuration do
         results.last.should match /one\/two\/three.rb/
       end
     end
-    
+
     context "glob is a file" do
       it "returns all files in the glob" do
-        subject.file_list('one/two/three.rb').last.should match /one\/two\/three.rb/
+        subject.file_list('one/two/three.rb').last.
+          should match /one\/two\/three.rb/
       end
     end
   end