tailor 0.1.5 → 1.0.0.alpha

data/lib/tailor/rulers/max_line_length_ruler.rb

@@ -0,0 +1,31 @@
+require_relative '../ruler'
+
+class Tailor
+  module Rulers
+    class MaxLineLengthRuler < Tailor::Ruler
+      def ignored_nl_update(lexed_line, lineno, column)
+        log "<#{self.class}> Line length: #{lexed_line.line_length}"
+        measure(lexed_line, lineno, column)
+      end
+
+      def nl_update(lexed_line, lineno, column)
+        ignored_nl_update(lexed_line, lineno, column)
+      end
+
+      # Checks to see if the line has more characters that given at +@config+.
+      #
+      # @param [Fixnum] lexed_line The line to measure.
+      # @param [Fixnum] lineno Line the potential problem is on.
+      # @param [Fixnum] column Column the potential problem is on
+      def measure(lexed_line, lineno, column)
+        if lexed_line.line_length > @config
+          options = {
+            actual_length: lexed_line.line_length,
+            should_be_at: @config
+          }
+          @problems << Problem.new(:line_length, lineno, column, options)
+        end
+      end
+    end
+  end
+end

data/lib/tailor/rulers/spaces_after_comma_ruler.rb

@@ -0,0 +1,83 @@
+require_relative '../ruler'
+
+class Tailor
+  module Rulers
+
+    # Looks for spaces after a ',' as given by +@config+.  It skips checking
+    # when:
+    # * the char after it is a '\n'.
+    # * it's at the end of a line, followed by a trailing comment.
+    class SpacesAfterCommaRuler < Tailor::Ruler
+      def initialize(config)
+        super(config)
+        @comma_columns = []
+      end
+
+      def comma_update(text_line, lineno, column)
+        @comma_columns << column
+      end
+
+      def comment_update(token, lexed_line, file_text, lineno, column)
+        if token =~ /\n$/
+          log "Found comment with trailing newline."
+          ignored_nl_update(lexed_line, lineno, column)
+        end
+      end
+
+      def ignored_nl_update(lexed_line, lineno, column)
+        check_spaces_after_comma(lexed_line, lineno)
+      end
+
+      def nl_update(lexed_line, lineno, column)
+        ignored_nl_update(lexed_line, lineno, column)
+      end
+
+      # Checks to see if the actual_spaces after a comma equals the value
+      # at +@config+.
+      #
+      # @param [Fixnum] actual_spaces The number of spaces after the comma.
+      # @param [Fixnum] lineno Line the problem is on.
+      # @param [Fixnum] column Column the potential problem is on.
+      def measure(actual_spaces, lineno, column)
+        if actual_spaces != @config
+          @problems << Problem.new(:spaces_after_comma, lineno, column + 1,
+            { actual_spaces: actual_spaces, should_have: @config })
+        end
+      end
+
+      def check_spaces_after_comma(lexed_line, lineno)
+        log "Commas found at: #{@comma_columns}" unless @comma_columns.empty?
+
+        @comma_columns.each do |c|
+          event_index = lexed_line.event_index(c)
+          if event_index.nil?
+            log "Event index is nil.  Weird..."
+            break
+          end
+
+          next_event = lexed_line.at(event_index + 1)
+          if next_event.nil?
+            log "Looks like there is no next event (this is last in the line)."
+            break
+          end
+
+          if next_event[1] == :on_nl || next_event[1] == :on_ignored_nl
+            log "Next event is a newline."
+            break
+          end
+
+          second_next_event = lexed_line.at(event_index + 2)
+          if second_next_event[1] == :on_comment
+            log "Event + 2 is a comment."
+            next
+          end
+
+          actual_spaces = next_event[1] != :on_sp ? 0 : next_event.last.size
+          measure(actual_spaces, lineno, c)
+        end
+
+        @comma_columns.clear
+      end
+    end
+  end
+end

data/lib/tailor/rulers/spaces_after_lbrace_ruler.rb

@@ -0,0 +1,114 @@
+require_relative '../ruler'
+
+class Tailor
+  module Rulers
+
+    # Checks for spaces after a '{' as given by +@config+.  It skips checking
+    # when:
+    # * it's at the end of a line.
+    # * the next char is a '}'
+    # * it's at the end of a line, followed by a trailing comment.
+    class SpacesAfterLbraceRuler < Tailor::Ruler
+      def initialize(config)
+        super(config)
+        @lbrace_columns = []
+      end
+
+      def comment_update(token, lexed_line, file_text, lineno, column)
+        if token =~ /\n$/
+          log "Found comment with trailing newline."
+          ignored_nl_update(lexed_line, lineno, column)
+        end
+      end
+
+      def ignored_nl_update(lexed_line, lineno, column)
+        check_spaces_after_lbrace(lexed_line, lineno)
+      end
+
+      def lbrace_update(lexed_line, lineno, column)
+        @lbrace_columns << column
+      end
+
+      def nl_update(lexed_line, lineno, column)
+        ignored_nl_update(lexed_line, lineno, column)
+      end
+
+      # Checks to see if the number of spaces after an lbrace equals the value
+      # at +@config+.
+      #
+      # @param [Fixnum] actual_spaces The number of spaces after the lbrace.
+      # @param [Fixnum] lineno Line the potential problem is on.
+      # @param [Fixnum] column Column the potential problem is on.
+      def measure(actual_spaces, lineno, column)
+        if actual_spaces != @config
+          @problems << Problem.new(:spaces_after_lbrace, lineno, column + 1,
+            { actual_spaces: actual_spaces, should_have: @config })
+        end
+      end
+
+      def check_spaces_after_lbrace(lexed_line, lineno)
+        log "lbraces found at: #{@lbrace_columns}" unless @lbrace_columns.empty?
+
+        @lbrace_columns.each do |column|
+          actual_spaces = count_spaces(lexed_line, column)
+          next if actual_spaces.nil?
+
+          if @do_measurement == false
+            log "Skipping measurement."
+          else
+            measure(actual_spaces, lineno, column)
+          end
+
+          @do_measurement = true
+        end
+
+        @lbrace_columns.clear
+      end
+
+      # Counts the number of spaces after the lbrace.
+      #
+      # @param [LexedLine] lexed_line The LexedLine that contains the context
+      #   the lbrace was found in.
+      # @param [Fixnum] column Column the lbrace was found at.
+      # @return [Fixnum] The number of spaces found after the lbrace.
+      def count_spaces(lexed_line, column)
+        event_index = lexed_line.event_index(column)
+
+        if event_index.nil?
+          log "No lbrace in this line.  Moving on..."
+          @do_measurement = false
+          return
+        end
+
+        next_event = lexed_line.at(event_index + 1)
+
+        if next_event.nil?
+          log "lbrace must be at the end of the line.  Moving on."
+          @do_measurement = false
+          return 0
+        end
+
+        if next_event[1] == :on_nl || next_event[1] == :on_ignored_nl
+          log "lbrace is followed by a '#{next_event[1]}'.  Moving on."
+          @do_measurement = false
+          return 0
+        end
+
+        if next_event[1] == :on_rbrace
+          log "lbrace is followed by an rbrace.  Moving on."
+          @do_measurement = false
+          return 0
+        end
+
+        second_next_event = lexed_line.at(event_index + 2)
+        if second_next_event[1] == :on_comment
+          log "Event + 2 is a comment."
+          @do_measurement = false
+          return next_event.last.size
+        end
+
+        next_event[1] != :on_sp ? 0 : next_event.last.size
+      end
+    end
+  end
+end

data/lib/tailor/rulers/spaces_after_lbracket_ruler.rb

@@ -0,0 +1,123 @@
+require_relative '../ruler'
+
+class Tailor
+  module Rulers
+
+    # Detects spaces after a '[' as given by +@config+.  It skips checking
+    # when:
+    # * it's the last char in line.
+    # * the char after it is a ']'.
+    # * the char after it is space, then a '{'.
+    class SpacesAfterLbracketRuler < Tailor::Ruler
+      def initialize(config)
+        super(config)
+        @lbracket_columns = []
+      end
+
+      def comment_update(token, lexed_line, file_text, lineno, column)
+        if token =~ /\n$/
+          log "Found comment with trailing newline."
+          ignored_nl_update(lexed_line, lineno, column)
+        end
+      end
+
+      def ignored_nl_update(lexed_line, lineno, column)
+        check_spaces_after_lbracket(lexed_line, lineno)
+      end
+
+      def lbracket_update(lexed_line, lineno, column)
+        @lbracket_columns << column
+      end
+
+      def nl_update(lexed_line, lineno, column)
+        ignored_nl_update(lexed_line, lineno, column)
+      end
+
+      # Checks to see if the actual_spaces after an lbracket equals the value
+      # at +@config+.
+      #
+      # @param [Fixnum] actual_spaces The number of spaces after the lbracket.
+      # @param [Fixnum] lineno Line the problem was found on.
+      # @param [Fixnum] column Column the problem was found on.
+      def measure(actual_spaces, lineno, column)
+        if actual_spaces != @config
+          @problems << Problem.new(:spaces_after_lbracket, lineno, column + 1,
+            { actual_spaces: actual_spaces, should_have: @config })
+        end
+      end
+
+      def check_spaces_after_lbracket(lexed_line, lineno)
+        unless @lbracket_columns.empty?
+          log "lbracket found at: #{@lbracket_columns}"
+        end
+
+        @lbracket_columns.each do |column|
+          actual_spaces = count_spaces(lexed_line, column)
+          next if actual_spaces.nil?
+
+          if @do_measurement == false
+            log "Skipping measurement."
+          else
+            measure(actual_spaces, lineno, column)
+          end
+
+          @do_measurement = true
+        end
+
+        @lbracket_columns.clear
+      end
+
+      # Counts the number of spaces after the lbracket.
+      #
+      # @param [LexedLine] lexed_line The LexedLine that contains the context
+      #   the lbracket was found in.
+      # @param [Fixnum] column Column the lbracket was found at.
+      # @return [Fixnum] The number of spaces found after the lbracket.
+      def count_spaces(lexed_line, column)
+        event_index = lexed_line.event_index(column)
+
+        if event_index.nil?
+          log "No lbracket in this line.  Moving on..."
+          @do_measurement = false
+          return
+        end
+
+        next_event = lexed_line.at(event_index + 1)
+        log "Next event: #{next_event}"
+
+        if next_event.nil?
+          log "lbracket must be at the end of the line."
+          @do_measurement = false
+          return 0
+        end
+
+        [:on_nl, :on_ignored_nl].each do |event|
+          if next_event[1] == event
+            log "lbracket is followed by a '#{event}'.  Moving on."
+            @do_measurement = false
+            return 0
+          end
+        end
+
+        if next_event[1] == :on_rbracket
+          log "lbracket is followed by a rbracket.  Moving on."
+          @do_measurement = false
+          return 0
+        end
+
+        second_next_event = lexed_line.at(event_index + 2)
+        log "Event + 2: #{second_next_event}"
+
+        [:on_comment, :on_lbrace].each do |event|
+          if second_next_event[1] == event
+            log "Event + 2 is a #{event}.  Moving on."
+            @do_measurement = false
+            return next_event.last.size
+          end
+        end
+
+        next_event[1] != :on_sp ? 0 : next_event.last.size
+      end
+    end
+  end
+end

data/lib/tailor/rulers/spaces_after_lparen_ruler.rb

@@ -0,0 +1,116 @@
+require_relative '../ruler'
+
+class Tailor
+  module Rulers
+    class SpacesAfterLparenRuler < Tailor::Ruler
+      def initialize(config)
+        super(config)
+        @lparen_columns = []
+      end
+
+      def comment_update(token, lexed_line, file_text, lineno, column)
+        if token =~ /\n$/
+          log "Found comment with trailing newline."
+          ignored_nl_update(lexed_line, lineno, column)
+        end
+      end
+
+      def ignored_nl_update(lexed_line, lineno, column)
+        check_spaces_after_lparen(lexed_line, lineno)
+      end
+
+      def lparen_update(lineno, column)
+        @lparen_columns << column
+      end
+
+      def nl_update(lexed_line, lineno, column)
+        ignored_nl_update(lexed_line, lineno, column)
+      end
+
+      # Checks to see if the number of spaces after an lparen equals the value
+      # at +@config+.
+      #
+      # @param [Fixnum] actual_spaces The number of spaces after the lparen.
+      # @param [Fixnum] lineno Line the potential problem is on.
+      # @param [Fixnum] column Column the potential problem is on.
+      def measure(actual_spaces, lineno, column)
+        if actual_spaces != @config
+          @problems << Problem.new(:spaces_after_lparen, lineno, column + 1,
+            { actual_spaces: actual_spaces, should_have: @config })
+        end
+      end
+
+      def check_spaces_after_lparen(lexed_line, lineno)
+        unless @lparen_columns.empty?
+          log "lparens found at: #{@lparen_columns}"
+        end
+
+        @lparen_columns.each do |column|
+          actual_spaces = count_spaces(lexed_line, column)
+          next if actual_spaces.nil?
+
+          if @do_measurement == false
+            log "Skipping measurement."
+          else
+            measure(actual_spaces, lineno, column)
+          end
+
+          @do_measurement = true
+        end
+
+        @lparen_columns.clear
+      end
+
+      # Counts the number of spaces after the lparen.
+      #
+      # @param [LexedLine] lexed_line The LexedLine that contains the context
+      #   the lparen was found in.
+      # @param [Fixnum] column Column the lparen was found at.
+      # @return [Fixnum] The number of spaces found after the lparen.
+      def count_spaces(lexed_line, column)
+        event_index = lexed_line.event_index(column)
+
+        if event_index.nil?
+          log "No lparen in this line.  Moving on..."
+          @do_measurement = false
+          return
+        end
+
+        next_event = lexed_line.at(event_index + 1)
+        log "Next event: #{next_event}"
+
+        if next_event.nil?
+          log "lparen must be at the end of the line."
+          @do_measurement = false
+          return 0
+        end
+
+        [:on_nl, :on_ignored_nl].each do |event|
+          if next_event[1] == event
+            log "lparen is followed by a '#{event}'.  Moving on."
+            return 0
+          end
+        end
+
+        if next_event[1] == :on_rparen
+          log "lparen is followed by an rparen.  Moving on."
+          @do_measurement = false
+          return 0
+        end
+
+        second_next_event = lexed_line.at(event_index + 2)
+        log "Event + 2: #{second_next_event}"
+
+        [:on_comment, :on_lbrace, :on_lparen].each do |event|
+          if second_next_event[1] == event
+            log "Event + 2 is a #{event}.  Moving on."
+            @do_measurement = false
+            return next_event.last.size
+          end
+        end
+
+        next_event[1] != :on_sp ? 0 : next_event.last.size
+      end
+    end
+  end
+end