taglib-ruby 1.0.1 → 1.1.0

data/lib/taglib/version.rb

@@ -1,8 +1,8 @@
 module TagLib
   module Version
     MAJOR = 1
-    MINOR = 0
-    PATCH = 1
+    MINOR = 1
+    PATCH = 0
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.')

data/taglib-ruby.gemspec

@@ -26,8 +26,8 @@ DESC
   s.add_development_dependency 'bundler', '>= 1.2', '< 3'
   s.add_development_dependency 'rake-compiler', '~> 0.9'
   s.add_development_dependency 'shoulda-context', '~> 1.0'
-  s.add_development_dependency 'yard', '~> 0.9.12'
-  s.add_development_dependency 'kramdown', '~> 1.0'
+  s.add_development_dependency 'yard', '~> 0.9.26'
+  s.add_development_dependency 'kramdown', '~> 2.3.0'
   s.add_development_dependency 'test-unit', '~> 3.1'
 
   s.extensions = [
@@ -134,6 +134,7 @@ DESC
     "test/data/crash.mp3",
     "test/data/flac-create.cpp",
     "test/data/flac.flac",
+    "test/data/flac_nopic.flac",
     "test/data/get_picture_data.cpp",
     "test/data/globe_east_540.jpg",
     "test/data/globe_east_90.jpg",
@@ -155,6 +156,7 @@ DESC
     "test/fileref_write_test.rb",
     "test/flac_file_test.rb",
     "test/flac_file_write_test.rb",
+    "test/flac_picture_memory_test.rb",
     "test/helper.rb",
     "test/id3v1_genres_test.rb",
     "test/id3v1_tag_test.rb",

data/tasks/gemspec_check.rake

@@ -1,6 +1,6 @@
 desc "Checks file list in .gemspec against files tracked in Git"
 task :gemspec_check do |t|
-  exclude = ['.gitignore', '.travis.yml']
+  exclude = ['.gitignore', '.github/workflows/ci.yml']
   git_files = `git ls-files`.split("\n") - exclude
   gemspec_files = $gemspec.files
 

data/test/flac_picture_memory_test.rb

@@ -0,0 +1,43 @@
+require File.join(File.dirname(__FILE__), 'helper')
+
+class TestFlacPictureMemory < Test::Unit::TestCase
+
+  N = 10000
+
+  context "TagLib::FLAC::Picture" do
+ 
+    setup do
+      
+    end
+
+    should "release memory when closing flac file with picture data" do
+      c = 0
+      N.times do
+        TagLib::FLAC::File.open("test/data/flac.flac", false) do |f|
+          f.picture_list.each do |p|
+            x = p.data
+            c = c + 1
+          end
+        end
+      end
+      assert_equal N,c
+    end
+
+    should "process a flac file without picture data" do
+      c = 0
+      N.times do
+        TagLib::FLAC::File.open("test/data/flac_nopic.flac", false) do |f|
+          f.picture_list.each do |p|
+            x = p.data
+            c = c + 1
+          end
+        end
+      end
+      assert_equal 0,c
+    end
+
+    teardown do
+
+    end
+  end
+end

data/test/id3v2_frames_test.rb

@@ -92,6 +92,70 @@ class TestID3v2Frames < Test::Unit::TestCase
       end
     end
 
+    context 'CTOC and CHAP frames' do
+      setup do
+        @chapters = [
+          { id: 'CH1', start_time: 100, end_time: 200 },
+          { id: 'CH2', start_time: 201, end_time: 300 },
+          { id: 'CH3', start_time: 301, end_time: 400 }
+        ]
+
+        @default_ctoc = TagLib::ID3v2::TableOfContentsFrame.new('Test')
+        @default_chap = TagLib::ID3v2::ChapterFrame.new('Test', 0, 1, 0xFFFFFFFF, 0xFFFFFFFF)
+      end
+
+      should 'not have a CTOC frame' do
+        assert_equal [], @tag.frame_list('CTOC')
+      end
+
+      should 'not have a CHAP frame' do
+        assert_equal [], @tag.frame_list('CHAP')
+      end
+
+      should 'have one CTOC frame (only one Table of Contents)' do
+        toc = TagLib::ID3v2::TableOfContentsFrame.new('TOC')
+        toc.is_top_level = true
+        toc.is_ordered = true
+
+        @chapters.each do |chapter|
+          toc.add_child_element(chapter[:id])
+        end
+
+        @tag.add_frame(toc)
+
+        ctoc_frame_list = @tag.frame_list('CTOC')
+        assert_equal @default_ctoc.class, ctoc_frame_list.first.class
+        assert_equal 1, ctoc_frame_list.size
+        assert_equal 'TOC', ctoc_frame_list.first.element_id
+        assert_equal 3, ctoc_frame_list.first.child_elements.size
+        assert_equal %w[CH1 CH2 CH3], ctoc_frame_list.first.child_elements
+      end
+
+      should 'have CHAP frames (multiple chapters)' do
+        start_offset = 0xFFFFFFFF
+        end_offset = 0xFFFFFFFF
+
+        @chapters.each do |chapter|
+          chapter_frame = TagLib::ID3v2::ChapterFrame.new(
+            chapter[:id],
+            chapter[:start_time].to_i,
+            chapter[:end_time].to_i,
+            start_offset,
+            end_offset
+          )
+
+          @tag.add_frame(chapter_frame)
+        end
+
+        chap_frame_list = @tag.frame_list('CHAP')
+        assert_equal @default_chap.class, chap_frame_list.first.class
+        assert_equal 3, chap_frame_list.size
+        assert_equal 'CH1', chap_frame_list[0].element_id
+        assert_equal 'CH2', chap_frame_list[1].element_id
+        assert_equal 'CH3', chap_frame_list[2].element_id
+      end
+    end
+
     context "TXXX frame" do
       setup do
         @txxx_frame = @tag.frame_list('TXXX').first

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: taglib-ruby
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Robin Stocker
 - Jacob Vosmaer
 - Thomas Chevereau
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-25 00:00:00.000000000 Z
+date: 2021-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,28 +66,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.12
+        version: 0.9.26
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.12
+        version: 0.9.26
 - !ruby/object:Gem::Dependency
   name: kramdown
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
@@ -213,6 +213,7 @@ files:
 - test/data/crash.mp3
 - test/data/flac-create.cpp
 - test/data/flac.flac
+- test/data/flac_nopic.flac
 - test/data/get_picture_data.cpp
 - test/data/globe_east_540.jpg
 - test/data/globe_east_90.jpg
@@ -234,6 +235,7 @@ files:
 - test/fileref_write_test.rb
 - test/flac_file_test.rb
 - test/flac_file_write_test.rb
+- test/flac_picture_memory_test.rb
 - test/helper.rb
 - test/id3v1_genres_test.rb
 - test/id3v1_tag_test.rb
@@ -260,7 +262,7 @@ homepage: http://robinst.github.io/taglib-ruby/
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -276,8 +278,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - taglib (libtag1-dev in Debian/Ubuntu, taglib-devel in Fedora/RHEL)
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Ruby interface for the taglib C++ library
 test_files: []