taglib-ruby 1.0.0 → 1.1.1

data/test/id3v2_write_test.rb

@@ -1,26 +1,25 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 require 'fileutils'
 
 class TestID3v2Write < Test::Unit::TestCase
+  SAMPLE_FILE = 'test/data/sample.mp3'
+  OUTPUT_FILE = 'test/data/output.mp3'
+  PICTURE_FILE = 'test/data/globe_east_540.jpg'
 
-  SAMPLE_FILE = "test/data/sample.mp3"
-  OUTPUT_FILE = "test/data/output.mp3"
-  PICTURE_FILE = "test/data/globe_east_540.jpg"
-
-  def reloaded
-    TagLib::MPEG::File.open(OUTPUT_FILE, false) do |file|
-      yield file
-    end
+  def reloaded(&block)
+    TagLib::MPEG::File.open(OUTPUT_FILE, false, &block)
   end
 
-  context "TagLib::MPEG::File" do
+  context 'TagLib::MPEG::File' do
     setup do
       FileUtils.cp SAMPLE_FILE, OUTPUT_FILE
       @file = TagLib::MPEG::File.new(OUTPUT_FILE, false)
     end
 
-    should "be able to strip the tag" do
+    should 'be able to strip the tag' do
       assert_not_nil @file.id3v2_tag
       success = @file.strip
       assert success
@@ -34,7 +33,7 @@ class TestID3v2Write < Test::Unit::TestCase
       end
     end
 
-    should "be able to save only ID3v2 tag" do
+    should 'be able to save only ID3v2 tag' do
       assert_not_nil @file.id3v2_tag
       assert_not_nil @file.id3v1_tag
       @file.save(TagLib::MPEG::File::ID3v2)
@@ -54,7 +53,7 @@ class TestID3v2Write < Test::Unit::TestCase
       end
     end
 
-    should "be able to save ID3v2.3" do
+    should 'be able to save ID3v2.3' do
       success = @file.save(TagLib::MPEG::File::ID3v2, true, 3)
       assert_equal true, success
       @file.close
@@ -64,38 +63,38 @@ class TestID3v2Write < Test::Unit::TestCase
         f.read(5)
       end
       # 3 stands for v2.3
-      s = "ID3" + 3.chr + 0.chr
+      s = "ID3#{3.chr}#{0.chr}"
       assert_equal s, header
     end
 
-    should "be able to set fields to nil" do
+    should 'be able to set fields to nil' do
       tag = @file.id3v2_tag
       tag.title = nil
       assert_equal [], tag.frame_list('TIT2')
     end
 
-    context "with a fresh tag" do
+    context 'with a fresh tag' do
       setup do
         @file.strip
         @tag = @file.id3v2_tag(true)
       end
 
-      should "be able to create a new tag" do
+      should 'be able to create a new tag' do
         assert_not_nil @tag
         assert_equal 0, @tag.frame_list.size
       end
 
-      should "be able to save it" do
+      should 'be able to save it' do
         success = @file.save
         assert success
       end
 
-      should "be able to add a new frame to it and read it back" do
+      should 'be able to add a new frame to it and read it back' do
         picture_data = File.open(PICTURE_FILE, 'rb') { |f| f.read }
 
         apic = TagLib::ID3v2::AttachedPictureFrame.new
-        apic.mime_type = "image/jpeg"
-        apic.description = "desc"
+        apic.mime_type = 'image/jpeg'
+        apic.description = 'desc'
         apic.text_encoding = TagLib::String::UTF8
         apic.picture = picture_data
         apic.type = TagLib::ID3v2::AttachedPictureFrame::FrontCover
@@ -108,16 +107,16 @@ class TestID3v2Write < Test::Unit::TestCase
         @file = nil
 
         written_file = TagLib::MPEG::File.new(OUTPUT_FILE, false)
-        written_apic = written_file.id3v2_tag.frame_list("APIC").first
-        assert_equal "image/jpeg", written_apic.mime_type
-        assert_equal "desc", written_apic.description
+        written_apic = written_file.id3v2_tag.frame_list('APIC').first
+        assert_equal 'image/jpeg', written_apic.mime_type
+        assert_equal 'desc', written_apic.description
         assert_equal picture_data, written_apic.picture
         written_file.close
       end
 
-      should "be able to set field_list" do
-        tit2 = TagLib::ID3v2::TextIdentificationFrame.new("TIT2", TagLib::String::UTF8)
-        texts = ["one", "two"]
+      should 'be able to set field_list' do
+        tit2 = TagLib::ID3v2::TextIdentificationFrame.new('TIT2', TagLib::String::UTF8)
+        texts = %w[one two]
         tit2.field_list = texts
         assert_equal texts, tit2.field_list
         @tag.add_frame(tit2)
@@ -125,14 +124,14 @@ class TestID3v2Write < Test::Unit::TestCase
         assert success
       end
 
-      should "not fail when field_list is nil" do
-        tit2 = TagLib::ID3v2::TextIdentificationFrame.new("TIT2", TagLib::String::UTF8)
+      should 'not fail when field_list is nil' do
+        tit2 = TagLib::ID3v2::TextIdentificationFrame.new('TIT2', TagLib::String::UTF8)
         tit2.field_list = nil
         assert_equal [], tit2.field_list
       end
 
       if HAVE_ENCODING
-        should "be able to set unicode fields" do
+        should 'be able to set unicode fields' do
           # Hello, Unicode Snowman (not in Latin1)
           text = "Hello, \u{2603}"
 

data/test/mp4_file_test.rb

@@ -1,62 +1,64 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class MP4FileTest < Test::Unit::TestCase
-  context "TagLib::MP4::File" do
+  context 'TagLib::MP4::File' do
     setup do
-      @file = TagLib::MP4::File.new("test/data/mp4.m4a")
+      @file = TagLib::MP4::File.new('test/data/mp4.m4a')
       @tag = @file.tag
     end
 
-    should "have an MP4 tag" do
+    should 'have an MP4 tag' do
       assert @file.mp4_tag?
       refute_nil @tag
     end
 
-    should "contain basic tag information" do
-      assert_equal "Title", @tag.title
-      assert_equal "Artist", @tag.artist
-      assert_equal "Album", @tag.album
-      assert_equal "Comment", @tag.comment
-      assert_equal "Pop", @tag.genre
+    should 'contain basic tag information' do
+      assert_equal 'Title', @tag.title
+      assert_equal 'Artist', @tag.artist
+      assert_equal 'Album', @tag.album
+      assert_equal 'Comment', @tag.comment
+      assert_equal 'Pop', @tag.genre
       assert_equal 2011, @tag.year
       assert_equal 7, @tag.track
 
       assert_equal false, @tag.empty?
     end
 
-    should "support testing for the presence of items" do
-      refute @tag.contains "unknown"
-      assert @tag.contains "trkn"
+    should 'support testing for the presence of items' do
+      refute @tag.contains 'unknown'
+      assert @tag.contains 'trkn'
     end
 
-    should "support accessing items" do
-      refute @tag["unkn"].valid?
+    should 'support accessing items' do
+      refute @tag['unkn'].valid?
 
-      assert @tag["trkn"].valid?
+      assert @tag['trkn'].valid?
       assert_equal 7, @tag.track
     end
 
-    should "support editing items" do
-      @tag["trkn"] = TagLib::MP4::Item.from_int(1)
+    should 'support editing items' do
+      @tag['trkn'] = TagLib::MP4::Item.from_int(1)
       assert_equal 1, @tag.track
     end
 
-    should "support removing items" do
-      assert @tag.contains "trkn"
-      @tag.remove_item("trkn")
-      refute @tag.contains "trkn"
+    should 'support removing items' do
+      assert @tag.contains 'trkn'
+      @tag.remove_item('trkn')
+      refute @tag.contains 'trkn'
     end
 
-    context "audio properties" do
+    context 'audio properties' do
       setup do
         @properties = @file.audio_properties
       end
 
-      should "exist" do
+      should 'exist' do
         assert_not_nil @properties
       end
 
-      should "contain basic information" do
+      should 'contain basic information' do
         assert_equal 1, @properties.length_in_seconds
         assert_equal 55, @properties.bitrate
         assert_equal 44100, @properties.sample_rate
@@ -64,7 +66,7 @@ class MP4FileTest < Test::Unit::TestCase
         assert_equal 2, @properties.channels
       end
 
-      should "contain mp4-specific information" do
+      should 'contain mp4-specific information' do
         assert_equal 16, @properties.bits_per_sample
         assert_equal false, @properties.encrypted?
         assert_equal TagLib::MP4::Properties::AAC, @properties.codec
@@ -76,5 +78,4 @@ class MP4FileTest < Test::Unit::TestCase
       @file = nil
     end
   end
-
 end

data/test/mp4_file_write_test.rb

@@ -1,27 +1,26 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class MP4FileWriteTest < Test::Unit::TestCase
+  SAMPLE_FILE = 'test/data/mp4.m4a'
+  OUTPUT_FILE = 'test/data/output.m4a'
+  PICTURE_FILE = 'test/data/globe_east_540.jpg'
 
-  SAMPLE_FILE = "test/data/mp4.m4a"
-  OUTPUT_FILE = "test/data/output.m4a"
-  PICTURE_FILE = "test/data/globe_east_540.jpg"
-
-  def reloaded
-    TagLib::MP4::File.open(OUTPUT_FILE, false) do |file|
-      yield file
-    end
+  def reloaded(&block)
+    TagLib::MP4::File.open(OUTPUT_FILE, false, &block)
   end
 
-  context "TagLib::MP4::File" do
+  context 'TagLib::MP4::File' do
     setup do
       FileUtils.cp SAMPLE_FILE, OUTPUT_FILE
       @file = TagLib::MP4::File.new(OUTPUT_FILE, false)
     end
 
-    should "be able to save the title" do
+    should 'be able to save the title' do
       tag = @file.tag
       assert_not_nil tag
-      tag.title = "New Title"
+      tag.title = 'New Title'
       success = @file.save
       assert success
       @file.close
@@ -30,10 +29,10 @@ class MP4FileWriteTest < Test::Unit::TestCase
       written_title = reloaded do |file|
         file.tag.title
       end
-      assert_equal "New Title", written_title
+      assert_equal 'New Title', written_title
     end
 
-    should "be able to add and save new cover art" do
+    should 'be able to add and save new cover art' do
       item_map = @file.tag.item_map
       cover_art_list = item_map['covr'].to_cover_art_list
       assert_equal 1, cover_art_list.size

data/test/mp4_items_test.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 require 'set'
 
@@ -7,55 +8,55 @@ class MP4ItemsTest < Test::Unit::TestCase
 
   context "The mp4.m4a file's items" do
     setup do
-      @file = TagLib::MP4::File.new("test/data/mp4.m4a")
+      @file = TagLib::MP4::File.new('test/data/mp4.m4a')
       @tag = @file.tag
       @item_map = @file.tag.item_map
       @item_keys = [
-        "covr", "#{ITUNES_LEADER}nam", "#{ITUNES_LEADER}ART", "#{ITUNES_LEADER}alb",
+        'covr', "#{ITUNES_LEADER}nam", "#{ITUNES_LEADER}ART", "#{ITUNES_LEADER}alb",
         "#{ITUNES_LEADER}cmt", "#{ITUNES_LEADER}gen", "#{ITUNES_LEADER}day",
-        "trkn", "#{ITUNES_LEADER}too", "#{ITUNES_LEADER}cpy"
+        'trkn', "#{ITUNES_LEADER}too", "#{ITUNES_LEADER}cpy"
       ]
     end
 
-    context "item_map" do
-      should "exist" do
+    context 'item_map' do
+      should 'exist' do
         assert_not_nil @item_map
       end
 
-      should "not be empty" do
+      should 'not be empty' do
         assert_equal false, @item_map.empty?
       end
 
-      should "contain 10 items" do
+      should 'contain 10 items' do
         assert_equal @item_keys.count, @item_map.size
       end
 
-      should "have keys" do
-        assert_equal true, @item_map.contains("trkn")
+      should 'have keys' do
+        assert_equal true, @item_map.contains('trkn')
         assert_equal true, @item_map.has_key?("#{ITUNES_LEADER}too")
         assert_equal true, @item_map.include?("#{ITUNES_LEADER}cpy")
-        assert_equal false, @item_map.include?("none such key")
+        assert_equal false, @item_map.include?('none such key')
       end
 
-      should "look up keys" do
-        assert_nil @item_map["none such key"]
-        assert_equal ["Title"], @item_map["#{ITUNES_LEADER}nam"].to_string_list
+      should 'look up keys' do
+        assert_nil @item_map['none such key']
+        assert_equal ['Title'], @item_map["#{ITUNES_LEADER}nam"].to_string_list
       end
 
-      should "be clearable" do
+      should 'be clearable' do
         assert_equal 10, @item_map.size
         comment = @item_map["#{ITUNES_LEADER}cmt"]
         @item_map.clear
         assert_equal true, @item_map.empty?
         begin
           comment.to_string_list
-          flunk("Should have raised ObjectPreviouslyDeleted.")
-        rescue => e
-          assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+          flunk('Should have raised ObjectPreviouslyDeleted.')
+        rescue StandardError => e
+          assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
         end
       end
 
-      should "be convertible to an array" do
+      should 'be convertible to an array' do
         array = @item_map.to_a
         assert_equal 10, array.count
         array.each do |object|
@@ -67,150 +68,149 @@ class MP4ItemsTest < Test::Unit::TestCase
         end
       end
 
-      should "be convertible to a hash" do
+      should 'be convertible to a hash' do
         hsh = @item_map.to_h
         assert_equal Set.new(hsh.keys), Set.new(@item_keys)
       end
     end
 
-    should "be removable" do
+    should 'be removable' do
       assert_equal 10, @item_map.size
       title = @item_map["#{ITUNES_LEADER}nam"]
       @item_map.erase("#{ITUNES_LEADER}nam")
       assert_equal 9, @item_map.size
       begin
         title.to_string_list
-        flunk("Should have raised ObjectPreviouslyDeleted.")
-      rescue => e
-        assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+        flunk('Should have raised ObjectPreviouslyDeleted.')
+      rescue StandardError => e
+        assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
       end
     end
 
-    should "reflect edition of items from the tag" do
-      assert @tag.contains "trkn"
-      track = @item_map["trkn"]
+    should 'reflect edition of items from the tag' do
+      assert @tag.contains 'trkn'
+      track = @item_map['trkn']
 
-      @tag["trkn"] = TagLib::MP4::Item.from_int(1)
+      @tag['trkn'] = TagLib::MP4::Item.from_int(1)
 
       begin
         track.to_int_pair[0]
-        flunk("Should have raised ObjectPreviouslyDeleted.")
-      rescue => e
-        assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+        flunk('Should have raised ObjectPreviouslyDeleted.')
+      rescue StandardError => e
+        assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
       end
     end
 
-    should "reflect removal of items from the tag" do
-      assert @tag.contains "trkn"
-      track = @item_map["trkn"]
+    should 'reflect removal of items from the tag' do
+      assert @tag.contains 'trkn'
+      track = @item_map['trkn']
 
-      @tag.remove_item("trkn")
-      refute @item_map.contains "trkn"
+      @tag.remove_item('trkn')
+      refute @item_map.contains 'trkn'
 
       begin
         track.to_int_pair[0]
-        flunk("Should have raised ObjectPreviouslyDeleted.")
-      rescue => e
-        assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+        flunk('Should have raised ObjectPreviouslyDeleted.')
+      rescue StandardError => e
+        assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
       end
     end
 
-    context "inserting items" do
-      should "insert a new item" do
+    context 'inserting items' do
+      should 'insert a new item' do
         new_title = TagLib::MP4::Item.from_string_list(['new title'])
         @item_map.insert("#{ITUNES_LEADER}nam", new_title)
-        new_title = nil
         GC.start
         assert_equal ['new title'], @item_map["#{ITUNES_LEADER}nam"].to_string_list
       end
 
-      should "unlink items that get replaced" do
+      should 'unlink items that get replaced' do
         title = @item_map["#{ITUNES_LEADER}nam"]
         @item_map.insert("#{ITUNES_LEADER}nam", TagLib::MP4::Item.from_int(1))
         begin
           title.to_string_list
-          flunk("Should have raised ObjectPreviouslyDeleted.")
-        rescue => e
-          assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+          flunk('Should have raised ObjectPreviouslyDeleted.')
+        rescue StandardError => e
+          assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
         end
       end
     end
 
-    context "TagLib::MP4::Item" do
-      should "be creatable from a boolean" do
+    context 'TagLib::MP4::Item' do
+      should 'be creatable from a boolean' do
         item = TagLib::MP4::Item.from_bool(false)
         assert_equal TagLib::MP4::Item, item.class
         assert_equal false, item.to_bool
       end
 
-      should "be creatable from a byte" do
+      should 'be creatable from a byte' do
         item = TagLib::MP4::Item.from_byte(123)
         assert_equal TagLib::MP4::Item, item.class
         assert_equal 123, item.to_byte
       end
 
-      should "be creatable from an unsigned int" do
-        item = TagLib::MP4::Item.from_int(12346)
+      should 'be creatable from an unsigned int' do
+        item = TagLib::MP4::Item.from_int(12_346)
         assert_equal TagLib::MP4::Item, item.class
-        assert_equal 12346, item.to_uint
+        assert_equal 12_346, item.to_uint
       end
 
-      should "be creatable from an int" do
+      should 'be creatable from an int' do
         item = TagLib::MP4::Item.from_int(-42)
         assert_equal TagLib::MP4::Item, item.class
-        assert_equal -42, item.to_int
+        assert_equal(-42, item.to_int)
       end
 
-      should "be creatable from a long long" do
-        item = TagLib::MP4::Item.from_long_long(1234567890)
+      should 'be creatable from a long long' do
+        item = TagLib::MP4::Item.from_long_long(1_234_567_890)
         assert_equal TagLib::MP4::Item, item.class
-        assert_equal 1234567890, item.to_long_long
+        assert_equal 1_234_567_890, item.to_long_long
       end
 
-      context ".from_int_pair" do
-        should "be creatable from a pair of ints" do
+      context '.from_int_pair' do
+        should 'be creatable from a pair of ints' do
           item = TagLib::MP4::Item.from_int_pair([123, 456])
           assert_equal TagLib::MP4::Item, item.class
           assert_equal [123, 456], item.to_int_pair
         end
 
-        should "raise an error when passed something other than an Array" do
+        should 'raise an error when passed something other than an Array' do
           begin
             TagLib::MP4::Item.from_int_pair(1)
-            flunk("Should have raised ArgumentError.")
-          rescue => e
-            assert_equal "ArgumentError", e.class.to_s
+            flunk('Should have raised ArgumentError.')
+          rescue StandardError => e
+            assert_equal 'ArgumentError', e.class.to_s
           end
         end
 
-        should "raise an error when passed an Array with more than two elements" do
+        should 'raise an error when passed an Array with more than two elements' do
           begin
             TagLib::MP4::Item.from_int_pair([1, 2, 3])
-            flunk("Should have raised ArgumentError.")
-          rescue => e
-            assert_equal "ArgumentError", e.class.to_s
+            flunk('Should have raised ArgumentError.')
+          rescue StandardError => e
+            assert_equal 'ArgumentError', e.class.to_s
           end
         end
 
-        should "raise an error when passed an Array with less than two elements" do
+        should 'raise an error when passed an Array with less than two elements' do
           begin
             TagLib::MP4::Item.from_int_pair([1])
-            flunk("Should have raised ArgumentError.")
-          rescue => e
-            assert_equal "ArgumentError", e.class.to_s
+            flunk('Should have raised ArgumentError.')
+          rescue StandardError => e
+            assert_equal 'ArgumentError', e.class.to_s
           end
         end
       end
 
-      context "created from an array of strings" do
-        should "interpreted as strings with an encoding" do
-          item = TagLib::MP4::Item.from_string_list(["héllo"])
+      context 'created from an array of strings' do
+        should 'interpreted as strings with an encoding' do
+          item = TagLib::MP4::Item.from_string_list(['héllo'])
           assert_equal TagLib::MP4::Item, item.class
-          assert_equal ["héllo"], item.to_string_list
+          assert_equal ['héllo'], item.to_string_list
         end
       end
 
-      should "be creatable from a CoverArt list" do
+      should 'be creatable from a CoverArt list' do
         cover_art = TagLib::MP4::CoverArt.new(TagLib::MP4::CoverArt::JPEG, 'foo')
         item = TagLib::MP4::Item.from_cover_art_list([cover_art])
         assert_equal TagLib::MP4::Item, item.class
@@ -220,8 +220,8 @@ class MP4ItemsTest < Test::Unit::TestCase
       end
     end
 
-    context "TagLib::MP4::CoverArt" do
-      should "be creatable from a string" do
+    context 'TagLib::MP4::CoverArt' do
+      should 'be creatable from a string' do
         cover_art = TagLib::MP4::CoverArt.new(TagLib::MP4::CoverArt::JPEG, 'foo')
         assert_equal TagLib::MP4::CoverArt::JPEG, cover_art.format
         assert_equal 'foo', cover_art.data
@@ -233,5 +233,4 @@ class MP4ItemsTest < Test::Unit::TestCase
       @file = nil
     end
   end
-
 end