tagalong 0.1.0 → 0.1.1

data/lib/tagalong/tagger.rb

@@ -28,9 +28,9 @@ module Tagalong
 
       def rename_tag(existing_tag, rename_to)
         if tag = tagalong_tags.find_by_name(existing_tag)
-          tag.name = rename_to
-          raise Tagalong::TagAlreadyInUse, "A tag already exists with the name '#{tag.name}'" unless tag.valid?
-          tag.save!
+          raise Tagalong::TagAlreadyInUse, "A tag already exists with the name '#{rename_to}'" if tagalong_tags.find_by_name(rename_to).present?
+          raise Tagalong::TagCannotBeBlank, "A tag cannot have a blank name" if rename_to.blank?
+          tag.update_attribute(:name, rename_to)
         else
           raise Tagalong::TagNotFound, "Tried to rename a tag that does not exist."
         end

data/lib/tagalong/version.rb

@@ -1,3 +1,3 @@
 module Tagalong
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/lib/tagalong/tagger_spec.rb

@@ -52,6 +52,10 @@ describe "Tagger" do
         it "should return true if rename was successfull" do
           @user.rename_tag('tag5', 'renamedTag5').should be_true
         end
+
+        it "should raise a cannot be blank error if the name is blank" do
+          lambda { @user.rename_tag('tag5', '') }.should raise_error(Tagalong::TagCannotBeBlank)
+        end
       end
 
       context "when the tagger does not own the tag being renamed" do
@@ -256,9 +260,8 @@ describe "Tagger" do
       it "should find the tag by its name" do
         tag = stub('tag', :name => 'tag7')
         Tagalong::TagalongTag.should_receive(:find_by_name).with('tag7').and_return(tag)
-        tag.stub(:name=)
-        tag.stub(:save!)
-        tag.stub(:valid?).and_return(true)
+        Tagalong::TagalongTag.stub(:find_by_name).with('renamedTag7').and_return(false)
+        tag.stub(:update_attribute)
         @user.rename_tag('tag7', 'renamedTag7')
       end
 
@@ -267,23 +270,11 @@ describe "Tagger" do
         lambda { @user.rename_tag('tag7', 'renamedTag7') }.should raise_error(Tagalong::TagNotFound)
       end
 
-      it "should assign and save the new tag name" do
-        tag8 = mock('tag 8', :name => 'tag8')
-        Tagalong::TagalongTag.stub(:find_by_name).and_return(tag8)
-        @user.stub(:has_tag?).and_return(true)
-        tag8.should_receive(:name=).with('renamedTag8')
-        tag8.stub(:valid?).and_return(true)
-        tag8.stub(:save!)
-        @user.rename_tag('tag8', 'renamedTag8')
-      end
-
       it "should save the tag if the Tagger owns it" do
         tag9 = mock('tag 9', :name => 'tag9')
-        Tagalong::TagalongTag.stub(:find_by_name).and_return(tag9)
-        @user.stub(:has_tag?).and_return(true)
-        tag9.stub(:name=)
-        tag9.stub(:valid?).and_return(true)
-        tag9.should_receive(:save!)
+        Tagalong::TagalongTag.stub(:find_by_name).with('tag9').and_return(tag9)
+        Tagalong::TagalongTag.stub(:find_by_name).with('renamedTag9').and_return(false)
+        tag9.should_receive(:update_attribute).with(:name, 'renamedTag9')
         @user.rename_tag('tag9', 'renamedTag9')
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tagalong
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-22 00:00:00.000000000 Z
+date: 2012-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70166046334400 !ruby/object:Gem::Requirement
+  requirement: &70345218560620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70166046334400
+  version_requirements: *70345218560620
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70166046333780 !ruby/object:Gem::Requirement
+  requirement: &70345218559740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70166046333780
+  version_requirements: *70345218559740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70166046333320 !ruby/object:Gem::Requirement
+  requirement: &70345218558920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70166046333320
+  version_requirements: *70345218558920
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70166046332840 !ruby/object:Gem::Requirement
+  requirement: &70345218558100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70166046332840
+  version_requirements: *70345218558100
 - !ruby/object:Gem::Dependency
   name: sunspot_rails
-  requirement: &70166046332400 !ruby/object:Gem::Requirement
+  requirement: &70345218557320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70166046332400
+  version_requirements: *70345218557320
 - !ruby/object:Gem::Dependency
   name: sunspot_solr
-  requirement: &70166046331960 !ruby/object:Gem::Requirement
+  requirement: &70345218556880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,10 +77,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70166046331960
+  version_requirements: *70345218556880
 - !ruby/object:Gem::Dependency
   name: sunspot_test
-  requirement: &70166046331440 !ruby/object:Gem::Requirement
+  requirement: &70345218556400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -88,7 +88,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70166046331440
+  version_requirements: *70345218556400
 description: A Rails tagging plugin that makes sense.
 email:
 - cyphactor@gmail.com
@@ -146,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.16
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: A Rails tagging plugin that makes sense.