tacky 0.5.0 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66e070784bf3eab59a930f0d63a5f910fb33f0bd6642c8d2148ea96adef88c9c
-  data.tar.gz: 94e8f05a030e86e042f839bb3f14c9bd10f193af4187ed83a7c54f4e94ac59c1
+  metadata.gz: d5169130c14020b608d8c321ecd838a5593c61b6c43494c69cad647611313d29
+  data.tar.gz: 95583567be0ac82aff2e1af2fbe310b9c4b3cd6bb34bfe75669adb4f734a772c
 SHA512:
-  metadata.gz: a4ca0db0df2352b30efa323b54ec6145a99cba13a57fa3d84c44d56ab6a949b97a664b100031b102d56bc935129275bccbe3e7c225074d609e7148da0ded2f8a
-  data.tar.gz: acb6474481c989d587516c2fd6a10220f2143e4c5eccd2d5eb3bec9b6442fc5b76e5628a3afa07e4e495feb57776fa0935bd3cdd37e8b618acacc34a4d644326
+  metadata.gz: 371e36840b98444725e97e6ab46080da007e34df15c557c09fcf3727e9b4cde6edd8b142ab773bce3ece3a4b3c16cfbaba52cb3b579498d467fefee66b6aa9c1
+  data.tar.gz: 875cecc83dc3b6b6b8b6b53eab2153adae00aa5f5fffc2c505396466cef25c0a68c1f1668a00e7f90cac95bdd4f3b29719dfcf7ccb75ec3b72007d252350e5b7

data/.rubocop.yml

@@ -29,9 +29,9 @@ Metrics/MethodLength:
 Metrics/ClassLength:
   Max: 180
 Metrics/CyclomaticComplexity:
-  Max: 10
+  Max: 15
 Metrics/PerceivedComplexity:
-  Max: 10
+  Max: 15
 Metrics/ParameterLists:
   Max: 10
 Layout/ParameterAlignment:

data/lib/tacky.rb

@@ -32,14 +32,26 @@ class Tacky
   end
 
   def method_missing(*args)
+    maybe = %i[key keyreq]
     @mutex.synchronize do
-      unless @cache.key?(args)
-        @cache[args] = @origin.__send__(*args) do |*a|
-          yield(*a) if block_given?
-        end
-        @cache[args] = Tacky.new(@cache[args], deep: @deep) if @deep && STOP.none? { |t| @cache[args].is_a?(t) }
+      key = args.dup
+      mtd = args.shift
+      unless @cache.key?(key)
+        params = @origin.method(mtd).parameters
+        reqs = params.count { |p| p[0] == :req }
+        @cache[key] =
+          if params.any? { |p| maybe.include?(p[0]) } && args.size > reqs
+            @origin.__send__(mtd, *args[0..-2], **args.last) do |*a|
+              yield(*a) if block_given?
+            end
+          else
+            @origin.__send__(mtd, *args) do |*a|
+              yield(*a) if block_given?
+            end
+          end
+        @cache[key] = Tacky.new(@cache[key], deep: @deep) if @deep && STOP.none? { |t| @cache[key].is_a?(t) }
       end
-      @cache[args]
+      @cache[key]
     end
   end
 

data/tacky.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
   s.required_ruby_version = '>= 2.3'
   s.name = 'tacky'
-  s.version = '0.5.0'
+  s.version = '0.5.2'
   s.license = 'MIT'
   s.summary = 'Primitive Object Memoization for Ruby'
   s.description =

data/test/test_tacky.rb

@@ -21,6 +21,51 @@ class TackyTest < Minitest::Test
     assert_equal(bar.value, first)
   end
 
+  def test_passes_hash_args
+    foo = Object.new
+    def foo.value(one, two:)
+      rand(one + two)
+    end
+    bar = Tacky.new(foo)
+    first = bar.value(42, two: 1)
+    assert_equal(bar.value(42, two: 1), first)
+    refute_equal(bar.value(777, two: 1), first)
+    refute_equal(bar.value(42, two: 555), first)
+  end
+
+  def test_passes_default_hash_args
+    foo = Object.new
+    def foo.value(_one, _two: 42)
+      rand(100)
+    end
+    bar = Tacky.new(foo)
+    first = bar.value(42)
+    assert_equal(bar.value(42), first)
+    refute_equal(bar.value(0), first)
+  end
+
+  def test_passes_one_default_hash_args
+    foo = Object.new
+    def foo.value(_one: 42)
+      rand(100)
+    end
+    bar = Tacky.new(foo)
+    first = bar.value
+    assert_equal(bar.value, first)
+    refute_equal(bar.value(_one: 44), first)
+  end
+
+  def test_passes_default_args
+    foo = Object.new
+    def foo.value(_one = 42)
+      rand(100)
+    end
+    bar = Tacky.new(foo)
+    first = bar.value
+    assert_equal(bar.value, first)
+    refute_equal(bar.value(7), first)
+  end
+
   def test_deep_caching
     foo = Object.new
     def foo.child

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tacky
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.2
 platform: ruby
 authors:
 - Yegor Bugayenko