tabs 0.9.1 → 1.0.0

data/spec/lib/tabs/resolutions/week_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+
+describe Tabs::Resolutions::Week do
+  let(:timestamp){ Time.utc(2000, 1, 1) }
+  let(:beginning_of_week_timestamp){ Time.utc(1999, 12, 27) }
+
+  context "#normalize" do
+    it "should roll to the beginning of the week" do
+      expect(subject.normalize(timestamp)).to eq(beginning_of_week_timestamp)
+    end
+  end
+
+  context "#serialize" do
+    it "should return YYYY-MM-DD based on beginning of the week" do
+      expect(subject.serialize(timestamp)).to eq("1999-12-27")
+    end
+  end
+
+  context "#deserialize" do
+    it "should convert beginning of week string into date" do
+      expect(subject.deserialize("1999-12-27")).to eq(beginning_of_week_timestamp)
+    end
+  end
+end

data/spec/lib/tabs/resolutions/year_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe Tabs::Resolutions::Year do
+  let(:timestamp){ Time.utc(2000, 2) }
+
+  context "#normalize" do
+    it "should normalize the date to year, month" do
+      expect(subject.normalize(timestamp)).to eq(timestamp.change(month: 1))
+    end
+  end
+
+  context "#serialize" do
+    it "should return YYYY" do
+      expect(subject.serialize(timestamp)).to eq("2000")
+    end
+  end
+
+  context "#deserialize" do
+    it "should convert string into date" do
+      expect(subject.deserialize("2000")).to eq(timestamp.change(month: 1))
+    end
+  end
+end

data/spec/lib/tabs/storage_spec.rb

@@ -0,0 +1,138 @@
+require "spec_helper"
+
+describe Tabs::Storage do
+  context "#redis" do
+    it "should return the configured Redis" do
+      expect(subject.redis).to eq(Tabs::Config.redis)
+    end
+  end
+
+  context "#tabs_key" do
+    after do
+      Tabs::Config.prefix = nil
+    end
+
+    it "should add prefix if configued" do
+      Tabs::Config.prefix = "myapp"
+      expect(subject.tabs_key("key")).to eq("tabs:myapp:key")
+    end
+
+    it "should not add prefix if not there" do
+      expect(subject.tabs_key("key")).to eq("tabs:key")
+    end
+  end
+
+  context "with stubbed redis" do
+
+    let(:stubbed_redis) { double("redis").as_null_object }
+
+    before do
+      subject.stub(redis: stubbed_redis)
+      subject.should_receive(:tabs_key).at_least(:once).and_call_original
+    end
+
+    it "#exists calls exists with the expected key" do
+      subject.exists("foo")
+      expect(stubbed_redis).to have_received(:exists).with("tabs:foo")
+    end
+
+    it "#expireat calls expireat with expected key and timestamp" do
+      subject.expireat("foo", 1234)
+      expect(stubbed_redis).to have_received(:expireat).with("tabs:foo", 1234)
+    end
+
+    it "#ttl calls ttl with expected key" do
+      subject.ttl("foo")
+      expect(stubbed_redis).to have_received(:ttl).with("tabs:foo")
+    end
+
+    it "#get calls get with expected key" do
+      subject.get("foo")
+      expect(stubbed_redis).to have_received(:get).with("tabs:foo")
+    end
+
+    it "#mget receives prefixed keys" do
+      subject.mget("foo", "bar")
+      expect(stubbed_redis).to have_received(:mget).with("tabs:foo", "tabs:bar")
+    end
+
+    it "#set calls set with the expected key and arg" do
+      subject.set("foo", "bar")
+      expect(stubbed_redis).to have_received(:set).with("tabs:foo", "bar")
+    end
+
+    it "#del" do
+      subject.del("foo")
+      expect(stubbed_redis).to have_received(:del).with("tabs:foo")
+    end
+
+    it "#del_by_prefix" do
+      stubbed_redis.stub(keys: ["foo:a", "foo:b"])
+      subject.del_by_prefix("foo")
+      expect(stubbed_redis).to have_received(:del).with("foo:a", "foo:b")
+    end
+
+    it "#incr" do
+      subject.incr("foo")
+      expect(stubbed_redis).to have_received(:incr).with("tabs:foo")
+    end
+
+    it "#rpush" do
+      subject.rpush("foo", "bar")
+      expect(stubbed_redis).to have_received(:rpush).with("tabs:foo", "bar")
+    end
+
+    it "#sadd" do
+      subject.sadd("foo", "bar", "baz")
+      expect(stubbed_redis).to have_received(:sadd).with("tabs:foo", "bar", "baz")
+    end
+
+    it "#smembers" do
+      subject.smembers("foo")
+      expect(stubbed_redis).to have_received(:smembers).with("tabs:foo")
+    end
+
+    it "#smembers_all" do
+      stubbed_redis.should_receive(:pipelined).and_yield
+      subject.smembers_all("foo", "bar")
+      expect(stubbed_redis).to have_received(:smembers).with("tabs:foo")
+      expect(stubbed_redis).to have_received(:smembers).with("tabs:bar")
+    end
+
+    it "#sismember" do
+      subject.sismember("foo", "bar")
+      expect(stubbed_redis).to have_received(:sismember).with("tabs:foo", "bar")
+    end
+
+    it "#hget" do
+      subject.hget("foo", "bar")
+      expect(stubbed_redis).to have_received(:hget).with("tabs:foo", "bar")
+    end
+
+    it "#hset" do
+      subject.hset("foo", "bar", "baz")
+      expect(stubbed_redis).to have_received(:hset).with("tabs:foo", "bar", "baz")
+    end
+
+    it "#hdel" do
+      subject.hdel("foo", "bar")
+      expect(stubbed_redis).to have_received(:hdel).with("tabs:foo", "bar")
+    end
+
+    it "#hkeys" do
+      subject.hkeys("foo")
+      expect(stubbed_redis).to have_received(:hkeys).with("tabs:foo")
+    end
+
+    it "#hincrby" do
+      subject.hincrby("foo", "bar", 42)
+      expect(stubbed_redis).to have_received(:hincrby).with("tabs:foo", "bar", 42)
+    end
+
+    it "#hgetall" do
+      subject.hgetall("foo")
+      expect(stubbed_redis).to have_received(:hgetall).with("tabs:foo")
+    end
+
+  end
+end

data/spec/lib/tabs_spec.rb

@@ -82,7 +82,7 @@ describe Tabs do
     end
 
     it "calls drop! on the metric" do
-      metric = stub(:metric)
+      metric = double(:metric)
       Tabs.stub(get_metric: metric)
       metric.should_receive(:drop!)
       Tabs.drop_metric!("foo")
@@ -138,6 +138,7 @@ describe Tabs do
     end
 
     it "calls record on the metric" do
+      Timecop.freeze(Time.now.utc)
       metric = Tabs.create_metric("foo", "value")
       Tabs.stub(get_metric: metric)
       metric.should_receive(:record).with(42, Time.now.utc)
@@ -176,4 +177,30 @@ describe Tabs do
 
   end
 
+  describe ".drop_resolution_for_metric!" do
+    it "raises unknown metric error if metric does not exist" do
+      expect{ Tabs.drop_resolution_for_metric!(:invalid, :minute) }.to raise_error(Tabs::UnknownMetricError)
+    end
+
+    it "raises resolution missing error if resolution not registered" do
+      Tabs.create_metric("baz", "value")
+      expect{ Tabs.drop_resolution_for_metric!("baz", :invalid) }.to raise_error(Tabs::ResolutionMissingError)
+    end
+
+    it "does not allow you to call drop_by_resolution if task metric" do
+      metric = Tabs.create_metric("baz", "task")
+      metric.should_not_receive(:drop_by_resolution!)
+      Tabs.drop_resolution_for_metric!("baz", :minute)
+    end
+
+    it "drops the metric by resolution" do
+      now = Time.utc(2000,1,1)
+      metric = Tabs.create_metric("baz", "value")
+      metric.record(42, now)
+      Tabs.drop_resolution_for_metric!("baz", :minute)
+      minute_key = Tabs::Metrics::Value.new("baz").storage_key(:minute, now)
+      expect(Tabs::Storage.exists(minute_key)).to be_false
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -1,9 +1,17 @@
 require "rubygems"
 require "tabs"
-require "fakeredis/rspec"
 require "pry"
 require "timecop"
 
 RSpec.configure do |config|
   config.mock_with :rspec
+
+  config.before(:each) do
+  	Tabs::Resolution.reset_default_resolutions
+    Tabs::Storage.del_by_prefix("")
+  end
+
+  config.after(:each) do
+    Timecop.return
+  end
 end

data/spec/support/custom_resolutions.rb

@@ -1,14 +1,18 @@
 module BadlyFormedResolution
-  extend Tabs::Resolutionable
+  include Tabs::Resolutionable
   extend self
 end
 
 module WellFormedResolution
-  extend Tabs::Resolutionable
+  include Tabs::Resolutionable
   extend self
 
   PATTERN = "%Y-%m-%d-%H-%M-%S"
 
+  def name
+    :seconds
+  end
+
   def serialize(timestamp)
     timestamp.strftime(PATTERN)
   end
@@ -22,6 +26,10 @@ module WellFormedResolution
     s / 1
   end
 
+  def to_seconds
+    1
+  end
+
   def add(ts, num)
     ts + num.seconds
   end

data/tabs.gemspec

@@ -12,6 +12,7 @@ Gem::Specification.new do |gem|
   gem.description   = %q{A redis-backed metrics tracker for keeping tabs on pretty much anything ;)}
   gem.summary       = %q{A redis-backed metrics tracker for keeping tabs on pretty much anything ;)}
   gem.homepage      = "https://github.com/devmynd/tabs"
+  gem.license       = "MIT"
 
   gem.files         = `git ls-files`.split($/)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
@@ -19,33 +20,17 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
   gem.post_install_message = <<EOS
-Tabs v0.8.0 - BREAKING CHANGES:
-In version 0.8.0 and higher the get_stats method returns a more robust
-object instead of just an array of hashes.  These stats objects are
-enumerable and most existing code utilizing tabs should continue to
-function.  However, please review the docs for more information if you
-encounter issues when upgrading.  Please review the README if installing
-v0.8.0 or higher.
-
-Tabs v0.8.2 - BREAKING CHANGES:
-In version 0.8.2 and higher the storage keys for value metrics have been
-changed.  Originally the various pieces (avg, sum, count, etc) were
-stored in a JSON serialized string in a single key.  The intent was that
-this would comprise a poor-mans transaction of sorts.  The downside
-however was a major hit on performance when doing a lot of writes or
-reading stats for a large date range.  In v0.8.2 these component values
-are stored in a real Redis hash and updated atomically when a value is
-recorded.  In future versions this will be changed to use a MULTI
-statement to simulate a transaction.  Value data that was recorded prior
-to v0.8.2 will not be accessible in this or future versions so please
-continue to use v0.8.1 or lower if that is an issue.
+Tabs v1.0.0 - BREAKING CHANGES:
+Please review the 'Change Log & Breaking Changes' section of the README.  Now that we have
+achieved 1.0.0 we will follow semantic versioning and will not break backwards compatibility
+within major point releases.
 EOS
 
   gem.add_dependency "activesupport", ">= 3.2"
   gem.add_dependency "redis", "~> 3.0.0"
 
-  gem.add_development_dependency "fakeredis"
   gem.add_development_dependency "pry"
+  gem.add_development_dependency "pry-nav"
   gem.add_development_dependency "rake"
   gem.add_development_dependency "rspec"
   gem.add_development_dependency "timecop"

metadata

@@ -1,36 +1,32 @@
 --- !ruby/object:Gem::Specification
 name: tabs
 version: !ruby/object:Gem::Version
-  version: 0.9.1
-  prerelease: 
+  version: 1.0.0
 platform: ruby
 authors:
 - JC Grubbs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-27 00:00:00.000000000 Z
+date: 2013-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,89 +34,78 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: fakeredis
+  name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-nav
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: A redis-backed metrics tracker for keeping tabs on pretty much anything
@@ -158,89 +143,71 @@ files:
 - lib/tabs/storage.rb
 - lib/tabs/tabs.rb
 - lib/tabs/version.rb
+- spec/lib/tabs/config_spec.rb
 - spec/lib/tabs/metrics/counter/stats_spec.rb
 - spec/lib/tabs/metrics/counter_spec.rb
 - spec/lib/tabs/metrics/task/token_spec.rb
+- spec/lib/tabs/metrics/task_spec.rb
 - spec/lib/tabs/metrics/value/stats_spec.rb
 - spec/lib/tabs/metrics/value_spec.rb
 - spec/lib/tabs/resolution_spec.rb
-- spec/lib/tabs/task_spec.rb
+- spec/lib/tabs/resolutionable_spec.rb
+- spec/lib/tabs/resolutions/day_spec.rb
+- spec/lib/tabs/resolutions/hour_spec.rb
+- spec/lib/tabs/resolutions/minute_spec.rb
+- spec/lib/tabs/resolutions/month_spec.rb
+- spec/lib/tabs/resolutions/week_spec.rb
+- spec/lib/tabs/resolutions/year_spec.rb
+- spec/lib/tabs/storage_spec.rb
 - spec/lib/tabs_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_resolutions.rb
 - tabs.gemspec
 homepage: https://github.com/devmynd/tabs
-licenses: []
-post_install_message: ! 'Tabs v0.8.0 - BREAKING CHANGES:
-
-  In version 0.8.0 and higher the get_stats method returns a more robust
-
-  object instead of just an array of hashes.  These stats objects are
-
-  enumerable and most existing code utilizing tabs should continue to
-
-  function.  However, please review the docs for more information if you
-
-  encounter issues when upgrading.  Please review the README if installing
-
-  v0.8.0 or higher.
-
-
-  Tabs v0.8.2 - BREAKING CHANGES:
-
-  In version 0.8.2 and higher the storage keys for value metrics have been
-
-  changed.  Originally the various pieces (avg, sum, count, etc) were
-
-  stored in a JSON serialized string in a single key.  The intent was that
-
-  this would comprise a poor-mans transaction of sorts.  The downside
-
-  however was a major hit on performance when doing a lot of writes or
-
-  reading stats for a large date range.  In v0.8.2 these component values
-
-  are stored in a real Redis hash and updated atomically when a value is
-
-  recorded.  In future versions this will be changed to use a MULTI
-
-  statement to simulate a transaction.  Value data that was recorded prior
-
-  to v0.8.2 will not be accessible in this or future versions so please
-
-  continue to use v0.8.1 or lower if that is an issue.
-
-'
+licenses:
+- MIT
+metadata: {}
+post_install_message: |
+  Tabs v1.0.0 - BREAKING CHANGES:
+  Please review the 'Change Log & Breaking Changes' section of the README.  Now that we have
+  achieved 1.0.0 we will follow semantic versioning and will not break backwards compatibility
+  within major point releases.
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A redis-backed metrics tracker for keeping tabs on pretty much anything ;)
 test_files:
+- spec/lib/tabs/config_spec.rb
 - spec/lib/tabs/metrics/counter/stats_spec.rb
 - spec/lib/tabs/metrics/counter_spec.rb
 - spec/lib/tabs/metrics/task/token_spec.rb
+- spec/lib/tabs/metrics/task_spec.rb
 - spec/lib/tabs/metrics/value/stats_spec.rb
 - spec/lib/tabs/metrics/value_spec.rb
 - spec/lib/tabs/resolution_spec.rb
-- spec/lib/tabs/task_spec.rb
+- spec/lib/tabs/resolutionable_spec.rb
+- spec/lib/tabs/resolutions/day_spec.rb
+- spec/lib/tabs/resolutions/hour_spec.rb
+- spec/lib/tabs/resolutions/minute_spec.rb
+- spec/lib/tabs/resolutions/month_spec.rb
+- spec/lib/tabs/resolutions/week_spec.rb
+- spec/lib/tabs/resolutions/year_spec.rb
+- spec/lib/tabs/storage_spec.rb
 - spec/lib/tabs_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_resolutions.rb
-has_rdoc: