tabs 0.5.3 → 0.5.4

data/lib/tabs/tabs.rb

@@ -19,20 +19,18 @@ module Tabs
     Config.redis
   end
 
-  def increment_counter(key)
-    raise UnknownMetricError.new("Unknown metric: #{key}") unless metric_exists?(key)
-    raise MetricTypeMismatchError.new("Only counter metrics can be incremented") unless metric_type(key) == "counter"
-    get_metric(key).increment
+  def config
+    Config
   end
 
-  def counter_total(key, period=nil)
-    raise UnknownMetricError.new("Unknown metric: #{key}") unless metric_exists?(key)
+  def increment_counter(key)
+    create_metric(key, "counter") unless metric_exists?(key)
     raise MetricTypeMismatchError.new("Only counter metrics can be incremented") unless metric_type(key) == "counter"
-    get_metric(key).total
+    get_metric(key).increment
   end
 
   def record_value(key, value)
-    raise UnknownMetricError.new("Unknown metric: #{key}") unless metric_exists?(key)
+    create_metric(key, "value") unless metric_exists?(key)
     raise MetricTypeMismatchError.new("Only value metrics can record a value") unless metric_type(key) == "value"
     get_metric(key).record(value)
   end
@@ -51,6 +49,12 @@ module Tabs
     metric_klass(type).new(key)
   end
 
+  def counter_total(key, period=nil)
+    raise UnknownMetricError.new("Unknown metric: #{key}") unless metric_exists?(key)
+    raise MetricTypeMismatchError.new("Only counter metrics can be incremented") unless metric_type(key) == "counter"
+    get_metric(key).total
+  end
+
   def get_stats(key, period, resolution)
     raise UnknownMetricError.new("Unknown metric: #{key}") unless metric_exists?(key)
     metric = get_metric(key)

data/lib/tabs/version.rb

@@ -1,3 +1,3 @@
 module Tabs
-  VERSION = "0.5.3"
+  VERSION = "0.5.4"
 end

data/spec/lib/tabs_spec.rb

@@ -87,15 +87,17 @@ describe Tabs do
 
   describe "#increment_counter" do
 
-    it "raises an Tabs::UnknownMetricError if the metric does not exist" do
-      lambda { Tabs.increment_counter("foo") }.should raise_error(Tabs::UnknownMetricError)
-    end
-
     it "raises a Tabs::MetricTypeMismatchError if the metric is the wrong type" do
       Tabs.create_metric("foo", "value")
       lambda { Tabs.increment_counter("foo") }.should raise_error(Tabs::MetricTypeMismatchError)
     end
 
+    it "creates the metric if it doesn't exist" do
+      expect(Tabs.metric_exists?("foo")).to be_false
+      lambda { Tabs.increment_counter("foo") }.should_not raise_error
+      expect(Tabs.metric_exists?("foo")).to be_true
+    end
+
     it "calls increment on the metric" do
       metric = Tabs.create_metric("foo", "counter")
       Tabs.stub(get_metric: metric)
@@ -105,10 +107,12 @@ describe Tabs do
 
   end
 
-  describe "#increment_counter" do
+  describe "#record_value" do
 
-    it "raises an Tabs::UnknownMetricError if the metric does not exist" do
-      lambda { Tabs.record_value("foo", 27) }.should raise_error(Tabs::UnknownMetricError)
+    it "creates the metric if it doesn't exist" do
+      expect(Tabs.metric_exists?("foo")).to be_false
+      lambda { Tabs.record_value("foo", 38) }.should_not raise_error
+      expect(Tabs.metric_exists?("foo")).to be_true
     end
 
     it "raises a Tabs::MetricTypeMismatchError if the metric is the wrong type" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tabs
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
   prerelease: 
 platform: ruby
 authors: