tablesmith 0.4.0 → 0.6.2

data/spec/array_table_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'Array Source' do
@@ -9,6 +11,71 @@ describe 'Array Source' do
       | d | e | f |
       +---+---+---+
     TABLE
-    [%w(a b c), %w(d e f)].to_table.text_table.to_s.should == expected
+    [%w[a b c], %w[d e f]].to_table.to_s.should == expected
+  end
+
+  def do_just_works_test(meth_id)
+    orig_stdout = $stdout
+    sio = StringIO.new
+    $stdout = sio
+    send(meth_id, [%w[a b c], %w[d e f]].to_table)
+    sio.string
+  ensure
+    $stdout = orig_stdout
+  end
+
+  def just_works(meth_id)
+    expected = <<~TABLE
+      +---+---+---+
+      | a | b | c |
+      +---+---+---+
+      | d | e | f |
+      +---+---+---+
+    TABLE
+
+    actual = do_just_works_test(meth_id)
+    actual.should == expected
+  end
+
+  it 'just works with print' do
+    just_works(:print)
+  end
+
+  it 'just works with puts' do
+    just_works(:puts)
+  end
+
+  it 'just works with p' do
+    expected = <<~TABLE
+      +---+---+---+
+      | a | b | c |
+      +---+---+---+
+      | d | e | f |
+      +---+---+---+
+    TABLE
+
+    actual = do_just_works_test(:p)
+    actual.should == "#{expected}\n"
+  end
+
+  it 'just works with inspect' do
+    expected = <<~TABLE
+      +---+---+---+
+      | a | b | c |
+      +---+---+---+
+      | d | e | f |
+      +---+---+---+
+    TABLE
+    [%w[a b c], %w[d e f]].to_table.inspect.should == expected
+  end
+
+  it 'just works with inspect two element integer array' do
+    expected = <<~TABLE
+      +---+
+      | 1 |
+      | 3 |
+      +---+
+    TABLE
+    [1, 3].to_table.inspect.should == expected
   end
-end
+end

data/spec/fixtures.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record'
 
 ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'

data/spec/hash_rows_table_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'HashRowsSource' do
@@ -9,7 +11,7 @@ describe 'HashRowsSource' do
       | 1 | 2 |
       +---+---+
     TABLE
-    [{a: 1, b: 2}].to_table.text_table.to_s.should == expected
+    [{ a: 1, b: 2 }].to_table.to_s.should == expected
   end
 
   it 'outputs text table of hash row with nested Array' do
@@ -20,7 +22,7 @@ describe 'HashRowsSource' do
       | 1 | [1, 2] |
       +---+--------+
     TABLE
-    [{a: 1, b: [1, 2]}].to_table.text_table.to_s.should == expected
+    [{ a: 1, b: [1, 2] }].to_table.to_s.should == expected
   end
 
   it 'outputs text table of hash row with nested Hash' do
@@ -31,7 +33,7 @@ describe 'HashRowsSource' do
       | 1 | {:c=>3} |
       +---+---------+
     TABLE
-    [{a: 1, b: {c: 3}}].to_table.text_table.to_s.should == expected
+    [{ a: 1, b: { c: 3 } }].to_table.to_s.should == expected
   end
 
   it 'outputs text table of mixed columns hash rows with default columns' do
@@ -44,12 +46,14 @@ describe 'HashRowsSource' do
       +---+---+---+
     TABLE
     [
-      {a: 1, b: 2},
-      {a: 2, c: '!'}
-    ].to_table.text_table.to_s.should == expected
+      { a: 1, b: 2 },
+      { a: 2, c: '!' }
+    ].to_table.to_s.should == expected
   end
 
   it 'outputs text table of deep hash rows with defined columns' do
+    pending
+
     expected = <<~TABLE
       +---+---+---+
       | a |   b   |
@@ -59,19 +63,18 @@ describe 'HashRowsSource' do
       | 1 | 2 | 2 |
       +---+---+---+
     TABLE
-    b = [{a: 1, b: {c: 2, d: 2}}].to_table
+    b = [{ a: 1, b: { c: 2, d: 2 } }].to_table
     def b.columns
       [
         Column.new(name: :a),
-        {b: [
+        { b: [
           Column.new(name: :c)
-        ]}
+        ] }
       ]
     end
 
     # this would be nice.
-    # b.text_table.to_s.should == expected
-    pending
+    b.to_s.should == expected
   end
 
   it 'keeps OrderedHash keys in order' do
@@ -85,7 +88,7 @@ describe 'HashRowsSource' do
       | 2 | 1 |
       +---+---+
     TABLE
-    h.to_table.text_table.to_s.should == expected
+    h.to_table.to_s.should == expected
   end
 
   it 'outputs text table of deep hash rows with default columns'

data/spec/hash_table_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'Hash Source' do
@@ -11,4 +13,24 @@ describe 'Hash Source' do
     TABLE
     {a: 1, b: 2, c: 3}.to_table.text_table.to_s.should == expected
   end
-end
+
+  it 'just works with print' do
+    expected = <<~TABLE
+      +---+---+---+
+      | a | b | c |
+      +---+---+---+
+      | 1 | 2 | 3 |
+      +---+---+---+
+    TABLE
+
+    begin
+      orig_stdout = $stdout
+      sio = StringIO.new
+      $stdout = sio
+      print({a: 1, b: 2, c: 3}.to_table)
+      sio.string.should == expected
+    ensure
+      $stdout = orig_stdout
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,7 @@
-require File.expand_path('../../lib/tablesmith', __FILE__)
+# frozen_string_literal: true
 
-require File.expand_path('../fixtures', __FILE__)
+require File.expand_path('../lib/tablesmith', __dir__)
+
+require File.expand_path('fixtures', __dir__)
+
+RSpec.configuration.expect_with(:rspec) { |c| c.syntax = :should }

data/spec/table_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-include Tablesmith
+include Tablesmith # rubocop:disable Style/MixinUsage:
 
 describe Table do
-  it 'should subclass array' do
+  it 'should delegate to the internal array' do
     b = Table.new
     b.length.should == 0
     b << 1
@@ -13,12 +15,17 @@ describe Table do
     b.class.should == Table
   end
 
-  it 'should pass unmatched Array messages to all items' do
+  it 'should no longer pass unmatched Array messages to all items' do
+    # earlier pre-1.0 versions implemented method_missing in order to provide
+    # syntactic sugar for calling map on the underlying Array. But as time went
+    # on, it felt too heavy-handed and not worth it.
+
     b = Table.new
     b.length.should == 0
     b << 1
     b << '2'
-    b.to_i.should == [1, 2]
+    b.map(&:to_i).should == [1, 2]
+    -> { b.to_i }.should raise_error(NoMethodError)
   end
 
   it 'should handle empty Array' do
@@ -27,11 +34,11 @@ describe Table do
       | (empty) |
       +---------+
     TEXT
-    [].to_table.text_table.to_s.should == expected
+    [].to_table.to_s.should == expected
   end
 
   it 'should handle a simple two row Array' do
-    a = [%w(a b c), %w(d e f)]
+    a = [%w[a b c], %w[d e f]]
     actual = a
     expected = <<~TABLE
       +---+---+---+
@@ -40,11 +47,11 @@ describe Table do
       | d | e | f |
       +---+---+---+
     TABLE
-    actual.to_table.text_table.to_s.should == expected
+    actual.to_table.to_s.should == expected
   end
 
   it 'should output csv' do
-    a = [['a', 'b,s', 'c'], %w(d e f)]
+    a = [['a', 'b,s', 'c'], %w[d e f]]
     actual = a
     expected = <<~TABLE
       a,"b,s",c
@@ -54,7 +61,7 @@ describe Table do
   end
 
   it 'should output html' do
-    actual = [%w[a b c], %w[d e f]]
+    actual = [%w[a b c], %w[d e f], %w[g h i]]
     expected = <<~TABLE
       <table>
           <thead>
@@ -70,6 +77,11 @@ describe Table do
               <td>e</td>
               <td>f</td>
           </tr>
+          <tr>
+              <td>g</td>
+              <td>h</td>
+              <td>i</td>
+          </tr>
           </tbody>
       </table>
     TABLE

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tablesmith
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.6.2
 platform: ruby
 authors:
 - chrismo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-28 00:00:00.000000000 Z
+date: 2020-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: text-table
@@ -30,16 +30,16 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,35 +53,63 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +123,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: rubocop_lineup
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -108,6 +164,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.6
 description: Minimal console table
 email:
 - chrismo@clabs.org
@@ -115,18 +199,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".rubocop.yml"
-- ".ruby-version"
-- ".travis.yml"
-- Gemfile
-- LICENSE
-- README.md
-- Rakefile
 - lib/tablesmith.rb
 - lib/tablesmith/active_record_source.rb
 - lib/tablesmith/array_rows_source.rb
+- lib/tablesmith/delegated_array_class.rb
 - lib/tablesmith/hash_rows_base.rb
 - lib/tablesmith/hash_rows_source.rb
 - lib/tablesmith/html_formatter.rb
@@ -139,7 +215,6 @@ files:
 - spec/hash_table_spec.rb
 - spec/spec_helper.rb
 - spec/table_spec.rb
-- tablesmith.gemspec
 homepage: http://github.com/livingsocial/tablesmith
 licenses: []
 metadata: {}
@@ -158,8 +233,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Minimal console table