table_warnings 0.0.2 → 0.0.3

data/lib/table_warnings/version.rb

@@ -1,3 +1,3 @@
 module TableWarnings
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/table_warnings/warning/blank.rb

@@ -1,20 +1,22 @@
 module TableWarnings
   class Warning
     class Blank < Warning
-      attr_reader :column_name
+      def column_name
+        @column_name.to_s
+      end
       
-      def effective_column_names
-        if column_name
-          [column_name]
+      def columns_hash
+        if column_name.present?
+          table.columns_hash.slice column_name
         else
-          table.column_names
+          table.columns_hash
         end
       end
       
       def messages
-        effective_column_names.map do |c|
-          if table.count(:conditions => { c => ''}) > 0 or table.count(:conditions => { c => nil }) > 0
-            "There are blanks in the `#{c}` column."
+        columns_hash.map do |_, c|
+          if table.count(:conditions => { c.name => nil }) > 0 or (c.text? and table.count(:conditions => [ "TRIM(#{table.quoted_table_name}.#{c.name}) = ''"]) > 0)
+            "There are blanks in the `#{c.name}` column."
           end
         end
       end

data/test/test_table_warnings.rb

@@ -13,21 +13,31 @@ class AutomobileFuelType < ActiveRecord::Base
   warn_unless_size_is 1..6
 end
 
-AutomobileMake.create! :name => '', :fuel_efficiency => nil, :fuel_efficiency_units => 'kilometres_per_litre'
-AutomobileMake.create! :name => 'Alfa Romeo', :fuel_efficiency => 10.4075, :fuel_efficiency_units => 'kilometres_per_litre'
-
-AutomobileFuelType.create! :name => 'gas'
-AutomobileFuelType.create! :name => 'diesel'
-
 class TestTableWarnings < Test::Unit::TestCase
-  def test_warn_for_blanks_in_specific_columns
+  def setup
+    AutomobileMake.delete_all
+    AutomobileFuelType.delete_all
+  end
+  
+  def test_001_warn_for_blanks_in_specific_columns
+    AutomobileMake.create! :name => '       ', :fuel_efficiency => nil, :fuel_efficiency_units => 'kilometres_per_litre'
+    AutomobileMake.create! :name => 'Alfa Romeo', :fuel_efficiency => 10.4075, :fuel_efficiency_units => 'kilometres_per_litre'
     assert AutomobileMake.table_warnings.one? { |w| w =~ /blanks in.*name.*column/ }
     assert AutomobileMake.table_warnings.one? { |w| w =~ /blanks in.*fuel_efficiency.*column/ }
   end
-  def test_warn_of_size
+  
+  def test_002_warn_of_size
+    assert_equal 0, AutomobileMake.count
     assert AutomobileMake.table_warnings.many? { |w| w =~ /expected.*size/ }
   end
-  def test_warn_for_blanks_in_any_column
+
+  def test_003_warn_for_blanks_in_any_column
+    AutomobileFuelType.create! :name => 'gas'
     assert AutomobileFuelType.table_warnings.one? { |w| w =~ /blanks in.*code.*column/ }
   end
+
+  def test_004_dont_treat_0_as_blank
+    AutomobileMake.create! :name => 'Acme', :fuel_efficiency => 0
+    assert !AutomobileMake.table_warnings.any? { |w| w =~ /blanks in.*fuel_efficiency.*column/ }
+  end
 end

metadata

@@ -1,77 +1,58 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: table_warnings
-version: !ruby/object:Gem::Version 
-  hash: 27
-  prerelease: false
-  segments: 
-  - 0
-  - 0
-  - 2
-  version: 0.0.2
+version: !ruby/object:Gem::Version
+  version: 0.0.3
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Seamus Abshere
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-02-18 00:00:00 -06:00
+date: 2011-06-22 00:00:00.000000000 -05:00
 default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+dependencies:
+- !ruby/object:Gem::Dependency
   name: fastercsv
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2155025560 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: earth
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *2155025560
+- !ruby/object:Gem::Dependency
+  name: earth
+  requirement: &2155025060 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        hash: 5
-        segments: 
-        - 0
-        - 3
-        - 11
+    requirements:
+    - - =
+      - !ruby/object:Gem::Version
         version: 0.3.11
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: activerecord
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *2155025060
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: &2155024640 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id003
-description: Validate an entire [ActiveRecord] table, checking for things like blank rows or total number of rows
-email: 
+  prerelease: false
+  version_requirements: *2155024640
+description: Validate an entire [ActiveRecord] table, checking for things like blank
+  rows or total number of rows
+email:
 - seamus@abshere.net
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - Gemfile
 - README.rdoc
@@ -88,37 +69,29 @@ files:
 has_rdoc: true
 homepage: https://github.com/seamusabshere/table_warnings
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: table_warnings
-rubygems_version: 1.3.7
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
-summary: It's called validations to remind people of per-record validations, but it works on the table, and is meant to be used after a table is completely populated.
-test_files: 
+summary: It's called validations to remind people of per-record validations, but it
+  works on the table, and is meant to be used after a table is completely populated.
+test_files:
 - test/helper.rb
 - test/test_table_warnings.rb