table_sync 5.1.0 → 6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e2da80dd5ebdacac4e255dd9aacae603e6c76c5f52677db25fab0e1bb0dc15e
-  data.tar.gz: 6edc6c7805c4f9eea01b43fb14dc3bb19e3af906a1016b2308350077935c911a
+  metadata.gz: 7854c781cde972c7dc2d12266f5c9f302e4a9a6b2ae4cfea8215c13bfb9dc326
+  data.tar.gz: dd87d2bc24ec62be162375352cd4f18fa1e0363f80cae49295dc2448d6c97aba
 SHA512:
-  metadata.gz: 3b2981462066a389651bef3be1a8301ce165d9b25298b0b912f3002a27daef1e566dc932dbe2aa5c89c70806457449c5c189949fd10c4d9efabf69ba37ee5627
-  data.tar.gz: 47c419f7dbdcfc4e8517604b4df14aaccf40d67eb2071e5991a6ccf211d6698735c22aad2cfba339b2d1b9d7b45405d7071b04045ac94c17fb8f8dd379d4eeaf
+  metadata.gz: 53d28d64907a36913b49a274246b096880be2be13767d639c9ed3e3e7951ba9595c1e548db4b09223ad41c0f36ef536b6ab13fd961ef2b11e2be1b769b12ce05
+  data.tar.gz: cc562e11bfdb74e3049857c96d428222d2c039ebf3808651f741ce20bdc969f57aca8a883ee568e33d06206303b5b4f54b8d6e4ca91e285c0ff63388653dfb3f

data/CHANGELOG.md

@@ -1,6 +1,48 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [6.0.0] - 2021-10-15
+### Added
+
+- A lot of specs for all the refactoring.
+- Docs
+- 100% coverage
+
+### Changed
+- Heavy refactoring of Publisher and BatchPublisher.
+All code is separated in different modules and classes.
+
+1. Job callables are now called:
+- single_publishing_job_class_callable
+- batch_publishing_job_class_callable
+
+2. Now there are three main classes for messaging:
+- TableSync::Publishing::Single - sends one row with initialization
+- TableSync::Publishing::Batch  - sends batch of rows with initialization
+- TableSync::Publishing::Raw    - sends raw data without checks
+
+Separate classes for publishing, object data, Rabbit params, debounce, serialization.
+
+3. Jobs are not constrained by being ActiveJob anymore. Just need to have #perform_at method
+
+4. Changed some method names towards consistency:
+- attrs_for_routing_key -> attributes_for_routing_key
+- attrs_for_metadata    -> attributes_for_headers
+
+5. Moved TableSync setup into separate classes.
+
+6. Changed ORMAdapters.
+
+7. Destroyed objects are initialized. 
+Now custom attributes for destruction will be called on instances.
+- Obj.table_sync_destroy_attributes() -> Obj#attributes_for_destroy
+
+8. Event constants are now kept in one place.
+
+### Removed
+
+- Plugin Errors
+
 ## [5.1.0] - 2021-09-09
 
 ### Changed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    table_sync (5.1.0)
+    table_sync (6.0)
       memery
       rabbit_messaging
       rails
@@ -98,7 +98,7 @@ GEM
       nokogiri (>= 1.5.9)
     mail (2.7.1)
       mini_mime (>= 0.1.1)
-    marcel (1.0.1)
+    marcel (1.0.2)
     memery (1.4.1)
       ruby2_keywords (~> 0.0.2)
     method_source (1.0.0)
@@ -106,7 +106,7 @@ GEM
     mini_portile2 (2.6.1)
     minitest (5.14.4)
     nio4r (2.5.8)
-    nokogiri (1.12.4)
+    nokogiri (1.12.5)
       mini_portile2 (~> 2.6.1)
       racc (~> 1.4)
     parallel (1.20.1)

data/README.md

@@ -22,6 +22,9 @@ require 'table_sync'
 
 - [Message protocol](docs/message_protocol.md)
 - [Publishing](docs/publishing.md)
+    - [Publishers](docs/publishing/publishers.md)
+    - [Configuration](docs/publishing/configuration.md)
+    - [Manual Sync (examples)](docs/publishing/manual.md)
 - [Receiving](docs/receiving.md)
 - [Notifications](docs/notifications.md)
 

data/docs/publishing/configuration.md

@@ -0,0 +1,143 @@
+# Configuration
+
+Customization, configuration and other options.
+
+## Model Customization
+
+There are methods you can define on a synched model to customize published messages for it.
+
+### `#attributes_for_sync`
+
+Models can implement `#attributes_for_sync` to override which attributes are published for `update` and `create` events. If not present, all attributes are published.
+
+### `#attributes_for_destroy`
+
+Models can implement `#attributes_for_destroy` to override which attributes are published for `destroy` events. If not present, `needle` (primary key) is published.
+
+### `#attributes_for_routing_key`
+
+Models can implement `#attributes_for_routing_key` to override which attributes are given to the `routing_key_callable`. If not present, published attributes are given.
+
+### `#attributes_for_headers`
+
+Models can implement `#attributes_for_headers` to override which attributes are given to the `headers_callable`. If not present, published attributes are given.
+
+### `.table_sync_model_name`
+
+Models can implement `.table_sync_model_name` class method to override the model name used for publishing events. Default is a model class name.
+
+## Callables
+
+Callables are defined once. TableSync will use them to dynamically resolve things like jobs, routing_key and headers.
+
+### Single publishing job (required for automatic and delayed publishing)
+
+- `TableSync.single_publishing_job_class_callable` is a callable which should resolve to a class that calls TableSync back to actually publish changes.
+
+It is expected to have `.perform_at(hash_with_options)` and it will be passed a hash with the following keys:
+
+- `original_attributes` - serialized `original_attributes`
+- `object_class` - model name
+- `debounce_time` - pause between publishing messages
+- `event` - type of event that happened to synched entity
+- `perform_at` - time to perform the job at (depends on debounce)
+
+Example:
+
+```ruby
+TableSync.single_publishing_job_class_callable = -> { TableSync::Job }
+
+class TableSync::Job < ActiveJob::Base
+  def perform(jsoned_attributes)
+    TableSync::Publishing::Single.new(
+      JSON.parse(jsoned_attributes),
+    ).publish_now
+  end
+
+  def self.perform_at(attributes)
+    set(wait_until: attributes.delete(:perform_at))
+      .perform_later(attributes.to_json)
+  end
+end
+
+# will enqueue the job described above
+
+TableSync::Publishing::Single.new(
+  object_class: "User",
+  original_attributes: { id: 1, name: "Mark" }, # will be serialized!
+  debounce_time: 60,
+  event: :update,
+).publish_later
+```
+
+### Batch publishing job (required only for `TableSync::Publishing::Batch#publish_later`)
+
+- `TableSync.batch_publishing_job_class_callable` is a callable which should resolve to a class that calls TableSync back to actually publish changes.
+
+It is expected to have `.perform_later(hash_with_options)` and it will be passed a hash with the following keys:
+
+- `original_attributes` - array of serialized `original_attributes`
+- `object_class` - model name
+- `event` - type of event that happened to synched entity
+- `routing_key` - custom routing_key (optional)
+- `headers` - custom headers (optional)
+
+More often than not this job is not very useful, since it makes more sense to use `#publish_now` from an already existing job that does a lot of things (not just publishing messages).
+
+### Example
+
+```ruby
+TableSync.batch_publishing_job_class_callable = -> { TableSync::BatchJob }
+
+class TableSync::BatchJob < ActiveJob::Base
+  def perform(jsoned_attributes)
+    TableSync::Publishing::Batch.new(
+      JSON.parse(jsoned_attributes),
+    ).publish_now
+  end
+
+  def self.perform_later(attributes)
+    super(attributes.to_json)
+  end
+end
+
+TableSync::Publishing::Batch.new(
+  object_class: "User",
+  original_attributes: [{ id: 1, name: "Mark" }, { id: 2, name: "Bob" }], # will be serialized!
+  event: :create,
+  routing_key: :custom_key,   # optional
+  headers: { type: "admin" }, # optional
+).publish_later
+```
+
+### Routing key callable (required)
+
+- `TableSync.routing_key_callable` is a callable that resolves which routing key to use when publishing changes. It receives object class and published attributes or `#attributes_for_routing_key` (if defined).
+
+Example:
+
+```ruby
+TableSync.routing_key_callable = -> (klass, attributes) { klass.gsub('::', '_').tableize }
+```
+
+### Headers callable (required)
+
+- `TableSync.headers_callable` is a callable that adds RabbitMQ headers which can be used in routing. It receives object class and published attributes or `#attributes_for_headers` (if defined).
+
+One possible way of using it is defining a headers exchange and routing rules based on key-value pairs (which correspond to sent headers).
+
+Example:
+
+```ruby
+TableSync.routing_metadata_callable = -> (klass, attributes) { attributes.slice("project_id") }
+```
+
+## Other
+
+- `TableSync.exchange_name` defines the exchange name used for publishing (optional, falls back to default Rabbit gem configuration).
+
+- `TableSync.notifier` is a module that provides publish and recieve notifications.
+
+- `TableSync.raise_on_empty_message` - raises an error on empty message if set to true.
+
+- `TableSync.orm` - set ORM (ActiveRecord or Sequel) used to process given entities. Required!

data/docs/publishing/manual.md

@@ -0,0 +1,155 @@
+# Manual Sync
+
+There are two ways you can manually publish large amounts of data.
+
+### `TableSync::Publishing:Batch`
+
+Easier to use, but does a lot of DB queries. May filter out invalid PK values.
+
+#### Pros:
+
+- requires less work
+- it will automatically use methods for data customization (`#attributes_for_sync`, `#attributes_for_destroy`)
+- you can be sure that data you publish is valid (more or less)
+- serializes values for (`#publish_later`)
+
+#### Cons:
+
+- it queries database for each entity in batch (for `create` and `update`)
+- it may also do a lot of queries if `#attributes_for_sync` contains additional data from other connected entities
+- serializes values for (`#publish_later`); if your PK contains invalid values (ex. Date) they will be filtered out
+
+### `TableSync::Publishing:Raw`
+
+More complex to use, but requires very few DB queries.
+You are responsible for the data you send!
+
+#### Pros:
+
+- very customizable; only requirement - `object_class` must exist
+- you can send whatever data you want
+
+#### Cons:
+
+- you have to manually prepare data for publishing
+- you have to be really sure you are sending valid data
+
+## Tips
+
+- **Don't make data batches too large!**
+
+It may result in failure to process them. Good rule is to send approx. 5000 rows in one batch.
+
+- **Make pauses between publishing data batches!**
+
+Publishing without pause may overwhelm the receiving side. Either their background job processor (ex. Sidekiq) may clog with jobs, or their consumers may not be able to get messages from Rabbit server fast enough.
+
+1 or 2 seconds is a good wait period.
+
+- **Do not use `TableSync::Publishing:Single` to send millions or even thousands of rows of data.**
+
+Or just calling update on rows with automatic sync.
+It WILL overwhelm the receiving side. Especially if they have some additional receiving logic.
+
+- **On the receiving side don't create job with custom logic (if it exists) for every row in a batch.**
+
+Better to process it whole. Otherwise three batches of 5000 will result in 15000 new jobs.
+
+- **Send one test batch before publishing the rest of the data.**
+
+Make sure it was received properly. This way you won't send a lot invalid messages.
+
+- **Check the other arguments.**
+
+    - Ensure the routing_key is correct if you are using a custom one. Remember, that batch publishing ignores `#attributes_for_routing_key` on a model.
+    - Ensure that `object_class` is correct. And it belongs to entities you want to send.
+    - Ensure that you chose the correct event.
+    - If you have some logic depending on headers, ensure they are also correct. Remember, that batch publishing ignores `#attributes_for_headers` on a model.
+
+- **You can check what you send before publishing with:**
+
+```ruby
+TableSync::Publishing:Batch.new(...).message.message_params
+
+TableSync::Publishing:Raw.new(...).message.message_params
+```
+
+## Examples
+
+### `TableSync::Publishing:Raw`
+
+```ruby
+  # For Sequel
+  # gem 'sequel-batches' or equivalent that will allow you to chunk data somehow
+  # or #each_page from Sequel
+
+  # this is a simple query
+  # they can be much more complex, with joins and other things
+  # just make sure that it results in a set of data you expect
+  data = User.in_batches(of: 5000).naked.select(:id, :name, :email)
+
+  data.each_with_index do |batch, i|
+    TableSync::Publishing::Raw.new(
+      object_class: "User",
+      original_attributes: batch,
+      event: :create,
+      routing_key: :custom_key,   # optional
+      headers: { type: "admin" }, # optional
+    ).publish_now
+
+    # make a pause between batches
+    sleep 1
+
+    # for when you are sending from terminal
+    # allows you to keep an eye on progress
+    # you can create more complex output
+    puts "Batch #{i} sent!"
+  end
+
+```
+
+#### Another way to gather data
+
+If you don't want to create a data query (maybe it's too complex) but there is a lot of quereing in `#attributes_for_sync` and you are willing to trade a little bit of perfomance, you can try the following.
+
+```ruby
+class User < Sequel
+  one_to_many :user_info
+
+  # For example our receiving side wants to know the ips user logged in under
+  # But doesn't want to sync the user_info
+  def attributes_for_sync
+    attributes.merge(
+      ips: user_info.ips
+    )
+  end
+end
+
+# to prevent the need to query for every piece of additional data we can user eager load
+# and construct published data by calling #attributes_for_sync
+# don't forget to chunk it into more managable sizes before trying to send
+data = User.eager(:statuses).map { |user| user.attributes_for_sync }
+```
+This way it will not make unnecessary queries.
+
+### `TableSync::Publishing::Batch`
+
+Remember, it will query or initialize each row.
+
+```ruby
+  # You can just send ids.
+  data = User.in_batches(of: 5000).naked.select(:id)
+
+  data.each_with_index do |data, i|
+    TableSync::Publishing::Batch.new(
+      object_class: "User",
+      original_attributes: data,
+      event: :create,
+      routing_key: :custom_key,   # optional
+      headers: { type: "admin" }, # optional
+    ).publish_now
+
+    sleep 1
+    puts "Batch #{i} sent!"
+  end
+```

data/docs/publishing/publishers.md

@@ -0,0 +1,162 @@
+# Publishers
+
+There are three publishers you can use to send data.
+
+- `TableSync::Publishing::Single` - sends one row with initialization.
+- `TableSync::Publishing::Batch` - sends a batch of rows with initialization.
+- `TableSync::Publishing::Raw`  - sends raw data without checks.
+
+## Single
+
+`TableSync::Publishing::Single` - sends one row with initialization.
+
+This is a publisher called by `TableSync.sync(self)`.
+
+### Expected parameters:
+
+- `object_class` - class (model) used to initialize published object
+- `original_attributes` - attributes used to initialize `object_class` with
+- `debounce_time` - minimum allowed time between delayed publishings
+- `event` - type of event that happened to the published object (`create`, `update`, `destroy`); `update` by default
+
+### What it does (when uses `#publish_now`):
+- takes in the `original_attributes`, `object_class`, `event`
+- constantizes `object_class`
+- extracts the primary key (`needle`) of the `object_class` from the `original_attributes`
+- queries the database for the object with the `needle` (for `update` and `create`) or initializes the `object_class` with `original_attributes` (for `destroy`)
+- constructs routing_key using `routing_key_callable` and `#attributes_for_routing_key` (if defined)
+- constructs headers using `headers_callable` and `#attributes_for_headers` (if defined)
+- publishes Rabbit message (uses attributes from queried/initialized object as data)
+- sends notification (if set up)
+
+### What it does (when uses `#publish_later`):
+- takes in the `original_attributes`, `object_class`, `debounce_time`, `event`
+- serializes the `original_attributes`, silently filters out unserializable keys/values
+- enqueues (or skips) the job with the `serialized_original_attributes` to be performed in time according to debounce
+- job (if enqueued) calls `TableSync::Publishing::Single#publish_now` with `serialized_original_attributes` and the same `object_class`, `debounce_time`, `event`
+
+### Serialization
+
+Currently allowed key/values are:
+  `NilClass`, `String`, `TrueClass`, `FalseClass`, `Numeric`, `Symbol`.
+
+### Job
+
+Job is defined in `TableSync.single_publishing_job_class_callable` as a proc. Read more in [Configuration](docs/publishing/configuration.md).
+
+### Example #1 (send right now)
+
+```ruby
+  TableSync::Publishing::Single.new(
+    object_class: "User",
+    original_attributes: { id: 1, name: "Mark" },
+    debounce_time: 60, # useless for #publish _now, can be skipped
+    event: :create,
+  ).publish_now
+```
+
+### Example #2 (enqueue job)
+
+```ruby
+  TableSync::Publishing::Single.new(
+    object_class: "User",
+    original_attributes: { id: 1, name: "Mark" }, # will be serialized!
+    debounce_time: 60,
+    event: :update,
+  ).publish_later
+```
+
+## Batch
+
+- `TableSync::Publishing::Batch` - sends a batch of rows with initialization.
+
+### Expected parameters:
+
+- `object_class` - class (model) used to initialize published objects
+- `original_attributes` - array of attributes used to initialize `object_class` with
+- `event` - type of event that happened to the published objects (`create`, `update`, `destroy`); `update` by default
+- `routing_key` - custom routing_key
+- `headers` - custom headers
+
+### What it does (when uses `#publish_now`):
+- takes in the `original_attributes`, `object_class`, `event`, `routing_key`, `headers`
+- constantizes `object_class`
+- extracts primary keys (`needles`) of the `object_class` from the array of `original_attributes`
+- queries the database for the objects with `needles` (for `update` and `create`) or initializes the `object_class` with `original_attributes` (for `destroy`)
+- constructs routing_key using `routing_key_callable` (ignores `#attributes_for_routing_key`) or uses `routing_key` if given
+- constructs headers using `headers_callable` (ignores `#attributes_for_headers`)  or uses `headers` if given
+- publishes Rabbit message (uses attributes from queried/initialized objects as data)
+- sends notification (if set up)
+
+### What it does (when uses `#publish_later`):
+- takes in the `original_attributes`, `object_class`, `event`, `routing_key`, `headers`
+- serializes the array of `original_attributes`, silently filters out unserializable keys/values
+- enqueues the job with the `serialized_original_attributes` 
+- job calls `TableSync::Publishing::Batch#publish_now` with `serialized_original_attributes` and the same `object_class`, `event`, `routing_key`, `headers`
+
+### Serialization
+
+Currently allowed key/values are:
+  `NilClass`, `String`, `TrueClass`, `FalseClass`, `Numeric`, `Symbol`.
+
+### Job
+
+Job is defined in `TableSync.batch_publishing_job_class_callable` as a proc. Read more in [Configuration](docs/publishing/configuration.md).
+
+### Example #1 (send right now)
+
+```ruby
+  TableSync::Publishing::Batch.new(
+    object_class: "User",
+    original_attributes: [{ id: 1, name: "Mark" }, { id: 2, name: "Bob" }],
+    event: :create,
+    routing_key: :custom_key,   # optional
+    headers: { type: "admin" }, # optional
+  ).publish_now
+```
+
+### Example #2 (enqueue job)
+
+```ruby
+  TableSync::Publishing::Batch.new(
+    object_class: "User",
+    original_attributes: [{ id: 1, name: "Mark" }, { id: 2, name: "Bob" }],
+    event: :create,
+    routing_key: :custom_key,   # optional
+    headers: { type: "admin" }, # optional
+  ).publish_later
+```
+
+## Raw
+- `TableSync::Publishing::Raw` - sends raw data without checks.
+
+Be carefull with this publisher. There are no checks for the data sent.
+You can send anything.
+
+### Expected parameters:
+
+- `object_class` - model
+- `original_attributes` - raw data that will be sent
+- `event` - type of event that happened to the published objects (`create`, `update`, `destroy`); `update` by default
+- `routing_key` - custom routing_key
+- `headers` - custom headers
+
+### What it does (when uses `#publish_now`):
+- takes in the `original_attributes`, `object_class`, `event`, `routing_key`, `headers`
+- constantizes `object_class`
+- constructs routing_key using `routing_key_callable` (ignores `#attributes_for_routing_key`) or uses `routing_key` if given
+- constructs headers using `headers_callable` (ignores `#attributes_for_headers`)  or uses `headers` if given
+- publishes Rabbit message (uses `original_attributes` as is)
+- sends notification (if set up)
+
+### Example
+
+```ruby
+  TableSync::Publishing::Raw.new(
+    object_class: "User",
+    original_attributes: [{ id: 1, name: "Mark" }, { id: 2, name: "Bob" }],
+    event: :create,
+    routing_key: :custom_key,   # optional
+    headers: { type: "admin" }, # optional
+  ).publish_now
+```