table_copy 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 82e2e7bc03e341d5b10e172c080499d174abd238
-  data.tar.gz: ccf3b5eebc929cefe8b9eeec212d7869b3cacb2c
+  metadata.gz: a22be48d16345c92700399d3cffdddff1df4378e
+  data.tar.gz: b7df0eafee1cd537a06931fd036a7663a0ebf539
 SHA512:
-  metadata.gz: 9be2278b5259705cbfb905422385a334145eeb5325d8f97b33eb253343e3838014d081e3f86417c7456c519364ad29e19ea40e3cedece2fe84550ca2514c9567
-  data.tar.gz: 4191cd39eda48dd99414e3f300a962d6de22e0ad756aaa9f7da8755ac5d0a4d42d14d185d4cf717a40e80524b254f8a80bbfacd4b4c842ba02dbf885a4e698cf
+  metadata.gz: f914d7745eb8e29085dcac211c7fef39dc03374bde943528d1e9037eb2dea78789be06b0e5b1c84600315189a02f2e3e18da7990584b7da7568f1216412e63ee
+  data.tar.gz: b927514b338af025f253de8cf6897ed1f3208d18e7b644bc678586332dea0e9a3022784773f4df216b44ef9d119920bfb52091e4b66937283be947fe1e68c9a1

data/lib/table_copy/copier.rb

@@ -10,27 +10,25 @@ module TableCopy
     end
 
     def update
-      if destination_table.none?
-        droppy
-      elsif (max_sequence = destination_table.max_sequence)
-        update_data(max_sequence)
-      else
-        diffy_update
+      with_rescue do
+        if destination_table.none?
+          droppy
+        elsif (max_sequence = destination_table.max_sequence)
+          update_data(max_sequence)
+        else
+          diffy_update
+        end
       end
-    rescue ::PG::UndefinedTable => e
-      ([e.inspect] + e.backtrace).each { |l| logger.warn(l) }
-      create_table
-      retry
-    rescue ::PG::UndefinedColumn => e
-      ([e.inspect] + e.backtrace).each { |l| logger.warn(l) }
-      droppy
     end
 
     def droppy
       logger.info { "Droppy #{destination_table.table_name}" }
       destination_table.transaction do
+        views = destination_table.query_views
         destination_table.drop(cascade: true)
         create_table
+        destination_table.create_views(views)
+        logger.info { "Created #{views.count} views for #{destination_table.table_name}" }
         moved_count = destination_table.copy_data_from(source_table)
         logger.info { "#{moved_count} rows moved to #{destination_table.table_name}" }
         destination_table.create_indexes
@@ -91,6 +89,17 @@ module TableCopy
       destination_table.create(source_table.fields_ddl)
     end
 
+    def with_rescue
+      yield
+    rescue ::PG::UndefinedTable => e
+      ([e.inspect] + e.backtrace).each { |l| logger.warn(l) }
+      create_table
+      yield
+    rescue ::PG::UndefinedColumn => e
+      ([e.inspect] + e.backtrace).each { |l| logger.warn(l) }
+      droppy
+    end
+
     def logger
       TableCopy.logger
     end

data/lib/table_copy/pg/destination.rb

@@ -101,8 +101,24 @@ module TableCopy
         end
       end
 
+      def query_views
+        with_conn do |conn|
+          conn.exec(views_sql)
+        end
+      end
+
+      def create_views(views)
+        with_conn do |conn|
+          views.each do |view|
+            conn.exec("create or replace view #{view['viewname']} as (#{view['definition'].gsub(/;\z/, '')})")
+          end
+        end
+      end
+
       private
 
+      attr_reader :primary_key
+
       def fields_list
         @fields_list ||= fields.join(', ')
       end
@@ -111,7 +127,6 @@ module TableCopy
         conn_method.call(&block)
       end
 
-      attr_reader :primary_key
 
       def drop_sql
         @drop_sql ||= "drop table if exists #{table_name}"
@@ -157,6 +172,21 @@ module TableCopy
           "nv.#{key}"
         end.join(',')
       end
+
+      def views_sql
+        <<-SQL
+        select viewname, definition from pg_views where viewname in
+          (SELECT distinct dependee.relname
+            FROM pg_depend
+            JOIN pg_rewrite ON pg_depend.objid = pg_rewrite.oid
+            JOIN pg_class as dependee ON pg_rewrite.ev_class = dependee.oid
+            JOIN pg_class as dependent ON pg_depend.refobjid = dependent.oid
+            JOIN pg_attribute ON pg_depend.refobjid = pg_attribute.attrelid
+                AND pg_depend.refobjsubid = pg_attribute.attnum
+            WHERE dependent.relname = '#{table_name}'
+            AND pg_attribute.attnum > 0)
+        SQL
+      end
     end
   end
 end

data/lib/table_copy/version.rb

@@ -1,3 +1,3 @@
 module TableCopy
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/lib/table_copy/copier_spec.rb

@@ -88,9 +88,11 @@ describe TableCopy::Copier do
 
     describe '#droppy' do
       it 'drops and rebuilds the destination table' do
+        expect(destination).to receive(:query_views).and_return('views')
         expect(destination).to receive(:drop).with(cascade: true)
         expect(source).to receive(:fields_ddl).and_return(fields_ddl)
         expect(destination).to receive(:create).with(fields_ddl)
+        expect(destination).to receive(:create_views).with('views')
         expect(destination).to receive(:copy_data_from).with(source)
         expect(destination).to receive(:create_indexes)
         copier.droppy

data/spec/lib/table_copy/pg/destination_spec.rb

@@ -4,6 +4,7 @@ require 'table_copy/pg/index'
 describe TableCopy::PG::Destination do
   let(:conn) { $pg_conn }
   let(:table_name) { 'table_name' }
+  let(:view_name)  { 'view_name' }
   let(:indexes_sql) {
     <<-SQL
       select
@@ -35,6 +36,10 @@ describe TableCopy::PG::Destination do
     conn.exec("select count(*) from pg_tables where tablename='#{name}'").first['count'] == '1'
   end
 
+  def view_exists?(name=view_name)
+    conn.exec("select count(*) from pg_views where viewname='#{name}'").first['count'] == '1'
+  end
+
   def insert_data(name=table_name)
     conn.exec("insert into #{name} values(1, 'foo', '{bar, baz}')")
   end
@@ -57,7 +62,7 @@ describe TableCopy::PG::Destination do
   )}
 
   after do
-    conn.exec("drop table if exists #{table_name}")
+    conn.exec("drop table if exists #{table_name} cascade")
   end
 
   describe '#to_s' do
@@ -71,6 +76,37 @@ describe TableCopy::PG::Destination do
       create_table
     end
 
+    let(:expected_view) {
+      [
+        {
+          "viewname"   => view_name,
+          "definition" => "SELECT #{table_name}.column1, #{table_name}.column2, #{table_name}.column3 FROM #{table_name};"
+        }
+      ]
+    }
+
+    context 'a view exists' do
+      before do
+        conn.exec("create view #{view_name} as (select * from #{table_name})")
+      end
+
+      describe '#query_views' do
+        it 'returns a hash of name => query for views dependent on this table' do
+          expect(dest.query_views.to_a).to eq expected_view
+        end
+      end
+    end
+
+    describe '#create_views' do
+      it 'creates the given views' do
+        expect {
+          dest.create_views(expected_view)
+        }.to change {
+          view_exists?
+        }.from(false).to(true)
+      end
+    end
+
     describe '#none?' do
       it 'indicates whether the table has any data' do
         expect {
@@ -108,6 +144,7 @@ describe TableCopy::PG::Destination do
           }
         end
       end
+
     end
 
     describe '#drop' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: table_copy
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - TLH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-29 00:00:00.000000000 Z
+date: 2014-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler