t 3.1.0 → 4.0.0

data/lib/t/collectable.rb

@@ -1,6 +1,6 @@
-require 'twitter'
-require 'retryable'
-require 'set'
+require "twitter"
+require "retryable"
+require "set"
 
 module T
   module Collectable
@@ -12,6 +12,7 @@ module T
         yield(max_id)
       end
       return collection if tweets.nil?
+
       collection += tweets
       tweets.empty? ? collection.flatten : collect_with_max_id(collection, tweets.last.id - 1, &block)
     end
@@ -22,7 +23,7 @@ module T
       collect_with_max_id do |max_id|
         opts[:max_id] = max_id unless max_id.nil?
         opts[:count] = count unless count >= MAX_NUM_RESULTS
-        if count > 0
+        if count.positive?
           tweets = yield opts
           count -= tweets.length
           tweets
@@ -35,6 +36,7 @@ module T
         yield page
       end
       return collection if tweets.nil? || tweets == previous || page >= MAX_PAGE
+
       collection += tweets
       tweets.empty? ? collection.flatten : collect_with_page(collection, page + 1, tweets, &block)
     end

data/lib/t/core_ext/kernel.rb

@@ -1,13 +1,13 @@
 module Kernel
-  def Bignum(arg, base = 0) # rubocop:disable MethodName
+  def Bignum(arg, base = 0) # rubocop:disable Naming/MethodName
     Integer(arg, base)
   end
 
-  def Fixnum(arg, base = 0) # rubocop:disable MethodName
+  def Fixnum(arg, base = 0) # rubocop:disable Naming/MethodName
     Integer(arg, base)
   end
 
-  def NilClass(_) # rubocop:disable MethodName
+  def NilClass(_) # rubocop:disable Naming/MethodName
     nil
   end
 end

data/lib/t/core_ext/string.rb

@@ -4,12 +4,12 @@ class String
   end
 
   def strip_ats
-    tr('@', '')
+    tr("@", "")
   end
 
   alias old_to_i to_i
 
   def to_i(base = 10)
-    tr(',', '').old_to_i(base)
+    tr(",", "").old_to_i(base)
   end
 end

data/lib/t/delete.rb

@@ -1,8 +1,8 @@
-require 'thor'
-require 'twitter'
-require 't/rcfile'
-require 't/requestable'
-require 't/utils'
+require "thor"
+require "twitter"
+require "t/rcfile"
+require "t/requestable"
+require "t/utils"
 
 module T
   class Delete < Thor
@@ -16,9 +16,9 @@ module T
       super
     end
 
-    desc 'block USER [USER...]', 'Unblock users.'
-    method_option 'id', aliases: '-i', type: :boolean, desc: 'Specify input as Twitter user IDs instead of screen names.'
-    method_option 'force', aliases: '-f', type: :boolean
+    desc "block USER [USER...]", "Unblock users."
+    method_option "id", aliases: "-i", type: :boolean, desc: "Specify input as Twitter user IDs instead of screen names."
+    method_option "force", aliases: "-f", type: :boolean
     def block(user, *users)
       unblocked_users, number = fetch_users(users.unshift(user), options) do |users_to_unblock|
         client.unblock(users_to_unblock)
@@ -28,35 +28,37 @@ module T
       say "Run `#{File.basename($PROGRAM_NAME)} block #{unblocked_users.collect { |unblocked_user| "@#{unblocked_user.screen_name}" }.join(' ')}` to block."
     end
 
-    desc 'dm [DIRECT_MESSAGE_ID] [DIRECT_MESSAGE_ID...]', 'Delete the last Direct Message sent.'
-    method_option 'force', aliases: '-f', type: :boolean
+    desc "dm [DIRECT_MESSAGE_ID] [DIRECT_MESSAGE_ID...]", "Delete the last Direct Message sent."
+    method_option "force", aliases: "-f", type: :boolean
     def dm(direct_message_id, *direct_message_ids)
       direct_message_ids.unshift(direct_message_id)
-      require 't/core_ext/string'
+      require "t/core_ext/string"
       direct_message_ids.collect!(&:to_i)
-      if options['force']
-        direct_messages = client.destroy_direct_message(direct_message_ids)
-        direct_messages.each do |direct_message|
-          say "@#{@rcfile.active_profile[0]} deleted the direct message sent to @#{direct_message.recipient.screen_name}: \"#{direct_message.text}\""
-        end
+      if options["force"]
+        client.destroy_direct_message(*direct_message_ids)
+        say "@#{@rcfile.active_profile[0]} deleted #{direct_message_ids.size} direct message#{direct_message_ids.size == 1 ? '' : 's'}."
       else
         direct_message_ids.each do |direct_message_id_to_delete|
           direct_message = client.direct_message(direct_message_id_to_delete)
-          next unless yes? "Are you sure you want to permanently delete the direct message to @#{direct_message.recipient.screen_name}: \"#{direct_message.text}\"? [y/N]"
+          next unless direct_message
+
+          recipient = client.user(direct_message.recipient_id)
+          next unless yes? "Are you sure you want to permanently delete the direct message to @#{recipient.screen_name}: \"#{direct_message.text}\"? [y/N]"
+
           client.destroy_direct_message(direct_message_id_to_delete)
-          say "@#{@rcfile.active_profile[0]} deleted the direct message sent to @#{direct_message.recipient.screen_name}: \"#{direct_message.text}\""
+          say "@#{@rcfile.active_profile[0]} deleted the direct message sent to @#{recipient.screen_name}: \"#{direct_message.text}\""
         end
       end
     end
-    map %w(d m) => :dm
+    map %w[d m] => :dm
 
-    desc 'favorite TWEET_ID [TWEET_ID...]', 'Delete favorites.'
-    method_option 'force', aliases: '-f', type: :boolean
+    desc "favorite TWEET_ID [TWEET_ID...]", "Delete favorites."
+    method_option "force", aliases: "-f", type: :boolean
     def favorite(status_id, *status_ids)
       status_ids.unshift(status_id)
-      require 't/core_ext/string'
+      require "t/core_ext/string"
       status_ids.collect!(&:to_i)
-      if options['force']
+      if options["force"]
         tweets = client.unfavorite(status_ids)
         tweets.each do |status|
           say "@#{@rcfile.active_profile[0]} unfavorited @#{status.user.screen_name}'s status: \"#{status.full_text}\""
@@ -65,32 +67,32 @@ module T
         status_ids.each do |status_id_to_unfavorite|
           status = client.status(status_id_to_unfavorite, include_my_retweet: false)
           next unless yes? "Are you sure you want to remove @#{status.user.screen_name}'s status: \"#{status.full_text}\" from your favorites? [y/N]"
+
           client.unfavorite(status_id_to_unfavorite)
           say "@#{@rcfile.active_profile[0]} unfavorited @#{status.user.screen_name}'s status: \"#{status.full_text}\""
         end
       end
     end
-    map %w(fave favourite) => :favorite
+    map %w[fave favourite] => :favorite
 
-    desc 'list LIST', 'Delete a list.'
-    method_option 'force', aliases: '-f', type: :boolean
-    method_option 'id', aliases: '-i', type: :boolean, desc: 'Specify list via ID instead of slug.'
+    desc "list LIST", "Delete a list."
+    method_option "force", aliases: "-f", type: :boolean
+    method_option "id", aliases: "-i", type: :boolean, desc: "Specify list via ID instead of slug."
     def list(list)
-      if options['id']
-        require 't/core_ext/string'
+      if options["id"]
+        require "t/core_ext/string"
         list = list.to_i
       end
       list = client.list(list)
-      unless options['force']
-        return unless yes? "Are you sure you want to permanently delete the list \"#{list.name}\"? [y/N]"
-      end
+      return if !options["force"] && !(yes? "Are you sure you want to permanently delete the list \"#{list.name}\"? [y/N]")
+
       client.destroy_list(list)
       say "@#{@rcfile.active_profile[0]} deleted the list \"#{list.name}\"."
     end
 
-    desc 'mute USER [USER...]', 'Unmute users.'
-    method_option 'id', aliases: '-i', type: :boolean, desc: 'Specify input as Twitter user IDs instead of screen names.'
-    method_option 'force', aliases: '-f', type: :boolean
+    desc "mute USER [USER...]", "Unmute users."
+    method_option "id", aliases: "-i", type: :boolean, desc: "Specify input as Twitter user IDs instead of screen names."
+    method_option "force", aliases: "-f", type: :boolean
     def mute(user, *users)
       unmuted_users, number = fetch_users(users.unshift(user), options) do |users_to_unmute|
         client.unmute(users_to_unmute)
@@ -100,7 +102,7 @@ module T
       say "Run `#{File.basename($PROGRAM_NAME)} mute #{unmuted_users.collect { |unmuted_user| "@#{unmuted_user.screen_name}" }.join(' ')}` to mute."
     end
 
-    desc 'account SCREEN_NAME [CONSUMER_KEY]', 'delete account or consumer key from t'
+    desc "account SCREEN_NAME [CONSUMER_KEY]", "delete account or consumer key from t"
     def account(account, key = nil)
       if key && @rcfile.profiles[account].keys.size > 1
         @rcfile.delete_key(account, key)
@@ -109,13 +111,13 @@ module T
       end
     end
 
-    desc 'status TWEET_ID [TWEET_ID...]', 'Delete Tweets.'
-    method_option 'force', aliases: '-f', type: :boolean
+    desc "status TWEET_ID [TWEET_ID...]", "Delete Tweets."
+    method_option "force", aliases: "-f", type: :boolean
     def status(status_id, *status_ids)
       status_ids.unshift(status_id)
-      require 't/core_ext/string'
+      require "t/core_ext/string"
       status_ids.collect!(&:to_i)
-      if options['force']
+      if options["force"]
         tweets = client.destroy_status(status_ids, trim_user: true)
         tweets.each do |status|
           say "@#{@rcfile.active_profile[0]} deleted the Tweet: \"#{status.full_text}\""
@@ -124,11 +126,12 @@ module T
         status_ids.each do |status_id_to_delete|
           status = client.status(status_id_to_delete, include_my_retweet: false)
           next unless yes? "Are you sure you want to permanently delete @#{status.user.screen_name}'s status: \"#{status.full_text}\"? [y/N]"
+
           client.destroy_status(status_id_to_delete, trim_user: true)
           say "@#{@rcfile.active_profile[0]} deleted the Tweet: \"#{status.full_text}\""
         end
       end
     end
-    map %w(post tweet update) => :status
+    map %w[post tweet update] => :status
   end
 end

data/lib/t/editor.rb

@@ -1,5 +1,5 @@
-require 'tempfile'
-require 'shellwords'
+require "tempfile"
+require "shellwords"
 
 module T
   class Editor
@@ -14,7 +14,7 @@ module T
       end
 
       def tempfile
-        Tempfile.new('TWEET_EDITMSG')
+        Tempfile.new("TWEET_EDITMSG")
       end
 
       def edit(path)
@@ -22,11 +22,11 @@ module T
       end
 
       def editor
-        ENV['VISUAL'] || ENV['EDITOR'] || system_editor
+        ENV["VISUAL"] || ENV["EDITOR"] || system_editor
       end
 
       def system_editor
-        RbConfig::CONFIG['host_os'] =~ /mswin|mingw/ ? 'notepad' : 'vi'
+        RbConfig::CONFIG["host_os"] =~ /mswin|mingw/ ? "notepad" : "vi"
       end
     end
   end

data/lib/t/identicon.rb

@@ -42,7 +42,7 @@ module T
   private
 
     def digest(string)
-      require 'digest'
+      require "digest"
       Digest::MD5.digest(string).chars.inject(0) { |acc, elem| (acc << 8) | elem.ord }
     end
   end

data/lib/t/list.rb

@@ -1,10 +1,10 @@
-require 'thor'
-require 'twitter'
-require 't/collectable'
-require 't/printable'
-require 't/rcfile'
-require 't/requestable'
-require 't/utils'
+require "thor"
+require "twitter"
+require "t/collectable"
+require "t/printable"
+require "t/rcfile"
+require "t/requestable"
+require "t/utils"
 
 module T
   class List < Thor
@@ -22,8 +22,8 @@ module T
       super
     end
 
-    desc 'add LIST USER [USER...]', 'Add members to a list.'
-    method_option 'id', aliases: '-i', type: :boolean, desc: 'Specify input as Twitter user IDs instead of screen names.'
+    desc "add LIST USER [USER...]", "Add members to a list."
+    method_option "id", aliases: "-i", type: :boolean, desc: "Specify input as Twitter user IDs instead of screen names."
     def add(list_name, user, *users)
       added_users, number = fetch_users(users.unshift(user), options) do |users_to_add|
         client.add_list_members(list_name, users_to_add)
@@ -31,63 +31,63 @@ module T
       end
       say "@#{@rcfile.active_profile[0]} added #{pluralize(number, 'member')} to the list \"#{list_name}\"."
       say
-      if options['id']
+      if options["id"]
         say "Run `#{File.basename($PROGRAM_NAME)} list remove --id #{list_name} #{added_users.join(' ')}` to undo."
       else
         say "Run `#{File.basename($PROGRAM_NAME)} list remove #{list_name} #{added_users.collect { |added_user| "@#{added_user}" }.join(' ')}` to undo."
       end
     end
 
-    desc 'create LIST [DESCRIPTION]', 'Create a new list.'
-    method_option 'private', aliases: '-p', type: :boolean
+    desc "create LIST [DESCRIPTION]", "Create a new list."
+    method_option "private", aliases: "-p", type: :boolean
     def create(list_name, description = nil)
       opts = description ? {description: description} : {}
-      opts[:mode] = 'private' if options['private']
+      opts[:mode] = "private" if options["private"]
       client.create_list(list_name, opts)
       say "@#{@rcfile.active_profile[0]} created the list \"#{list_name}\"."
     end
 
-    desc 'information [USER/]LIST', 'Retrieves detailed information about a Twitter list.'
-    method_option 'csv', aliases: '-c', type: :boolean, desc: 'Output in CSV format.'
+    desc "information [USER/]LIST", "Retrieves detailed information about a Twitter list."
+    method_option "csv", aliases: "-c", type: :boolean, desc: "Output in CSV format."
     def information(user_list)
       owner, list_name = extract_owner(user_list, options)
       list = client.list(owner, list_name)
-      if options['csv']
-        require 'csv'
-        say ['ID', 'Description', 'Slug', 'Screen name', 'Created at', 'Members', 'Subscribers', 'Following', 'Mode', 'URL'].to_csv
+      if options["csv"]
+        require "csv"
+        say ["ID", "Description", "Slug", "Screen name", "Created at", "Members", "Subscribers", "Following", "Mode", "URL"].to_csv
         say [list.id, list.description, list.slug, list.user.screen_name, csv_formatted_time(list), list.member_count, list.subscriber_count, list.following?, list.mode, list.uri].to_csv
       else
         array = []
-        array << ['ID', list.id.to_s]
-        array << ['Description', list.description] unless list.description.nil?
-        array << ['Slug', list.slug]
-        array << ['Screen name', "@#{list.user.screen_name}"]
-        array << ['Created at', "#{ls_formatted_time(list, :created_at, false)} (#{time_ago_in_words(list.created_at)} ago)"]
-        array << ['Members', number_with_delimiter(list.member_count)]
-        array << ['Subscribers', number_with_delimiter(list.subscriber_count)]
-        array << ['Status', list.following? ? 'Following' : 'Not following']
-        array << ['Mode', list.mode]
-        array << ['URL', list.uri]
+        array << ["ID", list.id.to_s]
+        array << ["Description", list.description] unless list.description.nil?
+        array << ["Slug", list.slug]
+        array << ["Screen name", "@#{list.user.screen_name}"]
+        array << ["Created at", "#{ls_formatted_time(list, :created_at, false)} (#{time_ago_in_words(list.created_at)} ago)"]
+        array << ["Members", number_with_delimiter(list.member_count)]
+        array << ["Subscribers", number_with_delimiter(list.subscriber_count)]
+        array << ["Status", list.following? ? "Following" : "Not following"]
+        array << ["Mode", list.mode]
+        array << ["URL", list.uri]
         print_table(array)
       end
     end
-    map %w(details) => :information
+    map %w[details] => :information
 
-    desc 'members [USER/]LIST', 'Returns the members of a Twitter list.'
-    method_option 'csv', aliases: '-c', type: :boolean, desc: 'Output in CSV format.'
-    method_option 'id', aliases: '-i', type: :boolean, desc: 'Specify user via ID instead of screen name.'
-    method_option 'long', aliases: '-l', type: :boolean, desc: 'Output in long format.'
-    method_option 'reverse', aliases: '-r', type: :boolean, desc: 'Reverse the order of the sort.'
-    method_option 'sort', aliases: '-s', type: :string, enum: %w(favorites followers friends listed screen_name since tweets tweeted), default: 'screen_name', desc: 'Specify the order of the results.', banner: 'ORDER'
-    method_option 'unsorted', aliases: '-u', type: :boolean, desc: 'Output is not sorted.'
+    desc "members [USER/]LIST", "Returns the members of a Twitter list."
+    method_option "csv", aliases: "-c", type: :boolean, desc: "Output in CSV format."
+    method_option "id", aliases: "-i", type: :boolean, desc: "Specify user via ID instead of screen name."
+    method_option "long", aliases: "-l", type: :boolean, desc: "Output in long format."
+    method_option "reverse", aliases: "-r", type: :boolean, desc: "Reverse the order of the sort."
+    method_option "sort", aliases: "-s", type: :string, enum: %w[favorites followers friends listed screen_name since tweets tweeted], default: "screen_name", desc: "Specify the order of the results.", banner: "ORDER"
+    method_option "unsorted", aliases: "-u", type: :boolean, desc: "Output is not sorted."
     def members(user_list)
       owner, list_name = extract_owner(user_list, options)
       users = client.list_members(owner, list_name).to_a
       print_users(users)
     end
 
-    desc 'remove LIST USER [USER...]', 'Remove members from a list.'
-    method_option 'id', aliases: '-i', type: :boolean, desc: 'Specify input as Twitter user IDs instead of screen names.'
+    desc "remove LIST USER [USER...]", "Remove members from a list."
+    method_option "id", aliases: "-i", type: :boolean, desc: "Specify input as Twitter user IDs instead of screen names."
     def remove(list_name, user, *users)
       removed_users, number = fetch_users(users.unshift(user), options) do |users_to_remove|
         client.remove_list_members(list_name, users_to_remove)
@@ -95,31 +95,31 @@ module T
       end
       say "@#{@rcfile.active_profile[0]} removed #{pluralize(number, 'member')} from the list \"#{list_name}\"."
       say
-      if options['id']
+      if options["id"]
         say "Run `#{File.basename($PROGRAM_NAME)} list add --id #{list_name} #{removed_users.join(' ')}` to undo."
       else
         say "Run `#{File.basename($PROGRAM_NAME)} list add #{list_name} #{removed_users.collect { |removed_user| "@#{removed_user}" }.join(' ')}` to undo."
       end
     end
 
-    desc 'timeline [USER/]LIST', 'Show tweet timeline for members of the specified list.'
-    method_option 'csv', aliases: '-c', type: :boolean, desc: 'Output in CSV format.'
-    method_option 'decode_uris', aliases: '-d', type: :boolean, desc: 'Decodes t.co URLs into their original form.'
-    method_option 'id', aliases: '-i', type: :boolean, desc: 'Specify user via ID instead of screen name.'
-    method_option 'long', aliases: '-l', type: :boolean, desc: 'Output in long format.'
-    method_option 'number', aliases: '-n', type: :numeric, default: DEFAULT_NUM_RESULTS, desc: 'Limit the number of results.'
-    method_option 'relative_dates', aliases: '-a', type: :boolean, desc: 'Show relative dates.'
-    method_option 'reverse', aliases: '-r', type: :boolean, desc: 'Reverse the order of the sort.'
+    desc "timeline [USER/]LIST", "Show tweet timeline for members of the specified list."
+    method_option "csv", aliases: "-c", type: :boolean, desc: "Output in CSV format."
+    method_option "decode_uris", aliases: "-d", type: :boolean, desc: "Decodes t.co URLs into their original form."
+    method_option "id", aliases: "-i", type: :boolean, desc: "Specify user via ID instead of screen name."
+    method_option "long", aliases: "-l", type: :boolean, desc: "Output in long format."
+    method_option "number", aliases: "-n", type: :numeric, default: DEFAULT_NUM_RESULTS, desc: "Limit the number of results."
+    method_option "relative_dates", aliases: "-a", type: :boolean, desc: "Show relative dates."
+    method_option "reverse", aliases: "-r", type: :boolean, desc: "Reverse the order of the sort."
     def timeline(user_list)
       owner, list_name = extract_owner(user_list, options)
-      count = options['number'] || DEFAULT_NUM_RESULTS
+      count = options["number"] || DEFAULT_NUM_RESULTS
       opts = {}
-      opts[:include_entities] = !!options['decode_uris']
+      opts[:include_entities] = !!options["decode_uris"]
       tweets = collect_with_count(count) do |count_opts|
         client.list_timeline(owner, list_name, count_opts.merge(opts))
       end
       print_tweets(tweets)
     end
-    map %w(tl) => :timeline
+    map %w[tl] => :timeline
   end
 end