t 2.3.0 → 2.4.0

data/spec/delete_spec.rb

@@ -3,7 +3,7 @@ require 'helper'
 
 describe T::Delete do
 
-  before :each do
+  before do
     T::RCFile.instance.path = fixture_path + '/.trc'
     @delete = T::Delete.new
     @old_stderr = $stderr
@@ -12,7 +12,7 @@ describe T::Delete do
     $stdout = StringIO.new
   end
 
-  after :each do
+  after do
     T::RCFile.instance.reset
     $stderr = @old_stderr
     $stdout = @old_stdout

data/spec/helper.rb

@@ -10,7 +10,7 @@ SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
 
 SimpleCov.start do
   add_filter '/spec/'
-  minimum_coverage(99.21)
+  minimum_coverage(99.24)
 end
 
 require 't'

data/spec/list_spec.rb

@@ -8,12 +8,7 @@ describe T::List do
     T.utc_offset = 'PST'
   end
 
-  after :all do
-    T.utc_offset = nil
-    Timecop.return
-  end
-
-  before :each do
+  before do
     T::RCFile.instance.path = fixture_path + '/.trc'
     @list = T::List.new
     @old_stderr = $stderr
@@ -22,12 +17,17 @@ describe T::List do
     $stdout = StringIO.new
   end
 
-  after :each do
+  after do
     T::RCFile.instance.reset
     $stderr = @old_stderr
     $stdout = @old_stdout
   end
 
+  after :all do
+    T.utc_offset = nil
+    Timecop.return
+  end
+
   describe '#add' do
     before do
       @list.options = @list.options.merge('profile' => fixture_path + '/.trc')

data/spec/rcfile_spec.rb

@@ -3,7 +3,7 @@ require 'helper'
 
 describe T::RCFile do
 
-  after :each do
+  after do
     T::RCFile.instance.reset
     File.delete(project_path + '/tmp/trc') if File.exist?(project_path + '/tmp/trc')
   end

data/spec/search_spec.rb

@@ -8,12 +8,7 @@ describe T::Search do
     T.utc_offset = 'PST'
   end
 
-  after :all do
-    T.utc_offset = nil
-    Timecop.return
-  end
-
-  before :each do
+  before do
     T::RCFile.instance.path = fixture_path + '/.trc'
     @search = T::Search.new
     @search.options = @search.options.merge('color' => 'always')
@@ -23,12 +18,17 @@ describe T::Search do
     $stdout = StringIO.new
   end
 
-  after :each do
+  after do
     T::RCFile.instance.reset
     $stderr = @old_stderr
     $stdout = @old_stdout
   end
 
+  after :all do
+    T.utc_offset = nil
+    Timecop.return
+  end
+
   describe '#all' do
     before do
       stub_get('/1.1/search/tweets.json').with(:query => {:q => 'twitter', :count => '100', :include_entities => 'false'}).to_return(:body => fixture('search.json'))

data/spec/set_spec.rb

@@ -3,7 +3,7 @@ require 'helper'
 
 describe T::Set do
 
-  before :each do
+  before do
     T::RCFile.instance.path = fixture_path + '/.trc'
     @set = T::Set.new
     @old_stderr = $stderr
@@ -12,7 +12,7 @@ describe T::Set do
     $stdout = StringIO.new
   end
 
-  after :each do
+  after do
     T::RCFile.instance.reset
     $stderr = @old_stderr
     $stdout = @old_stdout

data/spec/stream_spec.rb

@@ -12,270 +12,265 @@ describe T::Stream do
     @status = status_from_fixture('status.json')
   end
 
-  before :each do
+  before do
     T::RCFile.instance.path = fixture_path + '/.trc'
-    @client = double('Twitter::Streaming::Client').as_null_object
+    @streaming_client = double('Twitter::Streaming::Client').as_null_object
     @stream = T::Stream.new
-    allow(@stream).to receive(:client) { @client }
+    allow(@stream).to receive(:streaming_client) { @streaming_client }
     allow(@stream).to receive(:say).and_return
     allow(STDOUT).to receive(:tty?).and_return(true)
   end
 
   describe '#all' do
+    before do
+      allow(@streaming_client).to receive(:sample).and_yield(@status)
+    end
+    it 'prints the tweet status' do
+      expect(@stream).to receive(:print_message)
+      @stream.all
+    end
     context '--csv' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('csv' => true)
       end
       it 'outputs headings when the stream initializes' do
-        allow(@client).to receive(:sample).and_return
-        allow(@client).to receive(:before_request).and_yield
+        allow(@streaming_client).to receive(:before_request).and_yield
+        allow(@streaming_client).to receive(:sample).and_return
         expect(@stream).to receive(:say).with("ID,Posted at,Screen name,Text\n")
         @stream.all
       end
       it 'outputs in CSV format' do
-        allow(@client).to receive(:before_request).and_return
-        allow(@client).to receive(:sample).
-          and_yield(@status)
+        allow(@streaming_client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:sample).and_yield(@status)
         expect(@stream).to receive(:print_csv_tweet).with(any_args)
         @stream.all
       end
     end
-
     context '--long' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('long' => true)
       end
-
       it 'outputs headings when the stream initializes' do
-        allow(@client).to receive(:before_request).and_yield
-        allow(@client).to receive(:sample).and_return
+        allow(@streaming_client).to receive(:before_request).and_yield
+        allow(@streaming_client).to receive(:sample).and_return
         expect(@stream).to receive(:print_table).with(any_args)
         @stream.all
       end
-
       it 'outputs in long text format' do
-        allow(@client).to receive(:before_request).and_return
-        allow(@client).to receive(:sample).
-          and_yield(@status)
+        allow(@streaming_client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:sample).and_yield(@status)
         expect(@stream).to receive(:print_table).with(any_args)
         @stream.all
       end
     end
+    it 'invokes Twitter::Streaming::Client#sample' do
+      allow(@streaming_client).to receive(:before_request).and_return
+      allow(@streaming_client).to receive(:sample).and_return
+      expect(@streaming_client).to receive(:sample)
+      @stream.all
+    end
+  end
 
-    context 'normal usage' do
-      before :each do
-        allow(@client).to receive(:sample).
-          and_yield(@status)
+  describe '#list' do
+    before do
+      stub_get('/1.1/lists/members.json').with(:query => {:cursor => '-1', :owner_screen_name => 'testcli', :slug => 'presidents'}).to_return(:body => fixture('users_list.json'))
+    end
+    it 'prints the tweet status' do
+      expect(@stream).to receive(:print_message)
+      allow(@streaming_client).to receive(:filter).and_yield(@status)
+      @stream.list('presidents')
+    end
+    it 'requests the correct resource' do
+      @stream.list('presidents')
+      expect(a_get('/1.1/lists/members.json').with(:query => {:cursor => '-1', :owner_screen_name => 'testcli', :slug => 'presidents'})).to have_been_made
+    end
+    context '--csv' do
+      before do
+        @stream.options = @stream.options.merge('csv' => true)
       end
-
-      it 'prints the tweet status' do
-        expect(@stream).to receive(:print_message)
-        @stream.all
+      it 'outputs in CSV format' do
+        allow(@streaming_client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:filter).and_yield(@status)
+        expect(@stream).to receive(:print_csv_tweet).with(any_args)
+        @stream.list('presidents')
+      end
+      it 'requests the correct resource' do
+        @stream.list('presidents')
+        expect(a_get('/1.1/lists/members.json').with(:query => {:cursor => '-1', :owner_screen_name => 'testcli', :slug => 'presidents'})).to have_been_made
       end
     end
-
-    it 'invokes Twitter::Streaming::Client#sample' do
-      expect(@client).to receive(:sample)
-      @stream.all
+    context '--long' do
+      before do
+        @stream.options = @stream.options.merge('long' => true)
+      end
+      it 'outputs in long text format' do
+        allow(@streaming_client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:filter).and_yield(@status)
+        expect(@stream).to receive(:print_table).with(any_args)
+        @stream.list('presidents')
+      end
+      it 'requests the correct resource' do
+        @stream.list('presidents')
+        expect(a_get('/1.1/lists/members.json').with(:query => {:cursor => '-1', :owner_screen_name => 'testcli', :slug => 'presidents'})).to have_been_made
+      end
+    end
+    it 'performs a REST search when the stream initializes' do
+      allow(@streaming_client).to receive(:before_request).and_yield
+      allow(@streaming_client).to receive(:filter).and_return
+      allow(T::List).to receive(:new).and_return(t_class)
+      expect(t_class).to receive(:timeline).and_return
+      @stream.list('presidents')
+    end
+    it 'invokes Twitter::Streaming::Client#userstream' do
+      allow(@streaming_client).to receive(:filter).and_return
+      expect(@streaming_client).to receive(:filter)
+      @stream.list('presidents')
     end
   end
 
   describe '#matrix' do
-    before :each do
-      allow(@client).to receive(:sample).
-        and_yield(@status)
+    before do
+      allow(@streaming_client).to receive(:sample).and_yield(@status)
     end
-
     it 'outputs the tweet status' do
       expect(@stream).to receive(:say).with(any_args)
       @stream.matrix
     end
-
     it 'invokes Twitter::Streaming::Client.sample' do
-      expect(@client).to receive(:sample)
+      expect(@streaming_client).to receive(:sample)
       @stream.matrix
     end
   end
 
   describe '#search' do
-    before :each do
-      allow(@client).to receive(:filter).with(:track => 'twitter,gem').
-        and_yield(@status)
+    before do
+      allow(@streaming_client).to receive(:filter).with(:track => 'twitter,gem').and_yield(@status)
+    end
+    it 'prints the tweet status' do
+      expect(@stream).to receive(:print_message)
+      @stream.search(%w[twitter gem])
     end
-
     context '--csv' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('csv' => true)
       end
-
       it 'outputs in CSV format' do
-        allow(@client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:before_request).and_return
         expect(@stream).to receive(:print_csv_tweet).with(any_args)
         @stream.search(%w[twitter gem])
       end
     end
-
     context '--long' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('long' => true)
       end
-
       it 'outputs in long text format' do
-        allow(@client).to receive(:before_request).and_return
-        allow(@client).to receive(:filter).with(:track => 'twitter,gem').
-          and_yield(@status)
+        allow(@streaming_client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:filter).with(:track => 'twitter,gem').and_yield(@status)
         expect(@stream).to receive(:print_table).with(any_args)
         @stream.search(%w[twitter gem])
       end
     end
-
-    context 'normal usage' do
-      before :each do
-        allow(@client).to receive(:filter).with(:track => 'twitter,gem').
-          and_yield(@status)
-      end
-      it 'prints the tweet status' do
-        expect(@stream).to receive(:print_message)
-        @stream.search(%w[twitter gem])
-      end
-    end
-
     it 'performs a REST search when the stream initializes' do
-      allow(@client).to receive(:filter).and_return
-      allow(@client).to receive(:before_request).and_yield
+      allow(@streaming_client).to receive(:before_request).and_yield
+      allow(@streaming_client).to receive(:filter).and_return
       allow(T::Search).to receive(:new).and_return(t_class)
       expect(t_class).to receive(:all).with('t OR gem').and_return
       @stream.search('t', 'gem')
     end
-
     it 'invokes Twitter::Streaming::Client#filter' do
-      allow(@client).to receive(:filter).and_return
-      expect(@client).to receive(:filter).with(:track => 'twitter,gem')
+      allow(@streaming_client).to receive(:filter).and_return
+      expect(@streaming_client).to receive(:filter).with(:track => 'twitter,gem')
       @stream.search(%w[twitter gem])
     end
   end
 
   describe '#timeline' do
-    before :each do
-      allow(@client).to receive(:user).
-        and_yield(@status)
+    before do
+      allow(@streaming_client).to receive(:user).and_yield(@status)
+    end
+    it 'prints the tweet status' do
+      expect(@stream).to receive(:print_message)
+      @stream.timeline
     end
-
     context '--csv' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('csv' => true)
       end
-
       it 'outputs in CSV format' do
-        allow(@client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:before_request).and_return
         expect(@stream).to receive(:print_csv_tweet).with(any_args)
         @stream.timeline
       end
     end
-
     context '--long' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('long' => true)
       end
-
       it 'outputs in long text format' do
-        allow(@client).to receive(:before_request).and_return
-        allow(@client).to receive(:user).
-          and_yield(@status)
+        allow(@streaming_client).to receive(:before_request).and_return
         expect(@stream).to receive(:print_table).with(any_args)
         @stream.timeline
       end
     end
-
-    context 'normal usage' do
-      before :each do
-        allow(@client).to receive(:user).
-          and_yield(@status)
-      end
-
-      it 'prints the tweet status' do
-        expect(@stream).to receive(:print_message)
-        @stream.timeline
-      end
-    end
-
     it 'performs a REST search when the stream initializes' do
-      allow(@client).to receive(:user).and_return
-      allow(@client).to receive(:before_request).and_yield
+      allow(@streaming_client).to receive(:before_request).and_yield
+      allow(@streaming_client).to receive(:user).and_return
       allow(T::CLI).to receive(:new).and_return(t_class)
       expect(t_class).to receive(:timeline).and_return
-
       @stream.timeline
     end
-
     it 'invokes Twitter::Streaming::Client#userstream' do
-      allow(@client).to receive(:user).and_return
-      expect(@client).to receive(:user)
+      allow(@streaming_client).to receive(:user).and_return
+      expect(@streaming_client).to receive(:user)
       @stream.timeline
     end
   end
 
   describe '#users' do
-    before :each do
-      allow(@client).to receive(:filter).
-        and_yield(@status)
+    before do
+      allow(@streaming_client).to receive(:filter).and_yield(@status)
+    end
+    it 'prints the tweet status' do
+      expect(@stream).to receive(:print_message)
+      @stream.users('123')
     end
-
     context '--csv' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('csv' => true)
       end
-
       it 'outputs headings when the stream initializes' do
-        allow(@client).to receive(:filter).and_return
-        allow(@client).to receive(:before_request).and_yield
+        allow(@streaming_client).to receive(:before_request).and_yield
+        allow(@streaming_client).to receive(:filter).and_return
         expect(@stream).to receive(:say).with("ID,Posted at,Screen name,Text\n")
         @stream.users('123')
       end
-
       it 'outputs in CSV format' do
-        allow(@client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:before_request).and_return
         expect(@stream).to receive(:print_csv_tweet).with(any_args)
         @stream.users('123')
       end
     end
-
     context '--long' do
-      before :each do
+      before do
         @stream.options = @stream.options.merge('long' => true)
       end
-
       it 'outputs headings when the stream initializes' do
-        allow(@client).to receive(:before_request).and_yield
-        allow(@client).to receive(:filter).and_return
+        allow(@streaming_client).to receive(:before_request).and_yield
+        allow(@streaming_client).to receive(:filter).and_return
         expect(@stream).to receive(:print_table).with(any_args)
         @stream.users('123')
       end
-
       it 'outputs in long text format' do
-        allow(@client).to receive(:before_request).and_return
-        allow(@client).to receive(:filter).
-          and_yield(@status)
+        allow(@streaming_client).to receive(:before_request).and_return
+        allow(@streaming_client).to receive(:filter).and_yield(@status)
         expect(@stream).to receive(:print_table).with(any_args)
         @stream.users('123')
       end
     end
-
-    context 'normal usage' do
-      before :each do
-        allow(@client).to receive(:filter).
-          and_yield(@status)
-      end
-
-      it 'prints the tweet status' do
-        expect(@stream).to receive(:print_message)
-        @stream.users('123')
-      end
-    end
-
     it 'invokes Twitter::Streaming::Client#follow' do
-      allow(@client).to receive(:filter).and_return
-      expect(@client).to receive(:filter).with(:follow => '123,456,789')
+      allow(@streaming_client).to receive(:filter).and_return
+      expect(@streaming_client).to receive(:filter).with(:follow => '123,456,789')
       @stream.users('123', '456', '789')
     end
   end