systemd-journal 1.0.2 → 1.1.0

data/spec/systemd/journal_spec.rb

@@ -10,15 +10,15 @@ describe Systemd::Journal do
     end
 
     it 'accepts flags as an argument' do
-      Systemd::Journal::Native.should_receive(:sd_journal_open).with(anything, 1234)
+      Systemd::Journal::Native.should_receive(:sd_journal_open)
+        .with(anything, 1234)
+
       Systemd::Journal.new(flags: 1234)
     end
 
     it 'raises a Journal Error if a native call fails' do
       Systemd::Journal::Native.should_receive(:sd_journal_open).and_return(-1)
-      expect {
-        Systemd::Journal.new
-      }.to raise_error(Systemd::JournalError)
+      expect { Systemd::Journal.new }.to raise_error(Systemd::JournalError)
     end
   end
 
@@ -36,44 +36,59 @@ describe Systemd::Journal do
     end
   end
 
-  ['next', 'previous'].each do |direction|
+  %w{next previous}.each do |direction|
     describe "#move_#{direction}" do
       it 'returns true on a successful move' do
         j = Systemd::Journal.new
-        Systemd::Journal::Native.should_receive(:"sd_journal_#{direction}").and_return(1)
+        Systemd::Journal::Native
+          .should_receive(:"sd_journal_#{direction}")
+          .and_return(1)
+
         j.send(:"move_#{direction}").should eq(true)
       end
 
       it 'returns false on EOF' do
         j = Systemd::Journal.new
-        Systemd::Journal::Native.should_receive(:"sd_journal_#{direction}").and_return(0)
+        Systemd::Journal::Native
+          .should_receive(:"sd_journal_#{direction}")
+          .and_return(0)
+
         j.send(:"move_#{direction}").should eq(false)
       end
 
       it 'raises an exception on failure' do
         j = Systemd::Journal.new
-        Systemd::Journal::Native.should_receive(:"sd_journal_#{direction}").and_return(-1)
-        expect {
+        Systemd::Journal::Native
+          .should_receive(:"sd_journal_#{direction}")
+          .and_return(-1)
+
+        expect do
           j.send(:"move_#{direction}")
-        }.to raise_error(Systemd::JournalError)
+        end.to raise_error(Systemd::JournalError)
       end
     end
 
     describe "#move_#{direction}_skip" do
       it 'returns the number of records moved by' do
-        Systemd::Journal::Native.should_receive(:"sd_journal_#{direction}_skip").
-          with(anything, 10).and_return(10)
+        Systemd::Journal::Native
+          .should_receive(:"sd_journal_#{direction}_skip")
+          .with(anything, 10)
+          .and_return(10)
 
         Systemd::Journal.new.send(:"move_#{direction}_skip", 10).should eq(10)
       end
 
       it 'raises an exception on failure' do
-        Systemd::Journal::Native.should_receive(:"sd_journal_#{direction}_skip").
-          with(anything, 10).and_return(-1)
+        Systemd::Journal::Native
+          .should_receive(:"sd_journal_#{direction}_skip")
+          .with(anything, 10)
+          .and_return(-1)
 
         j = Systemd::Journal.new
 
-        expect { j.send(:"move_#{direction}_skip", 10) }.to raise_error(Systemd::JournalError)
+        expect do
+          j.send(:"move_#{direction}_skip", 10)
+        end.to raise_error(Systemd::JournalError)
       end
     end
   end
@@ -83,7 +98,7 @@ describe Systemd::Journal do
       j = Systemd::Journal.new
       j.should_receive(:seek).with(:head).and_return(0)
       j.stub(:move_next).and_return(nil)
-      j.each{|e| nil }
+      j.each { |e| nil }
     end
 
     it 'should return an enumerator if no block is given' do
@@ -92,7 +107,7 @@ describe Systemd::Journal do
     end
 
     it 'should return each entry in the journal' do
-      entries = [{'_PID' => 1}, {'_PID' => 2}]
+      entries = [{ '_PID' => 1 }, { '_PID' => 2 }]
       entry   = nil
 
       j = Systemd::Journal.new
@@ -100,7 +115,7 @@ describe Systemd::Journal do
       j.stub(:current_entry) { entry }
       j.stub(:move_next)     { entry = entries.shift }
 
-      j.map{|e| e['_PID'] }.should eq([1, 2])
+      j.map { |e| e['_PID'] }.should eq([1, 2])
     end
 
   end
@@ -108,29 +123,40 @@ describe Systemd::Journal do
   describe '#seek' do
     it 'moves to the first entry of the file' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_seek_head).and_return(0)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_seek_head)
+        .and_return(0)
+
       j.seek(:head).should eq(true)
     end
 
     it 'moves to the last entry of the file' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_seek_tail).and_return(0)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_seek_tail)
+        .and_return(0)
+
       j.seek(:tail).should eq(true)
     end
 
     it 'seeks based on time when a time is provided' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_seek_realtime_usec).and_return(0)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_seek_realtime_usec)
+        .and_return(0)
+
       j.seek(Time.now).should eq(true)
     end
 
     it 'seeks based on a cursor when a string is provided' do
       j = Systemd::Journal.new
 
-      Systemd::Journal::Native.should_receive(:sd_journal_seek_cursor).
-        with(anything, "123").and_return(0)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_seek_cursor)
+        .with(anything, '123')
+        .and_return(0)
 
-      j.seek("123")
+      j.seek('123')
     end
 
     it 'throws an exception if it doesnt understand the type' do
@@ -141,34 +167,41 @@ describe Systemd::Journal do
 
   describe '#read_field' do
     it 'raises an exception if the call fails' do
-      Systemd::Journal::Native.should_receive(:sd_journal_get_data).and_return(-1)
-
       j = Systemd::Journal.new
-      expect{ j.read_field(:message) }.to raise_error(Systemd::JournalError)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_data)
+        .and_return(-1)
+
+      expect { j.read_field(:message) }.to raise_error(Systemd::JournalError)
     end
 
     it 'parses the returned value correctly.' do
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_data) do |ptr, field, out_ptr, len_ptr|
+          dummy = 'MESSAGE=hello world'
+          out_ptr.write_pointer(FFI::MemoryPointer.from_string(dummy))
+          len_ptr.write_size_t(dummy.size)
+          0
+        end
 
-      Systemd::Journal::Native.should_receive(:sd_journal_get_data) do |ptr, field, out_ptr, len_ptr|
-        dummy = "MESSAGE=hello world"
-        out_ptr.write_pointer(FFI::MemoryPointer.from_string(dummy))
-        len_ptr.write_size_t(dummy.size)
-        0
-      end
-
-      j.read_field(:message).should eq("hello world")
+      j.read_field(:message).should eq('hello world')
     end
   end
 
   describe '#current_entry' do
     before(:each) do
-      Systemd::Journal::Native.should_receive(:sd_journal_restart_data).and_return(nil)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_restart_data)
+        .and_return(nil)
     end
 
     it 'raises an exception if the call fails' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_enumerate_data).and_return(-1)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_enumerate_data)
+        .and_return(-1)
+
       expect { j.current_entry }.to raise_error(Systemd::JournalError)
     end
 
@@ -176,40 +209,52 @@ describe Systemd::Journal do
       j = Systemd::Journal.new
       results = ['_PID=100', 'MESSAGE=hello world']
 
-      Systemd::Journal::Native.should_receive(:sd_journal_enumerate_data).exactly(3).times do |ptr, out_ptr, len_ptr|
-        if results.any?
-          x = results.shift
-          out_ptr.write_pointer(FFI::MemoryPointer.from_string(x))
-          len_ptr.write_size_t(x.length)
-          1
-        else
-          0
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_enumerate_data)
+        .exactly(3).times do |ptr, out_ptr, len_ptr|
+          if results.any?
+            x = results.shift
+            out_ptr.write_pointer(FFI::MemoryPointer.from_string(x))
+            len_ptr.write_size_t(x.length)
+            1
+          else
+            0
+          end
         end
-      end
 
       entry = j.current_entry
 
       entry._pid.should     eq('100')
       entry.message.should eq('hello world')
-
     end
   end
 
   describe '#query_unique' do
     before(:each) do
-      Systemd::Journal::Native.should_receive(:sd_journal_restart_unique).and_return(nil)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_restart_unique)
+        .and_return(nil)
     end
 
     it 'raises an exception if the call fails' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_query_unique).and_return(-1)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_query_unique)
+        .and_return(-1)
+
       expect { j.query_unique(:_pid) }.to raise_error(Systemd::JournalError)
     end
 
     it 'raises an exception if the call fails (2)' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_query_unique).and_return(0)
-      Systemd::Journal::Native.should_receive(:sd_journal_enumerate_unique).and_return(-1)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_query_unique)
+        .and_return(0)
+
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_enumerate_unique)
+        .and_return(-1)
+
       expect { j.query_unique(:_pid) }.to raise_error(Systemd::JournalError)
     end
 
@@ -217,20 +262,24 @@ describe Systemd::Journal do
       j = Systemd::Journal.new
       results = ['_PID=100', '_PID=200', '_PID=300']
 
-      Systemd::Journal::Native.should_receive(:sd_journal_query_unique).and_return(0)
-
-      Systemd::Journal::Native.should_receive(:sd_journal_enumerate_unique).exactly(4).times do |ptr, out_ptr, len_ptr|
-        if results.any?
-          x = results.shift
-          out_ptr.write_pointer(FFI::MemoryPointer.from_string(x))
-          len_ptr.write_size_t(x.length)
-          1
-        else
-          0
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_query_unique)
+        .and_return(0)
+
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_enumerate_unique)
+        .exactly(4).times do |ptr, out_ptr, len_ptr|
+          if results.any?
+            x = results.shift
+            out_ptr.write_pointer(FFI::MemoryPointer.from_string(x))
+            len_ptr.write_size_t(x.length)
+            1
+          else
+            0
+          end
         end
-      end
 
-      j.query_unique(:_pid).should eq(['100', '200', '300'])
+      j.query_unique(:_pid).should eq(%w{100 200 300})
     end
 
   end
@@ -240,36 +289,47 @@ describe Systemd::Journal do
       Systemd::Journal::Native.should_receive(:sd_journal_wait).and_return(-1)
 
       j = Systemd::Journal.new
-      expect{ j.wait(100) }.to raise_error(Systemd::JournalError)
+      expect { j.wait(100) }.to raise_error(Systemd::JournalError)
     end
 
     it 'returns the reason we were woken up' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_wait).and_return(:append)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_wait)
+        .and_return(:append)
+
       j.wait(100).should eq(:append)
     end
 
     it 'returns nil if we reached the timeout.' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_wait).and_return(:nop)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_wait)
+        .and_return(:nop)
+
       j.wait(100).should eq(nil)
     end
   end
 
   describe '#add_filter' do
     it 'raises an exception if the call fails' do
-      Systemd::Journal::Native.should_receive(:sd_journal_add_match).and_return(-1)
-
       j = Systemd::Journal.new
-      expect{ j.add_filter(:message, "test") }.to raise_error(Systemd::JournalError)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_add_match)
+        .and_return(-1)
+
+      expect do
+        j.add_filter(:message, 'test')
+      end.to raise_error(Systemd::JournalError)
     end
 
     it 'formats the arguments appropriately' do
-      Systemd::Journal::Native.should_receive(:sd_journal_add_match).
-        with(anything, "MESSAGE=test", "MESSAGE=test".length).
-        and_return(0)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_add_match)
+        .with(anything, 'MESSAGE=test', 'MESSAGE=test'.length)
+        .and_return(0)
 
-      Systemd::Journal.new.add_filter(:message, "test")
+      Systemd::Journal.new.add_filter(:message, 'test')
     end
   end
 
@@ -288,7 +348,7 @@ describe Systemd::Journal do
       j.should_receive(:add_filter).with(:priority, 2)
       j.should_receive(:add_filter).with(:priority, 3)
 
-      j.add_filters(priority: [1,2,3])
+      j.add_filters(priority: [1, 2, 3])
     end
   end
 
@@ -308,50 +368,62 @@ describe Systemd::Journal do
       j.should_receive(:add_disjunction).ordered
       j.should_receive(:add_filter).with(:message, 'hello').ordered
 
-      j.filter({priority: 1}, {message: 'hello'})
+      j.filter({ priority: 1 }, { message: 'hello' })
 
     end
   end
 
   describe '#add_conjunction' do
     it 'raises an exception if the call fails' do
-      Systemd::Journal::Native.should_receive(:sd_journal_add_conjunction).and_return(-1)
-
       j = Systemd::Journal.new
-      expect{ j.add_conjunction }.to raise_error(Systemd::JournalError)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_add_conjunction)
+        .and_return(-1)
+
+      expect { j.add_conjunction }.to raise_error(Systemd::JournalError)
     end
   end
 
   describe '#add_disjunction' do
     it 'raises an exception if the call fails' do
-      Systemd::Journal::Native.should_receive(:sd_journal_add_disjunction).and_return(-1)
-
       j = Systemd::Journal.new
-      expect{ j.add_disjunction }.to raise_error(Systemd::JournalError)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_add_disjunction)
+        .and_return(-1)
+
+      expect { j.add_disjunction }.to raise_error(Systemd::JournalError)
     end
   end
 
   describe '#clear_filters' do
     it 'flushes the matches' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_flush_matches).and_return(nil)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_flush_matches)
+        .and_return(nil)
+
       j.clear_filters
     end
   end
 
   describe '#disk_usage' do
     it 'returns the size used on disk' do
-      Systemd::Journal::Native.should_receive(:sd_journal_get_usage) do |ptr, size_ptr|
-        size_ptr.write_size_t(12)
-        0
-      end
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_usage) do |ptr, size_ptr|
+          size_ptr.write_size_t(12)
+          0
+        end
+
       j.disk_usage.should eq(12)
     end
 
     it 'raises an error if the call fails' do
-      Systemd::Journal::Native.should_receive(:sd_journal_get_usage).and_return(-1)
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_usage)
+        .and_return(-1)
+
       expect { j.disk_usage }.to raise_error(Systemd::JournalError)
     end
   end
@@ -359,41 +431,46 @@ describe Systemd::Journal do
   describe '#data_threshold=' do
     it 'sets the data threshold' do
       j = Systemd::Journal.new
-
-      Systemd::Journal::Native.should_receive(:sd_journal_set_data_threshold).
-        with(anything, 0x1234).and_return(0)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_set_data_threshold)
+        .with(anything, 0x1234)
+        .and_return(0)
 
       j.data_threshold = 0x1234
     end
 
     it 'raises a JournalError on failure' do
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_set_data_threshold)
+        .with(anything, 0x1234)
+        .and_return(-1)
 
-      Systemd::Journal::Native.should_receive(:sd_journal_set_data_threshold).
-        with(anything, 0x1234).and_return(-1)
-
-      expect { j.data_threshold = 0x1234 }.to raise_error(Systemd::JournalError)
+      expect do
+        j.data_threshold = 0x1234
+      end.to raise_error(Systemd::JournalError)
     end
   end
 
   describe '#data_threshold' do
     it 'gets the data threshold' do
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_data_threshold) do |ptr, size_ptr|
+          size_ptr.write_size_t(0x1234)
+          0
+        end
 
-      Systemd::Journal::Native.should_receive(:sd_journal_get_data_threshold) do |ptr, size_ptr|
-        size_ptr.write_size_t(0x1234)
-        0
-      end
       j.data_threshold.should eq(0x1234)
     end
 
     it 'raises a JournalError on failure' do
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_data_threshold)
+        .and_return(-3)
 
-      Systemd::Journal::Native.should_receive(:sd_journal_get_data_threshold).
-        and_return(-3)
-
-      expect{ j.data_threshold }.to raise_error(Systemd::JournalError)
+      expect { j.data_threshold }.to raise_error(Systemd::JournalError)
     end
 
   end
@@ -401,27 +478,30 @@ describe Systemd::Journal do
   describe '#cursor?' do
     it 'returns true if the current cursor is the provided value' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_test_cursor).
-        with(anything, "1234").and_return(1)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_test_cursor)
+        .with(anything, '1234').and_return(1)
 
-      j.cursor?("1234").should eq(true)
+      j.cursor?('1234').should eq(true)
     end
 
     it 'returns false otherwise' do
       j = Systemd::Journal.new
-      Systemd::Journal::Native.should_receive(:sd_journal_test_cursor).
-        with(anything, "1234").and_return(0)
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_test_cursor)
+        .with(anything, '1234')
+        .and_return(0)
 
-      j.cursor?("1234").should eq(false)
+      j.cursor?('1234').should eq(false)
     end
 
     it 'raises a JournalError on failure' do
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_test_cursor)
+        .and_return(-3)
 
-      Systemd::Journal::Native.should_receive(:sd_journal_test_cursor).
-        and_return(-3)
-
-      expect{ j.cursor?('123') }.to raise_error(Systemd::JournalError)
+      expect { j.cursor?('123') }.to raise_error(Systemd::JournalError)
     end
 
   end
@@ -429,26 +509,27 @@ describe Systemd::Journal do
   describe '#cursor' do
     it 'returns the current cursor' do
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_cursor) do |ptr, out_ptr|
+          # this memory will be manually freed. not setting autorelease to
+          # false would cause a double free.
+          str = FFI::MemoryPointer.from_string('5678')
+          str.autorelease = false
 
-      Systemd::Journal::Native.should_receive(:sd_journal_get_cursor) do |ptr, out_ptr|
-        # this memory will be manually freed. not setting autorelease to false
-        # would cause a double free.
-        str = FFI::MemoryPointer.from_string("5678")
-        str.autorelease = false
+          out_ptr.write_pointer(str)
+          0
+        end
 
-        out_ptr.write_pointer(str)
-        0
-      end
-      j.cursor.should eq("5678")
+      j.cursor.should eq('5678')
     end
 
     it 'raises a JournalError on failure' do
       j = Systemd::Journal.new
+      Systemd::Journal::Native
+        .should_receive(:sd_journal_get_cursor)
+        .and_return(-3)
 
-      Systemd::Journal::Native.should_receive(:sd_journal_get_cursor).
-        and_return(-3)
-
-      expect{ j.cursor }.to raise_error(Systemd::JournalError)
+      expect { j.cursor }.to raise_error(Systemd::JournalError)
     end
 
   end