sys-uname 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5cbd8721570c3681f05f66562a956b366d7839da185a309acc136fceab2f9b8
-  data.tar.gz: 315ba4bc84cbfb0e1201a78062858218f6652148a37d9e62f90a7200c70d3d50
+  metadata.gz: da53561b44caf45c227aad7130b9b120e9bbdd3cd35b665ecf527b8a7ad51996
+  data.tar.gz: ce041695020d00b6eeacb5861fc39268a84a6bc4f586f3c2576f2b4e599816d7
 SHA512:
-  metadata.gz: 5c22800edea9dfd5b9057fb3fae10a76e88ecbead21e02b8d66ce7b1105294f01efe661d9ae9e9fe9653293acd8966aabd667296c40d1891225fd54289422845
-  data.tar.gz: 10cad4749fee0e1e6fcd5f531e046ba8f9ce9af354401d065b8d786365aa7e87d6691745e84f164cf3ef87f1a5849b52f815d7c9a517ec839005963c5ca75d7b
+  metadata.gz: dd826360df12898bb135c2a442c475cbf209c1dae207b290214af3ae8130eaaed41800c2744942908ac11469c4ec9c7d2bebbd25bf112041148c629b502431d3
+  data.tar.gz: bd9cdeff9d5459e7c66e86b280c6f19f046812bfdb3abb05b8c874cfd535df3895f8ad3198026df3ac2f845690bc85dd0b9ab939212b6563c95071215e011453

data/CHANGES.md

@@ -1,3 +1,10 @@
+## 1.2.3 - 9-Apr-2023
+* Added rubygems_mfa_required and github_repo to metadata.
+* Miscellaneous rubocop related updates.
+* Fixed one test for Windows.
+* The rubocop and rubocop-rspec gems are now development dependencies.
+* Now assumes Ruby 2.0 or later.
+
 ## 1.2.2 - 30-Oct-2020
 * Added a Gemfile.
 * The ffi dependency is now slightly more restrictive.

data/Gemfile

@@ -1,7 +1,2 @@
-source 'https://rubygems.org' do
-  gem 'ffi', '~> 1.1'
-  group 'test' do
-    gem 'rake'
-    gem 'rspec', '~> 3.9'
-  end
-end
+source 'https://rubygems.org'
+gemspec

data/README.md

@@ -1,3 +1,5 @@
+[![Ruby](https://github.com/djberg96/sys-uname/actions/workflows/ruby.yml/badge.svg)](https://github.com/djberg96/sys-uname/actions/workflows/ruby.yml)
+
 ## Description
 A cross-platform Ruby interface for getting operating system information. The name
 comes from the Unix 'uname' command, but this library works on MS Windows as well.
@@ -8,8 +10,11 @@ ffi 1.0 or later
 ## Installation
 `gem install sys-uname`
 
+## Adding the trusted cert
+`gem cert --add <(curl -Ls https://raw.githubusercontent.com/djberg96/sys-uname/main/certs/djberg96_pub.pem)`
+
 ## Synopsis
-```
+```ruby
 require 'sys/uname' # require 'sys-uname' works, too
 
 # You now have Sys::Uname and Sys::Platform classes available.
@@ -23,21 +28,31 @@ p Sys::Platform::ARCH  # => :x86_64
 ```
    
 ## Solaris Notes
-Users on SunOS get several extra methods: architecture, platform,
-hw_serial, hw_provider, srpc_domain, isa_list, and dhcp_cache.
+Users on SunOS get several extra methods:
+
+* architecture
+* platform
+* hw_serial
+* hw_provider
+* srpc_domain
+* isa_list
+* dhcp_cache
+
+Note that Solaris is essentially a dead OS at this point, so it will not be
+supported going forward, and will likely be dropped in the next major release.
 
 ## BSD flavors, including OS X
-Users on BSD platforms get the extra Uname.model method.
+Users on BSD platforms get the extra `Uname.model` method.
 
 ## HP-UX Notes
-HP-UX users get the extra Uname.id_number method. This is actually a
+HP-UX users get the extra `Uname.id_number` method. This is actually a
 String, not a Fixnum, because that's how it's defined in the utsname
 struct.
 
 ## MS Windows Notes
 The C version for Windows has been completely scrapped in favor of an OLE
 plus WMI approach. It is pure Ruby. Please see the MSDN documentation for
-the Win32_OperatingSystem class for a complete list of what each of the
+the `Win32_OperatingSystem` class for a complete list of what each of the
 UnameStruct members mean.
 
 ## The Platform Class

data/Rakefile

@@ -1,8 +1,8 @@
 require 'rake'
-require 'rake/testtask'
 require 'rake/clean'
 require 'rbconfig'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 CLEAN.include("**/*.rbc", "**/*.rbx", "**/*.gem", "**/*.lock")
 
@@ -19,7 +19,7 @@ namespace :gem do
   desc "Create the sys-uname gem"
   task :create => [:clean] do
     require 'rubygems/package'
-    spec = eval(IO.read('sys-uname.gemspec'))
+    spec = Gem::Specification.load('sys-uname.gemspec')
     spec.signing_key = File.join(Dir.home, '.ssh', 'gem-private_key.pem')
     Gem::Package.build(spec)
   end
@@ -31,6 +31,8 @@ namespace :gem do
   end
 end
 
+RuboCop::RakeTask.new
+
 desc "Run the test suite"
 RSpec::Core::RakeTask.new(:spec)
 

data/doc/uname.rdoc

@@ -112,7 +112,7 @@ Add additional info for Linux, Solaris, BSD.
 Apache-2.0
 
 == Copyright
-(C) 2002-2020 Daniel J. Berger
+(C) 2002-2023 Daniel J. Berger
 All Rights Reserved
 
 == Warranty

data/lib/sys/platform.rb

@@ -1,4 +1,8 @@
+# frozen_string_literal: true
+
+# The Sys module is a namespace only.
 module Sys
+  # The Platform class provides singleton methods to tell you what OS you're on.
   class Platform
     # The CPU architecture
     ARCH = File::ALT_SEPARATOR ? Uname.architecture.to_sym : Uname.machine.to_sym
@@ -8,18 +12,18 @@ module Sys
 
     # Returns the OS type, :macosx, :linux, :mingw32, etc
     IMPL = case Uname.sysname
-      when /darwin|mac/i
-        :macosx
-      when /mingw|windows/i
-        require 'rbconfig'
-        RbConfig::CONFIG['host_os'].split('_').first[/[a-z]+/i].downcase.to_sym
-      when /linux/i
-        :linux
-      when /sunos|solaris/i
-        :solaris
-      when /bsd/i
-        :bsd
-    end
+             when /darwin|mac/i
+               :macosx
+             when /mingw|windows/i
+               require 'rbconfig'
+               RbConfig::CONFIG['host_os'].split('_').first[/[a-z]+/i].downcase.to_sym
+             when /linux/i
+               :linux
+             when /sunos|solaris/i
+               :solaris
+             when /bsd/i
+               :bsd
+           end
 
     # Returns whether or not you're on a Windows OS
     def self.windows?
@@ -28,7 +32,7 @@ module Sys
 
     # Returns whether or not you're on a Unixy (non-Windows) OS
     def self.unix?
-      Uname.sysname !~ /microsoft/i ? true : false
+      Uname.sysname =~ /microsoft/i ? false : true
     end
 
     # Returns whether or not you're on a mac, i.e. OSX

data/lib/sys/uname.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Sys
   class Uname
     # The version of the sys-uname gem.
-    VERSION = '1.2.2'.freeze
+    VERSION = '1.2.3'
   end
 
   class Platform

data/lib/sys/unix/uname.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'ffi'
 require 'rbconfig'
 require 'ostruct'
@@ -30,7 +32,7 @@ module Sys
     private_class_method :uname_c
 
     begin
-      attach_function :sysctl, [:pointer, :uint, :pointer, :pointer, :pointer, :size_t], :int
+      attach_function :sysctl, %i[pointer uint pointer pointer pointer size_t], :int
       private_class_method :sysctl
 
       CTL_HW   = 6   # Generic hardware/cpu
@@ -40,7 +42,7 @@ module Sys
     end
 
     begin
-      attach_function :sysinfo, [:int, :pointer, :long], :long
+      attach_function :sysinfo, %i[int pointer long], :long
       private_class_method :sysinfo
 
       SI_SYSNAME      = 1   # OS name
@@ -59,6 +61,7 @@ module Sys
       # Ignore. Not suppored.
     end
 
+    # FFI class passed to the underlying C uname function.
     class UnameFFIStruct < FFI::Struct
       members = [
         :sysname,  [:char, BUFSIZE],
@@ -68,13 +71,8 @@ module Sys
         :machine,  [:char, BUFSIZE]
       ]
 
-      if RbConfig::CONFIG['host_os'] =~ /linux/i
-        members.push(:domainname, [:char, BUFSIZE])
-      end
-
-      if RbConfig::CONFIG['host_os'] =~ /hpux/i
-        members.push(:__id_number, [:char, BUFSIZE])
-      end
+      members.push(:domainname, [:char, BUFSIZE]) if RbConfig::CONFIG['host_os'] =~ /linux/i
+      members.push(:__id_number, [:char, BUFSIZE]) if RbConfig::CONFIG['host_os'] =~ /hpux/i
 
       layout(*members)
     end
@@ -87,13 +85,8 @@ module Sys
       machine
     ]
 
-    if RbConfig::CONFIG['host_os'] =~ /linux/i
-      fields.push('domainname')
-    end
-
-    if RbConfig::CONFIG['host_os'] =~ /hpux/i
-      fields.push('id_number')
-    end
+    fields.push('domainname') if RbConfig::CONFIG['host_os'] =~ /linux/i
+    fields.push('id_number') if RbConfig::CONFIG['host_os'] =~ /hpux/i
 
     if RbConfig::CONFIG['host_os'] =~ /sunos|solaris/i
       fields.push(
@@ -107,13 +100,13 @@ module Sys
       )
     end
 
-    if RbConfig::CONFIG['host_os'] =~ /darwin|bsd/i
-      fields.push('model')
-    end
+    fields.push('model') if RbConfig::CONFIG['host_os'] =~ /darwin|bsd/i
+
+    private_constant :UnameFFIStruct
 
     # :startdoc:
 
-    UnameStruct = Struct.new("UnameStruct", *fields)
+    UnameStruct = Struct.new('UnameStruct', *fields)
 
     # Returns a struct that contains the sysname, nodename, machine, version
     # and release of your system.
@@ -133,9 +126,7 @@ module Sys
     def self.uname
       utsname = UnameFFIStruct.new
 
-      if uname_c(utsname) < 0
-        raise Error, "uname() function call failed"
-      end
+      raise Error, 'uname() function call failed' if uname_c(utsname) < 0
 
       struct = UnameStruct.new
       struct[:sysname]  = utsname[:sysname].to_s
@@ -144,9 +135,7 @@ module Sys
       struct[:version]  = utsname[:version].to_s
       struct[:machine]  = utsname[:machine].to_s
 
-      if RbConfig::CONFIG['host_os'] =~ /darwin|bsd/i
-        struct[:model] = get_model()
-      end
+      struct[:model] = get_model() if RbConfig::CONFIG['host_os'] =~ /darwin|bsd/i
 
       if RbConfig::CONFIG['host_os'] =~ /sunos|solaris/i
         struct[:architecture] = get_si(SI_ARCHITECTURE)
@@ -165,21 +154,17 @@ module Sys
         struct[:machine]  = get_si(SI_MACHINE) if struct.machine.empty?
       end
 
-      if RbConfig::CONFIG['host_os'] =~ /hpux/i
-        struct[:id_number] = utsname[:__id_number].to_s
-      end
+      struct[:id_number] = utsname[:__id_number].to_s if RbConfig::CONFIG['host_os'] =~ /hpux/i
 
-      if RbConfig::CONFIG['host_os'] =~ /linux/i
-        struct[:domainname] = utsname[:domainname].to_s
-      end
+      struct[:domainname] = utsname[:domainname].to_s if RbConfig::CONFIG['host_os'] =~ /linux/i
 
       # Let's add a members method that works for testing and compatibility
       if struct.members.nil?
-        struct.instance_eval(%Q{
+        struct.instance_eval <<-RUBY, __FILE__, __LINE__ + 1
           def members
-            @table.keys.map{ |k| k.to_s }
+            @table.keys.map(&:to_s)
           end
-        })
+        RUBY
       end
 
       struct.freeze