sys-admin 1.8.0-universal-mingw32 → 1.8.2-universal-mingw32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da216caeef1d2038bbbeace7ed087e6835ec210870a34f89653945ffa2245b72
-  data.tar.gz: 7c36e9ed782cb6be87cdc69cd94ff3c06894afb96cc54fa3db1af06fa48499dc
+  metadata.gz: e0a5f8abb2d51fd89dfaba1749f6ebedc824e53c16f5d19c7a09d8e5964643f6
+  data.tar.gz: b15cbcbdcb14f3c8067f0d445acad1eb4a106a9a0670640b03d04fd45d49ff03
 SHA512:
-  metadata.gz: 6ad2079f20c0d05e4d9d6efac82e560d88f6c78a248131135c7e1455ef02d84bbf0dc628a5913a21689c888be614f5b30b7ce4ab61c63bb9a77c6c44a174420c
-  data.tar.gz: b564a7e2cf651b86ecb08084b13813a33ac199707292fc56f7b3daad770cdd150358b7110dfb53c2913864ebb5d9ec25f1bcac30828c140748fcabfc59f8152f
+  metadata.gz: 5344588bd21a2d4cbff3e845cf3dd1bff33f1e5e1996f499e874b100d40861c01f5646212bd0e860b48c6e67c458a4664092efd136beea30deef467476289b4e
+  data.tar.gz: 7b8852c72276c2480320f3fe680baf1a1339b8b51f87a4558eb96610288ffebef45a53f247bf6ed129c2de838c32db37ce883d0d59d6a449287b9e26313830a9

data/CHANGES.md

@@ -1,9 +1,22 @@
+## 1.8.2 - 9-Apr-2023
+* Lots of rubocop related updates.
+* Refactored specs to use shared specs.
+* The lastlog key will return nil instead of an empty struct if it can't be read.
+* Added more information to the gemspec metadata.
+* The rubocop and rubocop-rspec gems are now development dependencies.
+
+## 1.8.1 - 25-Sep-2021
+* The users and get_user methods on Darwin now take an optional :lastlog key
+  that you can set to false in order to significantly speed up those methods
+  at the expense of taking away lastlog information.
+* Some internal rspec refactoring.
+
 ## 1.8.0 - 26-Aug-2021
 * Switched from test-unit to rspec, with some tests refactored. The Rakefile
   and gemspec files were updated accordingly.
 * The User and Group classes for the Windows implementation are now properly
   scoped under Sys::Admin instead of just Sys.
-* Fixed a bug in the get_user and get_group methods on Winodws where the WQL
+* Fixed a bug in the get_user and get_group methods on Windows where the WQL
   it generates internally might not be correct.
 
 ## 1.7.6 - 24-Mar-2021

data/MANIFEST.md

@@ -15,6 +15,7 @@
 * lib/sunos/sys/admin.rb
 * lib/sys/admin/common.rb
 * lib/sys/admin/custom.rb
-* test/test_sys_admin.rb
-* test/test_sys_admin_unix.rb
-* test/test_sys_admin_windows.rb
+* spec/spec_helper.rb
+* spec/sys_admin_universal_spec.rb
+* spec/sys_admin_unix_spec.rb
+* spec/sys_admin_windows_spec.rb

data/README.md

@@ -1,3 +1,5 @@
+[![Ruby](https://github.com/djberg96/sys-admin/actions/workflows/ruby.yml/badge.svg)](https://github.com/djberg96/sys-admin/actions/workflows/ruby.yml)
+
 ## Description
 The sys-admin library is a unified, cross platform replacement for the Etc module.
    
@@ -142,6 +144,11 @@ The underlying implementation is similar to core Ruby's Etc implementation.
 But, in addition to the different interface, I use the re-entrant version
 of the appropriate functions when available.
 
+### OSX
+The slowdown for collecting lastlog information on OSX seems to have gotten
+progressively worse over time. Do not be surprised by significant slowdowns
+if you opt to collect it.
+
 ## Future Plans
 * Make the User and Group objects comparable.
 * Add ability to add, configure and delete users on Unix platforms.

data/Rakefile

@@ -2,11 +2,12 @@ require 'rake'
 require 'rake/clean'
 require 'rspec/core/rake_task'
 require 'rbconfig'
+require 'rubocop/rake_task'
 
 CLEAN.include("**/*.gem", "**/*.rbx", "**/*.rbc", "ruby.core", "**/*.lock")
 
 namespace :gem do
-  desc "Create the sys-uname gem"
+  desc "Create the sys-admin gem"
   task :create => [:clean] do
     require 'rubygems/package'
     spec = Gem::Specification.load('sys-admin.gemspec')
@@ -14,7 +15,7 @@ namespace :gem do
     Gem::Package.build(spec)
   end
 
-  desc "Install the sys-uname gem"
+  desc "Install the sys-admin gem"
   task :install => [:create] do
     file = Dir["*.gem"].first
     sh "gem install -l #{file}"
@@ -23,7 +24,6 @@ end
 
 desc "Run the specs for the sys-admin library"
 RSpec::Core::RakeTask.new(:spec) do |t|
-  t.pattern = 'spec/sys_admin_unix_spec.rb'
   case RbConfig::CONFIG['host_os']
   when /darwin|osx/i
     t.rspec_opts = '-Ilib/darwin'
@@ -35,10 +35,11 @@ RSpec::Core::RakeTask.new(:spec) do |t|
     t.rspec_opts = '-Ilib/bsd'
   when /windows|win32|mingw|cygwin|dos/i
     t.rspec_opts = '-Ilib/windows'
-    t.pattern = 'spec/sys_admin_windows_spec.rb'
   else
     t.rspec_opts = '-Ilib/unix'
   end
 end
 
+RuboCop::RakeTask.new
+
 task :default => :spec

data/lib/bsd/sys/admin.rb

@@ -1,42 +1,46 @@
+# frozen_string_literal: true
+
 require 'sys/admin/custom'
 require 'sys/admin/common'
 require 'rbconfig'
 
 # The BSD specific code.
 
+# The Sys module serves as a namespace only.
 module Sys
+  # The Admin class provides a unified, cross platform replacement for the Etc module.
   class Admin
     # :no-doc:
     BUF_MAX = 65536 # Max buffer for retry
     private_constant :BUF_MAX
 
     # I'm making some aliases here to prevent potential conflicts
-    attach_function :open_c, :open, [:string, :int], :int
-    attach_function :pread_c, :pread, [:int, :pointer, :size_t, :off_t], :size_t
+    attach_function :open_c, :open, %i[string int], :int
+    attach_function :pread_c, :pread, %i[int pointer size_t off_t], :size_t
     attach_function :close_c, :close, [:int], :int
 
-    attach_function :getlogin_r, [:pointer, :int], :int
-    attach_function :getpwnam_r, [:string, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getpwuid_r, [:long, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getgrnam_r, [:string, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getgrgid_r, [:long, :pointer, :pointer, :size_t, :pointer], :int
+    attach_function :getlogin_r, %i[pointer int], :int
+    attach_function :getpwnam_r, %i[string pointer pointer size_t pointer], :int
+    attach_function :getpwuid_r, %i[long pointer pointer size_t pointer], :int
+    attach_function :getgrnam_r, %i[string pointer pointer size_t pointer], :int
+    attach_function :getgrgid_r, %i[long pointer pointer size_t pointer], :int
 
     private_class_method :getlogin_r, :getpwnam_r, :getpwuid_r, :getgrnam_r, :getgrgid_r
     private_class_method :open_c, :pread_c, :close_c
 
     # struct passwd from /usr/include/pwd.h
     class PasswdStruct < FFI::Struct
-      fields = [
-        :pw_name, :string,
-        :pw_passwd, :string,
-        :pw_uid, :uid_t,
-        :pw_gid, :gid_t,
-        :pw_change, :time_t,
-        :pw_class, :string,
-        :pw_gecos, :string,
-        :pw_dir, :string,
-        :pw_shell, :string,
-        :pw_expire, :time_t
+      fields = %i[
+        pw_name string
+        pw_passwd string
+        pw_uid uid_t
+        pw_gid gid_t
+        pw_change time_t
+        pw_class string
+        pw_gecos string
+        pw_dir string
+        pw_shell string
+        pw_expire time_t
       ]
 
       if RbConfig::CONFIG['host_os'] =~ /freebsd/i
@@ -77,7 +81,7 @@ module Sys
       buf = FFI::MemoryPointer.new(:char, 256)
 
       if getlogin_r(buf, buf.size) != 0
-        raise Error, "getlogin_r function failed: " + strerror(FFI.errno)
+        raise Error, "getlogin_r function failed: #{strerror(FFI.errno)}"
       end
 
       buf.read_string
@@ -98,11 +102,11 @@ module Sys
 
       if uid.is_a?(String)
         if getpwnam_r(uid, temp, buf, buf.size, pbuf) != 0
-          raise Error, "getpwnam_r function failed: " + strerror(FFI.errno)
+          raise Error, "getpwnam_r function failed: #{strerror(FFI.errno)}"
         end
       else
         if getpwuid_r(uid, temp, buf, buf.size, pbuf) != 0
-          raise Error, "getpwuid_r function failed: " + strerror(FFI.errno)
+          raise Error, "getpwuid_r function failed: #{strerror(FFI.errno)}"
         end
       end
 
@@ -242,13 +246,13 @@ module Sys
       begin
         fd = open_c(logfile, File::RDONLY)
 
-        if fd != -1
+        if fd >= 0
           bytes = pread_c(fd, lastlog, lastlog.size, uid * lastlog.size)
           if bytes < 0
-            raise Error, "pread function failed: " + strerror(FFI.errno)
+            raise Error, "pread function failed: #{strerror(FFI.errno)}"
           end
         else
-          nil # Ignore, improper permissions
+          lastlog = nil # Ignore, most likely improper permissions
         end
       ensure
         close_c(fd) if fd && fd >= 0

data/lib/darwin/sys/admin.rb

@@ -1,20 +1,24 @@
+# frozen_string_literal: true
+
 require 'sys/admin/custom'
 require 'sys/admin/common'
 
 # The Darwin specific code.
 
+# The Sys module serves as a namespace only.
 module Sys
+  # The Admin class provides a unified, cross platform replacement for the Etc module.
   class Admin
     # :no-doc:
     BUF_MAX = 65536 # Max buf size for retry.
     private_constant :BUF_MAX
 
-    attach_function :getlogin_r, [:pointer, :int], :int
-    attach_function :getpwnam_r, [:string, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getpwuid_r, [:long, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getgrnam_r, [:string, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getgrgid_r, [:long, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getlastlogx, [:long, :pointer], :pointer
+    attach_function :getlogin_r, %i[pointer int], :int
+    attach_function :getpwnam_r, %i[string pointer pointer size_t pointer], :int
+    attach_function :getpwuid_r, %i[long pointer pointer size_t pointer], :int
+    attach_function :getgrnam_r, %i[string pointer pointer size_t pointer], :int
+    attach_function :getgrgid_r, %i[long pointer pointer size_t pointer], :int
+    attach_function :getlastlogx, %i[long pointer], :pointer
 
     private_class_method :getlogin_r, :getpwnam_r, :getpwuid_r
     private_class_method :getgrnam_r, :getgrgid_r, :getlastlogx
@@ -67,7 +71,7 @@ module Sys
       buf = FFI::MemoryPointer.new(:char, 256)
 
       if getlogin_r(buf, buf.size) != 0
-        raise Error, "getlogin_r function failed: " + strerror(FFI.errno)
+        raise Error, "getlogin_r function failed: #{strerror(FFI.errno)}"
       end
 
       buf.read_string
@@ -80,19 +84,23 @@ module Sys
     #
     #    Sys::Admin.get_user('joe')
     #    Sys::Admin.get_user(501)
+    #    Sys::Admin.get_user('joe', :lastlog => false) # Less info but faster
+    #
+    # Set the :lastlog option to false if you want to ignore lastlog
+    # information and speed this method up considerably.
     #
-    def self.get_user(uid)
+    def self.get_user(uid, options = {})
       buf  = FFI::MemoryPointer.new(:char, 1024)
       pbuf = FFI::MemoryPointer.new(PasswdStruct)
       temp = PasswdStruct.new
 
       if uid.is_a?(String)
         if getpwnam_r(uid, temp, buf, buf.size, pbuf) != 0
-          raise Error, "getpwnam_r function failed: " + strerror(FFI.errno)
+          raise Error, "getpwnam_r function failed: #{strerror(FFI.errno)}"
         end
       else
         if getpwuid_r(uid, temp, buf, buf.size, pbuf) != 0
-          raise Error, "getpwuid_r function failed: " + strerror(FFI.errno)
+          raise Error, "getpwuid_r function failed: #{strerror(FFI.errno)}"
         end
       end
 
@@ -103,7 +111,7 @@ module Sys
       end
 
       pwd = PasswdStruct.new(ptr)
-      get_user_from_struct(pwd)
+      get_user_from_struct(pwd, options)
     end
 
     # Returns a Group object for the given name or uid. Raises an error
@@ -148,11 +156,19 @@ module Sys
 
     # Returns an array of User objects for each user on the system.
     #
+    # Examples:
+    #
+    #   Sys::Admin.users
+    #   Sys::Admin.users(:lastlog => false) # Less info but faster
+    #
+    # Note that on Darwin this method can be very slow. If you want to
+    # speed it up considerably by ignoring lastlog information then set
+    # the :lastlog option to false as part of the +options+ hash.
     #--
     # This method is somewhat slow on OSX because of the call to get
     # lastlog information. I'm not sure why.
     #
-    def self.users
+    def self.users(options = {})
       users = []
 
       begin
@@ -160,7 +176,7 @@ module Sys
 
         until (ptr = getpwent()).null?
           pwd = PasswdStruct.new(ptr)
-          users << get_user_from_struct(pwd)
+          users << get_user_from_struct(pwd, options)
         end
       ensure
         endpwent()
@@ -201,7 +217,7 @@ module Sys
     private_class_method :get_group_from_struct
 
     # Takes a UserStruct and converts it to a User object.
-    def self.get_user_from_struct(pwd)
+    def self.get_user_from_struct(pwd, options)
       user = User.new do |u|
         u.name         = pwd[:pw_name]
         u.passwd       = pwd[:pw_passwd]
@@ -215,12 +231,14 @@ module Sys
         u.expire       = Time.at(pwd[:pw_expire])
       end
 
-      log = get_lastlog_info(user.uid)
+      unless options[:lastlog] == false
+        log = get_lastlog_info(user.uid)
 
-      if log
-        user.login_time = Time.at(log[:tv_sec])
-        user.login_device = log[:ll_line].to_s
-        user.login_host = log[:ll_host].to_s
+        if log
+          user.login_time = Time.at(log[:tv_sec])
+          user.login_device = log[:ll_line].to_s
+          user.login_host = log[:ll_host].to_s
+        end
       end
 
       user

data/lib/linux/sys/admin.rb

@@ -1,25 +1,29 @@
+# frozen_string_literal: true
+
 require 'sys/admin/custom'
 require 'sys/admin/common'
 
 # The Linux specific code.
 
+# The Sys module serves as a namespace only.
 module Sys
+  # The Admin class provides a unified, cross platform replacement for the Etc module.
   class Admin
     # :no-doc:
     BUF_MAX = 65536 # Absolute max buffer size for retry attempts.
     private_constant :BUF_MAX
 
     # I'm making some aliases here to prevent potential conflicts
-    attach_function :open_c, :open, [:string, :int], :int
-    attach_function :pread_c, :pread, [:int, :pointer, :size_t, :off_t], :size_t
+    attach_function :open_c, :open, %i[string int], :int
+    attach_function :pread_c, :pread, %i[int pointer size_t off_t], :size_t
     attach_function :close_c, :close, [:int], :int
 
-    attach_function :getpwnam_r, [:string, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getpwuid_r, [:long, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getpwent_r, [:pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getgrent_r, [:pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getgrnam_r, [:string, :pointer, :pointer, :size_t, :pointer], :int
-    attach_function :getgrgid_r, [:long, :pointer, :pointer, :size_t, :pointer], :int
+    attach_function :getpwnam_r, %i[string pointer pointer size_t pointer], :int
+    attach_function :getpwuid_r, %i[long pointer pointer size_t pointer], :int
+    attach_function :getpwent_r, %i[pointer pointer size_t pointer], :int
+    attach_function :getgrent_r, %i[pointer pointer size_t pointer], :int
+    attach_function :getgrnam_r, %i[string pointer pointer size_t pointer], :int
+    attach_function :getgrgid_r, %i[long pointer pointer size_t pointer], :int
 
     private_class_method :getgrent_r, :getgrnam_r, :getgrgid_r
     private_class_method :open_c, :pread_c, :close_c
@@ -83,11 +87,11 @@ module Sys
 
       if uid.is_a?(String)
         if getpwnam_r(uid, temp, buf, buf.size, pbuf) != 0
-          raise Error, "getpwnam_r function failed: " + strerror(FFI.errno)
+          raise Error, "getpwnam_r function failed: #{strerror(FFI.errno)}"
         end
       else
         if getpwuid_r(uid, temp, buf, buf.size, pbuf) != 0
-          raise Error, "getpwuid_r function failed: " + strerror(FFI.errno)
+          raise Error, "getpwuid_r function failed: #{strerror(FFI.errno)}"
         end
       end
 
@@ -239,7 +243,7 @@ module Sys
 
     private_class_method :get_user_from_struct
 
-    # Note: it seems that Linux, or at least Ubuntu, does not track logins
+    # NOTE: It seems that Linux, or at least Ubuntu, does not track logins
     # via GDM (Gnome Display Manager) for some reason, so this may not return
     # anything useful.
     #
@@ -252,13 +256,13 @@ module Sys
       begin
         fd = open_c(logfile, File::RDONLY)
 
-        if fd != -1
+        if fd >= 0
           bytes = pread_c(fd, lastlog, lastlog.size, uid * lastlog.size)
           if bytes < 0
-            raise Error, "pread function failed: " + strerror(FFI.errno)
+            raise Error, "pread function failed: #{strerror(FFI.errno)}"
           end
         else
-          nil # Ignore, improper permissions
+          lastlog = nil # Ignore, most likely improper permissions
         end
       ensure
         close_c(fd) if fd && fd >= 0

data/lib/sunos/sys/admin.rb

@@ -1,26 +1,30 @@
+# frozen_string_literal: true
+
 require 'sys/admin/custom'
 require 'sys/admin/common'
 
 # The Solaris specific code.
 
+# The Sys module serves as a namespace only.
 module Sys
+  # The Admin class provides a unified, cross platform replacement for the Etc module.
   class Admin
     # :no-doc:
     BUF_MAX = 65536 # Max buffer size for retry.
     private_constant :BUF_MAX
 
     # I'm making some aliases here to prevent potential conflicts
-    attach_function :open_c, :open, [:string, :int], :int
-    attach_function :pread_c, :pread, [:int, :pointer, :size_t, :off_t], :size_t
+    attach_function :open_c, :open, %i[string int], :int
+    attach_function :pread_c, :pread, %i[int pointer size_t off_t], :size_t
     attach_function :close_c, :close, [:int], :int
 
-    attach_function :getlogin_r, [:pointer, :size_t], :pointer
-    attach_function :getpwnam_r, [:string, :pointer, :pointer, :size_t], :pointer
-    attach_function :getpwuid_r, [:long, :pointer, :pointer, :size_t], :pointer
-    attach_function :getpwent_r, [:pointer, :pointer, :int], :pointer
-    attach_function :getgrent_r, [:pointer, :pointer, :int], :pointer
-    attach_function :getgrnam_r, [:string, :pointer, :pointer, :int], :pointer
-    attach_function :getgrgid_r, [:long, :pointer, :pointer, :int], :pointer
+    attach_function :getlogin_r, %i[pointer size_t], :pointer
+    attach_function :getpwnam_r, %i[string pointer pointer size_t], :pointer
+    attach_function :getpwuid_r, %i[long pointer pointer size_t], :pointer
+    attach_function :getpwent_r, %i[pointer pointer int], :pointer
+    attach_function :getgrent_r, %i[pointer pointer int], :pointer
+    attach_function :getgrnam_r, %i[string pointer pointer int], :pointer
+    attach_function :getgrgid_r, %i[long pointer pointer int], :pointer
 
     private_class_method :getlogin_r, :getpwnam_r, :getpwuid_r, :getpwent_r
     private_class_method :getgrent_r, :getgrnam_r, :getgrgid_r
@@ -74,7 +78,7 @@ module Sys
       ptr = getlogin_r(buf, buf.size)
 
       if ptr.null?
-        raise Error, "getlogin_r function failed: " + strerror(FFI.errno)
+        raise Error, "getlogin_r function failed: #{strerror(FFI.errno)}"
       end
 
       buf.read_string
@@ -99,7 +103,7 @@ module Sys
       end
 
       if ptr.null?
-        raise Error, "getpwnam_r or getpwuid_r function failed: " + strerror(FFI.errno)
+        raise Error, "getpwnam_r or getpwuid_r function failed: #{strerror(FFI.errno)}"
       end
 
       pwd = PasswdStruct.new(ptr)
@@ -251,7 +255,7 @@ module Sys
         if fd != -1
           bytes = pread_c(fd, lastlog, lastlog.size, uid * lastlog.size)
           if bytes < 0
-            raise Error, "pread function failed: " + strerror(FFI.errno)
+            raise Error, "pread function failed: #{strerror(FFI.errno)}"
           end
         else
           nil # Ignore, improper permissions

data/lib/sys/admin/common.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'ffi'
 
 # The Sys module serves as a namespace only.
 module Sys
-
   # The Admin class provides a unified, cross platform replacement
   # for the Etc module.
   class Admin
@@ -99,9 +100,9 @@ module Sys
       def groups
         array = []
 
-        Sys::Admin.groups.each{ |grp|
-          array << grp.name if grp.members.include?(self.name)
-        }
+        Sys::Admin.groups.each do |grp|
+          array << grp.name if grp.members.include?(name)
+        end
 
         array
       end

data/lib/sys/admin/custom.rb

@@ -1,14 +1,17 @@
+# frozen_string_literal: true
+
 require 'ffi'
 
+# Re-open the FFI::Pointer class to add a custom method.
 class FFI::Pointer
   def read_array_of_string
     elements = []
 
     loc = self
 
-    until ((element = loc.read_pointer).null?)
-     elements << element.read_string
-     loc += FFI::Type::POINTER.size
+    until (element = loc.read_pointer).null?
+      elements << element.read_string
+      loc += FFI::Type::POINTER.size
     end
 
     elements

data/lib/sys/admin.rb

@@ -1,7 +1,13 @@
+# frozen_string_literal: true
+
+# The Sys modules serves as a namespace only.
 module Sys
+  # The Admin class provides a unified, cross platform replacement for the Etc module.
   class Admin
     # The version of the sys-admin library.
-    VERSION = '1.8.0'.freeze
+    VERSION = '1.8.2'
+
+    private_class_method :new
   end
 end
 

data/lib/sys-admin.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require_relative 'sys/admin'

data/lib/unix/sys/admin.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'sys/admin/custom'
 require 'sys/admin/common'
 
 # Code used as a fallback for UNIX platforms.
 
+# The Sys module serves as a namespace only.
 module Sys
+  # The Admin class provides a unified, cross platform replacement for the Etc module.
   class Admin
     class PasswdStruct < FFI::Struct
       layout(
@@ -55,7 +59,7 @@ module Sys
         raise Error, "no user found for: #{uid}"
       end
 
-      user = User.new do |u|
+      User.new do |u|
         u.name   = pwd[:pw_name]
         u.passwd = pwd[:pw_passwd]
         u.uid    = pwd[:pw_uid]
@@ -64,8 +68,6 @@ module Sys
         u.dir    = pwd[:pw_dir]
         u.shell  = pwd[:pw_shell]
       end
-
-      user
     end
 
     # Returns a Group object for the given name or uid. Raises an error
@@ -147,7 +149,7 @@ module Sys
 
     # Takes a UserStruct and converts it to a User object.
     def self.get_user_from_struct(pwd)
-      user = User.new do |u|
+      User.new do |u|
         u.name         = pwd[:pw_name]
         u.passwd       = pwd[:pw_passwd]
         u.uid          = pwd[:pw_uid]
@@ -156,8 +158,6 @@ module Sys
         u.dir          = pwd[:pw_dir]
         u.shell        = pwd[:pw_shell]
       end
-
-      user
     end
 
     private_class_method :get_user_from_struct