synvert 0.0.17 → 0.1.0

data/lib/synvert/snippets/rails/strong_parameters.rb

@@ -1,93 +0,0 @@
-Synvert::Rewriter.new "strong_parameters" do
-  description <<-EOF
-It uses string_parameters to replace attr_accessible.
-
-1. it removes active_record configurations.
-
-    config.active_record.whitelist_attributes = ...
-    config.active_record.mass_assignment_sanitizer = ...
-
-2. it removes attr_accessible and attr_protected code in models.
-
-3. it adds xxx_params in controllers
-
-    def xxx_params
-      params.require(:xxx).permit(...)
-    end
-
-4. it replaces params[:xxx] with xxx_params.
-
-    params[:xxx] => xxx_params
-  EOF
-
-  within_files 'config/**/*.rb' do
-    # remove config.active_record.whitelist_attributes = ...
-    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'whitelist_attributes=' do
-      remove
-    end
-
-    # remove config.active_record.mass_assignment_sanitizer = ...
-    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'mass_assignment_sanitizer=' do
-      remove
-    end
-  end
-
-  attributes = {}
-  within_file 'db/schema.rb' do
-    within_node type: 'block', caller: {type: 'send', message: 'create_table'} do
-      object_name = eval(node.caller.arguments.first.source(self)).singularize
-      attributes[object_name] = []
-      with_node type: 'send', receiver: 't' do
-        attribute_name = eval(node.arguments.first.source(self)).to_sym
-        attributes[object_name] << attribute_name
-      end
-    end
-  end
-
-  parameters = {}
-  within_files 'app/models/**/*.rb' do
-    # assign and remove attr_accessible ...
-    within_node type: 'class' do
-      object_name = node.name.source(self).underscore
-      with_node type: 'send', message: 'attr_accessible' do
-        parameters[object_name] = node.arguments.map { |key| eval(key.source(self)) }
-        remove
-      end
-    end
-
-    # assign and remove attr_protected ...
-    within_node type: 'class' do
-      object_name = node.name.source(self).underscore
-      with_node type: 'send', message: 'attr_protected' do
-        parameters[object_name] = attributes[object_name] - node.arguments.map { |key| eval(key.source(self)) }
-        remove
-      end
-    end
-  end
-
-  within_file 'app/controllers/**/*.rb' do
-    within_node type: 'class' do
-      object_name = node.name.source(self).sub('Controller', '').singularize.underscore
-      if_exist_node type: 'send', receiver: 'params', message: '[]', arguments: [object_name.to_sym] do
-        if parameters[object_name]
-          # append def xxx_params; ...; end
-          permit_params = ":" + parameters[object_name].join(", :")
-          unless_exist_node type: 'def', name: "#{object_name}_params" do
-            new_code =  "def #{object_name}_params\n"
-            new_code << "  params.require(:#{object_name}).permit(#{permit_params})\n"
-            new_code << "end"
-            append new_code
-          end
-
-          # params[:xxx] => xxx_params
-          with_node type: 'send', receiver: 'params', message: '[]' do
-            object_name = eval(node.arguments.first.source(self)).to_s
-            if parameters[object_name]
-              replace_with "#{object_name}_params"
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/synvert/snippets/rails/upgrade_3_0_to_3_1.rb

@@ -1,135 +0,0 @@
-Synvert::Rewriter.new 'upgrade_rails_3_0_to_3_1' do
-  description <<-EOF
-It upgrade rails from 3.0 to 3.1.
-
-1. it enables asset pipeline.
-
-    config.assets.enabled = true
-    config.assets.version = '1.0'
-
-2. it removes config.action_view.debug_rjs in config/environments/development.rb
-
-3. it adds asset pipeline configs in config/environments/development.rb
-
-    # Do not compress assets
-    config.assets.compress = false
-
-    # Expands the lines which load the assets
-    config.assets.debug = true
-
-4. it adds asset pipeline configs in config/environments/production.rb
-
-    # Compress JavaScripts and CSS
-    config.assets.compress = true
-
-    # Don't fallback to assets pipeline if a precompiled asset is missed
-    config.assets.compile = false
-
-     # Generate digests for assets URLs
-     config.assets.digest = true
-
-5. it adds asset pipeline configs in config/environments/test.rb
-
-    # Configure static asset server for tests with Cache-Control for performance
-    config.serve_static_assets = true
-    config.static_cache_control = "public, max-age=3600"
-
-6. it creates config/environments/wrap_parameters.rb.
-
-7. it replaces session_store in config/initializers/session_store.rb
-
-    Application.session_store :cookie_store, key: '_xxx-session'
-  EOF
-
-  if_gem 'rails', {gte: '3.0.0'}
-
-  within_file 'config/application.rb' do
-    # insert config.assets.version = '1.0'
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'version=' do
-      insert "config.assets.version = '1.0'"
-    end
-
-    # insert config.assets.enabled = true
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'enabled=' do
-      insert 'config.assets.enabled = true'
-    end
-  end
-
-  within_file 'config/environments/development.rb' do
-    # remove config.action_view.debug_rjs = true
-    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'action_view'}, message: 'debug_rjs=' do
-      remove
-    end
-
-    # insert config.assets.debug = true
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'debug=' do
-      insert "config.assets.debug = true"
-    end
-
-    # insert config.assets.compress = false
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'compress=' do
-      insert "config.assets.compress = false"
-    end
-  end
-
-  within_file 'config/environments/production.rb' do
-    # insert config.assets.digest = true
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'digest=' do
-      insert "config.assets.digest = true"
-    end
-
-    # insert config.assets.compile = false
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'compile=' do
-      insert "config.assets.compile = false"
-    end
-
-    # insert config.assets.compress = true
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'compress=' do
-      insert "config.assets.compress = true"
-    end
-  end
-
-  within_file 'config/environments/test.rb' do
-    # insert config.static_cache_control = "public, max-age=3600"
-    unless_exist_node type: 'send', receiver: {type: 'send', message: 'config'}, message: 'static_cache_control=' do
-      insert 'config.static_cache_control = "public, max-age=3600"'
-    end
-
-    # insert config.serve_static_assets = true
-    unless_exist_node type: 'send', receiver: {type: 'send', message: 'config'}, message: 'serve_static_assets=' do
-      insert "config.serve_static_assets = true"
-    end
-  end
-
-  # add config/initializers/wrap_parameters.rb'
-  new_code =  "# Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.\n"
-  new_code << "ActiveSupport.on_load(:action_controller) do\n"
-  new_code << "  wrap_parameters format: [:json]\n"
-  new_code << "end\n"
-  new_code << "\n"
-  new_code << "# Disable root element in JSON by default.\n"
-  new_code << "ActiveSupport.on_load(:active_record) do\n"
-  new_code << "  self.include_root_in_json = false\n"
-  new_code << "end"
-  add_file 'config/initializers/wrap_parameters.rb', new_code
-
-  within_file 'config/initializers/session_store.rb' do
-    # add Application.session_store :cookie_store, key: '_xxx-session'
-    with_node type: 'send', receiver: {type: 'send', message: 'config'}, message: 'session_store', arguments: {first: :cookie_store} do
-      session_store_key = node.receiver.receiver.source(self).split(":").first.underscore
-      replace_with "{{receiver}}.session_store :cookie_store, key: '_#{session_store_key}-session'"
-    end
-  end
-
-  todo <<-EOF
-Make the following changes to your Gemfile.
-
-    group :assets do
-      gem 'sass-rails',   "~> 3.1.5"
-      gem 'coffee-rails', "~> 3.1.1"
-      gem 'uglifier',     ">= 1.0.3"
-    end
-
-    gem 'jquery-rails'
-  EOF
-end

data/lib/synvert/snippets/rails/upgrade_3_1_to_3_2.rb

@@ -1,42 +0,0 @@
-Synvert::Rewriter.new 'upgrade_rails_3_1_to_3_2' do
-  description <<-EOF
-It upgrades rails from 3.1 to 3.2.
-
-1. it insrts new configs in config/environments/development.rb.
-
-    config.active_record.mass_assignment_sanitizer = :strict
-    config.active_record.auto_explain_threshold_in_seconds = 0.5
-
-2. it insert new configs in config/environments/test.rb.
-
-    config.active_record.mass_assignment_sanitizer = :strict
-  EOF
-
-  if_gem 'rails', {gte: '3.1.0'}
-
-  within_file 'config/environments/development.rb' do
-    # insert config.active_record.auto_explain_threshold_in_seconds = 0.5
-    unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'auto_explain_threshold_in_seconds=' do
-      insert 'config.active_record.auto_explain_threshold_in_seconds = 0.5'
-    end
-  end
-
-  %w(config/environments/development.rb config/environments/test.rb).each do |file_pattern|
-    within_file file_pattern do
-      # insert config.active_record.mass_assignment_sanitizer = :strict
-      unless_exist_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'mass_assignment_sanitizer=' do
-        insert 'config.active_record.mass_assignment_sanitizer = :strict'
-      end
-    end
-  end
-
-  todo <<-EOF
-Make the following changes to your Gemfile.
-
-    group :assets do
-      gem 'sass-rails',   '~> 3.2.3'
-      gem 'coffee-rails', '~> 3.2.1'
-      gem 'uglifier',     '>= 1.0.3'
-    end
-  EOF
-end

data/lib/synvert/snippets/rails/upgrade_3_2_to_4_0.rb

@@ -1,230 +0,0 @@
-require 'securerandom'
-
-Synvert::Rewriter.new "upgrade_rails_3_2_to_4_0" do
-  description <<-EOF
-It upgrades rails from 3.2 to 4.0.
-
-1. it removes assets group in config/application.rb.
-
-    if defined?(Bundler)
-      Bundler.require(*Rails.groups(:assets => %w(development test)))
-    end
-    => Bundler.require(:default, Rails.env)
-
-2. it removes config.active_record.identity_map = true from config files.
-
-3. it changes config.assets.compress = ... to config.assets.js_compressor = ...
-
-4. it removes include_root_in_json from config/initializers/secret_token.rb.
-
-    ActiveSupport.on_load(:active_record) do
-      self.include_root_in_json = false
-    end
-
-5. it inserts secret_key_base to config/initializers/session_store.rb.
-
-    Application.config.secret_key_base = '...'
-
-6. it removes config.action_dispatch.best_standards_support = ... from config files.
-
-7. it inserts config.eager_load = true in config/environments/production.rb.
-
-8. it inserts config.eager_load = false in config/environments/development.rb.
-
-9. it inserts config.eager_load = false in config/environments/test.rb.
-
-10. it removes any code using ActionDispatch::BestStandardsSupport in config files.
-
-11. it replaces ActionController::Base.page_cache_extension = ... with ActionController::Base.default_static_extension = ... in config files.
-
-12. it removes Rack::Utils.escape in config/routes.rb.
-
-    Rack::Utils.escape('こんにちは') => 'こんにちは'
-
-13. it replaces match in config/routes.rb.
-
-    match "/" => "root#index" => get "/" => "root#index"
-
-14. it removes rename_index in db migrations.
-
-15. it replaces instance method serialized_attributes with class method.
-
-    self.serialized_attributes => self.class.serialized_attributes
-
-16. it adds lambda for scope.
-
-    scope :active, where(active: true) => scope :active, -> { where(active: true) }
-
-17. it replaces ActiveRecord::Fixtures with ActiveRecord::FixtureSet.
-       replaces ActiveRecord::TestCase with ActiveSupport::TestCase.
-       replaces ActionController::Integration with ActionDispatch::Integration
-       replaces ActionController::IntegrationTest with ActionDispatch::IntegrationTest
-       replaces ActionController::PerformanceTest with ActionDispatch::PerformanceTest
-       replaces ActionController::AbstractRequest with ActionDispatch::Request
-       replaces ActionController::Request with ActionDispatch::Request
-       replaces ActionController::AbstractResponse with ActionDispatch::Response
-       replaces ActionController::Response with ActionDispatch::Response
-       replaces ActionController::Routing with ActionDispatch::Routing
-
-18. it calls another snippet convert_rails_dynamic_finder.
-
-19. it calls another snippet strong_parameters.
-  EOF
-
-  if_gem 'rails', {gte: '3.2.0'}
-
-  within_file 'config/application.rb' do
-    # if defined?(Bundler)
-    #   Bundler.require(*Rails.groups(:assets => %w(development test)))
-    # end
-    # => Bundler.require(:default, Rails.env)
-    with_node type: 'if', condition: {type: 'defined?', arguments: ['Bundler']} do
-      replace_with 'Bundler.require(:default, Rails.env)'
-    end
-  end
-
-  within_file 'config/**/*.rb' do
-    # remove config.active_record.identity_map = true
-    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'identity_map=' do
-      remove
-    end
-  end
-
-  within_file 'config/**/*.rb' do
-    # config.assets.compress = ... => config.assets.js_compressor = ...
-    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'assets'}, message: 'compress=' do
-      replace_with "config.assets.js_compressor = {{arguments}}"
-    end
-  end
-
-  within_file 'config/initializers/wrap_parameters.rb' do
-    # remove
-    # ActiveSupport.on_load(:active_record) do
-    #   self.include_root_in_json = false
-    # end
-    with_node type: 'block', caller: {receiver: 'ActiveSupport', message: 'on_load', arguments: [:active_record]} do
-      if_only_exist_node type: 'send', receiver: 'self', message: 'include_root_in_json=', arguments: [false] do
-        remove
-      end
-    end
-  end
-
-  within_file 'config/initializers/secret_token.rb' do
-    # insert Application.config.secret_key_base = '...'
-    unless_exist_node type: 'send', message: 'secret_key_base=' do
-      with_node type: 'send', message: 'secret_token=' do
-        secret = SecureRandom.hex(64)
-        insert_after "{{receiver}}.secret_key_base = \"#{secret}\""
-      end
-    end
-  end
-
-  within_files 'config/**/*.rb' do
-    # remove config.action_dispatch.best_standards_support = ...
-    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'action_dispatch'}, message: 'best_standards_support=' do
-      remove
-    end
-  end
-
-  within_file 'config/environments/production.rb' do
-    # insert config.eager_load = true
-    unless_exist_node type: 'send', message: 'eager_load=' do
-      insert 'config.eager_load = true'
-    end
-  end
-
-  within_file 'config/environments/development.rb' do
-    # insert config.eager_load = false
-    unless_exist_node type: 'send', message: 'eager_load=' do
-      insert 'config.eager_load = false'
-    end
-  end
-
-  within_file 'config/environments/test.rb' do
-    # insert config.eager_load = false
-    unless_exist_node type: 'send', message: 'eager_load=' do
-      insert 'config.eager_load = false'
-    end
-  end
-
-  within_files 'config/**/*.rb' do
-    # remove config.middleware.xxx(..., ActionDispatch::BestStandardsSupport)
-    with_node type: 'send', arguments: {any: 'ActionDispatch::BestStandardsSupport'} do
-      remove
-    end
-  end
-
-  within_files 'config/**/*.rb' do
-    # ActionController::Base.page_cache_extension = ... => ActionController::Base.default_static_extension = ...
-    with_node type: 'send', message: 'page_cache_extension=' do
-      replace_with 'ActionController::Base.default_static_extension = {{arguments}}'
-    end
-  end
-
-  within_file 'config/routes.rb' do
-    # Rack::Utils.escape('こんにちは') => 'こんにちは'
-    with_node type: 'send', receiver: 'Rack::Utils', message: 'escape' do
-      replace_with '{{arguments}}'
-    end
-  end
-
-  within_file 'config/routes.rb' do
-    # match "/" => "root#index" => get "/" => "root#index"
-    with_node type: 'send', message: 'match' do
-      replace_with 'get {{arguments}}'
-    end
-  end
-
-  within_files 'db/migrate/*.rb' do
-    # remove rename_index ...
-    with_node type: 'send', message: 'rename_index' do
-      remove
-    end
-  end
-
-  within_files 'app/models/**/*.rb' do
-    # self.serialized_attributes => self.class.serialized_attributes
-    with_node type: 'send', receiver: 'self', message: 'serialized_attributes' do
-      replace_with 'self.class.serialized_attributes'
-    end
-  end
-
-  within_files 'app/models/**/*.rb' do
-    # scope :active, where(active: true) => scope :active, -> { where(active: true) }
-    with_node type: 'send', receiver: nil, message: 'scope' do
-      unless_exist_node type: 'block', caller: {type: 'send', message: 'lambda'} do
-        replace_with 'scope {{arguments.first}}, -> { {{arguments.last}} }'
-      end
-    end
-  end
-
-  within_files '**/*.rb' do
-    {'ActiveRecord::Fixtures' => 'ActiveRecord::FixtureSet',
-     'ActiveRecord::TestCase' => 'ActiveSupport::TestCase',
-     'ActionController::Integration' => 'ActionDispatch::Integration',
-     'ActionController::IntegrationTest' => 'ActionDispatch::IntegrationTest',
-     'ActionController::PerformanceTest' => 'ActionDispatch::PerformanceTest',
-     'ActionController::AbstractRequest' => 'ActionDispatch::Request',
-     'ActionController::Request' => 'ActionDispatch::Request',
-     'ActionController::AbstractResponse' => 'ActionDispatch::Response',
-     'ActionController::Response' => 'ActionDispatch::Response',
-     'ActionController::Routing' => 'ActionDispatch::Routing'}.each do |deprecated, favor|
-      with_node source: deprecated do
-        replace_with favor
-      end
-    end
-  end
-
-  add_snippet 'convert_rails_dynamic_finders'
-  add_snippet 'strong_parameters'
-
-  todo <<-EOF
-1. Rails 4.0 no longer supports loading plugins from vendor/plugins. You must replace any plugins by extracting them to gems and adding them to your Gemfile. If you choose not to make them gems, you can move them into, say, lib/my_plugin/* and add an appropriate initializer in config/initializers/my_plugin.rb.
-
-2.  Make the following changes to your Gemfile.
-
-    gem 'sass-rails', '~> 4.0.0'
-    gem 'coffee-rails', '~> 4.0.0'
-    gem 'uglifier', '>= 1.3.0'
-  EOF
-end

data/lib/synvert/snippets/rspec/be_close_to_be_within.rb

@@ -1,18 +0,0 @@
-Synvert::Rewriter.new "convert_rspec_be_close_to_be_within" do
-  description <<-EOF
-It converts rspec be_close matcher to be_within matcher.
-
-    expect(1.0 / 3.0).to be_close(0.333, 0.001) => expect(1.0 / 3.0).to be_within(0.001).of(0.333)
-  EOF
-
-  if_gem 'rspec', {gte: '2.1.0'}
-
-  within_files 'spec/**/*.rb' do
-    # expect(1.0 / 3.0).to be_close(0.333, 0.001) => expect(1.0 / 3.0).to be_within(0.001).of(0.333)
-    with_node type: 'send', message: 'to', arguments: {first: {type: 'send', message: 'be_close'}} do
-      within_arg = node.arguments.first.arguments.last.source(self)
-      of_arg = node.arguments.first.arguments.first.source(self)
-      replace_with "{{receiver}}.to be_within(#{within_arg}).of(#{of_arg})"
-    end
-  end
-end

data/lib/synvert/snippets/rspec/block_to_expect.rb

@@ -1,22 +0,0 @@
-Synvert::Rewriter.new "convert_rspec_block_to_expect" do
-  description <<-EOF
-It converts rspec block to expect.
-
-    lambda { do_something }.should raise_error => expect { do_something }.to raise_error
-    proc { do_something }.should raise_error => expect { do_something }.to raise_error
-    -> { do_something }.should raise_error => expect { do_something }.to raise_error
-  EOF
-
-  if_gem 'rspec', {gte: '2.11.0'}
-
-  within_files 'spec/**/*.rb' do
-    # lambda { do_something }.should raise_error => expect { do_something }.to raise_error
-    # proc { do_something }.should raise_error => expect { do_something }.to raise_error
-    # -> { do_something }.should raise_error => expect { do_something }.to raise_error
-    {should: 'to', should_not: 'not_to'}.each do |old_message, new_message|
-      with_node type: 'send', receiver: {type: 'block'}, message: old_message do
-        replace_with "expect { {{receiver.body}} }.#{new_message} {{arguments}}"
-      end
-    end
-  end
-end

data/lib/synvert/snippets/rspec/boolean_matcher.rb

@@ -1,20 +0,0 @@
-Synvert::Rewriter.new "convert_rspec_boolean_matcher" do
-  description <<-EOF
-It converts rspec boolean matcher.
-
-    be_true => be_truthy
-    be_false => be_falsey
-  EOF
-
-  if_gem 'rspec', {gte: '2.99.0'}
-
-  within_files 'spec/**/*_spec.rb' do
-    # be_true => be_truthy
-    # be_false => be_falsey
-    {be_true: 'be_truthy', be_false: 'be_falsey'}.each do |old_matcher, new_matcher|
-      with_node type: 'send', receiver: nil, message: old_matcher do
-        replace_with new_matcher
-      end
-    end
-  end
-end

data/lib/synvert/snippets/rspec/collection_matcher.rb

@@ -1,34 +0,0 @@
-Synvert::Rewriter.new "convert_rspec_collection_matcher" do
-  description <<-EOF
-It converts rspec collection matcher.
-
-    expect(collection).to have(3).items => expect(collection.size).to eq(3)
-    expect(collection).to have_exactly(3).items => expect(collection.size).to eq(3)
-    expect(collection).to have_at_least(3).items => expect(collection.size).to be >= 3
-    expect(collection).to have_at_most(3).items => expect(collection.size).to be <= 3
-
-    expect(team).to have(3).players => expect(team.players.size).to eq 3
-  EOF
-
-  if_gem 'rspec', {gte: '2.11.0'}
-
-  within_files 'spec/**/*_spec.rb' do
-    # expect(collection).to have(3).items => expect(collection.size).to eq(3)
-    # expect(collection).to have_exactly(3).items => expect(collection.size).to eq(3)
-    # expect(collection).to have_at_least(3).items => expect(collection.size).to be >= 3
-    # expect(collection).to have_at_most(3).items => expect(collection.size).to be <= 3
-    #
-    # expect(team).to have(3).players => expect(team.players.size).to eq 3
-    {have: 'eq', have_exactly: 'eq', have_at_least: 'be >=', have_at_most: 'be <='}.each do |old_matcher, new_matcher|
-      with_node type: 'send', message: 'to', arguments: {first: {type: 'send', receiver: {type: 'send', message: old_matcher}}} do
-        times = node.arguments.first.receiver.arguments.first.source(self)
-        items_name = node.arguments.first.message
-        if :items == items_name
-          replace_with "expect({{receiver.arguments}}.size).to #{new_matcher} #{times}"
-        else
-          replace_with "expect({{receiver.arguments}}.#{items_name}.size).to #{new_matcher} #{times}"
-        end
-      end
-    end
-  end
-end