synvert 0.0.13 → 0.0.14

data/spec/synvert/rewriter_spec.rb

@@ -2,10 +2,18 @@ require 'spec_helper'
 
 module Synvert
   describe Rewriter do
+    it 'parses description' do
+      rewriter = Rewriter.new 'name' do
+        description 'rewriter description'
+      end
+      rewriter.process
+      expect(rewriter.description).to eq 'rewriter description'
+    end
+
     it 'parses if_gem' do
-      expect(Rewriter::GemSpec).to receive(:new).with('synvert', '1.0.0')
-      rewriter = Rewriter.new 'name', 'description' do
-        if_gem 'synvert', '1.0.0'
+      expect(Rewriter::GemSpec).to receive(:new).with('synvert', {gte: '1.0.0'})
+      rewriter = Rewriter.new 'name' do
+        if_gem 'synvert', {gte: '1.0.0'}
       end
       rewriter.process
     end
@@ -14,7 +22,7 @@ module Synvert
       it 'does nothing if if_gem not match' do
         expect_any_instance_of(Rewriter::GemSpec).to receive(:match?).and_return(false)
         expect_any_instance_of(Rewriter::Instance).not_to receive(:process)
-        rewriter = Rewriter.new 'name', 'description' do
+        rewriter = Rewriter.new 'name' do
           if_gem 'synvert', '1.0.0'
           within_file 'config/routes.rb' do; end
         end
@@ -23,7 +31,7 @@ module Synvert
 
       it 'delegates process to instances if if_gem not exist' do
         expect_any_instance_of(Rewriter::Instance).to receive(:process)
-        rewriter = Rewriter.new 'name', 'description' do
+        rewriter = Rewriter.new 'name' do
           within_file 'config/routes.rb' do; end
         end
         rewriter.process
@@ -32,67 +40,91 @@ module Synvert
       it 'delegates process to instances if if_gem matches' do
         expect_any_instance_of(Rewriter::GemSpec).to receive(:match?).and_return(true)
         expect_any_instance_of(Rewriter::Instance).to receive(:process)
-        rewriter = Rewriter.new 'name', 'description' do
+        rewriter = Rewriter.new 'name' do
           if_gem 'synvert', '1.0.0'
           within_file 'config/routes.rb' do; end
         end
         rewriter.process
       end
+
+      it 'does nothing in sandbox mode' do
+        expect_any_instance_of(Rewriter::GemSpec).not_to receive(:match?)
+        expect_any_instance_of(Rewriter::Instance).not_to receive(:process)
+        rewriter = Rewriter.new 'name' do
+          if_gem 'synvert', '1.0.0'
+          within_file 'config/routes.rb' do; end
+        end
+        rewriter.process_with_sandbox
+      end
     end
 
     describe 'parses add_file' do
-      it 'processes the rewriter' do
-        rewriter = Rewriter.new 'rewriter2', 'description2' do
+      it 'creates a new file' do
+        rewriter = Rewriter.new 'rewriter2' do
           add_file './foo.bar', 'FooBar'
         end
         rewriter.process
         expect(File.read './foo.bar').to eq 'FooBar'
         FileUtils.rm './foo.bar'
       end
+
+      it 'does nothing in sandbox mode' do
+        rewriter = Rewriter.new 'rewriter2' do
+          add_file './foo.bar', 'FooBar'
+        end
+        rewriter.process_with_sandbox
+        expect(File.exist?('./foo.bar')).to be_false
+      end
     end
 
     describe 'parses add_snippet' do
       it 'processes the rewritter' do
-        rewriter1 = Rewriter.new 'rewriter1', 'description1'
-        rewriter2 = Rewriter.new 'rewriter2', 'description2' do
+        rewriter1 = Rewriter.new 'rewriter1'
+        rewriter2 = Rewriter.new 'rewriter2' do
           add_snippet :rewriter1
         end
         expect(rewriter1).to receive(:process)
         rewriter2.process
       end
 
+      it 'adds sub_snippets' do
+        rewriter1 = Rewriter.new 'rewriter1'
+        rewriter2 = Rewriter.new 'rewriter2' do
+          add_snippet :rewriter1
+        end
+        expect(rewriter1).to receive(:process)
+        rewriter2.process
+        expect(rewriter2.sub_snippets).to eq [rewriter1]
+      end
+
       it 'raises RewriterNotFound' do
-        rewriter = Rewriter.new 'name', 'description' do
+        rewriter = Rewriter.new 'name' do
           add_snippet :not_exist
         end
         expect { rewriter.process }.to raise_error(RewriterNotFound)
       end
     end
 
-    describe 'parses helper_method' do
-      it 'adds helper method to new instance' do
-        instance = double
-        expect(Rewriter::Instance).to receive(:new).and_return(instance)
-        expect(instance).to receive(:process)
-        rewriter = Rewriter.new 'name', 'description' do
-          helper_method 'dynamic_helper' do |arg1, arg2|
-            'dynamic result'
-          end
-          within_file 'spec/spec_helper.rb' do; end
+    it 'parses helper_method' do
+      instance = double
+      expect(Rewriter::Instance).to receive(:new).and_return(instance)
+      expect(instance).to receive(:process)
+      rewriter = Rewriter.new 'name' do
+        helper_method 'dynamic_helper' do |arg1, arg2|
+          'dynamic result'
         end
-        rewriter.process
-        expect(instance.dynamic_helper('arg1', 'arg2')).to eq 'dynamic result'
+        within_file 'spec/spec_helper.rb' do; end
       end
+      rewriter.process
+      expect(instance.dynamic_helper('arg1', 'arg2')).to eq 'dynamic result'
     end
 
-    describe 'parses todo' do
-      it 'sets todo_list' do
-        rewriter = Rewriter.new 'name', 'description' do
-          todo "this rewriter doesn't do blah blah blah"
-        end
-        rewriter.process
-        expect(rewriter.todo_list).to eq "this rewriter doesn't do blah blah blah"
+    it 'parses todo' do
+      rewriter = Rewriter.new 'name' do
+        todo "this rewriter doesn't do blah blah blah"
       end
+      rewriter.process
+      expect(rewriter.todo).to eq "this rewriter doesn't do blah blah blah"
     end
 
     describe 'class methods' do
@@ -100,15 +132,20 @@ module Synvert
         Rewriter.clear
       end
 
+      it 'registers and fetches' do
+        rewriter = Rewriter.new 'rewriter'
+        expect(Rewriter.fetch('rewriter')).to eq rewriter
+      end
+
       it 'registers and calls rewriter' do
-        rewriter = Rewriter.new 'rewriter', 'description'
+        rewriter = Rewriter.new 'rewriter'
         expect(rewriter).to receive(:process)
         Rewriter.call 'rewriter'
       end
 
-      it 'registers and list all available rewriters' do
-        rewriter1 = Rewriter.new 'rewriter1', 'description1'
-        rewriter2 = Rewriter.new 'rewriter2', 'description2'
+      it 'registers and lists all available rewriters' do
+        rewriter1 = Rewriter.new 'rewriter1'
+        rewriter2 = Rewriter.new 'rewriter2'
         expect(Rewriter.availables).to eq [rewriter1, rewriter2]
       end
     end

data/spec/synvert/snippets/rails/upgrade_3_0_to_3_1_spec.rb

@@ -11,14 +11,12 @@ describe 'Upgrade rails from 3.0 to 3.1' do
   describe 'with fakefs', fakefs: true do
     let(:application_content) {"""
 Synvert::Application.configure do
-  config.assets.prefix = '/assets'
 end
     """}
     let(:application_rewritten_content) {"""
 Synvert::Application.configure do
   config.assets.enabled = true
   config.assets.version = '1.0'
-  config.assets.prefix = '/asset-files'
 end
     """}
     let(:development_content) {"""
@@ -54,10 +52,12 @@ Synvert::Application.configure do
 end
     '''}
     let(:wrap_parameters_rewritten_content) {"""
+# Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.
 ActiveSupport.on_load(:action_controller) do
   wrap_parameters format: [:json]
 end
 
+# Disable root element in JSON by default.
 ActiveSupport.on_load(:active_record) do
   self.include_root_in_json = false
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-02 00:00:00.000000000 Z
+date: 2014-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -114,6 +114,7 @@ files:
 - lib/synvert.rb
 - lib/synvert/cli.rb
 - lib/synvert/configuration.rb
+- lib/synvert/exceptions.rb
 - lib/synvert/node_ext.rb
 - lib/synvert/rewriter.rb
 - lib/synvert/rewriter/action.rb
@@ -121,7 +122,6 @@ files:
 - lib/synvert/rewriter/gem_spec.rb
 - lib/synvert/rewriter/instance.rb
 - lib/synvert/rewriter/scope.rb
-- lib/synvert/rewriter_not_found.rb
 - lib/synvert/snippets/factory_girl/syntax_methods.rb
 - lib/synvert/snippets/rails/convert_dynamic_finders.rb
 - lib/synvert/snippets/rails/strong_parameters.rb
@@ -182,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0.rc.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: synvert = syntax + convert.

data/lib/synvert/rewriter_not_found.rb

@@ -1,4 +0,0 @@
-module Synvert
-  class RewriterNotFound < Exception
-  end
-end