synvert 0.0.1 → 0.0.2

data/lib/synvert/rewriter/scopes.rb

@@ -0,0 +1,39 @@
+# encoding: utf-8
+
+module Synvert
+  class Rewriter::Scopes
+    def initialize
+      @scopes = []
+    end
+
+    def add(options)
+      @scopes << Rewriter::Scope.new(options)
+    end
+
+    def matching_nodes(node)
+      nodes = [node]
+      @scopes.each do |scope|
+        break if nodes.empty?
+        nodes = scope.matching_nodes(nodes)
+      end
+      nodes
+    end
+  end
+
+  class Rewriter::Scope
+    def initialize(options)
+      @options = options
+    end
+
+    def matching_nodes(nodes)
+      matching_nodes = []
+      while node = nodes.shift
+        matching_nodes << node if node.match?(@options)
+        node.recursive_children do |child_node|
+          matching_nodes << child_node if child_node.match?(@options)
+        end
+      end
+      matching_nodes
+    end
+  end
+end

data/lib/synvert/version.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
 
 module Synvert
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/spec_helper.rb

@@ -6,9 +6,9 @@ Dir[File.join(File.dirname(__FILE__), 'support', '*')].each do |path|
   require path
 end
 
-require 'mocha/api'
-
 RSpec.configure do |config|
+  config.include ParserHelper
+
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus

data/spec/support/parser_helper.rb

@@ -0,0 +1,5 @@
+module ParserHelper
+  def parse(code)
+    Parser::CurrentRuby.parse code
+  end
+end

data/spec/synvert/node_ext_spec.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+
+describe Parser::AST::Node do
+  describe '#name' do
+    it 'gets for class node' do
+      node = parse('class Synvert; end')
+      expect(node.name).to eq parse('Synvert')
+
+      node = parse('class Synvert::Rewriter::Instance; end')
+      expect(node.name).to eq parse('Synvert::Rewriter::Instance')
+    end
+  end
+
+  describe '#receiver' do
+    it 'gets for send node' do
+      node = parse('FactoryGirl.create :post')
+      expect(node.receiver).to eq parse('FactoryGirl')
+    end
+  end
+
+  describe '#message' do
+    it 'gets for send node' do
+      node = parse('FactoryGirl.create :post')
+      expect(node.message).to eq :create
+    end
+  end
+
+  describe '#arguments' do
+    it 'gets for send node' do
+      node = parse("FactoryGirl.create :post, title: 'post'")
+      expect(node.arguments).to eq parse("[:post, title: 'post']").children
+    end
+
+    it 'gets for block node' do
+      node = parse('RSpec.configure do |config|; end')
+      expect(node.arguments.map(&:to_s)).to eq ['config']
+    end
+  end
+
+  describe '#caller' do
+    it 'gets for block node' do
+      node = parse('RSpec.configure do |config|; end')
+      expect(node.caller).to eq parse('RSpec.configure')
+    end
+  end
+
+  describe '#to_s' do
+    it 'gets for const node' do
+      node = parse('Synvert')
+      expect(node.to_s).to eq 'Synvert'
+
+      node = parse('Synvert::Rewriter::Instance')
+      expect(node.to_s).to eq 'Synvert::Rewriter::Instance'
+    end
+
+    it 'gets for sym node' do
+      node = parse(':synvert')
+      expect(node.to_s).to eq ':synvert'
+    end
+
+    it 'gets for str node' do
+      node = parse("'synvert'")
+      expect(node.to_s).to eq 'synvert'
+    end
+
+    it 'gets for lvar node' do
+      node = parse("user = User.find 1; user.valid?").grep_node(type: 'lvar')
+      expect(node.to_s).to eq 'user'
+    end
+
+    it 'gets for ivar node' do
+      node = parse('@user')
+      expect(node.to_s).to eq '@user'
+    end
+
+    it 'gets for arg node' do
+      node = parse("RSpec.configure do |config|; end").grep_node(type: 'arg')
+      expect(node.to_s).to eq 'config'
+    end
+  end
+
+  describe '#indent' do
+    it 'gets column number' do
+      node = parse('  FactoryGirl.create :post')
+      expect(node.indent).to eq 2
+    end
+  end
+end

data/spec/synvert/rewriter/action_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+module Synvert
+  describe Rewriter::ReplaceWithAction do
+    describe '#rewrite' do
+      it 'replaces code' do
+        action = Rewriter::ReplaceWithAction.new('create_list {{node.arguments}}')
+        source = "post = FactoryGirl.create_list :post, 2"
+        send_node = Parser::CurrentRuby.parse(source).children[1]
+        output = action.rewrite(source, send_node)
+        expect(output).to eq "post = create_list :post, 2"
+      end
+    end
+  end
+
+  describe Rewriter::InsertAction do
+    describe '#rewrite' do
+      it 'insert code to block node' do
+        action = Rewriter::InsertAction.new('{{node.arguments.first}}.include FactoryGirl::Syntax::Methods')
+        source = "RSpec.configure do |config|\nend"
+        block_node = Parser::CurrentRuby.parse(source)
+        output = action.rewrite(source, block_node)
+        expect(output).to eq "RSpec.configure do |config|\n  config.include FactoryGirl::Syntax::Methods\nend"
+      end
+
+      it 'insert code to class node' do
+        action = Rewriter::InsertAction.new('include FactoryGirl::Syntax::Methods')
+        source = "class Test::Unit::TestCase\nend"
+        block_node = Parser::CurrentRuby.parse(source)
+        output = action.rewrite(source, block_node)
+        expect(output).to eq "class Test::Unit::TestCase\n  include FactoryGirl::Syntax::Methods\nend"
+      end
+
+      it 'insert code to begin node' do
+        action = Rewriter::InsertAction.new('World(FactoryGirl::Syntax::Methods)')
+        source = "require 'cucumber/rails'\nActionController::Base.allow_rescue = false"
+        block_node = Parser::CurrentRuby.parse(source)
+        output = action.rewrite(source, block_node)
+        expect(output).to eq "require 'cucumber/rails'\nActionController::Base.allow_rescue = false\nWorld(FactoryGirl::Syntax::Methods)"
+      end
+
+      it 'insert code to other node' do
+        action = Rewriter::InsertAction.new('World(FactoryGirl::Syntax::Methods)')
+        source = "require 'cucumber/rails'"
+        block_node = Parser::CurrentRuby.parse(source)
+        output = action.rewrite(source, block_node)
+        expect(output).to eq "require 'cucumber/rails'\nWorld(FactoryGirl::Syntax::Methods)"
+      end
+    end
+  end
+end

data/spec/synvert/rewriter/conditions_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+module Synvert
+  describe Rewriter::Conditions do
+
+  end
+
+  describe Rewriter::UnlessExistCondition do
+    let(:source) {
+"""
+RSpec.configure do |config|
+  config.include EmailSpec::Helpers
+  config.include EmailSpec::Methods
+end
+"""
+    }
+    let(:node) { Parser::CurrentRuby.parse(source) }
+
+    describe '#matching_nodes' do
+      it 'gets empty array if does not matchi anything' do
+        condition = Rewriter::UnlessExistCondition.new type: 'send', message: 'include', arguments: {first: {to_s: 'FactoryGirl::Syntax::Methods'} }
+        expect(condition.matching_nodes([node]).size).to eq 1
+      end
+
+      it 'gets matching nodes' do
+        condition = Rewriter::UnlessExistCondition.new type: 'send', message: 'include', arguments: {first: {to_s: 'EmailSpec::Helpers'} }
+        expect(condition.matching_nodes([node])).to eq []
+      end
+    end
+  end
+end

data/spec/synvert/rewriter/instances_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+module Synvert
+  describe Rewriter::Instances do
+
+  end
+
+  describe Rewriter::Instance do
+    let(:instance) { Rewriter::Instance.new('file pattern') }
+
+    describe '#within_node' do
+      it 'adds a scope'do
+        expect_any_instance_of(Rewriter::Scopes).to receive(:add).with(type: 'block', caller: {receiver: 'RSpec', message: 'configure'})
+        instance.within_node type: 'block', caller: {receiver: 'RSpec', message: 'configure'} do; end
+      end
+    end
+
+    describe '#with_node' do
+      it 'adds a scope' do
+        expect_any_instance_of(Rewriter::Scopes).to receive(:add).with(type: 'send', receiver: 'FactoryGirl', message: 'create')
+        instance.with_node type: 'send', receiver: 'FactoryGirl', message: 'create' do; end
+      end
+    end
+
+    describe '#insert' do
+      it 'sets an action' do
+        expect(Rewriter::InsertAction).to receive(:new).with('{{node.arguments.first}}.include FactoryGirl::Syntax::Methods')
+        instance.insert "{{node.arguments.first}}.include FactoryGirl::Syntax::Methods"
+      end
+    end
+
+    describe '#replace_with' do
+      it 'sets an action' do
+        expect(Rewriter::ReplaceWithAction).to receive(:new).with('create {{node.arguments}}')
+        instance.replace_with 'create {{node.arguments}}'
+      end
+    end
+
+    describe '#process' do
+      before { Configuration.instance.set :path, '.' }
+
+      it 'FactoryGirl uses short syntax' do
+        instance = Rewriter::Instance.new('spec/**/*_spec.rb')
+        instance.with_node type: 'send', receiver: 'FactoryGirl', message: 'create' do
+          replace_with 'create {{node.arguments}}'
+        end
+        input = """
+it 'uses factory_girl' do
+  user = FactoryGirl.create :user
+  post = FactoryGirl.create :post, user: user
+  assert post.valid?
+end
+"""
+        output = """
+it 'uses factory_girl' do
+  user = create :user
+  post = create :post, user: user
+  assert post.valid?
+end
+"""
+        expect(Dir).to receive(:glob).with('./spec/**/*_spec.rb').and_return(['spec/models/post_spec.rb'])
+        expect(File).to receive(:read).with('spec/models/post_spec.rb').and_return(input)
+        expect(File).to receive(:write).with('spec/models/post_spec.rb', output)
+        instance.process
+      end
+
+      it 'includes FactoryGirl::Syntax::Methods' do
+        instance = Rewriter::Instance.new('spec/spec_helper.rb')
+        instance.with_node type: 'block', caller: {receiver: 'RSpec', message: 'configure'} do
+          unless_exist_node type: 'send', message: 'include', arguments: {first: {to_s: 'FactoryGirl::Syntax::Methods'}} do
+            insert "{{node.arguments.first}}.include FactoryGirl::Syntax::Methods"
+          end
+        end
+        input = """
+        RSpec.configure do |config|
+        end
+        """
+        output = """
+        RSpec.configure do |config|
+          config.include FactoryGirl::Syntax::Methods
+        end
+        """
+        expect(Dir).to receive(:glob).with('./spec/spec_helper.rb').and_return(['spec/spec_helper.rb'])
+        expect(File).to receive(:read).with('spec/spec_helper.rb').and_return(input)
+        expect(File).to receive(:write).with('spec/spec_helper.rb', output)
+        instance.process
+      end
+
+      it 'does not include FactoryGirl::Syntax::Methods' do
+        instance = Rewriter::Instance.new('spec/spec_helper.rb')
+        instance.with_node type: 'block', caller: {receiver: 'RSpec', message: 'configure'} do
+          unless_exist_node type: 'send', message: 'include', arguments: {first: {to_s: 'FactoryGirl::Syntax::Methods'}} do
+            insert "{{node.arguments.first}}.include FactoryGirl::Syntax::Methods"
+          end
+        end
+        input = """
+        RSpec.configure do |config|
+          config.include FactoryGirl::Syntax::Methods
+        end
+        """
+        output = """
+        RSpec.configure do |config|
+          config.include FactoryGirl::Syntax::Methods
+        end
+        """
+        expect(Dir).to receive(:glob).with('./spec/spec_helper.rb').and_return(['spec/spec_helper.rb'])
+        expect(File).to receive(:read).with('spec/spec_helper.rb').and_return(input)
+        expect(File).to receive(:write).with('spec/spec_helper.rb', output)
+        instance.process
+      end
+    end
+  end
+end

data/spec/synvert/rewriter/scopes_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+module Synvert
+  describe Rewriter::Scopes do
+    let(:source) {
+"""
+describe Post do
+  before :each do
+    @user = FactoryGirl.create :user
+  end
+
+  it 'gets posts' do
+    post1 = FactoryGirl.create :post
+    post2 = FactoryGirl.create :post
+  end
+end
+"""
+    }
+    let(:node) { Parser::CurrentRuby.parse(source) }
+
+    before(:each) { @scopes = Rewriter::Scopes.new }
+
+    describe '#matching_nodes' do
+      it 'gets original node if scopes are empty' do
+        scoped_nodes = @scopes.matching_nodes(node)
+        expect(scoped_nodes).to eq [node]
+      end
+
+      it 'gets all matching nodes with one scope' do
+        @scopes.add type: 'send', receiver: 'FactoryGirl', message: 'create'
+        scoped_nodes = @scopes.matching_nodes(node)
+        expect(scoped_nodes.size).to eq 3
+      end
+
+      it 'gets all matching nodes with multi scopes' do
+        @scopes.add type: 'block', caller: {message: 'describe', arguments: ['Post']}
+        @scopes.add type: 'block', caller: {message: 'before', arguments: [':each']}
+        @scopes.add type: 'send', receiver: 'FactoryGirl', message: 'create'
+        scoped_nodes = @scopes.matching_nodes(node)
+        expect(scoped_nodes.size).to eq 1
+      end
+    end
+  end
+
+  describe Rewriter::Scope do
+    let(:source) {
+"""
+describe Post do
+  before :each do
+    @user = FactoryGirl.create :user
+  end
+
+  it 'gets posts' do
+    post1 = FactoryGirl.create :post
+    post2 = FactoryGirl.create :post
+  end
+end
+"""
+    }
+    let(:node) { Parser::CurrentRuby.parse(source) }
+
+    describe '#matching_nodes' do
+      it 'gets empty array if does not match anything' do
+        scope = Rewriter::Scope.new type: 'send', message: 'missing'
+        expect(scope.matching_nodes([node])).to eq []
+      end
+
+      it 'gets matching nodes' do
+        scope = Rewriter::Scope.new type: 'send', receiver: 'FactoryGirl', message: 'create', arguments: [':post']
+        expect(scope.matching_nodes([node]).size).to eq 2
+      end
+
+      it 'gets matching nodes witch block caller' do
+        scope = Rewriter::Scope.new type: 'block', caller: {message: 'it', arguments: ['gets posts']}
+        expect(scope.matching_nodes([node]).size).to eq 1
+      end
+    end
+  end
+end

data/spec/synvert/rewriter_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+module Synvert
+  describe Rewriter do
+    it 'sets description' do
+      rewriter = Rewriter.new 'this is description' do; end
+      expect(rewriter.description).to eq 'this is description'
+    end
+
+    it 'parses from_version' do
+      rewriter = Rewriter.new 'description' do
+        from_version '1.0.0'
+      end
+      expect(rewriter.version.to_s).to eq '1.0.0'
+    end
+
+    it 'parses within_file' do
+      expect_any_instance_of(Rewriter::Instances).to receive(:add).with('spec/spec_helper.rb')
+      Rewriter.new 'description' do
+        within_file 'spec/spec_helper.rb' do; end
+      end
+    end
+
+    it 'parses within_files' do
+      expect_any_instance_of(Rewriter::Instances).to receive(:add).with('spec/**/*_spec.rb')
+      Rewriter.new 'description' do
+        within_files 'spec/**/*_spec.rb' do; end
+      end
+    end
+  end
+end