synvert-core 2.1.2 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a46f27187479785039c353bc33688eb5528d2d6591485d5e55efd43f2f6cd817
-  data.tar.gz: 1b96464e513f2a8b3beb3421eb021e1efd5c41045698aa4eb26fbaa0b94703d3
+  metadata.gz: a8de6e08c31aaa4768912559d7192f5eb447a5f7e4110f09b8bac0363e0df253
+  data.tar.gz: 57eb0b68bf973e02a83589ea9ae6b06b955aa07cd4400000604845f10cd8e4c3
 SHA512:
-  metadata.gz: b5b68e153d26a3bac0a6b2ced72b2cd33b7b3b05159f7932c49b9fdb20822561d17c6d13aca805b21ae3bbeb156ed479845c531755ce1d5e53f78e15bc5c2068
-  data.tar.gz: b1978636d9eb02f79f8f92eaba1cd702d2be8748a42deb7d5c34645dd28e388b1d99471a826e0d0ce17571a2c8fe71dab32545fe5f0c4f6dc77ec54ea1edbe96
+  metadata.gz: 167371f72e5abf567047a57b9af8ac7765b34f9ffff99092094cf92635dd54345cc6dac800b928ab16223aa5ed003c4d16464f3b856810a822b19a65ee038a25
+  data.tar.gz: 31248d3db71575585065e364e5130d6313474d6df3e86bf3667b451b3a9ffdceea7a125bc8c995faf8162bc367f7571320187f5404d78e84836e4aa0c81b09d3

data/.github/workflows/stale.yml

@@ -0,0 +1,29 @@
+name: Close stale issues
+
+on:
+  schedule:
+    - cron: '0 0 * * *'  # Runs at 00:00 UTC every day
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v9
+        with:
+          # Issues
+          stale-issue-message: 'This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.'
+          close-issue-message: 'This issue was closed because it has been stale for 30 days with no activity.'
+          days-before-issue-stale: 60
+          days-before-issue-close: 30
+
+          # Pull Requests
+          stale-pr-message: 'This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.'
+          close-pr-message: 'This pull request was closed because it has been stale for 30 days with no activity.'
+          days-before-pr-stale: 60
+          days-before-pr-close: 30
+
+          # General settings
+          exempt-issue-labels: 'pinned,security'
+          exempt-pr-labels: 'pinned,security'
+          stale-issue-label: 'stale'
+          stale-pr-label: 'stale'

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # CHANGELOG
 
+## 2.2.1 (2024-12-27)
+
+* Raise error to notify user instance method should not be called in rewriter
+
+## 2.2.0 (2024-07-20)
+
+* Remove `save_data` and `load_data` dsls
+
 ## 2.1.2 (2024-07-17)
 
 * Update `parser_node_ext` to 1.4.2

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    synvert-core (2.1.2)
-      activesupport
+    synvert-core (2.2.1)
+      activesupport (= 7.1.3.4)
       node_mutation (>= 1.24.4)
       node_query (>= 1.15.4)
       node_visitor (>= 1.1.0)
@@ -29,9 +29,9 @@ GEM
       tzinfo (~> 2.0)
     ast (2.4.2)
     base64 (0.2.0)
-    bigdecimal (3.1.8)
+    bigdecimal (3.1.9)
     coderay (1.1.3)
-    concurrent-ruby (1.3.3)
+    concurrent-ruby (1.3.4)
     connection_pool (2.4.1)
     diff-lcs (1.5.1)
     drb (2.2.1)
@@ -52,36 +52,36 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    i18n (1.14.5)
+    i18n (1.14.6)
       concurrent-ruby (~> 1.0)
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.10)
     method_source (1.1.0)
-    minitest (5.24.1)
-    mutex_m (0.2.0)
+    minitest (5.25.4)
+    mutex_m (0.3.0)
     nenv (0.3.0)
     node_mutation (1.24.4)
-    node_query (1.15.4)
+    node_query (1.16.0)
     node_visitor (1.1.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.25.1)
-    parser (3.3.4.0)
+    parallel (1.26.3)
+    parser (3.3.6.0)
       ast (~> 2.4.1)
       racc
     parser_node_ext (1.4.2)
       parser
     prettier_print (1.2.1)
-    prism (0.30.0)
+    prism (1.3.0)
     prism_ext (0.4.2)
       prism
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    racc (1.8.0)
+    racc (1.8.1)
     rake (13.0.6)
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)

data/README.md

@@ -78,8 +78,6 @@ DSLs are as follows
 * [add_snippet](https://synvert-hq.github.io/synvert-core-ruby/Synvert/Core/Rewriter.html#add_snippet-instance_method) - call another rewriter
 * [call_helper](https://synvert-hq.github.io/synvert-core-ruby/Synvert/Core/Rewriter.html#call_helper-instance_method) - call a shared rewriter
 * [with_configurations](https://synvert-hq.github.io/synvert-core-ruby/Synvert/Core/Rewriter.html#with_configurations-instance_method) - execute a block of code with temporary configurations
-* [save_data](https://synvert-hq.github.io/synvert-core-ruby/Synvert/Core/Rewriter.html#save_data-instance_method) - save data
-* [load_data](https://synvert-hq.github.io/synvert-core-ruby/Synvert/Core/Rewriter.html#load_data-instance_method) - load data
 
 Scopes:
 

data/lib/synvert/core/rewriter/instance.rb

@@ -15,6 +15,15 @@ module Synvert::Core
   class Rewriter::Instance
     include Rewriter::Helper
 
+    DSL_METHODS = %i[
+      within_node with_node find_node goto_node
+      if_exist_node unless_exist_node
+      append prepend insert insert_after insert_before replace delete remove wrap replace_with warn replace_erb_stmt_with_expr noop group add_action
+      add_callback
+      wrap_with_quotes add_leading_spaces
+      file_path node mutation_adapter
+    ].freeze
+
     # Initialize an Instance.
     #
     # @param rewriter [Synvert::Core::Rewriter]

data/lib/synvert/core/rewriter.rb

@@ -416,20 +416,19 @@ module Synvert::Core
       Configuration.with_temporary_configurations(configurations, &block)
     end
 
-    # Saves data with a given key and value.
-    #
-    # @param key [Symbol] the key to identify the data
-    # @param value [Object] the value to be saved
-    def save_data(key, value)
-      Synvert::Core.instance_variable_set("@#{key}", value)
+    # Raise error to notify user instance method should not be called in Rewriter.
+    (Rewriter::Instance::DSL_METHODS - %i[group]).each do |method|
+      define_method(method) do |**|
+        raise NoMethodError, "#{method} must be called within within_files or within_file block."
+      end
     end
 
-    # Loads data with the given key.
-    #
-    # @param key [Symbol] the key of the data to be loaded
-    # @return [Object] the data loaded
-    def load_data(key)
-      Synvert::Core.instance_variable_get("@#{key}")
+    def group
+      if block_given?
+        raise NoMethodError, 'group must be called within rewriter block.'
+      else
+        @group
+      end
     end
 
     private

data/lib/synvert/core/version.rb

@@ -2,6 +2,6 @@
 
 module Synvert
   module Core
-    VERSION = '2.1.2'
+    VERSION = '2.2.1'
   end
 end

data/spec/synvert/core/rewriter_spec.rb

@@ -91,6 +91,21 @@ module Synvert::Core
           expect(File.read("code.rb")).to eq output
         end
       end
+
+      it 'does not rewrite the file if within_files is not called' do
+        rewriter =
+          Rewriter.new('group', 'name') do
+            with_node node_type: 'class', name: 'Foobar' do
+              replace :name, with: 'Synvert'
+            end
+          end
+        input = "class Foobar\nend"
+        output = "class Synvert\nend"
+        FakeFS do
+          File.write("code.rb", input)
+          expect { rewriter.process }.to raise_error(NoMethodError, 'with_node must be called within within_files or within_file block.')
+        end
+      end
     end
 
     describe '#test' do
@@ -346,11 +361,10 @@ module Synvert::Core
       it 'eval helper by name' do
         block_receiver = nil
         block_options = {}
-        helper =
-          Synvert::Helper.new 'helper' do |options|
-            block_receiver = self.class.name
-            block_options = options
-          end
+        Synvert::Helper.new 'helper' do |options|
+          block_receiver = self.class.name
+          block_options = options
+        end
         rewriter =
           Rewriter.new 'group', 'rewriter' do
             call_helper('helper', foo: 'bar')
@@ -395,18 +409,6 @@ module Synvert::Core
       expect(instance.dynamic_helper('arg1', 'arg2')).to eq 'dynamic result'
     end
 
-    it 'parses save_data and load_data' do
-      data = nil
-      rewriter =
-        Rewriter.new 'group', 'name' do
-          hash = { foo: 'bar' }
-          save_data :object, hash
-          data = load_data :object
-        end
-      rewriter.process
-      expect(data).to eq({ foo: 'bar' })
-    end
-
     describe 'class methods' do
       before :each do
         Rewriter.clear

data/synvert-core-ruby.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "activesupport"
+  spec.add_runtime_dependency "activesupport", '7.1.3.4' # to support ruby 2.7
   spec.add_runtime_dependency "node_query", ">= 1.15.4"
   spec.add_runtime_dependency "node_mutation", ">= 1.24.4"
   spec.add_runtime_dependency "node_visitor", ">= 1.1.0"

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: synvert-core
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 2.2.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-17 00:00:00.000000000 Z
+date: 2024-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 7.1.3.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 7.1.3.4
 - !ruby/object:Gem::Dependency
   name: node_query
   requirement: !ruby/object:Gem::Requirement
@@ -172,6 +172,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/main.yml"
+- ".github/workflows/stale.yml"
 - ".gitignore"
 - ".rspec"
 - ".vscode/settings.json"
@@ -249,7 +250,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.14
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: convert ruby code to better syntax.