synvert-core 2.0.2 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 666eb48f4d58bd41854a7f48e9aadf201321023f546b5682abe21e56ed80a204
-  data.tar.gz: b6a555693e36b13806d156761a7003e06a6be8104c6102fd11ac5e920a687dd2
+  metadata.gz: fce0541de0c11b2a281d837c23669ea6fbe768f53b551549e1693119be907a1b
+  data.tar.gz: 413625544e125e8d9ec114e6dbe1021d2ca46969b319b56037a2fad4a5ba1c45
 SHA512:
-  metadata.gz: 24b42ba9dd6ba2e16fc4218fbae4f333d8ac193fa4c58de8781836f4b3c7189a342a15088364071b52edf955365f0920bc4773d62f7d36e88c69b50e03f6df60
-  data.tar.gz: '081411c60033db6c980fe7204e0e7dde12c7110a5839c545bb59943e3da3e881a0f505cc521284f6753e8f34d47319a9e1bc582126ea27cf82e4b696b170ce3f'
+  metadata.gz: 2695eb816b145e15644104da335f58d7038ed698f998348e35f23c0e42a0c3e119bc1feefc2cc12875d4dc26e3b9dbccd468c61e117f8e5dbd1efdebb2f95fea
+  data.tar.gz: fe5d4072638d277b8eedbf488540bd85632118721c2092f9c6117a41f7a761e70d21a9652a7f8fd007f260885ef9930dfd9000d295f6733dc3fda73925c29aee

data/.vscode/settings.json

@@ -1,5 +1,21 @@
 {
   "cSpell.words": [
-    "synvert"
+    "asgn",
+    "autoindent",
+    "blockarg",
+    "casgn",
+    "csend",
+    "cvar",
+    "erange",
+    "fileutils",
+    "haml",
+    "ivar",
+    "lvar",
+    "mlhs",
+    "restarg",
+    "rvmrc",
+    "synvert",
+    "Yardoc",
+    "zsuper"
   ]
 }

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## 2.0.3 (2024-06-16)
+
+* Fix `gem_spec_spec` test failures
+* Use `NodeMutation` to fetch file line
+
 ## 2.0.2 (2024-05-30)
 
 * Do not raise error for prism

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    synvert-core (2.0.2)
+    synvert-core (2.0.3)
       activesupport
       node_mutation (>= 1.24.4)
       node_query (>= 1.15.3)
@@ -17,7 +17,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3.3)
+    activesupport (7.1.3.4)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -31,7 +31,7 @@ GEM
     base64 (0.2.0)
     bigdecimal (3.1.8)
     coderay (1.1.3)
-    concurrent-ruby (1.3.1)
+    concurrent-ruby (1.3.3)
     connection_pool (2.4.1)
     diff-lcs (1.5.1)
     drb (2.2.1)
@@ -68,14 +68,14 @@ GEM
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.24.0)
-    parser (3.3.1.0)
+    parallel (1.25.1)
+    parser (3.3.3.0)
       ast (~> 2.4.1)
       racc
     parser_node_ext (1.3.2)
       parser
     prettier_print (1.2.1)
-    prism (0.29.0)
+    prism (0.30.0)
     prism_ext (0.3.2)
       prism
     pry (0.14.2)

data/lib/synvert/core/rewriter/instance.rb

@@ -436,7 +436,8 @@ module Synvert::Core
     #   end
     # @param message [String] warning message.
     def warn(message)
-      @rewriter.add_warning Rewriter::Warning.new(self, message)
+      line = @current_mutation.adapter.get_start_loc(@current_node).line
+      @rewriter.add_warning Rewriter::Warning.new(@file_path, line, message)
     end
 
     # It adds a callback when visiting an ast node.

data/lib/synvert/core/rewriter/warning.rb

@@ -5,11 +5,12 @@ module Synvert::Core
   class Rewriter::Warning
     # Initialize a Warning.
     #
-    # @param instance [Synvert::Core::Rewriter::Instance]
+    # @param file_path [String] file path.
+    # @param line [Integer] file line.
     # @param message [String] warning message.
-    def initialize(instance, message)
-      @file_path = instance.file_path
-      @line = instance.current_node.loc.expression.line
+    def initialize(file_path, line, message)
+      @file_path = file_path
+      @line = line
       @message = message
     end
 

data/lib/synvert/core/rewriter.rb

@@ -201,7 +201,7 @@ module Synvert::Core
     # @option strategy [String] 'allow_insert_at_same_position'
     def configure(options)
       @options = @options.merge(options)
-      if options[:parser] && ![Synvert::PARSER_PARSER, Synvert::SYNTAX_TREE_PARSER, Synvert::PRISM_PARSER].include?(options[:parser])
+      if options[:parser] && !Synvert::ALL_PARSERS.include?(options[:parser])
         raise Errors::ParserNotSupported.new("Parser #{options[:parser]} not supported")
       end
     end

data/lib/synvert/core/utils.rb

@@ -40,7 +40,7 @@ module Synvert::Core
           ignored_files = []
 
           if Configuration.respect_gitignore
-            Open3.popen3('git check-ignore --stdin') do |stdin, stdout, stderr, wait_thr|
+            Open3.popen3('git check-ignore --stdin') do |stdin, stdout, _stderr, _wait_thr|
               stdin.puts(all_files.join("\n"))
               stdin.close
 

data/lib/synvert/core/version.rb

@@ -2,6 +2,6 @@
 
 module Synvert
   module Core
-    VERSION = '2.0.2'
+    VERSION = '2.0.3'
   end
 end

data/lib/synvert/core.rb

@@ -77,4 +77,5 @@ module Synvert
   PARSER_PARSER = 'parser'
   SYNTAX_TREE_PARSER = 'syntax_tree'
   PRISM_PARSER = 'prism'
+  ALL_PARSERS = [PARSER_PARSER, SYNTAX_TREE_PARSER, PRISM_PARSER].freeze
 end

data/spec/synvert/core/rewriter/gem_spec_spec.rb

@@ -16,7 +16,17 @@ module Synvert::Core
           slop (3.4.7)
     EOS
     let(:lock_path) { File.absolute_path('./Gemfile.lock') }
-    before { allow(File).to receive(:exist?).with(File.join(ENV['HOME'], '.gem/specs')).and_return(false) }
+
+    before do
+      Configuration.root_path = File.dirname(lock_path)
+      allow(File).to receive(:exist?).with(File.join(ENV['HOME'])).and_return(true)
+      allow(File).to receive(:exist?).with(File.join(ENV['HOME'], '.gem')).and_return(false)
+      allow(File).to receive(:exist?).with(File.join(ENV['HOME'], '.gem/specs')).and_return(false)
+    end
+
+    after do
+      Configuration.root_path = nil
+    end
 
     it 'returns true if version in Gemfile.lock is greater than definition' do
       expect(File).to receive(:exist?).with(lock_path).and_return(true)

data/spec/synvert/core/rewriter/instance_spec.rb

@@ -260,7 +260,9 @@ module Synvert::Core
     end
 
     it 'parses warn' do
-      expect(Rewriter::Warning).to receive(:new).with(instance, 'foobar')
+      instance.instance_variable_set(:@file_path, 'app/test.rb')
+      expect(@current_mutation).to receive_message_chain(:adapter, :get_start_loc, :line).and_return(2)
+      expect(Rewriter::Warning).to receive(:new).with('app/test.rb', 2, 'foobar')
       instance.warn 'foobar'
     end
 
@@ -549,10 +551,6 @@ module Synvert::Core
           = form_for @post do |f|
           = form_for @post do |f|
         EOS
-        output = <<~EOS
-          = form_for post do |f|
-          = form_for post do |f|
-        EOS
         allow(File).to receive(:read).with('./app/views/posts/_form.html.haml', encoding: 'UTF-8').and_return(input)
         result = instance.test
         expect(result.file_path).to eq 'app/views/posts/_form.html.haml'
@@ -578,10 +576,6 @@ module Synvert::Core
           = form_for @post do |f|
           = form_for @post do |f|
         EOS
-        output = <<~EOS
-          = form_for post do |f|
-          = form_for post do |f|
-        EOS
         allow(File).to receive(:read).with('./app/views/posts/_form.html.slim', encoding: 'UTF-8').and_return(input)
         result = instance.test
         expect(result.file_path).to eq 'app/views/posts/_form.html.slim'

data/spec/synvert/core/rewriter/warning_spec.rb

@@ -5,10 +5,7 @@ require 'spec_helper'
 module Synvert::Core
   describe Rewriter::Warning do
     subject {
-      source = "def test\n  debugger\nend"
-      send_node = Parser::CurrentRuby.parse(source).body.first
-      instance = double(current_node: send_node, file_path: 'app/test.rb')
-      Rewriter::Warning.new(instance, 'remove debugger')
+      Rewriter::Warning.new('app/test.rb', 2, 'remove debugger')
     }
 
     it 'gets message with filename and line number' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert-core
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.0.3
 platform: ruby
 authors:
 - Richard Huang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-30 00:00:00.000000000 Z
+date: 2024-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport