synvert-core 1.14.2 → 1.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf73847a243ca7bed5a7838e67f7ca4841818d6fa71645e5d6e5ab752be5c2e0
-  data.tar.gz: 6b1acefc43253e642ea3ce012665a8288b9064927590e7b7a5a7410c43db14d6
+  metadata.gz: 82066eb2fad44d4ca47831672a31195bba96aa07206aa23e449d5c519b94b23d
+  data.tar.gz: 70a8566412fc3cf9004441a07e706c79807820003155b4bafdc03cf4c62042cc
 SHA512:
-  metadata.gz: 808cebc5d15d61324aa00407e8932857ea93928cc2bf6948a253870f6cb5bc9e7a59e09e8172d01fdce61f01ee28667d4eae92ac09993a33bb769e34e2d31b8a
-  data.tar.gz: 30c5e89a55fd489948e8aa7e3867fb9188b9b12abb8eb81ed5c106c6ae277f954fab9b7bca2a332a5a323c4e8508510c1b178a307e3fa3056581c1845fd00a71
+  metadata.gz: b33e55196d7d3e13097e7b101ee693111e5a49ad6d93015eba85886214abb125b5a938908ca0feadef772ef6eecdaa8874fc2d8d6ecff044d5506f685db8bc8d
+  data.tar.gz: aa7f05784e6e8710903c47e6616dac0a18bca66b0f04fc6b7089ff8d47f8c5c6d073bdb45fccb04b25765feed6b28313ea08dd80d166e0283cd931e2d9482229

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 1.15.0 (2022-11-30)
+
+* Load snippet from github
+
 ## 1.14.2 (2022-11-19)
 
 * Specify `node_query`, `node_mutation` and `parser_node_ext` versions

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    synvert-core (1.14.2)
+    synvert-core (1.15.0)
       activesupport (< 7.0.0)
       erubis
       node_mutation (>= 1.7.1)
@@ -59,7 +59,7 @@ GEM
       nenv (~> 0.1)
       shellany (~> 0.0)
     parallel (1.22.1)
-    parser (3.1.2.1)
+    parser (3.1.3.0)
       ast (~> 2.4.1)
     parser_node_ext (0.4.1)
       parser

data/lib/synvert/core/node_ext.rb

@@ -27,7 +27,7 @@ module Parser::AST
   # +type: 'send', receiver: { type: 'send', receiver: { type: 'send', message: 'config' }, message: 'active_record' }, message: 'identity_map='+
   #
   # Source Code to Ast Node
-  # {https://synvert-playground.xinminlabs.com/ruby}
+  # {https://playground.synvert.net/ruby}
   class Node
     # Get the file name of node.
     #

data/lib/synvert/core/snippet_not_found_error.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class SnippetNotFoundError < StandardError
+end

data/lib/synvert/core/utils.rb

@@ -1,18 +1,29 @@
 # frozen_string_literal: true
 
+require 'net/http'
 require 'uri'
+require 'open-uri'
 
 module Synvert::Core
   class Utils
     class << self
       def eval_snippet(snippet_name)
+        eval(load_snippet(snippet_name))
+      end
+
+      def load_snippet(snippet_name)
         if is_valid_url?(snippet_name)
           uri = URI.parse(format_url(snippet_name))
-          eval(uri.open.read)
+          return uri.open.read if remote_snippet_exists?(uri)
+          raise SnippetNotFoundError.new("#{snippet_name} nout found")
         elsif is_valid_file?(snippet_name)
-          eval(File.read(snippet_name))
+          return File.read(snippet_name)
         else
-          eval(File.read(File.join(default_snippets_home, 'lib', "#{snippet_name}.rb")))
+          snippet_path = snippet_expand_path(snippet_name)
+          return File.read(snippet_path) if File.exist?(snippet_path)
+          snippet_uri = URI.parse(format_url(remote_snippet_url(snippet_name)))
+          return snippet_uri.open.read if remote_snippet_exists?(snippet_uri)
+          raise SnippetNotFoundError.new("#{snippet_name} nout found")
         end
       end
 
@@ -26,10 +37,25 @@ module Synvert::Core
         File.exist?(path)
       end
 
+      def remote_snippet_exists?(uri)
+        req = Net::HTTP.new(uri.host, uri.port)
+        req.use_ssl = uri.scheme == 'https'
+        res = req.request_head(uri.path)
+        res.code == "200"
+      end
+
+      def snippet_expand_path(snippet_name)
+        File.join(default_snippets_home(), 'lib', "#{snippet_name}.rb")
+      end
+
       def default_snippets_home
         ENV['SYNVERT_SNIPPETS_HOME'] || File.join(ENV['HOME'], '.synvert-ruby')
       end
 
+      def remote_snippet_url(snippet_name)
+        "https://github.com/xinminlabs/synvert-snippets-ruby/blob/main/lib/#{snippet_name}.rb"
+      end
+
       def format_url(url)
         convert_to_github_raw_url(url)
       end

data/lib/synvert/core/version.rb

@@ -2,6 +2,6 @@
 
 module Synvert
   module Core
-    VERSION = '1.14.2'
+    VERSION = '1.15.0'
   end
 end

data/lib/synvert/core.rb

@@ -19,6 +19,7 @@ module Synvert
     autoload :Engine, 'synvert/core/engine'
     autoload :Utils, 'synvert/core/utils'
     autoload :Strategy, 'synvert/core/strategy'
+    autoload :SnippetNotFoundError, 'synvert/core/snippet_not_found_error'
   end
 end
 

data/spec/synvert/core/utils_spec.rb

@@ -3,27 +3,54 @@ require 'spec_helper'
 module Synvert::Core
   RSpec.describe Utils do
     describe '.eval_snippet' do
-      it 'evals snippet by http url' do
-        expect_any_instance_of(URI).to receive(:open).and_return(StringIO.new("Rewriter.new 'group', 'name' do\nend"))
-        rewriter = described_class.eval_snippet('http://example.com/rewriter.rb')
-        expect(rewriter.group).to eq 'group'
-        expect(rewriter.name).to eq 'name'
+      context "by http url" do
+        it 'evals snippet' do
+          expect(described_class).to receive(:remote_snippet_exists?).with(URI.parse('http://example.com/rewriter.rb')).and_return(true)
+          expect_any_instance_of(URI::HTTP).to receive(:open).and_return(StringIO.new("Rewriter.new 'group', 'name' do\nend"))
+          rewriter = described_class.eval_snippet('http://example.com/rewriter.rb')
+          expect(rewriter.group).to eq 'group'
+          expect(rewriter.name).to eq 'name'
+        end
+
+        it 'raises error' do
+          expect(described_class).to receive(:remote_snippet_exists?).and_return(false)
+          expect do
+            described_class.eval_snippet('http://example.com/rewriter.rb')
+          end.to raise_error(SnippetNotFoundError)
+        end
       end
 
-      it 'adds snippet by file path' do
-        expect(File).to receive(:exist?).and_return(true)
-        expect(File).to receive(:read).and_return("Rewriter.new 'group', 'name' do\nend")
-        rewriter = described_class.eval_snippet('/home/richard/foo/bar.rb')
-        expect(rewriter.group).to eq 'group'
-        expect(rewriter.name).to eq 'name'
+      context 'by file path' do
+        it 'evals snippet' do
+          expect(File).to receive(:exist?).and_return(true)
+          expect(File).to receive(:read).and_return("Rewriter.new 'group', 'name' do\nend")
+          rewriter = described_class.eval_snippet('/home/richard/foo/bar.rb')
+          expect(rewriter.group).to eq 'group'
+          expect(rewriter.name).to eq 'name'
+        end
       end
 
-      it 'adds snippet by snippet name' do
-        expect(File).to receive(:exist?).and_return(false)
-        expect(File).to receive(:read).and_return("Rewriter.new 'group', 'name' do\nend")
-        rewriter = described_class.eval_snippet('/home/richard/foo/bar.rb')
-        expect(rewriter.group).to eq 'group'
-        expect(rewriter.name).to eq 'name'
+      context 'by snippet name' do
+        it 'evals snippet as file' do
+          expect(File).to receive(:exist?).with("group/name").and_return(false)
+          expect(described_class).to receive(:default_snippets_home).and_return('/home/richard/.synvert-ruby')
+          expect(File).to receive(:exist?).with("/home/richard/.synvert-ruby/lib/group/name.rb").and_return(true)
+          expect(File).to receive(:read).and_return("Rewriter.new 'group', 'name' do\nend")
+          rewriter = described_class.eval_snippet('group/name')
+          expect(rewriter.group).to eq 'group'
+          expect(rewriter.name).to eq 'name'
+        end
+
+        it 'evals snippet as github url' do
+          expect(File).to receive(:exist?).with("group/name").and_return(false)
+          expect(described_class).to receive(:default_snippets_home).and_return('/home/richard/.synvert-ruby')
+          expect(File).to receive(:exist?).with("/home/richard/.synvert-ruby/lib/group/name.rb").and_return(false)
+          expect(described_class).to receive(:remote_snippet_exists?).with(URI.parse("https://raw.githubusercontent.com/xinminlabs/synvert-snippets-ruby/main/lib/group/name.rb")).and_return(true)
+          expect_any_instance_of(URI::HTTP).to receive(:open).and_return(StringIO.new("Rewriter.new 'group', 'name' do\nend"))
+          rewriter = described_class.eval_snippet('group/name')
+          expect(rewriter.group).to eq 'group'
+          expect(rewriter.name).to eq 'name'
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert-core
 version: !ruby/object:Gem::Version
-  version: 1.14.2
+  version: 1.15.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-19 00:00:00.000000000 Z
+date: 2022-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -145,6 +145,7 @@ files:
 - lib/synvert/core/rewriter/scope/goto_scope.rb
 - lib/synvert/core/rewriter/scope/within_scope.rb
 - lib/synvert/core/rewriter/warning.rb
+- lib/synvert/core/snippet_not_found_error.rb
 - lib/synvert/core/strategy.rb
 - lib/synvert/core/utils.rb
 - lib/synvert/core/version.rb
@@ -187,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.22
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: convert ruby code to better syntax.