synvert-core 0.42.0 → 0.45.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19c77660c79cc18a6c2d720d7a8bada136dc0397a2cc73610cc87d3412ac5306
-  data.tar.gz: '083cc96fa1b41d83a4bd5c3512440ec88223bbc67969aca2d03dd58f87a26b24'
+  metadata.gz: 79cd6bc1c9d3e69d97ee47a276165412326be82a0d87f4527742c6d6c2acdca8
+  data.tar.gz: efa16f88a2a075aa33b3dc5aba653e8c188317840a5a0af75dfba87878a4c7d3
 SHA512:
-  metadata.gz: 6403332404a070851c4817321702097cbff8cc34f75bc23d8dba236be878c83948012f79ba36ed51bea4e275f61f4adf4a5b638e35b0c8fd88dfd370b720854f
-  data.tar.gz: dc6bbc40dc208bb9ed9b8f9003b7a11e59ece0e79fb8db3cc4466f7c5b6f70574f71a5c7e4e161e762498854954293105b2023a996802b2906df04af51286f9a
+  metadata.gz: 51115212e46d96e19fc611a565535246e0fa25d43b8ad6d8830c7e149571b0ff682621ba9525a2d9ab0250d1a98afde7f02d5d8f414457d00fcbbd5bf5352372
+  data.tar.gz: a6b3c930b1183abd25ee03e5c371a5a937f22e686e975f8de48afb882ff82deb8b43432ada7ff85254c2f04e7be1081bca8b7cd4af475cc94ad1250fd8c02846

data/.github/workflows/main.yml

@@ -0,0 +1,32 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.5', '2.6', '2.7', '3.0']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true
+    - name: Run tests
+      run: bundle exec rake

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # CHANGELOG
 
+# 0.45.0 (2021-07-22)
+
+* Handle `nil` child node for `begin_pos` and `end_pos`
+* Remove `Rewriter::Instance` options
+
+# 0.44.0 (2021-07-19)
+
+* Return rewrtier after executing snippet
+* `left_value` and `right_value` support `or_asgn` node
+* `child_node_range` supports send `parentheses`
+
 # 0.42.0 (2021-07-11)
 
 * Match string with quote

data/README.md

@@ -1,6 +1,6 @@
 # Synvert::Core
 
-[![Build Status](https://secure.travis-ci.org/xinminlabs/synvert-core.png)](http://travis-ci.org/xinminlabs/synvert-core)
+![Main workflow](https://github.com/xinminlabs/synvert-core/actions/workflows/main.yml/badge.svg)
 [![Coverage Status](https://coveralls.io/repos/xinminlabs/synvert-core/badge.png?branch=master)](https://coveralls.io/r/xinminlabs/synvert-core)
 [![Gem Version](https://badge.fury.io/rb/synvert-core.png)](http://badge.fury.io/rb/synvert-core)
 

data/lib/synvert/core/node_ext.rb

@@ -217,6 +217,8 @@ module Parser::AST
     def left_value
       if %i[masgn lvasgn ivasgn].include? type
         children[0]
+      elsif :or_asgn == type
+        children[0].children[0]
       else
         raise Synvert::Core::MethodNotSupported, "left_value is not handled for #{debug_info}"
       end
@@ -227,7 +229,7 @@ module Parser::AST
     # @return [Array<Parser::AST::Node>] variable nodes.
     # @raise [Synvert::Core::MethodNotSupported] if calls on other node.
     def right_value
-      if %i[masgn lvasgn ivasgn].include? type
+      if %i[masgn lvasgn ivasgn or_asgn].include? type
         children[1]
       else
         raise Synvert::Core::MethodNotSupported, "right_value is not handled for #{debug_info}"
@@ -360,6 +362,10 @@ module Parser::AST
         else
           loc.selector
         end
+      when %i[send parentheses]
+        if loc.begin && loc.end
+          Parser::Source::Range.new('(string)', loc.begin.begin_pos, loc.end.end_pos)
+        end
       else
         if respond_to?(child_name)
           child_node = send(child_name)

data/lib/synvert/core/rewriter.rb

@@ -52,7 +52,9 @@ module Synvert::Core
       #
       # @param block [Block] a block defines the behaviors of the rewriter.
       def execute(&block)
-        Rewriter.new('', '', &block).process
+        rewriter = Rewriter.new('', '', &block)
+        rewriter.process
+        rewriter
       end
 
       # Register a rewriter with its group and name.
@@ -243,13 +245,12 @@ module Synvert::Core
     # It creates a [Synvert::Core::Rewriter::Instance] to rewrite code.
     #
     # @param file_pattern [String] pattern to find files, e.g. spec/**/*_spec.rb
-    # @param options [Hash] instance options.
     # @param block [Block] the block to rewrite code in the matching files.
-    def within_files(file_pattern, options = {}, &block)
+    def within_files(file_pattern, &block)
       return if @sandbox
 
       if (!@ruby_version || @ruby_version.match?) && (!@gem_spec || @gem_spec.match?)
-        Rewriter::Instance.new(self, file_pattern, options, &block).process
+        Rewriter::Instance.new(self, file_pattern, &block).process
       end
     end
 

data/lib/synvert/core/rewriter/action/delete_action.rb

@@ -12,14 +12,14 @@ module Synvert::Core
     #
     # @return [Integer] begin position.
     def begin_pos
-      @selectors.map { |selector| @node.child_node_range(selector).begin_pos }.min
+      @selectors.map { |selector| @node.child_node_range(selector) }.compact.map(&:begin_pos).min
     end
 
     # End position of code to replace.
     #
     # @return [Integer] end position.
     def end_pos
-      @selectors.map { |selector| @node.child_node_range(selector).end_pos }.max
+      @selectors.map { |selector| @node.child_node_range(selector) }.compact.map(&:end_pos).max
     end
 
     # The rewritten code, always empty string.

data/lib/synvert/core/rewriter/instance.rb

@@ -64,20 +64,16 @@ module Synvert::Core
     #   @return current filename
     attr_accessor :current_node, :current_file
 
-    DEFAULT_OPTIONS = { sort_by: 'begin_pos' }.freeze
-
     # Initialize an instance.
     #
     # @param rewriter [Synvert::Core::Rewriter]
     # @param file_pattern [String] pattern to find files, e.g. spec/**/*_spec.rb
-    # @param options [Hash] instance options, it includes :sort_by.
     # @param block [Block] block code to find nodes, match conditions and rewrite code.
     # @return [Synvert::Core::Rewriter::Instance]
-    def initialize(rewriter, file_pattern, options = {}, &block)
+    def initialize(rewriter, file_pattern, &block)
       @rewriter = rewriter
       @actions = []
       @file_pattern = file_pattern
-      @options = DEFAULT_OPTIONS.merge(options)
       @block = block
       rewriter.helpers.each { |helper| singleton_class.send(:define_method, helper[:name], &helper[:block]) }
     end
@@ -107,7 +103,7 @@ module Synvert::Core
           end
 
           if @actions.length > 0
-            @actions.sort_by! { |action| action.send(@options[:sort_by]) }
+            @actions.sort_by! { |action| [action.begin_pos, action.end_pos] }
             conflict_actions = get_conflict_actions
             @actions.reverse_each do |action|
               source[action.begin_pos...action.end_pos] = action.rewritten_code

data/lib/synvert/core/version.rb

@@ -2,6 +2,6 @@
 
 module Synvert
   module Core
-    VERSION = '0.42.0'
+    VERSION = '0.45.0'
   end
 end

data/spec/synvert/core/node_ext_spec.rb

@@ -261,6 +261,11 @@ describe Parser::AST::Node do
       node = parse('@a = 1')
       expect(node.left_value).to eq :@a
     end
+
+    it 'gets for or_asgn' do
+      node = parse('a ||= 1')
+      expect(node.left_value).to eq :a
+    end
   end
 
   describe '#right_value' do
@@ -283,6 +288,11 @@ describe Parser::AST::Node do
       node = parse('@a = 1')
       expect(node.right_value).to eq parse('1')
     end
+
+    it 'gets for or_asgn' do
+      node = parse('a ||= 1')
+      expect(node.right_value).to eq parse('1')
+    end
   end
 
   describe '#to_value' do
@@ -614,6 +624,20 @@ describe Parser::AST::Node do
         range = node.child_node_range(:arguments)
         expect(range).to be_nil
       end
+
+      it 'checks parentheses' do
+        node = parse('foo.bar(test)')
+        range = node.child_node_range(:parentheses)
+        expect(range.to_range).to eq(7...13)
+
+        node = parse('foobar(test)')
+        range = node.child_node_range(:parentheses)
+        expect(range.to_range).to eq(6...12)
+
+        node = parse('foo.bar')
+        range = node.child_node_range(:parentheses)
+        expect(range).to be_nil
+      end
     end
   end
 

data/spec/synvert/core/rewriter/gem_spec_spec.rb

@@ -4,19 +4,18 @@ require 'spec_helper'
 
 module Synvert::Core
   describe Rewriter::GemSpec do
-    let(:gemfile_lock_content) {
-      '
-GEM
-  remote: https://rubygems.org/
-  specs:
-    ast (1.1.0)
-    parser (2.1.7)
-      ast (~> 1.1)
-      slop (~> 3.4, >= 3.4.5)
-    rake (10.1.1)
-    slop (3.4.7)
-    '
-    }
+    let(:gemfile_lock_content) { <<~EOS }
+      GEM
+        remote: https://rubygems.org/
+        specs:
+          ast (1.1.0)
+          parser (2.1.7)
+            ast (~> 1.1)
+            slop (~> 3.4, >= 3.4.5)
+          rake (10.1.1)
+          slop (3.4.7)
+    EOS
+    before { allow(File).to receive(:exist?).with(File.join(ENV['HOME'], '.gem/specs')).and_return(false) }
 
     it 'returns true if version in Gemfile.lock is greater than definition' do
       expect(File).to receive(:exist?).with('./Gemfile.lock').and_return(true)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert-core
 version: !ruby/object:Gem::Version
-  version: 0.42.0
+  version: 0.45.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-11 00:00:00.000000000 Z
+date: 2021-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -129,9 +129,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Guardfile

data/.travis.yml

@@ -1,8 +0,0 @@
-language: ruby
-rvm:
-  - 2.3
-  - 2.4
-  - 2.5
-  - 2.6
-  - 2.7
-  - 3.0