synvert-core 0.16.1 → 0.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 327989a145ffc5562768e51cf54f6a86ad2bed0b329c7398eb9499a3fa0f4b07
-  data.tar.gz: d7cb9ca59c8a821329b7063e515a329ab451a83ce80439028af458d9cf745804
+  metadata.gz: b73d8898436945c3266c9d0e4eec002491c3b031e1d571f94b3a59443142a9dd
+  data.tar.gz: c8afb1ce36ef5d3e826ebbc7ca10103175661e14f8ea1af1ae5a1a83b8714dbf
 SHA512:
-  metadata.gz: 7e3afcda5002e5d275faba969dc193e0d8f88781e647ab7fecb44bbbe3b0de383aa74bfad2341b406e148005c4ec7b44fbe941ab884f2a1968d4c81ec1cb9080
-  data.tar.gz: 2b504f8c0a822ae0874e154d45f811b9301bda4c7399bf4c54c365d30bf719367d17a04f0bd41fd77c618c0045901bf70e825301b3811ba023fe0f20bf1c17d5
+  metadata.gz: b7198c44b3696f0c0f640fe378ff3b9923799517998d6be38177096a552b33885bf5df6113d1aa1a0b68432bff79d0322587648d221bd6fbaebcf75ab8b2d32d
+  data.tar.gz: 39b8bf09735971e108b112b96b3377df988b82e891c76d5050fef978aec81bf340ff096463ac9416848fd9b8e412b95537377d0647d11a6028d5ab909cac4fa4

data/CHANGELOG.md

@@ -1,6 +1,8 @@
 # CHANGELOG
 
-* Abstract `find_matching_nodes`
+## 0.17.0 (2021-01-29)
+
+* Ignore `gem_spec` check if `Gemfile.lock` does not eixst
 
 ## 0.16.0 (2021-01-17)
 

data/lib/synvert/core.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require "synvert/core/version"
-
-# coding: utf-8
 require "synvert/core/version"
 require 'bundler'
 require 'parser'

data/lib/synvert/core/rewriter/gem_spec.rb

@@ -27,15 +27,14 @@ module Synvert::Core
     # @raise [Synvert::Core::GemfileLockNotFound] raise if Gemfile.lock does not exist.
     def match?
       gemfile_lock_path = File.join(Configuration.instance.get(:path), 'Gemfile.lock')
-      if File.exists? gemfile_lock_path
-        parser = Bundler::LockfileParser.new(File.read(gemfile_lock_path))
-        if spec = parser.specs.find { |spec| spec.name == @name }
-          Gem::Version.new(spec.version).send(OPERATORS[@operator], @version)
-        else
-          false
-        end
+      # if Gemfile.lock does not exist, just ignore this check
+      return true unless File.exist?(gemfile_lock_path)
+
+      parser = Bundler::LockfileParser.new(File.read(gemfile_lock_path))
+      if spec = parser.specs.find { |spec| spec.name == @name }
+        Gem::Version.new(spec.version).send(OPERATORS[@operator], @version)
       else
-        raise GemfileLockNotFound.new 'Gemfile.lock does not exist'
+        false
       end
     end
   end

data/lib/synvert/core/version.rb

@@ -2,6 +2,6 @@
 
 module Synvert
   module Core
-    VERSION = "0.16.1"
+    VERSION = "0.17.0"
   end
 end

data/spec/synvert/core/rewriter/action/replace_with_action_spec.rb

@@ -30,10 +30,10 @@ module Synvert::Core
         source = "  its(:size) { should == 1 }"
         send_node = Parser::CurrentRuby.parse(source)
         instance = double(current_node: send_node)
-        Rewriter::ReplaceWithAction.new(instance, """describe '#size' do
+        Rewriter::ReplaceWithAction.new(instance, "describe '#size' do
   subject { super().size }
   it { {{body}} }
-end""", autoindent: false)
+end", autoindent: false)
       }
 
       it 'gets begin_pos' do
@@ -45,10 +45,10 @@ end""", autoindent: false)
       end
 
       it 'gets rewritten_code' do
-        expect(subject.rewritten_code).to eq """describe '#size' do
+        expect(subject.rewritten_code).to eq "describe '#size' do
   subject { super().size }
   it { should == 1 }
-end"""
+end"
       end
     end
   end

data/spec/synvert/core/rewriter/condition/if_exist_condition_spec.rb

@@ -5,12 +5,12 @@ require 'spec_helper'
 module Synvert::Core
   describe Rewriter::IfExistCondition do
     let(:source) {
-      """
+      "
       RSpec.configure do |config|
         config.include EmailSpec::Helpers
         config.include EmailSpec::Methods
       end
-      """
+      "
     }
     let(:node) { Parser::CurrentRuby.parse(source) }
     let(:instance) { double(:current_node => node) }

data/spec/synvert/core/rewriter/condition/if_only_exist_condition_spec.rb

@@ -5,23 +5,23 @@ require 'spec_helper'
 module Synvert::Core
   describe Rewriter::IfOnlyExistCondition do
     let(:source) {
-      """
+      "
       RSpec.configure do |config|
         config.include EmailSpec::Helpers
         config.include EmailSpec::Methods
       end
-      """
+      "
     }
     let(:node) { Parser::CurrentRuby.parse(source) }
     let(:instance) { double(:current_node => node) }
 
     describe '#process' do
       it 'gets matching nodes' do
-        source = """
+        source = "
           RSpec.configure do |config|
             config.include EmailSpec::Helpers
           end
-        """
+        "
         node = Parser::CurrentRuby.parse(source)
         instance = double(:current_node => node)
         run = false

data/spec/synvert/core/rewriter/condition/unless_exist_condition_spec.rb

@@ -5,12 +5,12 @@ require 'spec_helper'
 module Synvert::Core
   describe Rewriter::UnlessExistCondition do
     let(:source) {
-      """
+      "
       RSpec.configure do |config|
         config.include EmailSpec::Helpers
         config.include EmailSpec::Methods
       end
-      """
+      "
     }
     let(:node) { Parser::CurrentRuby.parse(source) }
     let(:instance) { double(:current_node => node) }

data/spec/synvert/core/rewriter/gem_spec_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 module Synvert::Core
   describe Rewriter::GemSpec do
-    let(:gemfile_lock_content) { """
+    let(:gemfile_lock_content) { "
 GEM
   remote: https://rubygems.org/
   specs:
@@ -14,41 +14,40 @@ GEM
       slop (~> 3.4, >= 3.4.5)
     rake (10.1.1)
     slop (3.4.7)
-      """
-    }
+    "}
 
     it 'returns true if version in Gemfile.lock is greater than definition' do
-      expect(File).to receive(:exists?).with('./Gemfile.lock').and_return(true)
+      expect(File).to receive(:exist?).with('./Gemfile.lock').and_return(true)
       expect(File).to receive(:read).with('./Gemfile.lock').and_return(gemfile_lock_content)
       gem_spec = Rewriter::GemSpec.new('ast', {gte: '1.0.0'})
       expect(gem_spec).to be_match
     end
 
     it 'returns true if version in Gemfile.lock is equal to definition' do
-      expect(File).to receive(:exists?).with('./Gemfile.lock').and_return(true)
+      expect(File).to receive(:exist?).with('./Gemfile.lock').and_return(true)
       expect(File).to receive(:read).with('./Gemfile.lock').and_return(gemfile_lock_content)
       gem_spec = Rewriter::GemSpec.new('ast', '1.1.0')
       expect(gem_spec).to be_match
     end
 
     it 'returns false if version in Gemfile.lock is less than definition' do
-      expect(File).to receive(:exists?).with('./Gemfile.lock').and_return(true)
+      expect(File).to receive(:exist?).with('./Gemfile.lock').and_return(true)
       expect(File).to receive(:read).with('./Gemfile.lock').and_return(gemfile_lock_content)
       gem_spec = Rewriter::GemSpec.new('ast', {gt: '1.2.0'})
       expect(gem_spec).not_to be_match
     end
 
     it 'returns false if gem does not exist in Gemfile.lock' do
-      expect(File).to receive(:exists?).with('./Gemfile.lock').and_return(true)
+      expect(File).to receive(:exist?).with('./Gemfile.lock').and_return(true)
       expect(File).to receive(:read).with('./Gemfile.lock').and_return(gemfile_lock_content)
       gem_spec = Rewriter::GemSpec.new('synvert', '1.0.0')
       expect(gem_spec).not_to be_match
     end
 
     it 'raise Synvert::Core::GemfileLockNotFound if Gemfile.lock does not exist' do
-      expect(File).to receive(:exists?).with('./Gemfile.lock').and_return(false)
+      expect(File).to receive(:exist?).with('./Gemfile.lock').and_return(false)
       gem_spec = Rewriter::GemSpec.new('ast', '1.1.0')
-      expect { gem_spec.match? }.to raise_error(Synvert::Core::GemfileLockNotFound)
+      expect(gem_spec).to be_match
     end
   end
 end

data/spec/synvert/core/rewriter/instance_spec.rb

@@ -114,20 +114,20 @@ module Synvert::Core
             replace_with 'create {{arguments}}'
           end
         end
-        input = """
+        input = "
 it 'uses factory_girl' do
   user = FactoryGirl.create :user
   post = FactoryGirl.create :post, user: user
   assert post.valid?
 end
-"""
-        output = """
+"
+        output = "
 it 'uses factory_girl' do
   user = create :user
   post = create :post, user: user
   assert post.valid?
 end
-"""
+"
         expect(Dir).to receive(:glob).with('./spec/**/*_spec.rb').and_return(['spec/models/post_spec.rb'])
         expect(File).to receive(:read).with('spec/models/post_spec.rb').and_return(input)
         expect(File).to receive(:write).with('spec/models/post_spec.rb', output)
@@ -142,16 +142,16 @@ end
             end
           end
         end
-        input = """
+        input = "
         RSpec.configure do |config|
           config.include FactoryGirl::Syntax::Methods
         end
-        """
-        output = """
+        "
+        output = "
         RSpec.configure do |config|
           config.include FactoryGirl::Syntax::Methods
         end
-        """
+        "
         expect(Dir).to receive(:glob).with('./spec/spec_helper.rb').and_return(['spec/spec_helper.rb'])
         expect(File).to receive(:read).with('spec/spec_helper.rb').and_return(input)
         expect(File).not_to receive(:write).with('spec/spec_helper.rb', output)
@@ -166,16 +166,16 @@ end
             end
           end
         end
-        input = """
+        input = "
         RSpec.configure do |config|
           config.include FactoryGirl::Syntax::Methods
         end
-        """
-        output = """
+        "
+        output = "
         RSpec.configure do |config|
           config.include FactoryGirl::Syntax::Methods
         end
-        """
+        "
         expect(Dir).to receive(:glob).with('./spec/spec_helper.rb').and_return(['spec/spec_helper.rb']).twice
         expect(File).to receive(:read).with('spec/spec_helper.rb').and_return(input).once
         expect(File).not_to receive(:write).with('spec/spec_helper.rb', output)
@@ -189,20 +189,20 @@ end
             replace_with 'create {{arguments}}'
           end
         end
-        input = """
+        input = "
 it 'uses factory_girl' do
   user = FactoryGirl.create :user
   post = FactoryGirl.create :post, user: user
   assert post.valid?
 end
-"""
-        output = """
+"
+        output = "
 it 'uses factory_girl' do
   user = create :user
   post = create :post, user: user
   assert post.valid?
 end
-"""
+"
         expect(Dir).to receive(:glob).with('./spec/**/*_spec.rb').and_return(['spec/models/post_spec.rb']).twice
         expect(File).to receive(:read).with('spec/models/post_spec.rb').and_return(input)
         expect(File).to receive(:write).with('spec/models/post_spec.rb', output)

data/spec/synvert/core/rewriter/scope/within_scope.rb

@@ -8,13 +8,13 @@ module Synvert::Core
       rewriter = Rewriter.new('foo', 'bar')
       Rewriter::Instance.new(rewriter, 'file pattern')
     }
-    let(:source) {"""
+    let(:source) {"
 describe Post do
   it 'gets post' do
     FactoryGirl.create :post
   end
 end
-    """
+    "
     }
     let(:node) { Parser::CurrentRuby.parse(source) }
     before do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert-core
 version: !ruby/object:Gem::Version
-  version: 0.16.1
+  version: 0.17.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-28 00:00:00.000000000 Z
+date: 2021-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser