synvert-core 0.16.0 → 0.20.0

data/spec/synvert/core/rewriter/scope/goto_scope_spec.rb

@@ -8,10 +8,11 @@ module Synvert::Core
       rewriter = Rewriter.new('foo', 'bar')
       Rewriter::Instance.new(rewriter, 'file pattern')
     }
-    let(:source) {'''
+    let(:source) {
+      '
 Factory.define :user do |user|
 end
-    '''
+    '
     }
     let(:node) { Parser::CurrentRuby.parse(source) }
     before do
@@ -23,10 +24,11 @@ end
       it 'call block with child node' do
         run = false
         type_in_scope = nil
-        scope = Rewriter::GotoScope.new instance, :caller do
-          run = true
-          type_in_scope = node.type
-        end
+        scope =
+          Rewriter::GotoScope.new instance, :caller do
+            run = true
+            type_in_scope = node.type
+          end
         scope.process
         expect(run).to be_truthy
         expect(type_in_scope).to eq :send

data/spec/synvert/core/rewriter/scope/within_scope.rb

@@ -8,13 +8,14 @@ module Synvert::Core
       rewriter = Rewriter.new('foo', 'bar')
       Rewriter::Instance.new(rewriter, 'file pattern')
     }
-    let(:source) {"""
+    let(:source) {
+      "
 describe Post do
   it 'gets post' do
     FactoryGirl.create :post
   end
 end
-    """
+    "
     }
     let(:node) { Parser::CurrentRuby.parse(source) }
     before do
@@ -25,9 +26,10 @@ end
     describe '#process' do
       it 'not call block if no matching node' do
         run = false
-        scope = Rewriter::WithinScope.new instance, type: 'send', message: 'missing' do
-          run = true
-        end
+        scope =
+          Rewriter::WithinScope.new instance, type: 'send', message: 'missing' do
+            run = true
+          end
         scope.process
         expect(run).to be_falsey
       end
@@ -35,10 +37,15 @@ end
       it 'call block if there is matching node' do
         run = false
         type_in_scope = nil
-        scope = Rewriter::WithinScope.new instance, type: 'send', receiver: 'FactoryGirl', message: 'create', arguments: [':post'] do
-          run = true
-          type_in_scope = node.type
-        end
+        scope =
+          Rewriter::WithinScope.new instance,
+                                    type: 'send',
+                                    receiver: 'FactoryGirl',
+                                    message: 'create',
+                                    arguments: [':post'] do
+            run = true
+            type_in_scope = node.type
+          end
         scope.process
         expect(run).to be_truthy
         expect(type_in_scope).to eq :send

data/spec/synvert/core/rewriter_spec.rb

@@ -4,27 +4,36 @@ require 'spec_helper'
 
 module Synvert::Core
   describe Rewriter do
+    it '.execute' do
+      run = false
+      Rewriter.execute { run = true }
+      expect(run).to be_truthy
+    end
+
     it 'parses description' do
-      rewriter = Rewriter.new 'group', 'name' do
-        description 'rewriter description'
-      end
+      rewriter =
+        Rewriter.new 'group', 'name' do
+          description 'rewriter description'
+        end
       rewriter.process
       expect(rewriter.description).to eq 'rewriter description'
     end
 
     it 'parses if_ruby' do
-      #stub_const("RUBY_VERSION", '2.0.0')
-      rewriter = Rewriter.new 'group', 'name' do
-        if_ruby '2.0.0'
-      end
+      expect(Rewriter::RubyVersion).to receive(:new).with('2.0.0')
+      rewriter =
+        Rewriter.new 'group', 'name' do
+          if_ruby '2.0.0'
+        end
       rewriter.process
     end
 
     it 'parses if_gem' do
-      expect(Rewriter::GemSpec).to receive(:new).with('synvert', {gte: '1.0.0'})
-      rewriter = Rewriter.new 'group', 'name' do
-        if_gem 'synvert', {gte: '1.0.0'}
-      end
+      expect(Rewriter::GemSpec).to receive(:new).with('synvert', { gte: '1.0.0' })
+      rewriter =
+        Rewriter.new 'group', 'name' do
+          if_gem 'synvert', { gte: '1.0.0' }
+        end
       rewriter.process
     end
 
@@ -32,76 +41,90 @@ module Synvert::Core
       it 'does nothing if if_ruby does not match' do
         stub_const('RUBY_VERSION', '2.0.0')
         expect_any_instance_of(Rewriter::Instance).not_to receive(:process)
-        rewriter = Rewriter.new 'group', 'name' do
-          if_ruby '2.2.3'
-          within_file 'config/routes.rb' do; end
-        end
+        rewriter =
+          Rewriter.new 'group', 'name' do
+            if_ruby '2.2.3'
+            within_file 'config/routes.rb' do
+            end
+          end
         rewriter.process
       end
 
       it 'delegates process to instances if if_ruby matches' do
         stub_const('RUBY_VERSION', '2.0.0')
         expect_any_instance_of(Rewriter::Instance).to receive(:process)
-        rewriter = Rewriter.new 'group', 'name' do
-          if_ruby '1.9.3'
-          within_file 'config/routes.rb' do; end
-        end
+        rewriter =
+          Rewriter.new 'group', 'name' do
+            if_ruby '1.9.3'
+            within_file 'config/routes.rb' do
+            end
+          end
         rewriter.process
       end
 
       it 'does nothing if if_gem does not match' do
         expect_any_instance_of(Rewriter::GemSpec).to receive(:match?).and_return(false)
         expect_any_instance_of(Rewriter::Instance).not_to receive(:process)
-        rewriter = Rewriter.new 'group', 'name' do
-          if_gem 'synvert', '1.0.0'
-          within_file 'config/routes.rb' do; end
-        end
+        rewriter =
+          Rewriter.new 'group', 'name' do
+            if_gem 'synvert', '1.0.0'
+            within_file 'config/routes.rb' do
+            end
+          end
         rewriter.process
       end
 
       it 'delegates process to instances if if_gem matches' do
         expect_any_instance_of(Rewriter::GemSpec).to receive(:match?).and_return(true)
         expect_any_instance_of(Rewriter::Instance).to receive(:process)
-        rewriter = Rewriter.new 'group', 'name' do
-          if_gem 'synvert', '1.0.0'
-          within_file 'config/routes.rb' do; end
-        end
+        rewriter =
+          Rewriter.new 'group', 'name' do
+            if_gem 'synvert', '1.0.0'
+            within_file 'config/routes.rb' do
+            end
+          end
         rewriter.process
       end
 
       it 'delegates process to instances if if_ruby and if_gem do not exist' do
         expect_any_instance_of(Rewriter::Instance).to receive(:process)
-        rewriter = Rewriter.new 'group', 'name' do
-          within_file 'config/routes.rb' do; end
-        end
+        rewriter =
+          Rewriter.new 'group', 'name' do
+            within_file 'config/routes.rb' do
+            end
+          end
         rewriter.process
       end
 
       it 'does nothing in sandbox mode' do
         expect_any_instance_of(Rewriter::GemSpec).not_to receive(:match?)
         expect_any_instance_of(Rewriter::Instance).not_to receive(:process)
-        rewriter = Rewriter.new 'group', 'name' do
-          if_gem 'synvert', '1.0.0'
-          within_file 'config/routes.rb' do; end
-        end
+        rewriter =
+          Rewriter.new 'group', 'name' do
+            if_gem 'synvert', '1.0.0'
+            within_file 'config/routes.rb' do
+            end
+          end
         rewriter.process_with_sandbox
       end
     end
 
     describe 'parses add_file' do
       it 'creates a new file' do
-        rewriter = Rewriter.new 'group', 'rewriter2' do
-          add_file 'foo.bar', 'FooBar'
-        end
+        rewriter =
+          Rewriter.new 'group', 'rewriter2' do
+            add_file 'foo.bar', 'FooBar'
+          end
         rewriter.process
         expect(File.read('./foo.bar')).to eq 'FooBar'
         FileUtils.rm './foo.bar'
       end
 
       it 'does nothing in sandbox mode' do
-        rewriter = Rewriter.new 'group', 'rewriter2' do
-          add_file 'foo.bar', 'FooBar'
-        end
+        rewriter =
+          Rewriter.new 'group', 'rewriter2' do
+            add_file 'foo.bar', 'FooBar'
+          end
         rewriter.process_with_sandbox
         expect(File.exist?('./foo.bar')).to be_falsey
       end
@@ -110,26 +133,29 @@ module Synvert::Core
     describe 'parses remove_file' do
       it 'removes a file' do
         FileUtils.touch './foo.bar'
-        rewriter = Rewriter.new 'group', 'rewriter2' do
-          remove_file 'foo.bar'
-        end
+        rewriter =
+          Rewriter.new 'group', 'rewriter2' do
+            remove_file 'foo.bar'
+          end
         rewriter.process
         expect(File.exist?('./foo.bar')).to be_falsey
       end
 
       it 'does nothing if file not exist' do
-        rewriter = Rewriter.new 'group', 'rewriter2' do
-          remove_file 'foo.bar'
-        end
+        rewriter =
+          Rewriter.new 'group', 'rewriter2' do
+            remove_file 'foo.bar'
+          end
         rewriter.process
         expect(File.exist?('./foo.bar')).to be_falsey
       end
 
       it 'does nothing in sandbox mode' do
         FileUtils.touch './foo.bar'
-        rewriter = Rewriter.new 'group', 'rewriter2' do
-          add_file 'foo.bar', 'FooBar'
-        end
+        rewriter =
+          Rewriter.new 'group', 'rewriter2' do
+            add_file 'foo.bar', 'FooBar'
+          end
         rewriter.process_with_sandbox
         expect(File.exist?('./foo.bar')).to be_truthy
         FileUtils.rm './foo.bar'
@@ -139,46 +165,51 @@ module Synvert::Core
     describe 'parses add_snippet' do
       it 'processes the rewritter' do
         rewriter1 = Rewriter.new 'group', 'rewriter1'
-        rewriter2 = Rewriter.new 'group', 'rewriter2' do
-          add_snippet :group, :rewriter1
-        end
+        rewriter2 =
+          Rewriter.new 'group', 'rewriter2' do
+            add_snippet :group, :rewriter1
+          end
         expect(rewriter1).to receive(:process)
         rewriter2.process
       end
 
       it 'adds sub_snippets' do
         rewriter1 = Rewriter.new 'group', 'rewriter1'
-        rewriter2 = Rewriter.new 'group', 'rewriter2' do
-          add_snippet :group, :rewriter1
-        end
+        rewriter2 =
+          Rewriter.new 'group', 'rewriter2' do
+            add_snippet :group, :rewriter1
+          end
         expect(rewriter1).to receive(:process)
         rewriter2.process
         expect(rewriter2.sub_snippets).to eq [rewriter1]
       end
 
       it 'raises RewriterNotFound' do
-        rewriter = Rewriter.new 'group', 'name' do
-          add_snippet :group, :not_exist
-        end
+        rewriter =
+          Rewriter.new 'group', 'name' do
+            add_snippet :group, :not_exist
+          end
         expect { rewriter.process }.to raise_error(RewriterNotFound)
       end
     end
 
     it 'parses helper_method' do
-      rewriter = Rewriter.new 'group', 'name' do
-        helper_method 'dynamic_helper' do |arg1, arg2|
-          'dynamic result'
+      rewriter =
+        Rewriter.new 'group', 'name' do
+          helper_method 'dynamic_helper' do |_arg1, _arg2|
+            'dynamic result'
+          end
         end
-      end
       rewriter.process
       instance = Rewriter::Instance.new(rewriter, '*.rb')
       expect(instance.dynamic_helper('arg1', 'arg2')).to eq 'dynamic result'
     end
 
     it 'parses todo' do
-      rewriter = Rewriter.new 'group', 'name' do
-        todo "this rewriter doesn't do blah blah blah"
-      end
+      rewriter =
+        Rewriter.new 'group', 'name' do
+          todo "this rewriter doesn't do blah blah blah"
+        end
       rewriter.process
       expect(rewriter.todo).to eq "this rewriter doesn't do blah blah blah"
     end
@@ -199,11 +230,17 @@ module Synvert::Core
         Rewriter.call 'group', 'rewriter'
       end
 
+      it 'registers and calls rewriter in sandbox mode' do
+        rewriter = Rewriter.new 'group', 'rewriter'
+        expect(rewriter).to receive(:process_with_sandbox)
+        Rewriter.call 'group', 'rewriter', true
+      end
+
       it 'raises RewriterNotFound if rewriter not found' do
         expect { Rewriter.call 'group', 'rewriter' }.to raise_error(RewriterNotFound)
       end
 
-      context "exist?" do
+      context 'exist?' do
         it 'returns true if rewriter exists' do
           Rewriter.new 'group', 'rewriter'
           expect(Rewriter.exist?('group', 'rewriter')).to be_truthy
@@ -214,7 +251,7 @@ module Synvert::Core
         end
       end
 
-      context "available" do
+      context 'available' do
         it 'lists empty rewriters' do
           expect(Rewriter.availables).to eq({})
         end
@@ -222,7 +259,7 @@ module Synvert::Core
         it 'registers and lists all available rewriters' do
           rewriter1 = Rewriter.new 'group', 'rewriter1'
           rewriter2 = Rewriter.new 'group', 'rewriter2'
-          expect(Rewriter.availables).to eq({'group' => {'rewriter1' => rewriter1, 'rewriter2' => rewriter2}})
+          expect(Rewriter.availables).to eq({ 'group' => { 'rewriter1' => rewriter1, 'rewriter2' => rewriter2 } })
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert-core
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.20.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-17 00:00:00.000000000 Z
+date: 2021-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -167,7 +167,6 @@ files:
 - lib/synvert/core/version.rb
 - spec/spec_helper.rb
 - spec/support/parser_helper.rb
-- spec/synvert/core/configuration_spec.rb
 - spec/synvert/core/engine/erb_spec.rb
 - spec/synvert/core/node_ext_spec.rb
 - spec/synvert/core/rewriter/action/append_action_spec.rb
@@ -216,7 +215,6 @@ summary: convert ruby code to better syntax.
 test_files:
 - spec/spec_helper.rb
 - spec/support/parser_helper.rb
-- spec/synvert/core/configuration_spec.rb
 - spec/synvert/core/engine/erb_spec.rb
 - spec/synvert/core/node_ext_spec.rb
 - spec/synvert/core/rewriter/action/append_action_spec.rb

data/spec/synvert/core/configuration_spec.rb

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-module Synvert::Core
-  describe Configuration do
-    it 'sets / gets' do
-      Configuration.instance.set :key, 'value'
-      expect(Configuration.instance.get(:key)).to eq 'value'
-    end
-  end
-end