syntropy 0.31.0 → 0.33.0

data/test/test_http_protocol.rb

@@ -0,0 +1,250 @@
+# frozen_string_literal: true
+
+require_relative './helper'
+
+class HTTPProtocolTest < Minitest::Test
+  def setup
+    @machine = UM.new
+    @r, @w = UM.pipe
+    @io = @machine.io(@r)
+  end
+
+  def teardown
+    @machine.close(@r) rescue nil
+    @machine.close(@w) rescue nil
+    @io = nil
+    @machine = nil
+  end
+
+  def write(str)
+    @machine.write(@w, str)
+  end
+end
+
+class HTTPProtocolRequestTest < HTTPProtocolTest
+  def test_http_request_headers_basic
+    write("GET /foo HTTP/1.1\r\nHost: bar.baz\r\n\r\n")
+    h = @io.http_read_request_headers
+    assert_equal({
+      ':method'   => 'get',
+      ':path'     => '/foo',
+      'host'    => 'bar.baz'
+    }, h)
+  end
+
+  def test_http_request_headers_bad_http_method
+    write("foo /foo HTTP/1.1\r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_request_headers }
+  end
+
+  def test_http_request_headers_bad_path
+    write("get HTTP/1.1\r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_request_headers }
+  end
+
+  def test_http_request_headers_bad_protocol
+    write("get / HTTP/1.0\r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_request_headers }
+  end
+
+  def test_http_request_headers_bad_header_missing_value
+    write("GET /foo HTTP/1.1\r\nHost: \r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_request_headers }
+  end
+
+  def test_http_request_headers_bad_header
+    write("GET /foo HTTP/1.1\r\nHost\r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_request_headers }
+  end
+
+  def test_http_request_with_body_cl
+    write("POST /foo HTTP/1.1\r\nContent-Length: 3\r\n\r\nabc")
+
+    h = @io.http_read_request_headers
+    assert_equal({
+      ':method'         => 'post',
+      ':path'           => '/foo',
+      'content-length'  => '3'
+    }, h)
+
+    b = @io.http_read_body(h)
+    assert_equal 'abc', b
+  end
+
+  def test_http_request_with_body_te
+    write("POST /foo HTTP/1.1\r\nTransfer-Encoding: chunked\r\n\r\n11\r\nabcdefghijKLMNOPQ\r\n3\r\nfoo\r\n0\r\n\r\n")
+
+    h = @io.http_read_request_headers
+    assert_equal({
+      ':method'           => 'post',
+      ':path'             => '/foo',
+      'transfer-encoding' => 'chunked'
+    }, h)
+
+    b = @io.http_read_body(h)
+    assert_equal 'abcdefghijKLMNOPQfoo', b
+  end
+
+  def test_http_request_pipelining
+    write(
+      "GET /a HTTP/1.1\r\n\r\n" +
+      "POST /b HTTP/1.1\r\nHost: foo.com\r\nContent-Length: 2\r\n\r\nab" +
+      "PATCH /c HTTP/1.1\r\nTransfer-Encoding: chunked\r\n\r\n3\r\nabc\r\n10\r\n#{'*' * 16}\r\n0\r\n\r\n" +
+      "GET /d HTTP/1.1\r\nFoo: bar\r\n\r\n"
+    )
+
+    reqs = 4.times.map {
+      h = @io.http_read_request_headers
+      b = @io.http_read_body(h)
+      [h, b]
+    }
+
+    assert_equal [
+      [
+        {
+          ':method'   => 'get',
+          ':path'     => '/a',
+        },
+        nil
+      ],
+      [
+        {
+          ':method'         => 'post',
+          ':path'           => '/b',
+          'host'            => 'foo.com',
+          'content-length'  => '2'
+        },
+        'ab'
+      ],
+      [
+        {
+          ':method'           => 'patch',
+          ':path'             => '/c',
+          'transfer-encoding' => 'chunked'
+        },
+        "abc#{'*' * 16}"
+      ],
+      [
+        {
+          ':method'   => 'get',
+          ':path'     => '/d',
+          'foo'       => 'bar'
+        },
+        nil
+      ],
+    ], reqs
+  end
+
+  def test_http_request_pipelining_skip_body
+    write(
+      "GET /a HTTP/1.1\r\n\r\n" +
+      "POST /b HTTP/1.1\r\nHost: foo.com\r\nContent-Length: 2\r\n\r\nab" +
+      "PATCH /c HTTP/1.1\r\nTransfer-Encoding: chunked\r\n\r\n3\r\nabc\r\n10\r\n#{'*' * 16}\r\n0\r\n\r\n" +
+      "GET /d HTTP/1.1\r\nFoo: bar\r\n\r\n"
+    )
+
+    reqs = 4.times.map {
+      h = @io.http_read_request_headers
+      @io.http_skip_body(h)
+      h
+    }
+
+    assert_equal [
+      {
+        ':method'   => 'get',
+        ':path'     => '/a'
+      },
+      {
+        ':method'         => 'post',
+        ':path'           => '/b',
+        'host'            => 'foo.com',
+        'content-length'  => '2'
+      },
+      {
+        ':method'           => 'patch',
+        ':path'             => '/c',
+        'transfer-encoding' => 'chunked'
+      },
+      {
+        ':method'   => 'get',
+        ':path'     => '/d',
+        'foo'       => 'bar'
+      }
+    ], reqs
+  end
+
+  def test_http_request_desync1
+    write(
+      "POST / HTTP/1.1\r\nHost: foo.com\r\nTransfer-Encoding: chunked\r\nContent-length: 35\r\n\r\n0\r\n\r\n" +
+      "GET /robots.txt HTTP/1.1\r\nX: y\r\n\r\n"
+    )
+
+    h = @io.http_read_request_headers
+    assert_equal({
+      ':method'           => 'post',
+      ':path'             => '/',
+      'host'              => 'foo.com',
+      'transfer-encoding' => 'chunked',
+      'content-length'    => '35'
+    }, h)
+
+    @io.http_skip_body(h)
+
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_request_headers }
+  end
+end
+
+class HTTPProtocolReadChunkTest < HTTPProtocolTest
+  def test_http_read_body_chunk_no_body
+    write("GET /foo HTTP/1.1\r\Host: bar.baz\r\n\r\n")
+    h = @io.http_read_request_headers
+    assert_nil @io.http_read_body_chunk(h)
+  end
+
+  def test_http_read_body_chunk_cl
+    write("POST /foo HTTP/1.1\r\Host: bar.baz\r\nContent-Length: 5\r\n\r\nabcde")
+    h = @io.http_read_request_headers
+    assert_equal 'abcde', @io.http_read_body_chunk(h)
+  end
+
+  def test_http_read_body_chunk_te
+    write("POST /foo HTTP/1.1\r\Host: bar.baz\r\nTransfer-Encoding: chunked\r\n\r\n5\r\nabcde\r\n0\r\n\r\n")
+    h = @io.http_read_request_headers
+    assert_equal 'abcde', @io.http_read_body_chunk(h)
+    assert_nil @io.http_read_body_chunk(h)
+  end
+
+  def test_http_read_body_chunk_te2
+    write("POST /foo HTTP/1.1\r\Host: bar.baz\r\nTransfer-Encoding: chunked\r\n\r\n5\r\nabcde\r\n3\r\nfgh\r\n0\r\n\r\n")
+    h = @io.http_read_request_headers
+    assert_equal 'abcde', @io.http_read_body_chunk(h)
+    assert_equal 'fgh', @io.http_read_body_chunk(h)
+    assert_nil @io.http_read_body_chunk(h)
+  end
+end
+
+class HTTPProtocolResponseTest < HTTPProtocolTest
+  def test_http_response_headers_basic
+    write("HTTP/1.1 200 OK\r\nHost: bar.baz\r\n\r\n")
+    h = @io.http_read_response_headers
+    assert_equal({
+      ':status' => 200,
+      'host'    => 'bar.baz'
+    }, h)
+  end
+
+  def test_http_response_headers_invalid_status_line1
+    write("HTTP 200 OK\r\nHost: bar.baz\r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_response_headers }
+  end
+
+  def test_http_response_headers_invalid_status_line2
+    write("HTTP/1.1\r\nHost: bar.baz\r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_response_headers }
+  end
+
+  def test_http_response_headers_invalid_status_line3
+    write("HTTP/1.1 ok\r\nBlahblah\r\n\r\n")
+    assert_raises(Syntropy::ProtocolError) { @io.http_read_response_headers }
+  end
+end

data/test/test_http_server_connection.rb

@@ -84,8 +84,7 @@ class HTTPServerConnectionTest < Minitest::Test
     headers = req.headers
     assert_equal({
       ':method'   => 'get',
-      ':path'     => '/',
-      ':protocol' => 'http/1.1'
+      ':path'     => '/'
     }, headers)
   end
 
@@ -94,7 +93,7 @@ class HTTPServerConnectionTest < Minitest::Test
       GET /foo HTTP/1.1
       Server: foo.com
 
-      SCHMET /bar HTTP/1.1
+      GET /bar HTTP/1.1
 
 
 
@@ -108,16 +107,14 @@ class HTTPServerConnectionTest < Minitest::Test
     assert_equal({
       ':method'   => 'get',
       ':path'     => '/foo',
-      ':protocol' => 'http/1.1',
       'server'    => 'foo.com'
     }, headers)
 
     req1 = @reqs.shift
     headers = req1.headers
     assert_equal({
-      ':method'   => 'schmet',
-      ':path'     => '/bar',
-      ':protocol' => 'http/1.1'
+      ':method'   => 'get',
+      ':path'     => '/bar'
     }, headers)
   end
 
@@ -127,7 +124,7 @@ class HTTPServerConnectionTest < Minitest::Test
       Server: foo.com
       Content-Length: 3
 
-      abcSCHMOST /bar HTTP/1.1
+      abcPOST /bar HTTP/1.1
       Server: bar.com
       Content-Length: 6
 
@@ -145,7 +142,6 @@ class HTTPServerConnectionTest < Minitest::Test
     assert_equal({
       ':method' => 'post',
       ':path' => '/foo',
-      ':protocol' => 'http/1.1',
       'server' => 'foo.com',
       'content-length' => '3',
       ':body-done-reading' => true
@@ -156,9 +152,8 @@ class HTTPServerConnectionTest < Minitest::Test
     req1 = @reqs.shift
     headers = req1.headers
     assert_equal({
-      ':method' => 'schmost',
+      ':method' => 'post',
       ':path' => '/bar',
-      ':protocol' => 'http/1.1',
       'server' => 'bar.com',
       'content-length' => '6',
       ':body-done-reading' => true
@@ -179,7 +174,7 @@ class HTTPServerConnectionTest < Minitest::Test
       de
       0
 
-      SCHMOST /bar HTTP/1.1
+      POST /bar HTTP/1.1
       Server: bar.com
       Transfer-Encoding: chunked
 
@@ -203,7 +198,6 @@ class HTTPServerConnectionTest < Minitest::Test
     assert_equal({
       ':method'             => 'post',
       ':path'               => '/foo',
-      ':protocol'           => 'http/1.1',
       'server'              => 'foo.com',
       'transfer-encoding'   => 'chunked',
       ':body-done-reading'  => true
@@ -214,9 +208,8 @@ class HTTPServerConnectionTest < Minitest::Test
     req1 = @reqs.shift
     headers = req1.headers
     assert_equal({
-      ':method'             => 'schmost',
+      ':method'             => 'post',
       ':path'               => '/bar',
-      ':protocol'           => 'http/1.1',
       'server'              => 'bar.com',
       'transfer-encoding'   => 'chunked',
       ':body-done-reading'  => true
@@ -237,7 +230,7 @@ class HTTPServerConnectionTest < Minitest::Test
       de
       0
 
-      SCHMOST /bar HTTP/1.1
+      POST /bar HTTP/1.1
       Server: bar.com
       Content-Length: 31
 
@@ -255,7 +248,6 @@ class HTTPServerConnectionTest < Minitest::Test
     assert_equal({
       ':method'             => 'post',
       ':path'               => '/foo',
-      ':protocol'           => 'http/1.1',
       'server'              => 'foo.com',
       'transfer-encoding'   => 'chunked',
       ':body-done-reading'  => true
@@ -269,9 +261,8 @@ class HTTPServerConnectionTest < Minitest::Test
     req1 = @reqs.shift
     headers = req1.headers
     assert_equal({
-      ':method'             => 'schmost',
+      ':method'             => 'post',
       ':path'               => '/bar',
-      ':protocol'           => 'http/1.1',
       'server'              => 'bar.com',
       'content-length'      => '31',
       ':body-done-reading'  => true
@@ -605,7 +596,7 @@ class HTTPServerConnectionTest < Minitest::Test
 
   def test_set_cookie_single
     @hook = ->(req) {
-      req.set_cookie('foo=bar; HttpOnly')
+      req.set_cookie('foo', 'bar; HttpOnly')
       req.respond('foo')
     }
 
@@ -619,7 +610,8 @@ class HTTPServerConnectionTest < Minitest::Test
 
   def test_set_cookie_multi1
     @hook = ->(req) {
-      req.set_cookie('foo=bar; HttpOnly', 'bar=baz')
+      req.set_cookie('foo', 'bar; HttpOnly')
+      req.set_cookie('bar', 'baz')
       req.respond('foo')
     }
 
@@ -633,9 +625,11 @@ class HTTPServerConnectionTest < Minitest::Test
 
   def test_set_cookie_multi2
     @hook = ->(req) {
-      req.set_cookie('a=1', 'b=2')
-      req.set_cookie('c=3')
-      req.set_cookie('d=4', 'e=5')
+      req.set_cookie('a', '1')
+      req.set_cookie('b', '2')
+      req.set_cookie('c', '3')
+      req.set_cookie('d', '4')
+      req.set_cookie('e', '5')
       req.respond('foo')
     }
 

data/test/test_json_api.rb

@@ -11,7 +11,7 @@ class JSONAPITest < Minitest::Test
     end
 
     def bar!(req)
-      @value = req.query[:v]
+      @value = req.query['v']
       true
     end
   end

data/test/{test_module.rb → test_module_loader.rb}

@@ -79,4 +79,35 @@ class ModuleTest < Minitest::Test
     mod = @loader.load('mod/foo/index')
     assert_equal '/mod/foo', mod.env[:ref]
   end
+
+  def test_list
+    list = @loader.list('_layout')
+    assert_equal ['_layout/default'], list
+
+    list = @loader.list('_lib')
+    assert_equal [
+      '_lib/callable',
+      '_lib/dep',
+      '_lib/env',
+      '_lib/klass',
+      '_lib/missing-export',
+      '_lib/self',
+    ], list
+
+    list = @loader.list('about')
+    assert_equal [
+      'about/_error',
+      'about/index',
+      'about/raise'
+    ], list
+
+    list = @loader.list('assets')
+    assert_equal [], list
+
+    list = @loader.list('mod')
+    assert_equal [], list
+
+    list = @loader.list('mod/bar')
+    assert_equal ['mod/bar/index+'], list
+  end
 end

data/test/test_request.rb

@@ -10,20 +10,20 @@ class RequestInfoTest < Minitest::Test
 
     r = Syntropy::MockAdapter.mock(':path' => '/test/path?a=1&b=2&c=3%2f4')
     assert_equal '/test/path', r.path
-    assert_equal({ a: '1', b: '2', c: '3/4' }, r.query)
+    assert_equal({ 'a' => '1', 'b' => '2', 'c' => '3/4' }, r.query)
   end
 
   def test_query
     r = Syntropy::MockAdapter.mock(':path' => '/GponForm/diag_Form?images/')
     assert_equal '/GponForm/diag_Form', r.path
-    assert_equal({:'images/' => true}, r.query)
+    assert_equal({ 'images/' => true }, r.query)
 
     r = Syntropy::MockAdapter.mock(':path' => '/?a=1&b=2')
     assert_equal '/', r.path
-    assert_equal({a: '1', b: '2'}, r.query)
+    assert_equal({ 'a' => '1', 'b' => '2'}, r.query)
 
     r = Syntropy::MockAdapter.mock(':path' => '/?l=a&t=&x=42')
-    assert_equal({l: 'a', t: '', x: '42'}, r.query)
+    assert_equal({ 'l' => 'a', 't' => '', 'x' => '42'}, r.query)
   end
 
   def test_host
@@ -157,6 +157,9 @@ class ValidationTest < Minitest::Test
     assert_equal 'foo', @req.validate('foo', [String, nil])
     assert_nil          @req.validate(nil, [String, nil])
 
+    assert_equal 'foo', @req.validate('foo', String, /.+/)
+    assert_raises(VE) { @req.validate('', String, /.+/) }
+
     assert_equal 123,   @req.validate('123', Integer)
     assert_raises(VE) { @req.validate('a123', Integer) }
     assert_equal 123,   @req.validate('123', Integer, 120..125)