syntax_tree-haml 4.0.2 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b926fc681f1792de33a0ab58885860f06337de292164185fd9d0cf86ff80da90
-  data.tar.gz: a09512989ef9b799975ec639ddbaa5fc65bddd76b0cdc9719b309372a5a4cb71
+  metadata.gz: c410fddce7b0b3de3dca5f4f0ff6f1f495f70897d1a07f956ceb3cedb8a3bc42
+  data.tar.gz: 6f4866aefe38f780411b65fa2671a9f9491aba0249884dc6c6f627d1a76f5520
 SHA512:
-  metadata.gz: a07aea76babd7c8a4c765749b3107c0dd3a904ced2550ddb15ea85cfaa6d3df12f6d20767c855eede216d54fdf844e41b00efcf186b9b44409510236823d58ae
-  data.tar.gz: 108994617aba53d1eb5758d563c3a5b96f65551ec7a0af9e66862f9c8e26c77232f4eb3bc727d9711f7da78f32d91d91adff3a0152ea6b35d7098a5c14d4fabd
+  metadata.gz: b79312706a5519a3d6933040c99f353ca344290d9c026d27ee2b6aa5b092ef8f03e735ae5e0de4b832bf7acbdceeceb844bdb9ca46ddd1b6aa9ea3f8c1d37cbc
+  data.tar.gz: e0993ba8112bb8149cbcaf972ba588e2b347431254bf0d3d0a63482657d18d5f70af4aa58f185b9d696d5c028bae55621cb483ad9800474242c2236be3043e98

data/CHANGELOG.md

@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [Unreleased]
 
+## [4.0.3] - 2023-03-12
+
+### Changed
+
+- Fixed a bug where blank lines were being inserted into filter nodes accidentally.
+
 ## [4.0.2] - 2023-03-09
 
 ### Changed
@@ -100,7 +106,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 - 🎉 Initial release! 🎉
 
-[unreleased]: https://github.com/ruby-syntax-tree/syntax_tree-haml/compare/v4.0.2...HEAD
+[unreleased]: https://github.com/ruby-syntax-tree/syntax_tree-haml/compare/v4.0.3...HEAD
+[4.0.3]: https://github.com/ruby-syntax-tree/syntax_tree-haml/compare/v4.0.2...v4.0.3
 [4.0.2]: https://github.com/ruby-syntax-tree/syntax_tree-haml/compare/v4.0.1...v4.0.2
 [4.0.1]: https://github.com/ruby-syntax-tree/syntax_tree-haml/compare/v4.0.0...v4.0.1
 [4.0.0]: https://github.com/ruby-syntax-tree/syntax_tree-haml/compare/v3.0.0...v4.0.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    syntax_tree-haml (4.0.2)
+    syntax_tree-haml (4.0.3)
       haml (>= 5.2)
       prettier_print (>= 1.2.1)
       syntax_tree (>= 6.0.0)

data/lib/syntax_tree/haml/format.rb

@@ -69,15 +69,17 @@ module SyntaxTree
             q.breakable_force
             first = true
 
-            node.value[:text].each_line(chomp: true) do |line|
-              if first
-                first = false
-              else
-                q.breakable_force
-              end
+            node.value[:text]
+              .rstrip
+              .each_line(chomp: true) do |line|
+                if first
+                  first = false
+                else
+                  q.breakable_force
+                end
 
-              q.text(line)
-            end
+                q.text(line)
+              end
           end
         end
       end
@@ -124,8 +126,7 @@ module SyntaxTree
 
         node.children.each do |child|
           q.breakable_force if previous_line && (child.line - previous_line) > 1
-          previous_line =
-            child.children.any? ? child.children.last.line : child.line
+          previous_line = child.last_line
 
           visit(child)
           q.breakable_force
@@ -513,10 +514,8 @@ module SyntaxTree
                   q.breakable_force
                 end
 
-                previous_line =
-                  child.children.any? ? child.children.last.line : child.line
-
                 visit(child)
+                previous_line = child.last_line
               end
             end
           end

data/lib/syntax_tree/haml/version.rb

@@ -2,6 +2,6 @@
 
 module SyntaxTree
   module Haml
-    VERSION = "4.0.2"
+    VERSION = "4.0.3"
   end
 end

data/lib/syntax_tree/haml.rb

@@ -82,10 +82,30 @@ class Haml::Parser::ParseNode
     end
   end
 
+  # This is our entrypoint for the formatter. We effectively delegate this to
+  # accepting the Format visitor.
   def format(q)
     accept(SyntaxTree::Haml::Format.new(q))
   end
 
+  # When we're formatting a list of children, we need to know the last line a
+  # node is on. This is because the next node in the list of children should be
+  # at most 1 blank line below the last line of the previous node. We cache this
+  # because at worst it requires walking the entire tree because filter nodes
+  # can take up multiple lines.
+  def last_line
+    @last_line ||=
+      if children.any?
+        children.last.last_line
+      elsif type == :filter
+        line + value[:text].rstrip.count("\n") + 1
+      else
+        line
+      end
+  end
+
+  # This is our entrypoint for the pretty printer. We effectively delegate this
+  # to accepting the PrettyPrint visitor.
   def pretty_print(q)
     accept(SyntaxTree::Haml::PrettyPrint.new(q))
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: syntax_tree-haml
 version: !ruby/object:Gem::Version
-  version: 4.0.2
+  version: 4.0.3
 platform: ruby
 authors:
 - Kevin Newton
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-03-09 00:00:00.000000000 Z
+date: 2023-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: haml